dsa2.c 16.2 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
/*
 * net/dsa/dsa2.c - Hardware switch handling, binding version 2
 * Copyright (c) 2008-2009 Marvell Semiconductor
 * Copyright (c) 2013 Florian Fainelli <florian@openwrt.org>
 * Copyright (c) 2016 Andrew Lunn <andrew@lunn.ch>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 */

#include <linux/device.h>
#include <linux/err.h>
#include <linux/list.h>
16
#include <linux/netdevice.h>
17 18 19 20
#include <linux/slab.h>
#include <linux/rtnetlink.h>
#include <linux/of.h>
#include <linux/of_net.h>
21

22 23
#include "dsa_priv.h"

24
static LIST_HEAD(dsa_tree_list);
25 26
static DEFINE_MUTEX(dsa2_mutex);

27 28 29
static const struct devlink_ops dsa_devlink_ops = {
};

30
static struct dsa_switch_tree *dsa_tree_find(int index)
31 32 33
{
	struct dsa_switch_tree *dst;

34
	list_for_each_entry(dst, &dsa_tree_list, list)
35
		if (dst->index == index)
36
			return dst;
37

38 39 40
	return NULL;
}

41
static struct dsa_switch_tree *dsa_tree_alloc(int index)
42 43 44 45 46 47
{
	struct dsa_switch_tree *dst;

	dst = kzalloc(sizeof(*dst), GFP_KERNEL);
	if (!dst)
		return NULL;
48

49
	dst->index = index;
50

51
	INIT_LIST_HEAD(&dst->list);
52
	list_add_tail(&dsa_tree_list, &dst->list);
53 54

	/* Initialize the reference counter to the number of switches, not 1 */
55
	kref_init(&dst->refcount);
56
	refcount_set(&dst->refcount.refcount, 0);
57 58 59 60

	return dst;
}

61 62 63 64 65 66
static void dsa_tree_free(struct dsa_switch_tree *dst)
{
	list_del(&dst->list);
	kfree(dst);
}

67 68 69 70 71 72 73 74 75 76 77
static struct dsa_switch_tree *dsa_tree_touch(int index)
{
	struct dsa_switch_tree *dst;

	dst = dsa_tree_find(index);
	if (!dst)
		dst = dsa_tree_alloc(index);

	return dst;
}

78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96
static void dsa_tree_get(struct dsa_switch_tree *dst)
{
	kref_get(&dst->refcount);
}

static void dsa_tree_release(struct kref *ref)
{
	struct dsa_switch_tree *dst;

	dst = container_of(ref, struct dsa_switch_tree, refcount);

	dsa_tree_free(dst);
}

static void dsa_tree_put(struct dsa_switch_tree *dst)
{
	kref_put(&dst->refcount, dsa_tree_release);
}

97 98 99
/* For platform data configurations, we need to have a valid name argument to
 * differentiate a disabled port from an enabled one
 */
100
static bool dsa_port_is_valid(struct dsa_port *port)
101
{
102
	return port->type != DSA_PORT_TYPE_UNUSED;
103 104
}

105
static bool dsa_port_is_dsa(struct dsa_port *port)
106
{
107
	return port->type == DSA_PORT_TYPE_DSA;
108 109 110 111
}

static bool dsa_port_is_cpu(struct dsa_port *port)
{
112
	return port->type == DSA_PORT_TYPE_CPU;
113 114
}

115 116 117 118 119
static bool dsa_port_is_user(struct dsa_port *dp)
{
	return dp->type == DSA_PORT_TYPE_USER;
}

120 121
static bool dsa_ds_find_port_dn(struct dsa_switch *ds,
				struct device_node *port)
122 123 124
{
	u32 index;

125
	for (index = 0; index < ds->num_ports; index++)
126 127 128 129 130
		if (ds->ports[index].dn == port)
			return true;
	return false;
}

131 132
static struct dsa_switch *dsa_dst_find_port_dn(struct dsa_switch_tree *dst,
					       struct device_node *port)
133 134 135 136 137 138 139 140 141
{
	struct dsa_switch *ds;
	u32 index;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

142
		if (dsa_ds_find_port_dn(ds, port))
143 144 145 146 147 148 149 150
			return ds;
	}

	return NULL;
}

static int dsa_port_complete(struct dsa_switch_tree *dst,
			     struct dsa_switch *src_ds,
151
			     struct dsa_port *port,
152 153 154 155 156 157 158
			     u32 src_port)
{
	struct device_node *link;
	int index;
	struct dsa_switch *dst_ds;

	for (index = 0;; index++) {
159
		link = of_parse_phandle(port->dn, "link", index);
160 161 162
		if (!link)
			break;

163
		dst_ds = dsa_dst_find_port_dn(dst, link);
164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181
		of_node_put(link);

		if (!dst_ds)
			return 1;

		src_ds->rtable[dst_ds->index] = src_port;
	}

	return 0;
}

/* A switch is complete if all the DSA ports phandles point to ports
 * known in the tree. A return value of 1 means the tree is not
 * complete. This is not an error condition. A value of 0 is
 * success.
 */
static int dsa_ds_complete(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
182
	struct dsa_port *port;
183 184 185
	u32 index;
	int err;

186
	for (index = 0; index < ds->num_ports; index++) {
187 188
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225
			continue;

		if (!dsa_port_is_dsa(port))
			continue;

		err = dsa_port_complete(dst, ds, port, index);
		if (err != 0)
			return err;
	}

	return 0;
}

/* A tree is complete if all the DSA ports phandles point to ports
 * known in the tree. A return value of 1 means the tree is not
 * complete. This is not an error condition. A value of 0 is
 * success.
 */
static int dsa_dst_complete(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;
	int err;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_complete(dst, ds);
		if (err != 0)
			return err;
	}

	return 0;
}

226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283
static struct dsa_port *dsa_tree_find_first_cpu(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	struct dsa_port *dp;
	int device, port;

	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			if (dsa_port_is_cpu(dp))
				return dp;
		}
	}

	return NULL;
}

static int dsa_tree_setup_default_cpu(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	struct dsa_port *dp;
	int device, port;

	/* DSA currently only supports a single CPU port */
	dst->cpu_dp = dsa_tree_find_first_cpu(dst);
	if (!dst->cpu_dp) {
		pr_warn("Tree has no master device\n");
		return -EINVAL;
	}

	/* Assign the default CPU port to all ports of the fabric */
	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			if (dsa_port_is_user(dp))
				dp->cpu_dp = dst->cpu_dp;
		}
	}

	return 0;
}

static void dsa_tree_teardown_default_cpu(struct dsa_switch_tree *dst)
{
	/* DSA currently only supports a single CPU port */
	dst->cpu_dp = NULL;
}

284
static int dsa_port_setup(struct dsa_port *dp)
285
{
286
	struct dsa_switch *ds = dp->ds;
287 288
	int err;

289
	memset(&dp->devlink_port, 0, sizeof(dp->devlink_port));
290

291 292
	err = devlink_port_register(ds->devlink, &dp->devlink_port, dp->index);
	if (err)
293 294
		return err;

295 296 297 298 299 300 301 302 303 304 305
	switch (dp->type) {
	case DSA_PORT_TYPE_UNUSED:
		break;
	case DSA_PORT_TYPE_CPU:
	case DSA_PORT_TYPE_DSA:
		err = dsa_port_fixed_link_register_of(dp);
		if (err) {
			dev_err(ds->dev, "failed to register fixed link for port %d.%d\n",
				ds->index, dp->index);
			return err;
		}
306

307 308 309 310 311 312 313 314 315
		break;
	case DSA_PORT_TYPE_USER:
		err = dsa_slave_create(dp);
		if (err)
			dev_err(ds->dev, "failed to create slave for port %d.%d\n",
				ds->index, dp->index);
		else
			devlink_port_type_eth_set(&dp->devlink_port, dp->slave);
		break;
316 317 318 319 320
	}

	return 0;
}

321
static void dsa_port_teardown(struct dsa_port *dp)
322
{
323 324 325 326 327 328 329 330 331 332 333 334 335 336 337
	devlink_port_unregister(&dp->devlink_port);

	switch (dp->type) {
	case DSA_PORT_TYPE_UNUSED:
		break;
	case DSA_PORT_TYPE_CPU:
	case DSA_PORT_TYPE_DSA:
		dsa_port_fixed_link_unregister_of(dp);
		break;
	case DSA_PORT_TYPE_USER:
		if (dp->slave) {
			dsa_slave_destroy(dp->slave);
			dp->slave = NULL;
		}
		break;
338 339 340
	}
}

341
static int dsa_switch_setup(struct dsa_switch *ds)
342 343 344
{
	int err;

345
	/* Initialize ds->phys_mii_mask before registering the slave MDIO bus
346
	 * driver and before ops->setup() has run, since the switch drivers and
347 348 349
	 * the slave MDIO bus driver rely on these values for probing PHY
	 * devices or not
	 */
350
	ds->phys_mii_mask |= dsa_user_ports(ds);
351

352 353 354 355 356 357 358 359 360 361 362
	/* Add the switch to devlink before calling setup, so that setup can
	 * add dpipe tables
	 */
	ds->devlink = devlink_alloc(&dsa_devlink_ops, 0);
	if (!ds->devlink)
		return -ENOMEM;

	err = devlink_register(ds->devlink, ds->dev);
	if (err)
		return err;

363
	err = ds->ops->setup(ds);
364 365 366
	if (err < 0)
		return err;

V
Vivien Didelot 已提交
367 368 369 370
	err = dsa_switch_register_notifier(ds);
	if (err)
		return err;

371
	if (!ds->slave_mii_bus && ds->ops->phy_read) {
372 373 374 375 376 377 378 379 380 381 382
		ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
		if (!ds->slave_mii_bus)
			return -ENOMEM;

		dsa_slave_mii_bus_init(ds);

		err = mdiobus_register(ds->slave_mii_bus);
		if (err < 0)
			return err;
	}

383 384 385
	return 0;
}

386
static void dsa_switch_teardown(struct dsa_switch *ds)
387
{
388
	if (ds->slave_mii_bus && ds->ops->phy_read)
389
		mdiobus_unregister(ds->slave_mii_bus);
V
Vivien Didelot 已提交
390 391

	dsa_switch_unregister_notifier(ds);
392 393 394 395 396 397 398

	if (ds->devlink) {
		devlink_unregister(ds->devlink);
		devlink_free(ds->devlink);
		ds->devlink = NULL;
	}

399 400
}

401 402 403
static int dsa_tree_setup_switches(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
404 405
	struct dsa_port *dp;
	int device, port;
406 407 408 409 410 411 412 413 414 415
	int err;

	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

		err = dsa_switch_setup(ds);
		if (err)
			return err;
416 417 418 419 420 421 422 423

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			err = dsa_port_setup(dp);
			if (err)
				return err;
		}
424 425 426 427 428 429 430 431
	}

	return 0;
}

static void dsa_tree_teardown_switches(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
432 433
	struct dsa_port *dp;
	int device, port;
434 435 436 437 438 439

	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

440 441 442 443 444 445
		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			dsa_port_teardown(dp);
		}

446 447 448 449
		dsa_switch_teardown(ds);
	}
}

450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466
static int dsa_tree_setup_master(struct dsa_switch_tree *dst)
{
	struct dsa_port *cpu_dp = dst->cpu_dp;
	struct net_device *master = cpu_dp->master;

	/* DSA currently supports a single pair of CPU port and master device */
	return dsa_master_setup(master, cpu_dp);
}

static void dsa_tree_teardown_master(struct dsa_switch_tree *dst)
{
	struct dsa_port *cpu_dp = dst->cpu_dp;
	struct net_device *master = cpu_dp->master;

	return dsa_master_teardown(master);
}

V
Vivien Didelot 已提交
467
static int dsa_tree_setup(struct dsa_switch_tree *dst)
468 469 470
{
	int err;

V
Vivien Didelot 已提交
471 472 473 474 475 476
	if (dst->setup) {
		pr_err("DSA: tree %d already setup! Disjoint trees?\n",
		       dst->index);
		return -EEXIST;
	}

477 478 479 480
	err = dsa_tree_setup_default_cpu(dst);
	if (err)
		return err;

481 482 483
	err = dsa_tree_setup_switches(dst);
	if (err)
		return err;
484

485
	err = dsa_tree_setup_master(dst);
486 487 488
	if (err)
		return err;

V
Vivien Didelot 已提交
489 490 491
	dst->setup = true;

	pr_info("DSA: tree %d setup\n", dst->index);
492 493 494 495

	return 0;
}

V
Vivien Didelot 已提交
496
static void dsa_tree_teardown(struct dsa_switch_tree *dst)
497
{
V
Vivien Didelot 已提交
498
	if (!dst->setup)
499 500
		return;

501
	dsa_tree_teardown_master(dst);
502

503
	dsa_tree_teardown_switches(dst);
504

505
	dsa_tree_teardown_default_cpu(dst);
506

V
Vivien Didelot 已提交
507 508 509
	pr_info("DSA: tree %d torn down\n", dst->index);

	dst->setup = false;
510 511
}

512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532
static void dsa_tree_remove_switch(struct dsa_switch_tree *dst,
				   unsigned int index)
{
	dst->ds[index] = NULL;
	dsa_tree_put(dst);
}

static int dsa_tree_add_switch(struct dsa_switch_tree *dst,
			       struct dsa_switch *ds)
{
	unsigned int index = ds->index;

	if (dst->ds[index])
		return -EBUSY;

	dsa_tree_get(dst);
	dst->ds[index] = ds;

	return 0;
}

533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552
static int dsa_port_parse_user(struct dsa_port *dp, const char *name)
{
	if (!name)
		name = "eth%d";

	dp->type = DSA_PORT_TYPE_USER;
	dp->name = name;

	return 0;
}

static int dsa_port_parse_dsa(struct dsa_port *dp)
{
	dp->type = DSA_PORT_TYPE_DSA;

	return 0;
}

static int dsa_port_parse_cpu(struct dsa_port *dp, struct net_device *master)
{
553 554 555 556 557 558 559 560 561 562 563 564
	struct dsa_switch *ds = dp->ds;
	struct dsa_switch_tree *dst = ds->dst;
	const struct dsa_device_ops *tag_ops;
	enum dsa_tag_protocol tag_protocol;

	tag_protocol = ds->ops->get_tag_protocol(ds);
	tag_ops = dsa_resolve_tag_protocol(tag_protocol);
	if (IS_ERR(tag_ops)) {
		dev_warn(ds->dev, "No tagger for this switch\n");
		return PTR_ERR(tag_ops);
	}

565
	dp->type = DSA_PORT_TYPE_CPU;
566 567
	dp->rcv = tag_ops->rcv;
	dp->tag_ops = tag_ops;
568
	dp->master = master;
569
	dp->dst = dst;
570 571 572 573

	return 0;
}

574 575
static int dsa_port_parse_of(struct dsa_port *dp, struct device_node *dn)
{
576
	struct device_node *ethernet = of_parse_phandle(dn, "ethernet", 0);
577
	const char *name = of_get_property(dn, "label", NULL);
578
	bool link = of_property_read_bool(dn, "link");
579

580 581
	dp->dn = dn;

582
	if (ethernet) {
583 584 585 586 587 588
		struct net_device *master;

		master = of_find_net_device_by_node(ethernet);
		if (!master)
			return -EPROBE_DEFER;

589
		return dsa_port_parse_cpu(dp, master);
590 591
	}

592 593
	if (link)
		return dsa_port_parse_dsa(dp);
594

595
	return dsa_port_parse_user(dp, name);
596 597
}

V
Vivien Didelot 已提交
598 599
static int dsa_switch_parse_ports_of(struct dsa_switch *ds,
				     struct device_node *dn)
600
{
601
	struct device_node *ports, *port;
602
	struct dsa_port *dp;
603
	u32 reg;
604 605 606 607 608 609 610
	int err;

	ports = of_get_child_by_name(dn, "ports");
	if (!ports) {
		dev_err(ds->dev, "no ports child node found\n");
		return -EINVAL;
	}
611 612 613 614 615 616

	for_each_available_child_of_node(ports, port) {
		err = of_property_read_u32(port, "reg", &reg);
		if (err)
			return err;

617
		if (reg >= ds->num_ports)
618 619
			return -EINVAL;

620 621 622 623 624
		dp = &ds->ports[reg];

		err = dsa_port_parse_of(dp, port);
		if (err)
			return err;
625 626 627 628 629
	}

	return 0;
}

V
Vivien Didelot 已提交
630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662
static int dsa_switch_parse_member_of(struct dsa_switch *ds,
				      struct device_node *dn)
{
	u32 m[2] = { 0, 0 };
	int sz;

	/* Don't error out if this optional property isn't found */
	sz = of_property_read_variable_u32_array(dn, "dsa,member", m, 2, 2);
	if (sz < 0 && sz != -EINVAL)
		return sz;

	ds->index = m[1];
	if (ds->index >= DSA_MAX_SWITCHES)
		return -EINVAL;

	ds->dst = dsa_tree_touch(m[0]);
	if (!ds->dst)
		return -ENOMEM;

	return 0;
}

static int dsa_switch_parse_of(struct dsa_switch *ds, struct device_node *dn)
{
	int err;

	err = dsa_switch_parse_member_of(ds, dn);
	if (err)
		return err;

	return dsa_switch_parse_ports_of(ds, dn);
}

663 664 665
static int dsa_port_parse(struct dsa_port *dp, const char *name,
			  struct device *dev)
{
666
	if (!strcmp(name, "cpu")) {
667 668 669 670 671 672 673 674
		struct net_device *master;

		master = dsa_dev_to_net_device(dev);
		if (!master)
			return -EPROBE_DEFER;

		dev_put(master);

675
		return dsa_port_parse_cpu(dp, master);
676 677
	}

678 679
	if (!strcmp(name, "dsa"))
		return dsa_port_parse_dsa(dp);
680

681
	return dsa_port_parse_user(dp, name);
682 683
}

V
Vivien Didelot 已提交
684 685
static int dsa_switch_parse_ports(struct dsa_switch *ds,
				  struct dsa_chip_data *cd)
686 687
{
	bool valid_name_found = false;
688 689 690
	struct dsa_port *dp;
	struct device *dev;
	const char *name;
691
	unsigned int i;
692
	int err;
693 694

	for (i = 0; i < DSA_MAX_PORTS; i++) {
695 696 697 698 699
		name = cd->port_names[i];
		dev = cd->netdev[i];
		dp = &ds->ports[i];

		if (!name)
700 701
			continue;

702 703 704 705
		err = dsa_port_parse(dp, name, dev);
		if (err)
			return err;

706 707 708 709 710 711 712 713 714
		valid_name_found = true;
	}

	if (!valid_name_found && i == DSA_MAX_PORTS)
		return -EINVAL;

	return 0;
}

V
Vivien Didelot 已提交
715
static int dsa_switch_parse(struct dsa_switch *ds, struct dsa_chip_data *cd)
716
{
V
Vivien Didelot 已提交
717
	ds->cd = cd;
718

V
Vivien Didelot 已提交
719 720 721 722 723 724 725
	/* We don't support interconnected switches nor multiple trees via
	 * platform data, so this is the unique switch of the tree.
	 */
	ds->index = 0;
	ds->dst = dsa_tree_touch(0);
	if (!ds->dst)
		return -ENOMEM;
726

V
Vivien Didelot 已提交
727
	return dsa_switch_parse_ports(ds, cd);
728 729
}

730
static int _dsa_register_switch(struct dsa_switch *ds)
731
{
732 733
	struct dsa_chip_data *pdata = ds->dev->platform_data;
	struct device_node *np = ds->dev->of_node;
734
	struct dsa_switch_tree *dst;
V
Vivien Didelot 已提交
735
	unsigned int index;
736
	int i, err;
737

V
Vivien Didelot 已提交
738 739 740 741 742 743
	if (np)
		err = dsa_switch_parse_of(ds, np);
	else if (pdata)
		err = dsa_switch_parse(ds, pdata);
	else
		err = -ENODEV;
744

V
Vivien Didelot 已提交
745 746
	if (err)
		return err;
747

V
Vivien Didelot 已提交
748 749
	index = ds->index;
	dst = ds->dst;
750

751 752 753 754
	/* Initialize the routing table */
	for (i = 0; i < DSA_MAX_SWITCHES; ++i)
		ds->rtable[i] = DSA_RTABLE_NONE;

755 756 757
	err = dsa_tree_add_switch(dst, ds);
	if (err)
		return err;
758 759 760 761 762

	err = dsa_dst_complete(dst);
	if (err < 0)
		goto out_del_dst;

763 764 765
	/* Not all switches registered yet */
	if (err == 1)
		return 0;
766

V
Vivien Didelot 已提交
767
	err = dsa_tree_setup(dst);
768
	if (err) {
V
Vivien Didelot 已提交
769
		dsa_tree_teardown(dst);
770 771 772 773 774 775
		goto out_del_dst;
	}

	return 0;

out_del_dst:
776
	dsa_tree_remove_switch(dst, index);
777 778 779 780

	return err;
}

781 782 783 784
struct dsa_switch *dsa_switch_alloc(struct device *dev, size_t n)
{
	size_t size = sizeof(struct dsa_switch) + n * sizeof(struct dsa_port);
	struct dsa_switch *ds;
785
	int i;
786 787 788 789 790 791 792 793

	ds = devm_kzalloc(dev, size, GFP_KERNEL);
	if (!ds)
		return NULL;

	ds->dev = dev;
	ds->num_ports = n;

794 795 796 797 798
	for (i = 0; i < ds->num_ports; ++i) {
		ds->ports[i].index = i;
		ds->ports[i].ds = ds;
	}

799 800 801 802
	return ds;
}
EXPORT_SYMBOL_GPL(dsa_switch_alloc);

803
int dsa_register_switch(struct dsa_switch *ds)
804 805 806 807
{
	int err;

	mutex_lock(&dsa2_mutex);
808
	err = _dsa_register_switch(ds);
809 810 811 812 813 814
	mutex_unlock(&dsa2_mutex);

	return err;
}
EXPORT_SYMBOL_GPL(dsa_register_switch);

815
static void _dsa_unregister_switch(struct dsa_switch *ds)
816 817
{
	struct dsa_switch_tree *dst = ds->dst;
818
	unsigned int index = ds->index;
819

V
Vivien Didelot 已提交
820
	dsa_tree_teardown(dst);
821

822
	dsa_tree_remove_switch(dst, index);
823 824 825 826 827 828 829 830 831
}

void dsa_unregister_switch(struct dsa_switch *ds)
{
	mutex_lock(&dsa2_mutex);
	_dsa_unregister_switch(ds);
	mutex_unlock(&dsa2_mutex);
}
EXPORT_SYMBOL_GPL(dsa_unregister_switch);