1. 03 3月, 2017 8 次提交
  2. 02 3月, 2017 19 次提交
    • H
      Remove redundant TINC tests on ANALYZE ROOTPARTITION. · 840370e5
      Heikki Linnakangas 提交于
      We have good coverage of this in the 'analyze' test in the main test suite
      now.
      840370e5
    • H
      Remove tests on REINDEX and TRUNCATE/ALTER/DROP TABLE running in parallel. · 8c3850fd
      Heikki Linnakangas 提交于
      REINDEX grabs a ShareLock on the table relation very early on, and
      TRUNCATE grabs an AccessExclusiveLock very early on. If we trust that the
      lock manager isn't broken, there's no need to test this combination of
      commands in particular. (For testing the lock manager, these tests give
      only very narrow coverage.) Furthermore, all these test cases are
      effectively the same, as it it makes no difference what kind of a table or
      what kind of an index it is, the locking works the same for all.
      
      ALTER and DROP TABLE also grab an AccessExclusiveLock on the table, which
      conflicts with the ShareLock that REINDEX takes. It works the same with all
      flavors of ALTER and DROP TABLE, and with all kinds of tables, and all
      kinds of indexes.
      8c3850fd
    • H
      9a8b5010
    • H
      Move/remove redundant test case from TINC. · f3dac087
      Heikki Linnakangas 提交于
      This was mostly already in bfv_partition. For completeness, move the code
      from the TINC test to bfv_partition to also execute the query, not just
      EXPLAIN it.
      f3dac087
    • H
      Remove redundant TINC test. · a0b02a7a
      Heikki Linnakangas 提交于
      There's a test in the main suite's 'partition' test for this already,
      with the 'deep_part' test table.
      a0b02a7a
    • H
      Remove redundant test. · 96367464
      Heikki Linnakangas 提交于
      There is already a similar test in the 'partition' test in the main test
      suite. Search for "-- Sub-partition insertion" in partition.sql to find
      it.
      96367464
    • H
      Remove redundant test for WITH OIDS=false on a partitioned table. · aa55fb57
      Heikki Linnakangas 提交于
      It's not allowed. We already have tests for both CREATE TABLE and ALTER
      TABLE ADD PARTITION, with "WITH OIDS=false", in the 'partition' test of
      the main test suite.
      aa55fb57
    • H
      Make partition tests robust against concurrent tests, and parallelize. · b1baaa17
      Heikki Linnakangas 提交于
      Rename the test tables in 'partition' test, so that they don't clash with
      the test tables in 'partition1' test. Change a few validation queries to
      not get confused if there are unrelated tables with partitions in the
      database. With these changes, we can run 'partition' and 'partition1' in
      the same parallel group, which is a more logical grouping.
      b1baaa17
    • H
      Move update_intersect_* test from TINC to main regression suite. · 1ed6f94a
      Heikki Linnakangas 提交于
      All of these tests used the same test table, but it was dropped and
      re-created for each test. To speed things up, create it once, and wrap each
      test in a begin-rollback block.
      
      The access plan of one of the tests varied depending on optimizer_segments,
      and it caused a difference in the ERROR message. The TINC tests were always
      run with 2 segments, but you got a different plan and message with 3 or
      more segments. Added a "SET optimizer_segments=2" to stabilize that, and a
      comment explaining the situation.
      1ed6f94a
    • H
      Move Left Anti Semi-Join tests from TINC. · ce6aafb0
      Heikki Linnakangas 提交于
      ce6aafb0
    • H
      Fix planning of NOT IN (<empty set>). · d94ed173
      Heikki Linnakangas 提交于
      The transformation of "NOT IN" or "= ALL" incorrectly added a condition
      that the outer side of the join must not be NULL. But that's not true,
      when the other side is an empty set.
      
      Discovered while moving old TINC tests to the main test suite. The
      'lasj_hash_all_3' test exposed this issue, when run with ORCA disabled.
      This has apparently gone unnoticed, because no-one has run those tests
      without ORCA. There were also incorrect query results memorized, for tests
      'lasj_notin_multiple_3' and 'lasj_hash_notin_multiple_3'. They are similar
      queries, but because ORCA falls back to the planner for them, we had
      memorized the Planner results for them, and hadn't noticed that the
      results were in fact incorrect.
      
      Fixes github issue #1907.
      d94ed173
    • H
      Remove a few disabled tests from TINC. · 600e284a
      Heikki Linnakangas 提交于
      We have a bunch of tests on subpartitioned tables in the main suite, e.g.
      in the 'partition' and 'bfv_partition' tests. And these tests were marked
      with "@skip", anyway, so they were not run by TINC either.
      600e284a
    • H
      Move tests for static partition selection from TINC. · 8f5f09d8
      Heikki Linnakangas 提交于
      I moved them to the 'partition_pruning_with_fn' test, but because there is
      no functions involved in these tests, I renamed the test to just
      'partition_pruning'.
      
      There is possibly some overlap with these new tests and the existing ones
      in the same file, but will let future test archeologists to decide that.
      These are cheap tests, in any case.
      8f5f09d8
    • H
      Move filerep TINC tests from one Concourse task to another. · d7340868
      Heikki Linnakangas 提交于
      The storage_persistent_filerep_accessmethods_and_vacuum task contained
      two filerep tests:
      
      FilerepResync.test_filerep_resysnc ... 585576.51 ms ... ok
      FilerepProcArrayRemoveTestCase.test_verify_ct_after_procarray_removal ... 136553.63 ms ... ok
      
      Move them together with the filerep_end_to_end_xlog_ctlog_cons task, so that
      all the filerep tests are in the same task. To reflect that, rename the
      'filerep_end_to_end_xlog_ctlog_cons task' to just 'filerep'.
      
      The 'storage_persistent_filerep_accessmethods_and_vacuum' task was the
      slowest task among the parallel tasks in the job, so moving the two filerep
      tests elsewhere should reduce overall runtime of the storage job.
      d7340868
    • H
      Remove redundant tests on AO tables and savepoints. · fb471821
      Heikki Linnakangas 提交于
      These are already covered by the 'appendonly' and 'uao_dml/uao_dml' tests
      in the main test suite.
      fb471821
    • H
      Remove redundant TINC tests on int and int4 types. · 989c502f
      Heikki Linnakangas 提交于
      "int" and "int4" are the same datatype. They are mapped to the same early
      on, in the parsing stage. For those tests that have been duplicated for
      many different datatypes, remove the _int_ variant, leaving just the
      _int4_ variant.
      989c502f
    • H
      Remove redundant tests on geometric types. · dddc4298
      Heikki Linnakangas 提交于
      We have sufficient coverage for these in the 'geometry' test in the main
      test suite. There are no UPDATEs in 'geometry', but that seems
      uninteresting; there is no reason to believe that UPDATE on these types
      would behave differently from an UPDATE on any other type.
      
      The test descriptions were misleading, BTW. These are not "boundary"
      tests, the values used are not close to the min or max values the data
      types can represent.
      dddc4298
    • H
    • H
      Move a few tests on UDFs from TINC to main test suite. · 6c4aedaa
      Heikki Linnakangas 提交于
      * Move all the udf_insert_* tests to the main suite.
      
      * Move 'volatilefn_dml_int8' test to the main suite.
      
      * Remove all the other volatilefn_dml_* tests. There's no reason to believe
        that the data types used in the table would make a difference, so keeping
        one variant of this is enough.
      6c4aedaa
  3. 01 3月, 2017 9 次提交
    • N
      resgroup: add view for resgroup runtime statistics information. · 5c0949f3
      Ning Yu 提交于
      Add view gp_toolkit.gp_resgroup_status for resource group runtime
      statistics information, such as cpu usage, memory usage, etc..
      
      Example:
      
          -- query resource group runtime statistics information
          SELECT * FROM gp_toolkit.gp_resgroup_status;
      
      A helper function pg_resgroup_get_status_kv() is also provided to
      collect these information.
      
      A new dir src/backend/utils/resgroup/ is created to hold the resgroup
      source code.
      
      As resgroup is not fully implemented yet there is only dummy output for
      this view at the moment.
      5c0949f3
    • N
      resgroup: add view for resgroup config information. · ae2da268
      Ning Yu 提交于
      Add view gp_toolkit.gp_resgroup_config for resource group information,
      such as concurrency, cpu rate limitation, etc..
      
      Example:
      
          -- query resource group config information
          SELECT * FROM gp_toolkit.gp_resgroup_config;
      ae2da268
    • H
      Move functionProperty tests from TINC. · 64f83aa8
      Heikki Linnakangas 提交于
      I'm not how many of these tests are worth keeping at all, but as a first
      step, let's get them into the main test suite. The runtime of the parallel
      group with these tests is about 1 minute on my laptop.
      
      This is mostly a straightforward move, with mechanical changes removing the
      useless TINC tags. However, some tests were marked with the special
      "@executemode ORCA_PLANNER_DIFF" tag. The code in __init__.py ran those
      tests differently. Normally, you run a test, and comparet the output with
      the expected output file. But those ORCA_PLANNER_DIFF tests were run twice,
      with and without ORCA, and the results were compared against each other,
      instead of the expected output stored in the repository. The expected
      outputs of those tests were out of date, you got a different error message
      now than what was remembered in the expected output.
      
      Now those tests are run as normal pg_regress tests. I updated the expected
      output of those tests to match what you get nowadays.
      64f83aa8
    • H
      Remove boring tests on pg_size_pretty. · c25d162a
      Heikki Linnakangas 提交于
      pg_size_pretty() is completely ordinary and boring function. It doesn't
      do database access or anything like that. We can live without testing it
      in every possible context.
      c25d162a
    • H
      Move misc test from TINC. · 334a8323
      Heikki Linnakangas 提交于
      334a8323
    • H
      Remove redundant or boring tests. · cc629da7
      Heikki Linnakangas 提交于
      * dml_boundary_bool seems redundant. We surely have a lot of other tests
        involving boolean columns.
      * dml_boundary_char is redundant with the 'char' test in main suite.
      * dml_boundary_money was disabled.
      * dml_boundary_smallint was redundant with 'int2' test in main suite.
      * dml_boundary_integer was redundant with 'int4' test in main suite.
      * dml_boundary_bigint was redundant with 'int8' test in main suite.
      cc629da7
    • H
      Remove redundant TINC tests for direct dispatch. · e17f1334
      Heikki Linnakangas 提交于
      There are a lot of similar and more interesting tests for direct dispatch
      in the main test suite ('direct_dispatch' test, for example).
      
      The negative test cases, like inserting into a randomly distributed table
      so that direct dispatch is not possible, were not very interesting, so I
      removed them. A mistake in the other direction, i.e. not performing direct
      dispatch when we could have, does not lead to incorrect query results, just
      slower performance, which is why we need bespoken tests for those. But
      if we erroneously do direct dispatch for a query, where it is not legal,
      that will lead to incorrect query results, so we should catch those cases
      by all the other tests in the test suite.
      
      There was one test case, involving DEFAULTs in the INSERT statement, that
      I thought is marginally worth keeping, so added a case for that in
      'direct_dispatch' before removing it.
      e17f1334
    • S
      Re-enable 3 runaway query tests. · 03ddc861
      Shreedhar Hardikar 提交于
      03ddc861
    • H
      Remove redundant TINC tests for ALTER TABLE. · 635f1d35
      Heikki Linnakangas 提交于
      We have sufficient coverage for these in the main regression suite already.
      
      * Partitions are covered by the 'partindex_test', 'partition', and
        'partition1' tests.
      
      * ALTER TABLE on non-partitioned tests are covered in 'alter_table' test.
      
      * SET DISTRIBUTION POLICY is covered by the 'alter_distribution_policy'
        test. It seems unnecessary test so many different data types,
        there is no datatype-specific handling in the set distribution policy
        code.
      635f1d35
  4. 28 2月, 2017 4 次提交
    • A
      Do not initialize relcache before xlog replay. · 6b9d44c9
      Ashwin Agrawal, Asim R P and Xin Zhang 提交于
      The need for heap access methods before xlog replay is removed by commit
      e2d6aa1481f6cdbd846d4b17b68eb4387dae9211. This commit simply moves the
      relcache initialization to pass4, where it is really needed.
      
      Do not bother to remove relcache init file at the end of crash recovery pass2.
      
      Error out if relation cache initialized at wrong time.
      6b9d44c9
    • D
      Fix typos in comments and elogs · 63a54605
      Daniel Gustafsson 提交于
      The error messages are developer or debug facing, no reason to
      believe this will break anyones regexing of logfiles in prod.
      63a54605
    • K
      Unskip select_notable_pg_lock_status test (#1888) · 5c989777
      khannaekta 提交于
      * Update regex to reflect output change [#140454709]
      
      `pg_lock_status` changed output format.
      5c989777
    • J
      Hard code to PST8 [#140373273] · c7ebc7b0
      Jesse Zhang 提交于
      We cannot assume we are running in a special environment that is always
      in -8 time zone without DST. Making such setting explicit to make tests
      portable.
      
      Unskipping test as they will succeed now.
      c7ebc7b0