1. 17 1月, 2010 7 次提交
  2. 16 1月, 2010 14 次提交
  3. 15 1月, 2010 5 次提交
  4. 14 1月, 2010 4 次提交
    • S
      First part of refactoring of code for ResolveRecoveryConflict. Purposes · e99767bc
      Simon Riggs 提交于
      of this are to centralise the conflict code to allow further change,
      as well as to allow passing through the full reason for the conflict
      through to the conflicting backends. Backend state alters how we
      can handle different types of conflict so this is now required.
      As originally suggested by Heikki, no longer optional.
      e99767bc
    • T
      Simplify validate_exec() by using access(2) to check file permissions, · 0fba3bef
      Tom Lane 提交于
      rather than trying to implement the equivalent logic by hand.  The motivation
      for the original coding appears to have been to check with the effective uid's
      permissions not the real uid's; but there is no longer any difference, because
      we don't run the postmaster setuid (indeed, main.c enforces that they're the
      same).  Using access() means we will get it right in situations the original
      coding failed to handle, such as ACL-based permissions.  Besides it's a lot
      shorter, cleaner, and more thread-safe.  Per bug #5275 from James Bellinger.
      0fba3bef
    • T
      When loading critical system indexes into the relcache, ensure we lock the · 715120e7
      Tom Lane 提交于
      underlying catalog not only the index itself.  Otherwise, if the cache
      load process touches the catalog (which will happen for many though not
      all of these indexes), we are locking index before parent table, which can
      result in a deadlock against processes that are trying to lock them in the
      normal order.  Per today's failure on buildfarm member gothic_moth; it's
      surprising the problem hadn't been identified before.
      
      Back-patch to 8.2.  Earlier releases didn't have the issue because they
      didn't try to lock these indexes during load (instead assuming that they
      couldn't change schema at all during multiuser operation).
      715120e7
    • T
      Fix bug #5269: ResetPlanCache mustn't invalidate cached utility statements, · dbba3a14
      Tom Lane 提交于
      especially not ROLLBACK.  ROLLBACK might need to be executed in an already
      aborted transaction, when there is no safe way to revalidate the plan.  But
      in general there's no point in marking utility statements invalid, since
      they have no plans in the normal sense of the word; so we might as well
      work a bit harder here to avoid future revalidation cycles.
      
      Back-patch to 8.4, where the bug was introduced.
      dbba3a14
  5. 13 1月, 2010 5 次提交
    • M
      Applied Zoltan's patch to make char the default sqlda type. · b3627d1d
      Michael Meskes 提交于
      Given that undefined types are handled as character strings anyway the type
      translation function can simply return the correcponding ECPGt_char type.
      b3627d1d
    • M
      Fix SQL3 type return value. · cf4d9c47
      Michael Meskes 提交于
      For non-SQL3 types ecpg used to return -Oid. This will break if there are
      enough Oids to fill the namespace. Therefore we play it safe and return 0 if
      there is no Oid->SQL3 tyoe mapping available.
      cf4d9c47
    • T
      Make fixed_paramref_hook behave properly when there are 'unused' slots · 43a9a2fb
      Tom Lane 提交于
      in the parameter array.  Noted while experimenting with an example
      from Pavel.  This wouldn't come up in normal use, but it ought to honor
      the specification that a parameter array can have unused slots.
      43a9a2fb
    • M
      Update MSVC build instructions. · b2aab424
      Magnus Hagander 提交于
      Updated to reflect building with Visual Studio 2008, with just the
      Platform SDK, and for 64-bit Windows.
      b2aab424
    • T
      Fix relcache reload mechanism to be more robust in the face of errors · 491dd4a9
      Tom Lane 提交于
      occurring during a reload, such as query-cancel.  Instead of zeroing out
      an existing relcache entry and rebuilding it in place, build a new relcache
      entry, then swap its contents with the old one, then free the new entry.
      This avoids problems with code believing that a previously obtained pointer
      to a cache entry must still reference a valid entry, as seen in recent
      failures on buildfarm member jaguar.  (jaguar is using CLOBBER_CACHE_ALWAYS
      which raises the probability of failure substantially, but the problem
      could occur in the field without that.)  The previous design was okay
      when it was made, but subtransactions and the ResourceOwner mechanism
      make it unsafe now.
      
      Also, make more use of the already existing rd_isvalid flag, so that we
      remember that the entry requires rebuilding even if the first attempt fails.
      
      Back-patch as far as 8.2.  Prior versions have enough issues around relcache
      reload anyway (due to inadequate locking) that fixing this one doesn't seem
      worthwhile.
      491dd4a9
  6. 12 1月, 2010 5 次提交