This test stage ran filerep_end_to_end test suite work-load and peformed crash
testing with the same. Takes around 2 hours for completion, It runs with
extremely heavy lifting things like gpfdist, resource queues, etc... which don't
seem of too much interest to crash testing. In long run really need much
simplfied crash recovery testing by creating wrk load to create all kinds of
xlog records in system and recover with it instead of piggy-backing for
work-loads on these already heavy test jobs.

This applies to tests that create a database with checkpoint skip fault
injected. Create database now requests checkpoint and if it is skipped, any
modifications to the template database pending to be written are potentially
lost. The database template0 is guaranteed to not have any modifications
because user connections are not allowed on it so use the same for testing.
Signed-off-by: NXin Zhang <xzhang@pivotal.io>

Also, update some answer files.
Signed-off-by: NXin Zhang <xzhang@pivotal.io>

* Add note about updatable cursor restriction

* Update/delete a single row. Remove mystery <image> tag.

* Remove suggestion that cursors can be updated with a dynamic PL/pgSQL execute statement.

* Edit out passive voice.

The count(*) on exttab_cte_1 errorlog has failed without explanation,
and without being reproducible, both locally and on the CI pipeline.
Since the errorlog might hold insights into what went wrong, print it
in an ignored block to preserve it for debugging before it's lost.
This will include the errorlog output prefixed with GP_IGNORE in the
regression.diffs file.

We have tons of tests on creating AO and AOCO tables in the regular
regression suite, with and without checksum. And a lot of tests on inserts
to AO/AOCO tests. There are also tests on having indexes on tables,
including AO/AOCO tests. I don't see anything interesting in these
particular combinations.

Blocks started by start_matchignore and start_matchsubs could be
closed by either end_ tag, and only the closing command determined
how the content was parsed/used.  This could lead to subtle issues
as only a more-or-less silent warning was issued in the diff.
Instead, save state from the start_ and match the end_ commands to
ensure they match and fail if they don't.

MetaTrackAddUpdInternal() takes a HeapTuple as argument, which in
turn is defined as a pointer to a HeapTupleData structure. Pass
NULL rather than InvalidOid as that gets treated as a null pointer
constant causing a compiler warning:

heap.c:750:13: warning: expression which evaluates to zero treated
               as a null pointer constant of type 'HeapTuple'
               (aka 'struct HeapTupleData *')
      [-Wnon-literal-null-conversion]

The old cdbfast test suite had tests for these. Seems like a good thing to
test.

These exact same tests were already in the 'external_table' and
'external_table_create_privs' tests in the main test suite. And they're not
specific to the gpfdist protocol, so indeed belong in the main test suite,
not here.

All the readable tests are moved to a new regression suite in
contrib/formatter_fixedwidth, next to the source. Writable tests, however
are added to gpfdist's 'custom_format' test, which already contained one
writable test like this (query07, in the old test suite).

Some minor changes to the original tests:

* Use file:// urls instead of gpfdist:// urls, for the readable tests.
  That's simpler, as you don't need a running gpfdist server.

* Left out a couple of redundant tests. Queries 6 and 7 were already in
  gpfdist's 'custom_format' test suite.

I kept the original numbering, so that you can relate to the old test
suite. That will become obsolete as soon as this is committed, but might
be useful for reviewing.

Signed-off-by: NTom Meyer <tmeyer@pivotal.io>

We do this to ensure all PRs will get picked up by the pipeline. Because
of a Concourse bug with specifying `version: every`, we are not able to
have a conventional pipeline with separate jobs.
Signed-off-by: NJingyi Mei <jmei@pivotal.io>

Signed-off-by: NTodd Sedano <tsedano@pivotal.io>

This is a backport of:
From 4893ccd0 Mon Sep 17 00:00:00 2001
From: Robert Haas <rhaas@postgresql.org>
Date: Sun, 6 Jul 2014 14:52:25 -0400
Subject: [PATCH] Remove swpb-based spinlock implementation for ARMv5 and
 earlier.

Per recent analysis by Andres Freund, this implementation is in fact
unsafe, because ARMv5 has weak memory ordering, which means tha the
CPU could move loads or stores across the volatile store performed by
the default S_UNLOCK.  We could try to fix this, but have no ARMv5
hardware to test on, so removing support seems better.  We can still
support ARMv5 systems on GCC versions new enough to have built-in
atomics support for this platform, and can also re-add support for
the old way if someone has hardware that can be used to test a fix.
However, since the requirement to use a relatively-new GCC hasn't
been an issue for ARMv6 or ARMv7, which lack the swpb instruction
altogether, perhaps it won't be an issue for ARMv5 either.

Signed-off-by: NTom Meyer <tmeyer@pivotal.io>

A collection typo fixes that were lying around.

[ci skip]

- Update sql/answer files to set timezone to PST.
- This prevents test failures if the tests are run on a
  machine that has a different timezone.

Authors: Chris Hajas and Karen Huddleston

Authors: Chris Hajas and Todd Sedano

read_bytes will be negative if read() returns a negative value on error.
Therefore, this should be a signed int.

This is a backup-breaking failure and the dump should exit rather than
simply breaking from the loop.

These .sql files assumed that the timezone for machines running the tests would
have the timezone as PST/PDT. This commit explicitly sets the timezone to PST in
the .sql files and updates the .ans files to handle this new behavior.

This resolves #1880. Thanks Lirong Jian for the inital PR #1952.

Details:
Fixed a typo of string comparison in cdbexplain
Fix the typo for UNINITIALIZED_SORT.
Add new method to convert sort space type str to enum.

These were not that exciting tests, because ORCA falls back to the Postgres
planner for these queries. But it's a reasonable test case of partition
pruning in general, after adding a WHERE clauses to the query, so add one
such test case to the main test suite.

These tests are from the legacy cdbfast test suite, from
writable_ext_tbl/test_* files. They're not very exciting, and we already
had tests for some variants of these commands, but looking at the way all
these privileges are handled in the code, perhaps it's indeed best to have
tests for many different combinations. The tests run in under a second, so
it's not too much of a burden.

Compared to the original tests, I removed the SELECTs and INSERTs that
tested that you can also read/write the external tables, after successfully
creating one. Those don't seem very useful, they all basically test that
the owner of an external table can read/write it. By getting rid of those
statements, these tests don't need a live gpfdist server to be running,
which makes them a lot simpler and faster to run.

Also move the existing tests on these privileges from the 'external_table'
test to the new file.

The gpcheckcat 'inconsistent' check should skip the pg_index.indcheckxmin column
for now as due to the HOT feature, the value of this column can be different
between the master and the segments.

A more long term fix will resolve the underlying issue that makes the
indcheckxmin column value to be different between the master and the segments.

rolresgroup was added to pg_authid in previous commits, we also should
add it to pg_authid.
Signed-off-by: NNing Yu <nyu@pivotal.io>

There is the same restrictions with the CREATE ROLE syntax, only
superuser can be assigned to the admin_group.

    -- assign the role r1 to resource group g1
    ALTER ROLE r1 RESOURCE GROUP g1;
Signed-off-by: NNing Yu <nyu@pivotal.io>

There are two default resource groups, default_group and admin_group,
roles will be assigned to one of them depending on they are superuser or
not unless a group is explicitly specified. Only superuser can be
assigned to the admin_group.

    -- create a role r1 and assign it to resgroup g1
    CREATE ROLE r1 RESOURCE GROUP g1;
Signed-off-by: NNing Yu <nyu@pivotal.io>

[ci skip]

dblink is a bulit-in module of postgresql, this patch enable it in GPDB.

1. Enable compiling dblink with GPDB
2. Update and enable dblink test cases

Known issue:

1. The following functions are not supported by GPDB and disabled temporarily
   due to GPDB behavior changed.
   dblink_send_query()
   dblink_is_busy()
   dblink_get_result()

2. Anonymous connection and connection by name are not supported in a nested statement with
   both write and read. E.g.
   INSERT INTO tblname SELECT * FROM dblink(['connName'],'SELECT * FROM otherdb.tblname') as tbl;
   Currently, only connection with connection string is supported in such statements.
Signed-off-by: NPeifeng Qiu <pqiu@pivotal.io>
Signed-off-by: NYuan Zhao <yuzhao@pivotal.io>
Signed-off-by: NJianxia Chen <jchen@pivotal.io>
Signed-off-by: NAdam Lee <ali@pivotal.io>

v22 of the pull_request resource removes the default behavior making
shallow clones. A shallow clone will not fetch tags, since no tagged
commits are walked over during the fetch. We need tags to be present to
build and determine the version string.
Signed-off-by: NJingyi Mei <jmei@pivotal.io>

Signed-off-by: NDavid Sharp <dsharp@pivotal.io>

* Transaction id support

* Removed extra line
[ci skip]

- Also remove unwanted test: the abort test should be skipped,
  based on feedback from Storage team
Signed-off-by: NC.J. Jameson <cjameson@pivotal.io>