1. 25 11月, 2011 3 次提交
    • R
      Move "hot" members of PGPROC into a separate PGXACT array. · ed0b409d
      Robert Haas 提交于
      This speeds up snapshot-taking and reduces ProcArrayLock contention.
      Also, the PGPROC (and PGXACT) structures used by two-phase commit are
      now allocated as part of the main array, rather than in a separate
      array, and we keep ProcArray sorted in pointer order.  These changes
      are intended to minimize the number of cache lines that must be pulled
      in to take a snapshot, and testing shows a substantial increase in
      performance on both read and write workloads at high concurrencies.
      
      Pavan Deolasee, Heikki Linnakangas, Robert Haas
      ed0b409d
    • T
      Fix unsupported options in CREATE TABLE ... AS EXECUTE. · 9ed439a9
      Tom Lane 提交于
      The WITH [NO] DATA option was not supported, nor the ability to specify
      replacement column names; the former limitation wasn't even documented, as
      per recent complaint from Naoya Anzai.  Fix by moving the responsibility
      for supporting these options into the executor.  It actually takes less
      code this way ...
      
      catversion bump due to change in representation of IntoClause, which might
      affect stored rules.
      9ed439a9
    • A
      Dump an unvalidated constraint separately from its table · e90710f3
      Alvaro Herrera 提交于
      This allows possibly violating data to be imported before the constraint
      is installed.
      
      Bug reported by Thom Brown
      e90710f3
  2. 24 11月, 2011 5 次提交
    • H
      Preserve SQLSTATE when an SPI error is propagated through PL/python · f21fc7f9
      Heikki Linnakangas 提交于
      exception handler. This was a regression in 9.1, when the capability
      to catch specific SPI errors was added, so backpatch to 9.1.
      
      Mika Eloranta, with some editing by Jan Urbański.
      f21fc7f9
    • B
      Add pg_upgrade ENABLE_SAME_CATVERSION_UPGRADES macro for testing to · 5df1403b
      Bruce Momjian 提交于
      allow upgrades of the same catalog version.  (Doesn't work for
      tablespaces, as indicated by C comment.)
      5df1403b
    • T
      Some more editing of the range-types documentation. · 604d4c4c
      Tom Lane 提交于
      Be more thorough about specifying the expectations for canonical and
      subtype_diff functions, and move that info to the same place.
      604d4c4c
    • T
      Adjust range_adjacent to support different canonicalization rules. · b7056b83
      Tom Lane 提交于
      The original coding would not work for discrete ranges in which the
      canonicalization rule is to produce symmetric boundaries (either [] or ()
      style), as noted by Jeff Davis.  Florian Pflug pointed out that we could
      fix that by invoking the canonicalization function to see if the range
      "between" the two given ranges normalizes to empty.  This implementation
      of Florian's idea is a tad slower than the original code, but only in the
      case where there actually is a canonicalization function --- if not, it's
      essentially the same logic as before.
      b7056b83
    • T
      Creator of a range type must have permission to call support functions. · a912a278
      Tom Lane 提交于
      Since range types can be created by non-superusers, we need to consider
      their permissions.  Ideally we'd check this when the type is used, not
      when it's created, but that seems like much more trouble than it's worth.
      The existing restriction that the support functions be immutable already
      prevents most cases where an unauthorized call to a function might be
      thought a security issue, and the fact that the user has no access to
      the results of the system's calls to subtype_diff closes off the other
      plausible reason for concern.  So this check is basically pro-forma,
      but let's make it anyway.
      a912a278
  3. 23 11月, 2011 6 次提交
    • T
      Remove user-selectable ANALYZE option for range types. · 74c1723f
      Tom Lane 提交于
      It's not clear that a per-datatype typanalyze function would be any more
      useful than a generic typanalyze for ranges.  What *is* clear is that
      letting unprivileged users select typanalyze functions is a crash risk or
      worse.  So remove the option from CREATE TYPE AS RANGE, and instead put in
      a generic typanalyze function for ranges.  The generic function does
      nothing as yet, but hopefully we'll improve that before 9.2 release.
      74c1723f
    • T
      Remove zero- and one-argument range constructor functions. · df735844
      Tom Lane 提交于
      Per discussion, the zero-argument forms aren't really worth the catalog
      space (just write 'empty' instead).  The one-argument forms have some use,
      but they also have a serious problem with looking too much like functional
      cast notation; to the point where in many real use-cases, the parser would
      misinterpret what was wanted.
      
      Committing this as a separate patch, with the thought that we might want
      to revert part or all of it if we can think of some way around the cast
      ambiguity.
      df735844
    • T
      Improve implementation of range-contains-element tests. · cddc819e
      Tom Lane 提交于
      Implement these tests directly instead of constructing a singleton range
      and then applying range-contains.  This saves a range serialize/deserialize
      cycle as well as a couple of redundant bound-comparison steps, and adds
      very little code on net.
      
      Remove elem_contained_by_range from the GiST opclass: it doesn't belong
      there because there is no way to use it in an index clause (where the
      indexed column would have to be on the left).  Its commutator is in the
      opclass, and that's what counts.
      cddc819e
    • R
      Check for INSERT privileges in SELECT INTO / CREATE TABLE AS. · f1b4aa2a
      Robert Haas 提交于
      In the normal course of events, this matters only if ALTER DEFAULT
      PRIVILEGES has been used to revoke default INSERT permission.  Whether
      or not the new behavior is more or less likely to be what the user wants
      when dealing only with the built-in privilege facilities is arguable,
      but it's clearly better when using a loadable module such as sepgsql
      that may use the hook in ExecCheckRTPerms to enforce additional
      permissions checks.
      
      KaiGai Kohei, reviewed by Albe Laurenz
      f1b4aa2a
    • T
      Still more review for range-types patch. · 766948be
      Tom Lane 提交于
      Per discussion, relax the range input/construction rules so that the
      only hard error is lower bound > upper bound.  Cases where the lower
      bound is <= upper bound, but the range nonetheless normalizes to empty,
      are now permitted.
      
      Fix core dump in range_adjacent when bounds are infinite.  Marginal
      cleanup of regression test cases, some more code commenting.
      766948be
    • P
      Small markup and wording improvement · 024ea25c
      Peter Eisentraut 提交于
      024ea25c
  4. 22 11月, 2011 3 次提交
    • S
      Continue to allow VACUUM to mark last block of index dirty · 2d2841a5
      Simon Riggs 提交于
      even when there is no work to do. Further analysis required.
      Revert of patch c1458cc4
      2d2841a5
    • T
      More code review for rangetypes patch. · a4ffcc8e
      Tom Lane 提交于
      Fix up some infelicitous coding in DefineRange, and add some missing error
      checks.  Rearrange operator strategy number assignments for GiST anyrange
      opclass so that they don't make such a mess of opr_sanity's table of
      operator names associated with different strategy numbers.  Assign
      hopefully-temporary selectivity estimators to range operators that didn't
      have one --- poor as the estimates are, they're still a lot better than the
      default 0.5 estimate, and they'll shut up the opr_sanity test that wants to
      see selectivity estimators on all built-in operators.
      a4ffcc8e
    • T
      Fix citext upgrade script to update derived copies of pg_type.typcollation. · 9b97b7f8
      Tom Lane 提交于
      If the existing citext type has not merely been created, but used in any
      tables, then the upgrade script wasn't doing enough.  We have to update
      attcollation for each citext table column, and indcollation for each citext
      index column, as well.  Per report from Rudolf van der Leeden.
      9b97b7f8
  5. 21 11月, 2011 1 次提交
  6. 19 11月, 2011 3 次提交
    • T
      Avoid floating-point underflow while tracking buffer allocation rate. · 40d35036
      Tom Lane 提交于
      When the system is idle for awhile after activity, the "smoothed_alloc"
      state variable in BgBufferSync converges slowly to zero.  With standard
      IEEE float arithmetic this results in several iterations with denormalized
      values, which causes kernel traps and annoying log messages on some
      poorly-designed platforms.  There's no real need to track such small values
      of smoothed_alloc, so we can prevent the kernel traps by forcing it to zero
      as soon as it's too small to be interesting for our purposes.  This issue
      is purely cosmetic, since the iterations don't happen fast enough for the
      kernel traps to pose any meaningful performance problem, but still it seems
      worth shutting up the log messages.
      
      The kernel log messages were previously reported by a number of people,
      but kudos to Greg Matthews for tracking down exactly where they were coming
      from.
      40d35036
    • T
      Further review of range-types patch. · a1a233af
      Tom Lane 提交于
      Lots of documentation cleanup today, and still more type_sanity tests.
      a1a233af
    • S
      Avoid marking buffer dirty when VACUUM has no work to do. · c1458cc4
      Simon Riggs 提交于
      When wal_level = 'hot_standby' we touched the last page of the
      relation during a VACUUM, even if nothing else had happened.
      That would alter the LSN of the last block and set the mtime
      of the relation file unnecessarily. Noted by Thom Brown.
      c1458cc4
  7. 18 11月, 2011 13 次提交
    • T
      Do missed autoheader run for previous commit. · f6438f66
      Tom Lane 提交于
      f6438f66
    • B
      Remove scandir() requirement in pg_upgrade; instead just use readdir() · 7012b5ed
      Bruce Momjian 提交于
      --- we were not using the scandir pattern filtering anyway.  This also
      removes the scandir requirement in configure.
      7012b5ed
    • R
      Further consolidation of DROP statement handling. · fc6d1006
      Robert Haas 提交于
      This gets rid of an impressive amount of duplicative code, with only
      minimal behavior changes.  DROP FOREIGN DATA WRAPPER now requires object
      ownership rather than superuser privileges, matching the documentation
      we already have.  We also eliminate the historical warning about dropping
      a built-in function as unuseful.  All operations are now performed in the
      same order for all object types handled by dropcmds.c.
      
      KaiGai Kohei, with minor revisions by me
      fc6d1006
    • T
      Declare range inclusion operators as taking anyelement not anynonarray. · 709aca59
      Tom Lane 提交于
      Use of anynonarray was a crude hack to get around ambiguity versus the
      array inclusion operators of the same names.  My previous patch to extend
      the parser's type resolution heuristics makes that unnecessary, so use
      the more general declaration instead.  This eliminates a wart that these
      operators couldn't be used with ranges over arrays, which are otherwise
      supported just fine.
      
      Also, mark range_before and range_after as commutator operators,
      per discussion with Jeff Davis.
      709aca59
    • T
      Extend the unknowns-are-same-as-known-inputs type resolution heuristic. · 1a8b9fb5
      Tom Lane 提交于
      For a very long time, one of the parser's heuristics for resolving
      ambiguous operator calls has been to assume that unknown-type literals are
      of the same type as the other input (if it's known).  However, this was
      only used in the first step of quickly checking for an exact-types match,
      and thus did not help in resolving matches that require coercion, such as
      matches to polymorphic operators.  As we add more polymorphic operators,
      this becomes more of a problem.  This patch adds another use of the same
      heuristic as a last-ditch check before failing to resolve an ambiguous
      operator or function call.  In particular this will let us define the range
      inclusion operator in a less limited way (to come in a follow-on patch).
      1a8b9fb5
    • T
      Fix range_cmp_bounds for the case of equal-valued exclusive bounds. · bf4f96b5
      Tom Lane 提交于
      Also improve its comments and related regression tests.
      
      Jeff Davis, with some further adjustments by Tom
      bf4f96b5
    • A
      Don't quote language name · ef27c81d
      Alvaro Herrera 提交于
      Same as previous patch, but give it actual thought this time
      ef27c81d
    • A
      Don't quote language name · b44dda71
      Alvaro Herrera 提交于
      It's been deprecated for ages according to Tom, and it breaks now given
      the previous patch anyway.
      
      Per buildfarm
      b44dda71
    • R
      Remove ancient downcasing code from procedural language operations. · 67dc4eed
      Robert Haas 提交于
      A very long time ago, language names were specified as literals rather
      than identifiers, so this code was added to do case-folding.  But that
      style has ben deprecated for many years so this isn't needed any more.
      Language names will still be downcased when specified as unquoted
      identifiers, but quoted identifiers or the old style using string
      literals will be left as-is.
      67dc4eed
    • B
    • B
      Fix pg_upgrade's pg_scandir_internal() to properly handle a NULL · 988f907d
      Bruce Momjian 提交于
      pattern, which is used on PG 9.1 and HEAD (but not pre-9.1).  Fixes
      crash on Windows.
      
      Backpatched to 9.1.
      
      Reported by Mark Dilger
      988f907d
    • B
    • R
      Restructure get_object_address() so it's safe against concurrent DDL. · b3ad5d02
      Robert Haas 提交于
      This gives a much better error message when the object of interest is
      concurrently dropped and avoids needlessly failing when the object of
      interest is concurrently dropped and recreated.  It also improves the
      behavior of two concurrent DROP IF EXISTS operations targeted at the
      same object; as before, one will drop the object, but now the other
      will emit the usual NOTICE indicating that the object does not exist,
      instead of rolling back.  As a fringe benefit, it's also slightly
      less code.
      b3ad5d02
  8. 17 11月, 2011 2 次提交
  9. 16 11月, 2011 3 次提交
    • R
      Don't elide blank lines when accumulating psql command history. · ff4fd4bf
      Robert Haas 提交于
      This can change the meaning of queries, if the blank line happens to
      occur in the middle of a quoted literal, as per complaint from Tomas Vondra.
      
      Back-patch to all supported branches.
      ff4fd4bf
    • T
      Improve caching in range type I/O functions. · 04da3232
      Tom Lane 提交于
      Cache the the element type's I/O info across calls, not only the range
      type's info.  In passing, also clean up hash_range a bit more.
      04da3232
    • T
      Restructure function-internal caching in the range type code. · 37ee4b75
      Tom Lane 提交于
      Move the responsibility for caching specialized information about range
      types into the type cache, so that the catalog lookups only have to occur
      once per session.  Rearrange APIs a bit so that fn_extra caching is
      actually effective in the GiST support code.  (Use of OidFunctionCallN is
      bad enough for performance in itself, but it also prevents the function
      from exploiting fn_extra caching.)
      
      The range I/O functions are still not very bright about caching repeated
      lookups, but that seems like material for a separate patch.
      
      Also, avoid unnecessary use of memcpy to fetch/store the range type OID and
      flags, and don't use the full range_deserialize machinery when all we need
      to see is the flags value.
      
      Also fix API error in range_gist_penalty --- it was failing to set *penalty
      for any case involving an empty range.
      37ee4b75
  10. 15 11月, 2011 1 次提交
    • T
      Fix alignment and toasting bugs in range types. · ad50934e
      Tom Lane 提交于
      A range type whose element type has 'd' alignment must have 'd' alignment
      itself, else there is no guarantee that the element value can be used
      in-place.  (Because range_deserialize uses att_align_pointer which forcibly
      aligns the given pointer, violations of this rule did not lead to SIGBUS
      but rather to garbage data being extracted, as in one of the added
      regression test cases.)
      
      Also, you can't put a toast pointer inside a range datum, since the
      referenced value could disappear with the range datum still present.
      For consistency with the handling of arrays and records, I also forced
      decompression of in-line-compressed bound values.  It would work to store
      them as-is, but our policy is to avoid situations that might result in
      double compression.
      
      Add assorted regression tests for this, and bump catversion because of
      fixes to built-in pg_type entries.
      
      Also some marginal cleanup of inconsistent/unnecessary error checks.
      ad50934e