1. 30 12月, 2015 4 次提交
    • H
      Fix expected output for DMLstmnt test. · e9d5d0db
      Heikki Linnakangas 提交于
      Commit 9e25d97f changed the .sql file, but forgot to change the expected
      outpout.
      e9d5d0db
    • H
      Silence warnings about converting string constants to char * without cast. · 4607a4a3
      Heikki Linnakangas 提交于
      * Add 'const' to arguments of some functions. While we're at it, remove the
      duplicate extern declaration of FaultInjector_InjectFaultIfSet from
      gpdbdefs.h.
      
      * pstrdup() constants passed to makeString(). I think the lack of copy
      was harmless, but makeString() explicitly says that the caller should make
      a copy, and all other callers seem to obey that, so better safe than sorry.
      4607a4a3
    • M
      Remove ALTER LANGUAGE plpgsql in bugbuster DMLstmnt test. · 9e25d97f
      Marbin Tan 提交于
      Removing ALTER LANGUAGE test as it's conflicting with a
      different test, specifically functions.sql.
      9e25d97f
    • H
      Remove hardcoded information about pg_part_rule_def functions. · dd43545b
      Heikki Linnakangas 提交于
      The hack was put in place, because prodataaccess values for these functions
      are wrong in the catalogs. They should be marked as READS SQL DATA, but
      they're marked as NO SQL. However, there are many more functions that are
      similarly marked incorrectly, so we really should go through the pg_proc
      catalog and fix all of them. But I'll leave that for another patch.
      
      ORCA doesn't actually pay any attention to the prodataaccess field. It used
      to to use it for optimization purposes at some point, but the code was taken
      out because most functions are indeed mislabeled, and it was causing
      problems.
      
      This hack was subtly wrong anyway: the functions were marked as set
      returning functions in the hard-coded structs, but they're not in fact
      set-returning.
      
      While we're at it, remove hardcoded OID of count() aggregate function, and
      include it from pg_proc.h instead.
      dd43545b
  2. 29 12月, 2015 1 次提交
    • J
      gpdbrestore --truncate will not try to truncate a nonexistent table. · 36e4fed9
      Jimmy Yih 提交于
      Previously, if the set of tables to be restored using gpdbrestore --truncate
      included a table that did not exist in the target database, gpdbrestore would
      raise an exception when attempting to truncate the nonexistent table.  Now,
      gpdbrestore displays a warning regarding the nonexistent table, and the table is
      restored normally.
      
      Authors: Jimmy Yih and James McAtamney
      36e4fed9
  3. 28 12月, 2015 5 次提交
  4. 24 12月, 2015 2 次提交
  5. 23 12月, 2015 6 次提交
  6. 22 12月, 2015 5 次提交
    • Y
      6946ee2c
    • Y
      fix dead loop issue when file is empty · 69be90c5
      Yandong Yao 提交于
      69be90c5
    • Y
    • Y
      fix failed orca-case: fix information_schema.out ans files · 358b99c3
      Yu Yang 提交于
      358b99c3
    • Y
      VARIADIC paramters of UDF ported from PostgreSQL. · 4665a8d5
      Yu Yang 提交于
      User could use VARIADIC to specify parameter list when defining UDF
      if they want to use variadic parameters. It is easier for user to write
      only one variadic function instead of same name function with different
      parameters. An example for using variadic:
      create function concat(text, variadic anyarray) returns text as $$
      select array_to_string($2, $1);
      $$ language sql immutable strict;
      
      select concat('%', 1, 2, 3, 4, 5);
      
      NOTE: The variadic change set is ported from upstream of PostgreSQL:
      commit 517ae403
      Author: Tom Lane <tgl@sss.pgh.pa.us>
      Date:   Thu Dec 18 18:20:35 2008 +0000
      
      Code review for function default parameters patch.  Fix numerous problems as
      per recent discussions.  In passing this also fixes a couple of bugs in
      the previous variadic-parameters patch.
      
      commit 6563e9e2
      Author: Tom Lane <tgl@sss.pgh.pa.us>
      Date:   Wed Jul 16 16:55:24 2008 +0000
      
      Add a "provariadic" column to pg_proc to eliminate the remarkably expensive
      need to deconstruct proargmodes for each pg_proc entry inspected by
      FuncnameGetCandidates().  Fixes function lookup performance regression
      caused by yesterday's variadic-functions patch.
      
      In passing, make pg_proc.probin be NULL, rather than a dummy value '-',
      in cases where it is not actually used for the particular type of function.
      This should buy back some of the space cost of the extra column.
      
      commit d89737d3
      Author: Tom Lane <tgl@sss.pgh.pa.us>
      Date:   Wed Jul 16 01:30:23 2008 +0000
      
      Support "variadic" functions, which can accept a variable number of arguments
      so long as all the trailing arguments are of the same (non-array) type.
      The function receives them as a single array argument (which is why they
      have to all be the same type).
      
      It might be useful to extend this facility to aggregates, but this patch
      doesn't do that.
      
      This patch imposes a noticeable slowdown on function lookup --- a follow-on
      patch will fix that by adding a redundant column to pg_proc.
      
      Conflicts:
      	src/backend/gpopt/gpdbwrappers.cpp
      4665a8d5
  7. 21 12月, 2015 4 次提交
  8. 20 12月, 2015 3 次提交
    • R
      Fix issue #74, make cluster in gpdemo failed(initdb failed on a 32-bit VM) · 94eacb66
      Robert Mu 提交于
      Heikki suggested that we backport atomic operation from PostgreSQL 9.5 to
      fix this
      
          commit b64d92f1
          Author: Andres Freund <andres@anarazel.de>
          Date:   Thu Sep 25 23:49:05 2014 +0200
      
          Add a basic atomic ops API abstracting away platform/architecture details.
      
          Several upcoming performance/scalability improvements require atomic
          operations. This new API avoids the need to splatter compiler and
          architecture dependent code over all the locations employing atomic
          ops.
      
          For several of the potential usages it'd be problematic to maintain
          both, a atomics using implementation and one using spinlocks or
          similar. In all likelihood one of the implementations would not get
          tested regularly under concurrency. To avoid that scenario the new API
          provides a automatic fallback of atomic operations to spinlocks. All
          properties of atomic operations are maintained. This fallback -
          obviously - isn't as fast as just using atomic ops, but it's not bad
          either. For one of the future users the atomics ontop spinlocks
          implementation was actually slightly faster than the old purely
          spinlock using implementation. That's important because it reduces the
          fear of regressing older platforms when improving the scalability for
          new ones.
      
          The API, loosely modeled after the C11 atomics support, currently
          provides 'atomic flags' and 32 bit unsigned integers. If the platform
          efficiently supports atomic 64 bit unsigned integers those are also
          provided.
      
          To implement atomics support for a platform/architecture/compiler for
          a type of atomics 32bit compare and exchange needs to be
          implemented. If available and more efficient native support for flags,
          32 bit atomic addition, and corresponding 64 bit operations may also
          be provided. Additional useful atomic operations are implemented
          generically ontop of these.
      
          The implementation for various versions of gcc, msvc and sun studio have
          been tested. Additional existing stub implementations for
          * Intel icc
          * HUPX acc
          * IBM xlc
          are included but have never been tested. These will likely require
          fixes based on buildfarm and user feedback.
      
          As atomic operations also require barriers for some operations the
          existing barrier support has been moved into the atomics code.
      
          Author: Andres Freund with contributions from Oskari Saarenmaa
          Reviewed-By: Amit Kapila, Robert Haas, Heikki Linnakangas and Álvaro Herrera
          Discussion: CA+TgmoYBW+ux5-8Ja=Mcyuy8=VXAnVRHp3Kess6Pn3DMXAPAEA@mail.gmail.com,
              20131015123303.GH5300@awork2.anarazel.de,
              20131028205522.GI20248@awork2.anarazel.de
      94eacb66
    • E
      OSX commercial blds, generate i686 instructions · 4f80ebf5
      Ed Espino 提交于
      For OSX commercial builds, instruct the gcc compiler to produce
      i686 (CPU) instructions.  This is needed to support an upstream
      PostgreSQL merge which uses atomic instructions introduced in one of
      those later CPUs.
      
      Previously, there was no autoconf test for those instructions, and we
      just compiled hand-crafted assembly to use those instructions anyway,
      even though the rest of the compiler was targeting the older cpus.
      
      reference: https://wiki.gentoo.org/wiki/GCC_optimization#-march
      
        Different CPUs have different capabilities, support different
        instruction sets, and have different ways of executing code. The
        -march flag will instruct the compiler to produce specific code for
        the system's CPU, with all its capabilities, features, instruction
        sets, quirks, and so on.
      4f80ebf5
    • A
      c8b6698f
  9. 19 12月, 2015 1 次提交
  10. 18 12月, 2015 3 次提交
    • H
      Fix bug in IN-to-join conversion. · f51ff613
      Heikki Linnakangas 提交于
      This bug was introduced in merge commit 1f4ad703, by a mishap in merging
      the upstream changes to convert_IN_to_join. The constructed InInfoClause
      entry was accidentally added to the list of in-clauses twice. That was
      usually harmless, but if the in-clause was later pulled up from a subquery,
      the code adjusts the varnos while merging the range tables of the subquery
      and its parent, ran twice. In doing so, it adjusted the varno twice,
      pointing it to wrong or non-existing range table entry.
      f51ff613
    • D
      Remove unused gnutar command lookup · b287a990
      Daniel Gustafsson 提交于
      While GNU TAR is used throughout GPDB this definition doesn't seem
      to be used so avoid spending cycles performing it.
      b287a990
    • N
      Fixed coverity issue about not freeing a variable · 28637e54
      Nikhil Kak 提交于
      28637e54
  11. 17 12月, 2015 6 次提交
    • D
      Merge commit '978fff79' from PostgreSQL 8.3 · 4b672210
      Daniel Gustafsson 提交于
      Almost everything in this set of commits was already merged via the XML merge
      from 9.1 which is in the tree already. The largeobject tests included in this
      merge (parallel and serial schedule) are currently left disabled due to test
      breakage, this needs to be handled in subsequent commits. The test is altered
      to distribute around the oid column (which is alse the default choice by GPDB
      in case no explicit distribution column in specified).
      
      Conflicts:
        Makefile
        doc/src/sgml/installation.sgml
        doc/src/sgml/manage-ag.sgml
        src/backend/Makefile
        src/backend/access/Makefile
        src/backend/access/common/Makefile
        src/backend/access/gin/Makefile
        src/backend/access/gist/Makefile
        src/backend/access/hash/Makefile
        src/backend/access/heap/Makefile
        src/backend/access/index/Makefile
        src/backend/access/nbtree/Makefile
        src/backend/bootstrap/Makefile
        src/backend/commands/Makefile
        src/backend/executor/Makefile
        src/backend/executor/execQual.c
        src/backend/lib/Makefile
        src/backend/libpq/Makefile
        src/backend/main/Makefile
        src/backend/nodes/Makefile
        src/backend/optimizer/Makefile
        src/backend/optimizer/geqo/Makefile
        src/backend/optimizer/path/Makefile
        src/backend/optimizer/plan/Makefile
        src/backend/optimizer/prep/Makefile
        src/backend/optimizer/util/Makefile
        src/backend/port/darwin/Makefile
        src/backend/port/nextstep/Makefile
        src/backend/port/sunos4/Makefile
        src/backend/port/win32/Makefile
        src/backend/postmaster/Makefile
        src/backend/rewrite/Makefile
        src/backend/storage/Makefile
        src/backend/storage/buffer/Makefile
        src/backend/storage/file/Makefile
        src/backend/storage/freespace/Makefile
        src/backend/storage/ipc/Makefile
        src/backend/storage/large_object/Makefile
        src/backend/storage/lmgr/Makefile
        src/backend/storage/page/Makefile
        src/backend/storage/smgr/Makefile
        src/backend/tcop/Makefile
        src/backend/utils/adt/Makefile
        src/backend/utils/adt/xml.c
        src/backend/utils/cache/Makefile
        src/backend/utils/error/Makefile
        src/backend/utils/error/elog.c
        src/backend/utils/hash/Makefile
        src/backend/utils/init/Makefile
        src/backend/utils/mb/Makefile
        src/backend/utils/mmgr/Makefile
        src/backend/utils/resowner/Makefile
        src/backend/utils/sort/Makefile
        src/backend/utils/time/Makefile
        src/bin/Makefile
        src/bin/initdb/initdb.c
        src/bin/psql/large_obj.c
        src/include/catalog/catversion.h
        src/include/utils/xml.h
        src/interfaces/Makefile
        src/interfaces/ecpg/compatlib/Makefile
        src/interfaces/ecpg/ecpglib/Makefile
        src/interfaces/ecpg/pgtypeslib/Makefile
        src/interfaces/ecpg/test/Makefile
        src/interfaces/ecpg/test/Makefile.regress
        src/test/regress/expected/xml.out
        src/test/regress/expected/xml_1.out
        src/test/regress/parallel_schedule
        src/test/regress/sql/xml.sql
      4b672210
    • E
      Copy perl modules (atmsort.pm & explain.pm) to bin · b6019439
      Ed Espino 提交于
      Additional perl module copy target in gpMgmt/Makefile:
      Supporting the commercial build, the new perl modules (atmsort.pm &
      explain.pm) supporting gpdiff.pl need to be copied to the bin directory.
      b6019439
    • E
      Copy perl modules (atmsort.pm & explain.pm) to bin · bf30b6a2
      Ed Espino 提交于
      Supporting the commercial build, the new perl modules (atmsort.pm &
      explain.pm) supporting gpdiff.pl need to be copied to the bin directory.
      bf30b6a2
    • H
      Track changes to catalogs that contain data cached in the metadata cache. · 7167ac78
      Heikki Linnakangas 提交于
      ORCA uses its own metadata cache to store information about relations,
      operators etc. Currently, we always reset the cache when planning a query,
      unless the optimizer_release_mdcache GUC is turned off, which is slow.
      
      To make it safe to turn optimizer_release_mdcache off, use the catalog
      cache invalidation mechanism to still reset the cache when there are
      changes to the catalogs that affect the metadata cache.
      
      The ORCA-facing interface of this is the same as in the previous attempt:
      A function that returns true/false indicating whether there has been any
      catalog changes whatsoever since last call.
      7167ac78
    • H
      Revert "Metadata Versioning feature for the ORCA Query Optimizer." · 6453dac7
      Heikki Linnakangas 提交于
      This reverts commit 6c31a3b4. Per
      discussion, we will implement the same functionality in a simpler way.
      6453dac7
    • H
      Fix outdated syscache information. · ddfb89a9
      Heikki Linnakangas 提交于
      Fix the fake-tidycat definitions of OPFAMILYOID and OPFAMILYAMNAMENSP
      syscaches. Remove reference to INHRELID - that syscache removed by one of
      the merged upstream 8.3 patches. Re-run tidycat.pl, to correct the "last"
      id number in syscache.h.
      ddfb89a9