method control structure, or a table of control structures.

. Use type LOCKMASK where an int is not a counter.

. Get rid of INVALID_TABLEID, use INVALID_LOCKMETHOD instead.

. Use INVALID_LOCKMETHOD instead of (LOCKMETHOD) NULL, because
  LOCKMETHOD is not a pointer.

. Define and use macro LockMethodIsValid.

. Rename LOCKMETHOD to LOCKMETHODID.

. Remove global variable LongTermTableId in lmgr.c, because it is
  never used.

. Make LockTableId static in lmgr.c, because it is used nowhere else.
  Why not remove it and use DEFAULT_LOCKMETHOD?

. Rename the lock method control structure from LOCKMETHODTABLE to
  LockMethodData.  Introduce a pointer type named LockMethod.

. Remove elog(FATAL) after InitLockTable() call in
  CreateSharedMemoryAndSemaphores(), because if something goes wrong,
  there is elog(FATAL) in LockMethodTableInit(), and if this doesn't
  help, an elog(ERROR) in InitLockTable() is promoted to FATAL.

. Make InitLockTable() void, because its only caller does not use its
  return value any more.

. Rename variables in lock.c to avoid statements like
        LockMethodTable[NumLockMethods] = lockMethodTable;
        lockMethodTable = LockMethodTable[lockmethod];

. Change LOCKMETHODID type to uint16 to fit into struct LOCKTAG.

. Remove static variables BITS_OFF and BITS_ON from lock.c, because
  I agree to this doubt:
 * XXX is a fetch from a static array really faster than a shift?

. Define and use macros LOCKBIT_ON/OFF.


Manfred Koizar

to note:

1) arttype is numeric. I thought this was the best way of allowing
arbitarily large factorials, even though factorial(2^63) is a large
number. Happy to change to integers if this is overkill.
2) since we're accepting numeric arguments, the patch tests for floats.
If a numeric is passed with non-zero decimal portion, an error is raised
since (from memory) they are undefined.

Gavin Sherry

cnliou.

per gripe from Joe Sunday.

since there is no need to worry about damaged pages when we are going to
overwrite them anyway from the WAL.  Per recent discussion.

while you can actually set them with SET.

This applied patch changes the wording from "Show" to "Set".

octal escape all octets outside the range 0x20 to 0x7e. This fixes
the problem pointed out by Sergey Yatskevich here:
http://archives.postgresql.org/pgsql-bugs/2003-11/msg00140.php

> * Have pg_ctl look at PGHOST in case it is a socket directory

documentation; this patch removes it.

Neil Conway

> * Make LENGTH() of CHAR() not count trailing spaces
>

< * Allow clients to query WITH HOLD cursors and prepared statements
> * Allow clients to query a list of WITH HOLD cursors and prepared statements

<   manuals (Rory)
>   manuals
496c496
< * Jan is Jan Wieck <JanWieck@Yahoo.com> of PeerDirect Corp.
> * Jan is Jan Wieck <JanWieck@Yahoo.com> of Afilias, Inc.

make sure the $Id tags are converted to $PostgreSQL as well ...

standalone backend --- the CVS revision number of postgres.c is not real
useful to anyone.

$Header: -> $PostgreSQL Changes ...

testing $PostgreSQL$ tag

Daniel Convissor

Viktor Vislobokov

persistent_conn was left dangling after a disconnect in the
unnamed connection case, causing a subsequent disconnect to
crash the backend.

--with-openssl options.  This creates too much risk to pick up the wrong
directory accidentally (for example when there are lib64 directories), and
does not really help much with contemporary installation layouts.

was specified.

Ward's report that it can still happen in RC2 forces me to realize that
this is not a can't-happen condition after all, and that the compaction
code had better cope rather than panicking.

reported by Andrea Grassi.

they might be of a wider type.