1. 26 1月, 2014 1 次提交
  2. 25 1月, 2014 5 次提交
    • H
      Add recovery_target='immediate' option. · 71c6a8e3
      Heikki Linnakangas 提交于
      This allows ending recovery as a consistent state has been reached. Without
      this, there was no easy way to e.g restore an online backup, without
      replaying any extra WAL after the backup ended.
      
      MauMau and me.
      71c6a8e3
    • N
      libpq: Support TLS versions beyond TLSv1. · 820f08ca
      Noah Misch 提交于
      Per report from Jeffrey Walton, libpq has been accepting only TLSv1
      exactly.  Along the lines of the backend code, libpq will now support
      new versions as OpenSSL adds them.
      
      Marko Kreen, reviewed by Wim Lewis.
      820f08ca
    • N
      psql: Mention SSL protocol version in \conninfo. · 3a531326
      Noah Misch 提交于
      Marko Kreen, reviewed by Wim Lewis.
      3a531326
    • S
      Avoid minor leak in parallel pg_dump · 6794a9f9
      Stephen Frost 提交于
      During parallel pg_dump, a worker process closing the connection caused
      a minor memory leak (particularly minor as we are likely about to exit
      anyway).  Instead, free the memory in this case prior to returning NULL
      to indicate connection closed.
      
      Spotting by the Coverity scanner.
      
      Back patch to 9.3 where this was introduced.
      6794a9f9
    • H
      Reset unused fields in GIN data leaf page footer. · d150ff57
      Heikki Linnakangas 提交于
      The maxoff field is not used in the new, compressed page format. Let's
      reset it when converting an old-format page to the new format. The code
      won't care either way, but this makes it possible to use the field for
      something else in the future.
      d150ff57
  3. 24 1月, 2014 10 次提交
    • H
      Fix off-by-one in newly-introdcued GIN assertion. · a8f37484
      Heikki Linnakangas 提交于
      Spotted by Alexander Korotkov
      a8f37484
    • H
      In GIN recompression code, use mmemove rather than memcpy, for vacuum. · 398cf255
      Heikki Linnakangas 提交于
      When vacuuming a data leaf page, any compressed posting lists that are not
      modified, are copied back to the buffer from a later location in the same
      buffer rather than from  a palloc'd copy. IOW, they are just moved
      downwards in the same buffer. Because the source and destination addresses
      can overlap, we must use memmove rather than memcpy.
      
      Report and fix by Alexander Korotkov.
      398cf255
    • S
      ALTER TABLESPACE ... MOVE ... OWNED BY · fbe19ee3
      Stephen Frost 提交于
      Add the ability to specify the objects to move by who those objects are
      owned by (as relowner) and change ALL to mean ALL objects.  This
      makes the command always operate against a well-defined set of objects
      and not have the objects-to-be-moved based on the role of the user
      running the command.
      
      Per discussion with Simon and Tom.
      fbe19ee3
    • F
      Remove duplicate index entry DATE_TRUNC in document. · 3ee74df2
      Fujii Masao 提交于
      3ee74df2
    • T
      Allow use of "z" flag in our printf calls, and use it where appropriate. · ac4ef637
      Tom Lane 提交于
      Since C99, it's been standard for printf and friends to accept a "z" size
      modifier, meaning "whatever size size_t has".  Up to now we've generally
      dealt with printing size_t values by explicitly casting them to unsigned
      long and using the "l" modifier; but this is really the wrong thing on
      platforms where pointers are wider than longs (such as Win64).  So let's
      start using "z" instead.  To ensure we can do that on all platforms, teach
      src/port/snprintf.c to understand "z", and add a configure test to force
      use of that implementation when the platform's version doesn't handle "z".
      
      Having done that, modify a bunch of places that were using the
      unsigned-long hack to use "z" instead.  This patch doesn't pretend to have
      gotten everyplace that could benefit, but it catches many of them.  I made
      an effort in particular to ensure that all uses of the same error message
      text were updated together, so as not to increase the number of
      translatable strings.
      
      It's possible that this change will result in format-string warnings from
      pre-C99 compilers.  We might have to reconsider if there are any popular
      compilers that will warn about this; but let's start by seeing what the
      buildfarm thinks.
      
      Andres Freund, with a little additional work by me
      ac4ef637
    • H
      Fix alignment of GIN in-line posting lists stored in entry tuples. · ec8f692c
      Heikki Linnakangas 提交于
      The Sparc machines in the buildfarm are crashing because of misaligned
      access to posting lists stored in entry tuples.
      
      I accidentally removed a critical SHORTALIGN() from ginFormTuple, as part
      of the packed posting lists patch. Perhaps I thought it was unnecessary,
      because the index_form_tuple() call above the SHORTALIGN already aligned
      the size, missing the fact that the null-category byte makes it misaligned
      again (I think the SHORTALIGN is indeed unnecessary if there's no null-
      category byte, but let's just play it safe...)
      ec8f692c
    • H
      Silence compiler warning. · 0fdb2f7d
      Heikki Linnakangas 提交于
      Not all compilers understand that elog(ERROR, ...) never returns.
      0fdb2f7d
    • A
      Make DROP IF EXISTS more consistently not fail · b152c6cd
      Alvaro Herrera 提交于
      Some cases were still reporting errors and aborting, instead of a NOTICE
      that the object was being skipped.  This makes it more difficult to
      cleanly handle pg_dump --clean, so change that to instead skip missing
      objects properly.
      
      Per bug #7873 reported by Dave Rolsky; apparently this affects a large
      number of users.
      
      Authors: Pavel Stehule and Dean Rasheed.  Some tweaks by Álvaro Herrera
      b152c6cd
    • F
      Add libpq function PQhostaddr(). · 9f80f483
      Fujii Masao 提交于
      There was a bug in the psql's meta command \conninfo. When the
      IP address was specified in the hostaddr and psql used it to create
      a connection (i.e., psql -d "hostaddr=xxx"), \conninfo could not
      display that address. This is because \conninfo got the connection
      information only from PQhost() which could not return hostaddr.
      
      This patch adds PQhostaddr(), and changes \conninfo so that it
      can display not only the host name that PQhost() returns but also
      the IP address which PQhostaddr() returns.
      
      The bug has existed since 9.1 where \conninfo was introduced.
      But it's too late to add new libpq function into the released versions,
      so no backpatch.
      9f80f483
    • A
      Allow case insensitive build version argument for MSVC. · d5bc6ce6
      Andrew Dunstan 提交于
      Dilip Kumar.
      d5bc6ce6
  4. 23 1月, 2014 4 次提交
    • F
      Fix bugs in PQhost(). · 77035fa8
      Fujii Masao 提交于
      In the platform that doesn't support Unix-domain socket, when
      neither host nor hostaddr are specified, the default host
      'localhost' is used to connect to the server and PQhost() must
      return that, but it didn't. This patch fixes PQhost() so that
      it returns the default host in that case.
      
      Also this patch fixes PQhost() so that it doesn't return
      Unix-domain socket directory path in the platform that doesn't
      support Unix-domain socket.
      
      Back-patch to all supported versions.
      77035fa8
    • B
      Add date_trunc('', interval) documentation mention · 90afc7d8
      Bruce Momjian 提交于
      Report from Eric Howe
      90afc7d8
    • H
      Fix declaration of GinVacuumState. · 6668ad1d
      Heikki Linnakangas 提交于
      gcc 4.8 was happy with having a duplicate typedef, but most compilers seem not
      to be, per buildfarm.
      6668ad1d
    • H
      Compress GIN posting lists, for smaller index size. · 36a35c55
      Heikki Linnakangas 提交于
      GIN posting lists are now encoded using varbyte-encoding, which allows them
      to fit in much smaller space than the straight ItemPointer array format used
      before. The new encoding is used for both the lists stored in-line in entry
      tree items, and in posting tree leaf pages.
      
      To maintain backwards-compatibility and keep pg_upgrade working, the code
      can still read old-style pages and tuples. Posting tree leaf pages in the
      new format are flagged with GIN_COMPRESSED flag, to distinguish old and new
      format pages. Likewise, entry tree tuples in the new format have a
      GIN_ITUP_COMPRESSED flag set in a bit that was previously unused.
      
      This patch bumps GIN_CURRENT_VERSION from 1 to 2. New indexes created with
      version 9.4 will therefore have version number 2 in the metapage, while old
      pg_upgraded indexes will have version 1. The code treats them the same, but
      it might be come handy in the future, if we want to drop support for the
      uncompressed format.
      
      Alexander Korotkov and me. Reviewed by Tomas Vondra and Amit Langote.
      36a35c55
  5. 22 1月, 2014 5 次提交
    • A
      Reindent json.c and jsonfuncs.c. · 243ee266
      Andrew Dunstan 提交于
      This will help in preparation of clean patches for upcoming
      json work.
      243ee266
    • S
      Allow type_func_name_keywords in even more places · 6c36f383
      Stephen Frost 提交于
      A while back, 2c92edad allowed
      type_func_name_keywords to be used in more places, including role
      identifiers.  Unfortunately, that commit missed out on cases where
      name_list was used for lists-of-roles, eg: for DROP ROLE.  This
      resulted in the unfortunate situation that you could CREATE a role
      with a type_func_name_keywords-allowed identifier, but not DROP it
      (directly- ALTER could be used to rename it to something which
      could be DROP'd).
      
      This extends allowing type_func_name_keywords to places where role
      lists can be used.
      
      Back-patch to 9.0, as 2c92edad was.
      6c36f383
    • T
      Tweak parse location assignment for CURRENT_DATE and related constructs. · 69c7a983
      Tom Lane 提交于
      All these constructs generate parse trees consisting of a Const and
      a run-time type coercion (perhaps a FuncExpr or a CoerceViaIO).  Modify
      the raw parse output so that we end up with the original token's location
      attached to the type coercion node while the Const has location -1;
      before, it was the other way around.  This makes no difference in terms
      of what exprLocation() will say about the parse tree as a whole, so it
      should not have any user-visible impact.  The point of changing it is that
      we do not want contrib/pg_stat_statements to treat these constructs as
      replaceable constants.  It will do the right thing if the Const has
      location -1 rather than a valid location.
      
      This is a pretty ugly hack, but then this code is ugly already; we should
      someday replace this translation with special-purpose parse node(s) that
      would allow ruleutils.c to reconstruct the original query text.
      
      (See also commit 5d3fcc4c, which also
      hacked location assignment rules for the benefit of pg_stat_statements.)
      
      Back-patch to 9.2 where pg_stat_statements grew the ability to recognize
      replaceable constants.
      
      Kyotaro Horiguchi
      69c7a983
    • R
      Add a cardinality function for arrays. · 01f7808b
      Robert Haas 提交于
      Unlike our other array functions, this considers the total number of
      elements across all dimensions, and returns 0 rather than NULL when the
      array has no elements.  But it seems that both of those behaviors are
      almost universally disliked, so hopefully that's OK.
      
      Marko Tiikkaja, reviewed by Dean Rasheed and Pavel Stehule
      01f7808b
    • R
      Fix inadvertent semantics change in last patch to plug memory leaks. · 033b2343
      Robert Haas 提交于
      Commit a5bca4ef accidentally changed
      the semantics when the "skipping missing configuration file" is
      emitted, because it forced OK to true instead of leaving the value
      untouched.
      
      Spotted by Tom Lane.
      033b2343
  6. 21 1月, 2014 7 次提交
  7. 20 1月, 2014 2 次提交
    • M
      Rename msvc build option krb5 to gss · 74a72ec2
      Magnus Hagander 提交于
      In the MSVC build system we've never separated krb5 from gss,
      and always built them both. Since the removal of native krb5
      support, this parameter only controls GSSAPI, so rename it
      accordingly.
      74a72ec2
    • M
      Remove support for native krb5 authentication · 98de86e4
      Magnus Hagander 提交于
      krb5 has been deprecated since 8.3, and the recommended way to do
      Kerberos authentication is using the GSSAPI authentication method
      (which is still fully supported).
      
      libpq retains the ability to identify krb5 authentication, but only
      gives an error message about it being unsupported. Since all authentication
      is initiated from the backend, there is no need to keep it at all
      in the backend.
      98de86e4
  8. 19 1月, 2014 6 次提交
    • M
      Adjust the SSL connection notification message · 4b8f2859
      Magnus Hagander 提交于
      Suggested by Tom
      4b8f2859
    • S
      Add CREATE TABLESPACE ... WITH ... Options · 5254958e
      Stephen Frost 提交于
      Tablespaces have a few options which can be set on them to give PG hints
      as to how the tablespace behaves (perhaps it's faster for sequential
      scans, or better able to handle random access, etc).  These options were
      only available through the ALTER TABLESPACE command.
      
      This adds the ability to set these options at CREATE TABLESPACE time,
      removing the need to do both a CREATE TABLESPACE and ALTER TABLESPACE to
      get the correct options set on the tablespace.
      
      Vik Fearing, reviewed by Michael Paquier.
      5254958e
    • T
      Fix VACUUM's reporting of dead-tuple counts to the stats collector. · 115f4141
      Tom Lane 提交于
      Historically, VACUUM has just reported its new_rel_tuples estimate
      (the same thing it puts into pg_class.reltuples) to the stats collector.
      That number counts both live and dead-but-not-yet-reclaimable tuples.
      This behavior may once have been right, but modern versions of the
      pgstats code track live and dead tuple counts separately, so putting
      the total into n_live_tuples and zero into n_dead_tuples is surely
      pretty bogus.  Fix it to report live and dead tuple counts separately.
      
      This doesn't really do much for situations where updating transactions
      commit concurrently with a VACUUM scan (possibly causing double-counting or
      omission of the tuples they add or delete); but it's clearly an improvement
      over what we were doing before.
      
      Hari Babu, reviewed by Amit Kapila
      115f4141
    • S
      Add ALTER TABLESPACE ... MOVE command · 76e91b38
      Stephen Frost 提交于
      This adds a 'MOVE' sub-command to ALTER TABLESPACE which allows moving sets of
      objects from one tablespace to another.  This can be extremely handy and avoids
      a lot of error-prone scripting.  ALTER TABLESPACE ... MOVE will only move
      objects the user owns, will notify the user if no objects were found, and can
      be used to move ALL objects or specific types of objects (TABLES, INDEXES, or
      MATERIALIZED VIEWS).
      76e91b38
    • S
      Allow SET TABLESPACE to database default · 6f25c62d
      Stephen Frost 提交于
      We've always allowed CREATE TABLE to create tables in the database's default
      tablespace without checking for CREATE permissions on that tablespace.
      Unfortunately, the original implementation of ALTER TABLE ... SET TABLESPACE
      didn't pick up on that exception.
      
      This changes ALTER TABLE ... SET TABLESPACE to allow the database's default
      tablespace without checking for CREATE rights on that tablespace, just as
      CREATE TABLE works today.  Users could always do this through a series of
      commands (CREATE TABLE ... AS SELECT * FROM ...; DROP TABLE ...; etc), so
      let's fix the oversight in SET TABLESPACE's original implementation.
      6f25c62d
    • T
      Make various variables const (read-only). · 0d79c0a8
      Tom Lane 提交于
      These changes should generally improve correctness/maintainability.
      A nice side benefit is that several kilobytes move from initialized
      data to text segment, allowing them to be shared across processes and
      probably reducing copy-on-write overhead while forking a new backend.
      Unfortunately this doesn't seem to help libpq in the same way (at least
      not when it's compiled with -fpic on x86_64), but we can hope the linker
      at least collects all nominally-const data together even if it's not
      actually part of the text segment.
      
      Also, make pg_encname_tbl[] static in encnames.c, since there seems
      no very good reason for any other code to use it; per a suggestion
      from Wim Lewis, who independently submitted a patch that was mostly
      a subset of this one.
      
      Oskari Saarenmaa, with some editorialization by me
      0d79c0a8