* Enable analyzing root partitions
* Ensure that the name of the guc is clear
* Remove double negation (where possible)
* Update comments
* Co-locate gucs that have similar purpose
* Remove dead gucs
* Classify them correctly so that they are no longer hidden

We had cherry-picked some of the PostgreSQL 9.3 functions, but not all the
subsequent fixes to them. I believe we need at least upstream commit
66008564 to fix github issue #2430, and surely the other bug fixes are
needed too.

Rather than cherry-pick individual commits, this replaces the JSON related
source files with the upstream files in toto. This will make diffing and
maintenance of these backported JSON function easier in the future.

Formally, GPDB assumed Gp_interconnect_queue_depth was constant during the interconnect life-time which was incorrect for Cursors, if Gp_interconnect_queue_depth was changed after a Cursor was declared, a panic occurred. To avoid this, we make a copy of Gp_interconnect_queue_depth when interconnect is set up. Gp_interconnect_snd_queue_depth has no such problem because it is only used by senders and senders of Cursor will never receive the GUC change command.

cache.

* Relocates gpperfmon reference from GPCC

* Remove emcconnect history and itorators from PDF ditamap

* Remove iterator metrics subtopic from PDF ditamap

* Additional edits to acknowledge gpperfmon without GPCC

* Incorporate gpperfmon.conf reference into gpperfmon_install reference

* #2427: changing the description, default, and set classification of standard_conforming_string to match code)

* small edit

* changing set classification to 'session'

Earlier `workfile_set` gets cleaned up only at the top transaction level.  If we
have a lot of sub-transaction, we found that we couldn't create more
`workfile_set` in shared memory. So we used resource owner to clean up
the `workfile_set` at the respective transaction level itself.

Thanks to Robert Mu <dbx_c@hotmail.com> for coming up with the initial
fix through the PR #2325.

This would resolve #1767
Signed-off-by: NKarthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>

* GPDB DOCS - Add information about pseudo-types.

* update pseudo-type doc based on feedback.

* GPDB DOCS - SELECT( INTO) - add WITH clause (common table expression)

* update SELECT (INTO) docs. Edits and remove RECURSIVE keyword.

* removing/rewording interconnect docs as only UDPIFC is supported in 5.0.0

* update docs to return TCP as valid interconnect for 5.0.0

* removing incorrect warnings stating that GPORCA is not compatible with gpperfmon db

* doc changes to support GPORCA on by default

This reverts commit a5e26310.

This reverts commit 8c62e892.

Make get_stack_depth_rlimit() handle RLIM_INFINITY more sanely.

Rather than considering this result as meaning "unknown", report LONG_MAX.
This won't change what superusers can set max_stack_depth to, but it will
cause InitializeGUCOptions() to set the built-in default to 2MB not 100kB.
The latter seems like a fairly unreasonable interpretation of "infinity".
Per my investigation of odd buildfarm results as well as an old complaint
from Heikki.

Since this should persuade all the buildfarm animals to use a reasonable
stack depth setting during "make check", revert previous patch that dumbed
down a recursive regression test to only 5 levels.

In commit 47e11a2d we unintentionally
included changes to submodules, revert this part.

Signed-off-by: NGang Xiong <gxiong@pivotal.io>

CID 169225: Dereference after null check (FORWARD_NULL)
var_deref_model: Passing null pointer onerel to AppendRelToVacuumRels, which
dereferences it.
In commit b3abb1b7 if
`open_relation_and_check_permission()` fails during dropPhase, we try to open
the relation again by passing the dropPhase flag set to false so that it can
perform the cleanup phase. We must check if onerel is NULL again after the
second call to `open_relation_and_check_permission()` before proceeding
further.

Since Travis doesn't build the Orca libraries, disable Orca in the
build since the default is now to enable Orca. This enables us to
keep running Travis as an alternative CI, albeit with non-default
options.

This should work with both dbid and contentid backup filenames.
Signed-off-by: NKaren Huddleston <khuddleston@pivotal.io>

Based on the experiments with tpch and tpcds, we found that 16MB would
be the optimal size of mdcache.
[#96490982].

Vacuum of AO tables happens in four phases: prepare, compact, drop and cleanup.
When there are concurrent transactions executing vacuum on AO tables, if one of
the vacuum transaction is executing a drop phase, the other transaction will
not be able to open the relation if it is also executing the drop phase. When
the relation open fails, vacuum simply exits without performing the cleanup
phase. The relfrozenxid in pg_class is updated during the cleanup phase and
hence the age of the table does not get reduced. This becomes a problem because
the age of the database does not reduce and eventually the xid wraparound issue
will be encountered.

This problem is fixed by performing the cleanup phase even if the open relation
fails during drop phase.

The column_to_scan function used to get the smallest eof column was
operating incorrectly. It would loop the segfiles until it found a
segfile with nonzero tuplecount, grab the first column that has a
nonzero eof, and return that value. The issue here is that it did not
iterate through all the columns to find the smallest nonzero eof. With
this commit, we now loop through all the columns of the segfile to
decide on a column to return. The unit tests for this function were
also incorrect so we fix that in this commit too.

Due to the different phases of VACUUM, compaction phase could have
committed but the drop was cancelled. This could leave some
aoseg/aocsseg entries in AOSEG_STATE_AWAITING_DROP state which could
then be cleaned up in a subsequent VACUUM as expected... but it
currently just skips. The master keeps a hash table (AppendOnlyHash)
and uses it during VACUUM to check tuple count, state, and
aborted/committed. Our issue here is that state checking was only
being done against state AWAITING_DROP_READY. It was not including
COMPACTED_AWAITING_DROP in the state check. This commit adds the check
and updates the detailed comment block on the state transitions in
appendonlywriter.h.

When doing an ADD COLUMN operation on an AOCO table, the vpinfo byte
array stored in the aocsseg auxiliary table for each column is updated
to add an extra vpinfo index to match the relnatts value in
pg_class. However, entries in the aocsseg auxiliary table with state 2
(AOSEG_STATE_AWAITING_DROP) will not have their vpinfo byte array
updated. Subsequent calls to getAOCSVPEntry function will then fail
due to the vpinfo size does not match the relnatts value in pg_class
(e.g. persistent table rebuild). Since we have the AccessExclusiveLock
on the table during ADD COLUMN, we might as well schedule the drop
before the vpinfos are updated to prevent any inconsistency issues.

We expect lazy VACUUM to skip drop phase if it cannot acquire the
relation's AccessExclusiveLock. This commit properly sets the dontWait
flag to True when calling try_relation_open during drop phase. We also
change the dontWait part of try_relation_open to not error out because
callers should be the ones to handle an invalid relation.

If GPDB is configured to build with orca, this commit adds checks to
ensure orca libraries are available.

We also chose more representative headers for the checks.

If gpdb is configured to build with orca it requires a Greenplum patched
version of Xerces library. This commit adds an explicit check for the
patched Xerces.

This also gives us an opportunity to be more idiomatic in doing
autoconf: we are replacing the manual manipulation of LIBS in
src/backend/Makefile with `AC_CHECK_LIB` in `configure.in`.

When the GPDB is build with GPORCA, `optimizer` GUC is set to on
by default. If GPDB is not build with GPORCA this guc is off by default.
Signed-off-by: NOmer Arap <oarap@pivotal.io>

This changes autoconf to enable orca by default. To be clear, the twin
flags of `--enable-orca` and `--disable-orca` are already available,
this commit merely changes the default (and help messages accordingly).
Signed-off-by: NOmer Arap <oarap@pivotal.io>

As of commit c7ff7663, subplans are initialized even they are unused. In some
case, the generated subplan is not used, but it has motionId = 0, which breaks
executor's sanity check. This patch fixes the issue by removing unused
subplans.

See discussions at:
https://github.com/greenplum-db/gpdb/issues/2383

To test if `ON SEGMENT` is compatible with all the other options.

Previously, we remove the shared memory object when drop resource group,
and restore it if the transaction aborts. The concurrently access to
shared memory object would fail in this way.
If the resource group is dropped, new transactions to this resource
group will be queued up until the drop transaction is finished.
Signed-off-by: NRichard Guo <riguo@pivotal.io>

Partition pruning test in ICW is failing because of `max_stack_depth` is
too small for sles11 environment. This commit increases the limit from
`100kB` to `500kB`.

Until now, people working on documentation would indicate that their
commits did not need to be run through automated testing by using the
`[ci skip]` annotation on their commit messages. This automates the same.

Signed-off-by: NDivya Bhargov <dbhargov@pivotal.io>