1. 04 5月, 2007 2 次提交
    • T
      Teach tuplesort.c about "top N" sorting, in which only the first N tuples · d26559db
      Tom Lane 提交于
      need be returned.  We keep a heap of the current best N tuples and sift-up
      new tuples into it as we scan the input.  For M input tuples this means
      only about M*log(N) comparisons instead of M*log(M), not to mention a lot
      less workspace when N is small --- avoiding spill-to-disk for large M
      is actually the most attractive thing about it.  Patch includes planner
      and executor support for invoking this facility in ORDER BY ... LIMIT
      queries.  Greg Stark, with some editorialization by moi.
      d26559db
    • T
      Tweak hash index AM to use the new ReadOrZeroBuffer bufmgr API when fetching · 0fef38da
      Tom Lane 提交于
      pages it intends to zero immediately.  Just to show there is some use for that
      function besides WAL recovery :-).
      Along the way, fold _hash_checkpage and _hash_pageinit calls into _hash_getbuf
      and friends, instead of expecting callers to do that separately.
      0fef38da
  2. 03 5月, 2007 7 次提交
  3. 02 5月, 2007 4 次提交
    • A
      Fix failure to check for INVALID worker entry in the new autovacuum code, which · a115bfe3
      Alvaro Herrera 提交于
      could happen when a worker took to long to start and was thus "aborted" by the
      launcher.  Noticed by lionfish buildfarm member.
      a115bfe3
    • T
      Fix oversight in PG_RE_THROW processing: it's entirely possible that there · 88f1fd29
      Tom Lane 提交于
      isn't any place to throw the error to.  If so, we should treat the error
      as FATAL, just as we would have if it'd been thrown outside the PG_TRY
      block to begin with.
      
      Although this is clearly a *potential* source of bugs, it is not clear
      at the moment whether it is an *actual* source of bugs; there may not
      presently be any PG_TRY blocks in code that can be reached with no outer
      longjmp catcher.  So for the moment I'm going to be conservative and not
      back-patch this.  The change breaks ABI for users of PG_RE_THROW and hence
      might create compatibility problems for loadable modules, so we should not
      put it into released branches without proof that it's needed.
      88f1fd29
    • M
      Add wrapper script around install.pl that calls buildenv.bat before doing · d6013a34
      Magnus Hagander 提交于
      the install.
      
      Dave Page
      d6013a34
    • T
      Fix a thinko in my patch of a couple months ago for bug #3116: it did the · b4349519
      Tom Lane 提交于
      wrong thing when inlining polymorphic SQL functions, because it was using the
      function's declared return type where it should have used the actual result
      type of the current call.  In 8.1 and 8.2 this causes obvious failures even if
      you don't have assertions turned on; in 8.0 and 7.4 it would only be a problem
      if the inlined expression were used as an input to a function that did
      run-time type determination on its inputs.  Add a regression test, since this
      is evidently an under-tested area.
      b4349519
  4. 01 5月, 2007 2 次提交
  5. 30 4月, 2007 4 次提交
    • T
      Implement rate-limiting logic on how often backends will attempt to send · 957d08c8
      Tom Lane 提交于
      messages to the stats collector.  This avoids the problem that enabling
      stats_row_level for autovacuum has a significant overhead for short
      read-only transactions, as noted by Arjen van der Meijden.  We can avoid
      an extra gettimeofday call by piggybacking on the one done for WAL-logging
      xact commit or abort (although that doesn't help read-only transactions,
      since they don't WAL-log anything).
      
      In my proposal for this, I noted that we could change the WAL log entries
      for commit/abort to record full TimestampTz precision, instead of only
      time_t as at present.  That's not done in this patch, but will be committed
      separately.
      957d08c8
    • T
      Marginal performance hack: use a dedicated routine instead of copyObject · 57b82bf3
      Tom Lane 提交于
      to copy nodes that are known to be Vars during plan reference adjustment.
      Saves useless memzero operation as well as the big switch in copyObject.
      57b82bf3
    • T
      Marginal performance hack: avoid unnecessary work in expression_tree_mutator. · afaa6b98
      Tom Lane 提交于
      We can just palloc, instead of using makeNode, when we are going to
      overwrite the whole node anyway in the FLATCOPY macro.  Also, use
      FLATCOPY instead of copyObject for common node types Var and Const.
      afaa6b98
    • T
      Marginal performance hack: remove the loop that used to be needed to · 39a333aa
      Tom Lane 提交于
      look through a freelist for a chunk of adequate size.  For a long time
      now, all elements of a given freelist have been exactly the same
      allocated size, so we don't need a loop.  Since the loop never iterated
      more than once, you'd think this wouldn't matter much, but it makes a
      noticeable savings in a simple test --- perhaps because the compiler
      isn't optimizing on a mistaken assumption that the loop would repeat.
      AllocSetAlloc is called often enough that saving even a couple of
      instructions is worthwhile.
      39a333aa
  6. 29 4月, 2007 4 次提交
  7. 28 4月, 2007 3 次提交
    • T
      Modify processing of DECLARE CURSOR and EXPLAIN so that they can resolve the · bbbe825f
      Tom Lane 提交于
      types of unspecified parameters when submitted via extended query protocol.
      This worked in 8.2 but I had broken it during plancache changes.  DECLARE
      CURSOR is now treated almost exactly like a plain SELECT through parse
      analysis, rewrite, and planning; only just before sending to the executor
      do we divert it away to ProcessUtility.  This requires a special-case check
      in a number of places, but practically all of them were already special-casing
      SELECT INTO, so it's not too ugly.  (Maybe it would be a good idea to merge
      the two by treating IntoClause as a form of utility statement?  Not going to
      worry about that now, though.)  That approach doesn't work for EXPLAIN,
      however, so for that I punted and used a klugy solution of running parse
      analysis an extra time if under extended query protocol.
      bbbe825f
    • N
      Remove no-longer-true statement from the docs. Since the default config · a2646711
      Neil Conway 提交于
      now enables row-level stats, the out of the box stats volume is no
      longer particularly low.
      a2646711
    • M
      Properly set MODULE_PATHNAME based on module name instead of incorrectly based · 6cc02136
      Magnus Hagander 提交于
      on directory name. Fixes the generation of .sql files in contrib/spi.
      
      Per complaint from Dave Page.
      6cc02136
  8. 27 4月, 2007 8 次提交
    • M
      Removed non-existant function from extern.h · 85a3fce9
      Michael Meskes 提交于
      85a3fce9
    • M
    • T
      Fix dynahash.c to suppress hash bucket splits while a hash_seq_search() scan · a2e923a6
      Tom Lane 提交于
      is in progress on the same hashtable.  This seems the least invasive way to
      fix the recently-recognized problem that a split could cause the scan to
      visit entries twice or (with much lower probability) miss them entirely.
      The only field-reported problem caused by this is the "failed to re-find
      shared lock object" PANIC in COMMIT PREPARED reported by Michel Dorochevsky,
      which was caused by multiply visited entries.  However, it seems certain
      that mdsync() is vulnerable to missing required fsync's due to missed
      entries, and I am fearful that RelationCacheInitializePhase2() might be at
      risk as well.  Because of that and the generalized hazard presented by this
      bug, back-patch all the supported branches.
      
      Along the way, fix pg_prepared_statement() and pg_cursor() to not assume
      that the hashtables they are examining will stay static between calls.
      This is risky regardless of the newly noted dynahash problem, because
      hash_seq_search() has never promised to cope with deletion of table entries
      other than the just-returned one.  There may be no bug here because the only
      supported way to call these functions is via ExecMakeTableFunctionResult()
      which will cycle them to completion before doing anything very interesting,
      but it seems best to get rid of the assumption.  This affects 8.2 and HEAD
      only, since those functions weren't there earlier.
      a2e923a6
    • N
      Another tweak for tab completion of CREATE TEMP. Instead of only · 8e90c544
      Neil Conway 提交于
      completing CREATE { TEMP | TEMPORARY } TABLE, we should also suggest
      VIEW and SEQUENCE. Per Greg Sabino Mullane.
      8e90c544
    • N
      Consistency tweaks for a table in the SGML docs: we don't terminate · 16fb5da7
      Neil Conway 提交于
      table entries describing functions with periods.
      16fb5da7
    • N
      Minor enhancement to psql tab completion. If we see "CREATE TEMPORARY", · 9475aa91
      Neil Conway 提交于
      we can complete "TABLE". The previous coding only looked for "CREATE TEMP".
      
      Note that I didn't add TEMPORARY to the list of suggested completions
      after we've seen "CREATE", since TEMP is equivalent and more concise. But
      if the user has already manually typed TEMPORARY, we may as well
      complete TABLE for them.
      9475aa91
    • N
      Minor tweak for DISCARD ref page. · c765ca24
      Neil Conway 提交于
      c765ca24
    • N
      Rename the newly-added commands for discarding session state. · 16efdb5e
      Neil Conway 提交于
      RESET SESSION, RESET PLANS, and RESET TEMP are now DISCARD ALL,
      DISCARD PLANS, and DISCARD TEMP, respectively. This is to avoid
      confusion with the pre-existing RESET variants: the DISCARD
      commands are not actually similar to RESET. Patch from Marko
      Kreen, with some minor editorialization.
      16efdb5e
  9. 26 4月, 2007 5 次提交
  10. 25 4月, 2007 1 次提交