These were both only used by a single, static, function.

Upstream doesn't have them, and they are just plain setter/getter
functions. Having functions like this woldn't be a bad idea per se, but
will cause merge conflicts.

This removes a couple of UnusedArg() calls. I'm not getting a compiler
warning from that function, and upstream seems to be happy without them
too.

It's unclear which upstream version our copy of this code is based on.
Looks like we have some of the changes from upstream commit b9527e98, but
not all. In any case, no upstream version has a variable called
'plannedstmt' here, all versions that have that variable call it 'pstmt'.

Adding a new 'return' like this in CheckAttributeType() is a bit risky, but
it seems better than re-indenting the whole function. Looking ahead at the
upcoming patches we're merging, we want to short-circuit all future checks
in this function too. In general, the reasoning is that any checks we might
want to perform on the attribute type should've been performed on the Query
Dispatcher already, and Query Executors should just follow orders.

The real ones are in parse_expr.h and makefuncs.h.

My compiler was complaining that the newResult variable might be passed
to pfree() uninitialized. I didn't spend too much time investigating that,
however. Instead, I replaced the whole FuncnameGetCandidates() function
with the PostgreSQL 8.4 version, and then modified it so that it works
without default-parameter support, which we haven't backported. Keeping
the code as close as possible to the upstream version seems like a good
idea. This also fixed some spurious whitespace differences vs. the upstream
version.

In the passing, clean up the regression test a bit. There are no
replacement strings in it, so move it from input/output to sql/expected
directories, and also add a comment pointing out that the tests are
backported from other PostgreSQL tests.

The user-visible effect is that you get error position in the original
query for some error messages, like the "type \"%s\" is only a shell"
error, if you try to use a shell type in CREATE TABLE, for example.

Not sure why this was different from upstream in GPDB, but seems prudent
to fix.

gpverify functionality was planned in past to deliver online
verification of primary and mirror. It's completely dead code as never
exposed this functionality and have no plans either. It eliminates
creation of unused processes, extra directory, some shared memory and
all.

Gpcrondump and gpdbrestore redirect stderr into status file for segments,
errors should be reflected into the master's report file.
Warnings will be given if process completed but errors were generated in
the report file.

Also made some refactor of the code.

Authors: Pengcheng Tang, Nikhil Kak

Consolidate on ip instead of mix of ip and ifconfig for ip4 and ip6 detection

The gptransfer utility was accidentally changed to 644 in commit
bdb29386.  This commit changes it back to 755.

Gptransfer previously supports transferring data of top level partition
table only. This is adding a support for leaf partition transfer.
The leaf partition pair should have same layout of columns and column
types (table name and column name can be different), also should have
same partition type and criteira (currently we support list and range partition).

Authors: Pengcheng Tang and Chumki Roy

Due to the misplaced conditional check, the byte string comparison
in checkRelationAfterInvalidation() will only check the first byte
of the passed byte strings.

The sync_multiplier value is passed onto pexpect.pxssh which is used to determine timeout
values for ssh connection prompt verification.  The 0.5 value can be too fast in some
environments.  Changing it to 1.0 should help stabilize the initial connection stage.

Author: Jimmy Yih

This is from a quick read through/skim of the code and comments.

fix gpfdist regression failure due to fdw code removing by 601c58c3; also remove duplicated cases

This is a more comprehensive fix to the quoting/escaping issues that
lead to pull request #44. With this patch, analyzedb will no longer
choke on tables that contain funny characters in their names.

The behaviour is slightly different than that proposed in #44. If you
pass -t Foo.Bar, without any quoting, the server will resolve that using
the usual lowercase-smashing rule, and will search for "foo.bar", in
lowercase. To avoid that, table names should be quoted. This is the same
behaviour as e.g. the Postgres' reindexdb and vacuumdb tools have, so I
think that's reasonable. The -s option behaves differently though: case
is preserved.

Heikki Linnakangas with minor changes from Entong Shen.

Closes #187.

cleanup of syntax around inet4 v inet6 parsing to match

changing spacing in piped commands

fixing case semicolons

Adding freebsd IP detection commands

When checking compiler switches during configure, reject the ones that
result in a compiler warning, this for example happens when building
with clang which throw a warning on unknown warning options when testing
gcc switches:

    warning: unknown warning option '-Wno-unused-but-set-variable';

This is a partial port of 44404f39 from
upstream, see original commitmessage below.

    commit 44404f39
    Author: Tom Lane <tgl@sss.pgh.pa.us>
    Date:   Thu May 26 17:29:33 2011 -0400

        Adjust configure to use "+Olibmerrno" with HP-UX C compiler, if possible.

        This is reported to be necessary on some versions of that OS.  In service
        of this, cause PGAC_PROG_CC_CFLAGS_OPT to reject switches that result in
        compiler warnings, since on yet other versions of that OS, the switch does
        nothing except provoke a warning.

        Report and patch by Ibrar Ahmed, further tweaking by me.

They are not generated files anymore.

Use the standard initdb mechanism for it, instead of having bespoken code
in gpinitsystem.

Also remove the unnecessarily complicated logic to generate gp_toolkit.sql
from gp_toolkit.sql.in. All the JETPACK_* variables were constants, and
there is particular need in making the gp_toolkit functions relocatable to
different schemas or prefixes, so just hardcode them and remove the sed
magic.

Rewrite the file header of gp_toolkit.sql. The legal blurp is not needed,
make the header look more like that of information_schema.sql and
system_views.sql.

Remove compaction_info.sql. It was only needed for old in-place
upgrade from 4.3.x to 4.3.4.2, which is not relevant for master branch.

Fix the "jetpack" bugbuster regression test. It was originally written to
test the gp_toolkit views, but gp_toolkit was in fact not installed in
bugbuster, and the expected output just contained a bunch of "relation
does not exist" errors. Now it actually tests gp_toolkit again. Some of
the test queries didn't produce repeateable results, due to differing oids,
differences in table sizes, and other tables created by previous tests, so
fixed those too.

This has a small user-visible difference: gp_toolkit schema is now also
installed in template0. That caused the difference in the expected outputs:
pg_regress creates the "regression" database using template0 as the
template, so gp_toolkit used to not be installed in it, but it is now.

Just some random things I happened to spot while reading code.

Picked up by clang using -Wheader-guard.

Fixed a small typo and ensured consistency of whitespace etc.