The test was sensitive to the number of pages in the pg_rewrite system
table's index, for no good reason. Also, don't create a new database for
it, to speed it up.

The gp_bloat_expected_pages.btdexppages column is numeric, but it was passed to
the function gp_bloat_diag() as integer in the definition of the view of the
same name gp_bloat_diag. This caused integer overflow errors when the number of
expected pages exceeded max integer limit for columns with very large widths.

This changes the function signature and call to use numeric for the
btxexppages paramter.

Adding a simple test to mimic the cutomer issue.

Author: Nadeem Ghani <nghani@pivotal.io>
Author: Shoaib Lari <slari@pivotal.io>

Also change a few regression tests to use the new syntax, instead of
gp_toolkit's __gp_localid and __gp_masterid functions.

These tests assumed OID == relfilenode. We updated the tests to not assume it
anymore.

* Sync plperl with PostgreSQL REL9_1_STABLE.

We had mostly backported plperl from 9.1, but not up to the tip of
the stable branch, and there were some cosmetic and other differences
that were not really necessary. It is simpler if the GPDB version is
as identical as possible to a particular upstream version, not a mismatch
of different versions.

Copy over everything from upstream REL9_1_STABLE, and tweak things to make
it compile and pass the regression tests.

I started hacking this because the regression tests were not passing. Now
they pass.

* Add "installcheck-world" makefile target, remove other top-level targets.

The master plan is that we will have straightforward "world" makefile
targets, like newer versions of PostgreSQL has, that build, install,
and test everything in the source tree. For example, "make world" builds
everything and the kitchen sink, and "make installcheck-world" runs
every test suite against an existing installation.

This patch is the first step in that direction. It creates a top-level
"installcheck-world" target, that runs some of the test suites we have.
It does not run everything, because the tests for some components are
either broken, or require additional setup to run. The point of this
first step is to establish the precedence, and clean up and add
everything else that we care about to this new target. For example, this
does not run the gphdfs tests, gpmapreduce tests, or orafce tests yet.

Also, this only adds the "installcheck-world" target, not "world",
"install-world" nor "check-world". Those are TODOs.

Remove other, defunct, top-level targets, to reduce confusion.

Move unittest-check top-level target from gpAux/Makefile to top-level
Makefile, to get some more visibility to it.

Adjust the concourse pipeline scripts to run the new "installcheck-world"
target, replacing the separate "installcheck-good" and
"installcheck-bugbuster" tasks. In the future, whenever a new test suite
is added, it can be added to the installcheck-world target, and the
pipeline will pick it up immediately, without having to modify the yaml
files.

An immediate benefit of this is that we now run the isolationtester test
suite, and the PL tests, as part of the pipeline.

* Fixed test cases

pgstat_write_statsfile() failed to write the resource queue statistics
to the stat file which in turn makes the pg_stat_resqueues view empty.

Patch by Github user LJoNe with testcase added by me

The regression database has grown over time, so that it's just above the
1 GB size that the regression test used as a "sanity check". I think the
new zlib regression test broke the camel's back. Bump it up to 5 GB, giving
us about 4 GB of headroom to grow.

There were failures from these in the Pivotal buildfarm. Some tables were
larger than expected. I'm not sure why - perhaps there was some concurrent
activity that bloats append-only tables - but there have been no functional
changes so these really should be passing.

This brings in test queries from the "jetpack" test case in cdbfast (a
legacy Pivotal test suite that has not been open sourced yet), to cover
the gp_toolkit functionality that was not already covered by the bugbuster
tests. Move the test case from bugbuster into the main suite - this should
not be considered optional or auxiliary anymore.