1. 24 4月, 2019 2 次提交
  2. 23 4月, 2019 10 次提交
    • D
      Update docs for gp_recursive_cte enabled by default · 86552d03
      Daniel Gustafsson 提交于
      Commit 4e337a33 enabled RECURSIVE
      CTEs by default, update the docs to reflect the current state of
      the GUC.
      Reviewed-by: NLisa Owen <lowen@pivotal.io>
      Reviewed-by: NDavid Yozie <dyozie@pivotal.io>
      86552d03
    • D
      Reflect that gp_recursive_cte is enabled by default · 58343e3c
      Daniel Gustafsson 提交于
      Commit 4e337a33 enabled RECURSIVE
      CTEs by default, so let's remove the final instances where we did
      override the previous default value.
      Reviewed-by: NLisa Owen <lowen@pivotal.io>
      Reviewed-by: NDavid Yozie <dyozie@pivotal.io>
      58343e3c
    • D
      Align disabled contrib modules with upstream · 2f325ac9
      Daniel Gustafsson 提交于
      The contrib/ directory in Greenplum had over the years had multiple
      files removed for various reasons. This tends to create confusion
      and pointless merge conflicts as we merge with upstream. This brings
      back a lot of files we generally don't really care about, to align
      us with upstream. See below for discussions on the various files:
      
      * adminpack is already imported into Greenplum core in order to
        better support pgAdmin3
      * earthdistance isn't supported as it relies on upstream features
        not present in Greenplum
      * lo is not supported in Greenplum as large objects are disabled
      * chkpass and intagg are uninteresting and obsolete modules which
        are being removed from upstream
      2f325ac9
    • J
      Fix bug missing initializing timeout · 57ae7186
      Jialun 提交于
      We found that if gp_segment_configuration is locked, then it will
      fail by triggering FTS. We got the stack below
      	#2  0x0000000000a6bb29 in ExceptionalCondition at assert.c:66
      	#3  0x0000000000aac19a in enable_timeout timeout.c:143
      	#4  0x0000000000aacb6c in enable_timeout_after timeout.c:473
      	#5  0x00000000008e86ef in ProcSleep at proc.c:1300
      	#6  0x00000000008deb70 in WaitOnLock at lock.c:1894
      	#7  0x00000000008e019e in LockAcquireExtended at lock.c:1205
      	#8  0x00000000008dd2d8 in LockRelationOid at lmgr.c:102
      	#9  0x000000000051c928 in heap_open at heapam.c:1083
      	#10 0x0000000000b7feaf in getCdbComponentInfo at cdbutil.c:173
      	#11 0x0000000000b81365 in cdbcomponent_getCdbComponents at cdbutil.c:606
      	#12 0x00000000007603e1 in ftsMain at fts.c:351
      	#13 0x0000000000760715 in ftsprobe_start at fts.c:121
      	#14 0x00000000004cc7b0 in ServerLoop ()
      	#15 0x00000000008769bf in PostmasterMain at postmaster.c:1531
      	#16 0x000000000079098b in main ()
      So it is that FTS hasn't initialized timeout. Any process that
      wants to use timeout must call initilization first. This is the
      root cause gpexpand job fails on master pipeline in build 71 and 79.
      We added this initialization in FTS and GDD.
      57ae7186
    • H
      fix gpfdist build error on USE_SSL off (#7522) · 1e7ef6d2
      Huiliang.liu 提交于
      1e7ef6d2
    • H
      Shutdown gpfdist SSL connection gracefully (#7470) · bd13e8f7
      Huiliang.liu 提交于
      GPDB uses libcurl-gnutls.so.4 as default libcurl on ubuntu. gpfdist SSL
      connection reports error (56 - Failure when receiving data from the peer)
      on handling POST message. We find it shutdown socket directly without sending
      close_notify to client. So we call SSL_shutdown() before socket shutdown.
      
      But SSL_accept() will return error with above patch on Centos, because
      GPDB curl reuses SSL session ID in the second client hello, but server considers
      that session is shutdown, so it won't accept that session ID.
      The solution is disabling SSL session ID cache by setting curl option.
      Then both Centos and ubuntu work well.
      
      Enable gpfdist SSL test case.
      bd13e8f7
    • X
      Remove transaction state DTX_STATE_ACTIVE_NOT_DISTRIBUTED · 72828c27
      xiong-gang 提交于
      DTX_STATE_ACTIVE_NOT_DISTRIBUTED indicates the transaction is started on QD and
      two-phase commit is not required yet, in this state, distributed transaction ID
      is also generated. If this transaction is not a two-phase transaction, e.g. implicit
      select-only transaction, it will also need to acquire the ProcArrayLock to clear
      the distributed transaction ID, and that leads to unnecessary lock contention.
      72828c27
    • M
      PrepareTempTablespaces directly before making temp file · d6ef4234
      Melanie Plageman 提交于
      PrepareTempTablespaces is called by almost all callers of
      BufFileCreateTemp* and seems like it would be easier from a readability
      perspective and as a developer when writing some code that is going to
      make temp files, I would prefer not to have to remember to check and set
      the value that the user set for temp tablespaces GUC. It seems like that
      is an unnecessary chore that is easily forgotten.
      
      For example, for HashAgg, we have our own spilling implementation and
      forgot to call PrepareTempTablespaces, so spill files were not getting
      created in the temp tablespace specified by the user.
      
      Note that in the workfile_mgr_test, we use SetConfigOption to set the
      temp_tablespaces GUC. It would also have worked to redeclare the
      variable in the test file and then assign to it. However, SetConfigOption
      is used when a user sets a GUC, so it seems more intuitive for the
      reader of the test to use this.
      Co-authored-by: NAshwin Agrawal <aagrawal@pivotal.io>
      d6ef4234
    • J
      gppkg: remove special Concourse task for GPHOME copying · e6b40a71
      Jacob Champion 提交于
      concourse/scripts/gppkg_behave.sh, which installs an identical copy of
      GPHOME into a new location, existed for exactly one test. Modify that
      test to perform its own copy-install.
      e6b40a71
    • J
      CI: fix Concourse template for gpexpand · 52a21767
      Jacob Champion 提交于
      gpexpand requires centos6, ICW, and CLI jobs to be enabled, but it was
      being included in the groups when only a subset of those requirements
      was met, so fly refused the pipeline. With this change, centos6/CLI
      pipelines should work again.
      52a21767
  3. 22 4月, 2019 3 次提交
  4. 21 4月, 2019 1 次提交
    • D
      contrib: Add missing code and testcases for ltree · 8682589d
      Daniel Gustafsson 提交于
      Add the missing code and testcases from upstream to make the ltree
      contrib module complete. With this the module builds and tests.
      
      The ignore block in the test case is to avoid a large diff in the
      expected file since the test in question fails on the below error
      in Greenplum:
      
        ERROR:  UNIQUE and DISTRIBUTED RANDOMLY are incompatible
      8682589d
  5. 20 4月, 2019 2 次提交
  6. 19 4月, 2019 14 次提交
  7. 18 4月, 2019 8 次提交