- 06 8月, 2011 3 次提交
-
-
由 Robert Haas 提交于
Shigeru Hanada, with fairly minor editing by me.
-
由 Robert Haas 提交于
The old check against MAX_RANDOM_VALUE is clearly irrelevant since getrand() no longer calls random(). Instead, check whether min and max are close enough together to avoid an overflow inside getrand(), as suggested by Tom Lane. This is still somewhat silly, because we're using atoi(), which doesn't check for overflow anyway and (at least on my system) will cheerfully return 0 when given "4294967296". But that's a problem for another commit.
-
由 Robert Haas 提交于
The previous test for status < 0 test is in fact testing nothing if the compiler considers an enum to be an unsigned data type. clang doesn't like tautologies, so do this instead. Report by Peter Geoghegan, fix as suggested by Tom Lane.
-
- 05 8月, 2011 5 次提交
-
-
由 Bruce Momjian 提交于
Backpatch to 9.1 and 9.0.
-
由 Andrew Dunstan 提交于
To avoid having the python headers hijack various definitions, we now include them after all the system headers we want, having first undefined some of the things they want to define. After that's done we restore the things they scribbled on that matter, namely our snprintf and vsnprintf macros, if we're using them.
-
由 Robert Haas 提交于
Instead of entering them on transaction startup, we materialize them only when someone wants to wait, which will occur only during CREATE INDEX CONCURRENTLY. In Hot Standby mode, the startup process must also be able to probe for conflicting VXID locks, but the lock need never be fully materialized, because the startup process does not use the normal lock wait mechanism. Since most VXID locks never need to touch the lock manager partition locks, this can significantly reduce blocking contention on read-heavy workloads. Patch by me. Review by Jeff Davis.
-
由 Robert Haas 提交于
The output of \dL (list languages) is fairly narrow, so we just always display the comment. \dC (list casts) can get fairly wide, so we only display comments if the new \dC+ option is specified. Josh Kupershmidt
-
由 Bruce Momjian 提交于
wal_level = minimum. Backpatch to 9.1 and 9.0.
-
- 04 8月, 2011 1 次提交
-
-
由 Robert Haas 提交于
glibc renders random() thread-safe by wrapping a futex lock around it; testing reveals that this limits the performance of pgbench on machines with many CPU cores. Rather than switching to random_r(), which is only available on GNU systems and crashes unless you use undocumented alchemy to initialize the random state properly, switch to our built-in implementation of erand48(), which is both thread-safe and concurrent. Since the list of reasons not to use the operating system's erand48() is getting rather long, rename ours to pg_erand48() (and similarly for our implementations of lrand48() and srand48()) and just always use those. We were already doing this on Cygwin anyway, and the glibc implementation is not quite thread-safe, so pgbench wouldn't be able to use that either. Per discussion with Tom Lane.
-
- 03 8月, 2011 2 次提交
-
-
由 Tom Lane 提交于
This kluge was inserted in a spot apparently chosen at random: the lock manager's state is not yet fully set up for the wait, and in particular LockWaitCancel hasn't been armed by setting lockAwaited, so the ProcLock will not get cleaned up if the ereport is thrown. This seems to not cause any observable problem in trivial test cases, because LockReleaseAll will silently clean up the debris; but I was able to cause failures with tests involving subtransactions. Fixes breakage induced by commit c85c9414. Back-patch to all affected branches.
-
由 Tom Lane 提交于
It was initialized in the wrong place and to the wrong value. With bad luck this could result in incorrect query-cancellation failures in hot standby sessions, should a HS backend be holding pin on buffer number 1 while trying to acquire a lock.
-
- 02 8月, 2011 1 次提交
-
-
由 Heikki Linnakangas 提交于
This fixes bug #6139 reported by Hitoshi Harada.
-
- 01 8月, 2011 1 次提交
-
-
由 Robert Haas 提交于
-
- 31 7月, 2011 1 次提交
-
-
由 Peter Eisentraut 提交于
This is to be able to analyze issues with host names in pg_hba.conf.
-
- 30 7月, 2011 3 次提交
-
-
由 Bruce Momjian 提交于
Win32. Backpatch to 9.1.
-
由 Robert Haas 提交于
Testing shows that the overhead of acquiring and releasing SInvalReadLock and msgNumLock on high-core count boxes can waste a lot of CPU time and hurt performance. This patch adds a per-backend flag that allows us to skip all that locking in most cases. Further testing shows that this improves performance even when sinval traffic is very high. Patch by me. Review and testing by Noah Misch.
-
由 Robert Haas 提交于
-
- 29 7月, 2011 1 次提交
-
-
由 Tom Lane 提交于
pg_backup_db.c contained a mini SQL lexer with which it tried to identify boundaries between SQL commands, but that code was not designed to cope with standard_conforming_strings, and would get the wrong answer if a backslash immediately precedes a closing single quote in such a string, as per report from Julian Mehnle. The bug only affects direct-to-database restores from archive files made with standard_conforming_strings = on. Rather than complicating the code some more to try to fix that, let's just rip it all out. The only reason it was needed was to cope with COPY data embedded into ordinary archive entries, which was a layout that was used only for about the first three weeks of the archive format's existence, and never in any production release of pg_dump. Instead, just rely on the archive file layout to tell us whether we're printing COPY data or not. This bug represents a data corruption hazard in all releases in which standard_conforming_strings can be turned on, ie 8.2 and later, so back-patch to all supported branches.
-
- 28 7月, 2011 1 次提交
-
-
由 Peter Eisentraut 提交于
-
- 27 7月, 2011 4 次提交
-
-
由 Robert Haas 提交于
Noted by Josh Kupershmidt.
-
由 Tom Lane 提交于
It turns out to be possible to link against a libxml2.so that does this differently than the version we configured and built against, so we need a runtime check to avoid bizarre behavior. Per report from Bernd Helmle. Patch by Florian Pflug.
-
由 Peter Eisentraut 提交于
-
由 Peter Eisentraut 提交于
They are identical, but the overwhelming majority of the code uses %d, so standardize on that.
-
- 26 7月, 2011 4 次提交
-
-
由 Robert Haas 提交于
Josh Kupershmidt, with minor modifications by me.
-
由 Robert Haas 提交于
Per discussion with Josh Kupershmidt.
-
由 Andrew Dunstan 提交于
Windows doesn't have Unix sockets, so it's not needed, and moreover causes compile warnings.
-
由 Andrew Dunstan 提交于
It is set correctly on the only path that uses it, but the compiler can't know that.
-
- 25 7月, 2011 7 次提交
-
-
由 Robert Haas 提交于
This probably needs more work, but it's a start. KaiGai Kohei
-
由 Robert Haas 提交于
Laurenz Albe, somewhat modified by me.
-
由 Robert Haas 提交于
Per a request from Greg Smith.
-
由 Robert Haas 提交于
This entails adjusting pgbench to use getopt_long() rather than getopt().
-
由 Tom Lane 提交于
On balance, the need to cover this case changes my mind in favor of pushing all error-message generation duties into the two fe-secure.c routines. So do it that way.
-
由 Tom Lane 提交于
In many cases, pqsecure_read/pqsecure_write set up useful error messages, which were then overwritten with useless ones by their callers. Fix this by defining the responsibility to set an error message to be entirely that of the lower-level function when using SSL. Back-patch to 8.3; the code is too different in 8.2 to be worth the trouble.
-
由 Tom Lane 提交于
This disables an entirely unnecessary "sanity check" that causes failures in nonblocking mode, because OpenSSL complains if we move or compact the write buffer. The only actual requirement is that we not modify pending data once we've attempted to send it, which we don't. Per testing and research by Martin Pihlak, though this fix is a lot simpler than his patch. I put the same change into the backend, although it's less clear whether it's necessary there. We do use nonblock mode in some situations in streaming replication, so seems best to keep the same behavior in the backend as in libpq. Back-patch to all supported releases.
-
- 24 7月, 2011 4 次提交
-
-
由 Bruce Momjian 提交于
creating and removing a file because access() doesn't work on that platform. Backpatch to 9.1 where this check was added.
-
由 Andrew Dunstan 提交于
-
由 Peter Eisentraut 提交于
Also change "switch" to "arg" because "switch" is a bit of a sloppy term. So the environment variable is called PSQL_EDITOR_LINENUMBER_ARG. Set "+" as hardcoded default value on Unix (since "vi" is the hardcoded default editor), so many users won't have to configure this at all. Move the documentation around a bit to centralize the editor configuration under environment variables, rather than repeating bits of it under every backslash command that invokes an editor.
-
由 Tom Lane 提交于
The original implementation simply did nothing when replacing an existing object during CREATE EXTENSION. The folly of this was exposed by a report from Marc Munro: if the existing object belongs to another extension, we are left in an inconsistent state. We should insist that the object does not belong to another extension, and then add it to the current extension if not already a member.
-
- 23 7月, 2011 1 次提交
-
-
由 Robert Haas 提交于
I broke this in commit 5da79169, which was obviously insufficiently well tested. Add some regression tests in the hope of making future slip-ups more likely to be noticed.
-
- 22 7月, 2011 1 次提交
-
-
由 Bruce Momjian 提交于
writes for logging.
-