1. 28 6月, 2017 8 次提交
  2. 27 6月, 2017 9 次提交
  3. 24 6月, 2017 15 次提交
    • T
      Creates installation directions for macOS · e4f357f5
      Todd Sedano 提交于
      e4f357f5
    • C
      Restore statistics file in gpdbrestore --restore-stats with ddboost · 481cdcef
      Chris Hajas 提交于
      The gp_statsistics prefix was not included in the list of files to
      restore from ddboost, causing restore to fail when gpdbrestore
      --restore-stats was used.
      481cdcef
    • C
      Fix gpcrondump to correctly backup ordered aggregates · 7256defe
      Chris Hajas 提交于
      This functionality was included with pg_dump, but was missing from
      gpcrondump.
      7256defe
    • J
      Update timestamps, correct example (#2682) · a638dfee
      Jane Beckman 提交于
      a638dfee
    • A
      5c3be9a0
    • A
      Delete files on mirror for AO/CO tables. · 99af62c4
      Ashwin Agrawal 提交于
      With --enable-segwalrep, mirror leverages replay of xl_mm_fs_obj records to
      delete files. Code was not correctly handling appendonly tables as was calling
      `smgrdounlink()`, which is for heap tables or indexes. For AO/CO tables, need to
      perform drop of specific single file mentioned in xlog record, which is
      performed by `MirroredAppendOnly_Drop()`. Without this code currently files like
      <relfilenode>.127, <relfilenode>.129,... etc get left behind on mirror. The
      problem was not seen so far as master never stores data for AO/CO tables hence
      these files are not created on master. Only when now we start enabling wal
      replication for segments this is required.
      99af62c4
    • A
      Change DEBUG1 to LOG for messages under Debug_print_qd_mirroring. · b938a87b
      Ashwin Agrawal 提交于
      Helpful for debugging to set GUC Debug_print_qd_mirroring but the message were
      with DEBUG1. Just enabling and disabling is guc enough to control the logging
      don't need second level.
      b938a87b
    • A
      Enable xlogging for create fs objects on segments. · 9efec6b2
      Ashwin Agrawal 提交于
      Incase of --enable-segwalrep, write-ahead logging should not be skipped for
      anything, as it relies on that mechanism to construct the things on
      mirror. Write-ahead logging for these pieces were only enabled performed for
      master, with this commit gets enabled for segments as well.
      9efec6b2
    • A
      Make get_filespaces_to_send() work for QEs for default filespaces. · a758cb32
      Ashwin Agrawal 提交于
      Currently, get_filespaces_to_send() only works for QD. To enable pg_basebackup
      and wal replication for QEs, this function must also work on QEs. This function
      relies on pg_filespace_entry table to provide information, as its only available
      on QD currently can't be leveraged. Hence just enabling basic support for QEs
      for default filespace. Supporting user defined filespaces and non-default
      transaction filespace, will be dealt incrementally later.
      a758cb32
    • J
      Add gpcheckcat behave test for dependency check · fbe35fe5
      Jimmy Yih 提交于
      In this behave test, we delete some entries in pg_depend and in some
      relative catalog tables to simulate a corruption around pg_depend. The
      gpcheckcat tool should then flag these down.
      fbe35fe5
    • J
      Update gpcheckcat dependency check · 6375e9bc
      Jimmy Yih 提交于
      The current gpcheckcat dependency check only checked for extra
      pg_depend entries where a pg_depend entry's objid or refobjid did not
      exist as an OID of any catalog table with hasoids set. We also need to
      check the reverse scenario where a catalog entry is missing an entry
      in pg_depend. This particular scenario is difficult to flag due to
      catalog entries having multiple unique pg_depend references or are
      created later from a query that may add dependency (e.g. granting
      ownership of a database to a certain user). Therefore, we add a very
      basic check only against catalog tables that immediately create
      dependencies upon its relative query.
      6375e9bc
    • J
      Change gpcheckcat missing/extra check to include pg_depend. · 4bdc7e45
      Jimmy Yih 提交于
      We did not check for missing or extra pg_depend entries across the
      cluster during gpcheckcat. We would be unaware of scenarios where a
      pg_depend entry went missing and the object that used that dependency
      is dropped. Those scenarios could lead to leftover catalog entries and
      prevent some simple CREATE statements.
      4bdc7e45
    • J
      Fix gpcheckcat output · 843b2109
      Jimmy Yih 提交于
      As gpcheckcat builds its mapping of catalog issues, it can flag
      objects whose parents no longer exist (e.g. a toast table left over
      after dropping a table). When these get caught, gpcheckcat will
      unfortunately error out on the reporting step. To prevent erroring
      out, we just check for None in the RelationObject's vars during
      reporting.
      
      Another issue that is fixed is the repetitive reporting of issues on
      the testing's current database following testing of a different
      database. The catalog issues reported were invalid for the current
      database and were actually issues from the previous database that was
      checked. This was caused by the improper resetting of the GPObjects
      and GPObjectGraph global dictionaries. To fix the issue, we properly
      use the clear() function to reuse the global variables.
      843b2109
    • F
      Stop enabling codegen in PR pipeline · fd8854bf
      Foyzur Rahman and Jesse Zhang 提交于
      [#147538353]
      fd8854bf
    • C
      Keep gpfdist logs when gptransfer run with gpfdist verbosity flags · 65fb3e09
      Chris Hajas 提交于
      When gptransfer is run with the gpfdist-verbose or gpfdist-very-verbose
      flags, the gpfdist logs will be kept.
      Signed-off-by: NJamie McAtamney <jmcatamney@pivotal.io>
      65fb3e09
  4. 23 6月, 2017 8 次提交
    • K
      Revert "Silence compiler warnings in pg_dump." · 8621392d
      Karen Huddleston 提交于
      This reverts commit 6a76c5d0.
      
      This commit caused gp_dump_agent to hang during backup.
      Signed-off-by: NTom Meyer <tmeyer@pivotal.io>
      8621392d
    • J
      DOCS: Adding extra concepts (#2586) · 52b5e817
      Jane Beckman 提交于
      * Clarify gpdb implementation
      
      * Minor updates
      
      * Add column storage info
      
      * Fix typo
      
      * Edits form Mel
      
      * Fix minor typo
      
      * Clarifying table compression
      
      * More on AO storage
      
      * Make append-optimized lower case
      52b5e817
    • J
      Disallow rescanning motion regardless of param change · c977d4de
      Jesse Zhang 提交于
      Context: unlike upstream Postgres, not every operator in Greenplum is
      rescannable, noticeably motions. Semantically, a motion is not
      rescannable except for one very limited cases:
      
      1. When the motion has been initialized, but it has never streamed out
      any tuples yet. Rescanning is permitted here, because it is as good as
      not rescanning.
      
      Historically, we've been checking for exactly this condition, until in
      4.2 we added a check to allow rescanning when parameters changed.
      Correlated subquery was cited as the intent of commit ea867177 (private)
      that introduced the additional relaxing check . But come to think of it,
      motions are not rescannable regardless of parameter change. In fact, if
      execution reaches this point, the optimizer must have generated a wrong
      plan.
      
      This commit reinstates the original stricter check.
      c977d4de
    • D
      DOCS: removing DDBoost from OSS build (#2677) · bde7f218
      David Yozie 提交于
      * DOCS: removing DDBoost info from OSS build
      
      * DOCS: Removing RHEL 5 reference
      bde7f218
    • H
      Fix dumping of "COUNT(*) FILTER (...)" expressions. · 54d6b71b
      Heikki Linnakangas 提交于
      Without this fix, the FILTER expression would be left out of the deparsed
      DDL of a view. Now it gets dumped as the CASE - WHEN expression that we
      tranform the FILTER to at parse analysis. Ideally, we would dump it using
      the original FILTER syntax, but that would be a much bigger patch. We'll
      get that when we merge the upstream FILTER implementation, in PostgreSQL
      9.4.
      
      Fixes github issue #1854, reported by @water32.
      54d6b71b
    • F
      Adding SQL tests to check successful elimination of alien nodes. (#2663) · ce5aef56
      foyzur 提交于
      This PR adds SQL test to verify that memory consumption of alien nodes drops to zero after we set the guc execute_pruned_plan=on.
      Signed-off-by: NFoyzur Rahman <foyzur@gmail.com>
      ce5aef56
    • H
      Remove incorrect optimizations on IS NOT FALSE. · 60787a9e
      Heikki Linnakangas 提交于
      Fixes github issue #2130
      60787a9e
    • H
      Revert part of commit c98b7eff, which caused compiler warnings. · 4430c831
      Heikki Linnakangas 提交于
      This re-introduces a minor memory leak, per dumped operator. That is
      not significant in practice, no-one has enough operators for that to
      matter, and we're storing some information in memory for each dumped
      operator anyway.
      
      Moreover, this is a divergence from the upstream. In the upstream, this was
      fixed in commit b1aebbb6, slightly differently, in a way that doesn't
      introduce new compiler warnings. If we must fix this, we should cherry-pick
      that commit, and fix it the same way in both pg_dump.c and cdb_dump_agent.c.
      But I think this is not worth fixing, and we are better off just leaving
      the code as it is in PostgreSQL 8.3.
      4430c831