This is dead, because SubPlan is an Expr node and therefore cannot appear
in a Plan tree.

This was broken, because the "subplan = (SubPlan *) subplan" cast didn't
do anything, and subplan was potentially uninitialized. It meant to say
"subplan = (SubPlan *) plan".

Spotted by Daniel Gustafsson.

This merges the COST and ROWS options for functions.

One GPDB-specific question was what the ROWS option means for GPDB
table functions. I decided to keep the old estimation method, where the
number of output rows for a table function is estimated to be the same
as input rows, and ignore the ROWS option.

Also regenerate 4.3.json file, which I forgot to do in the previous commit.

Conflicts:
	doc/src/sgml/catalogs.sgml
	doc/src/sgml/ref/create_function.sgml
	src/backend/bootstrap/bootstrap.c
	src/backend/catalog/pg_aggregate.c
	src/backend/catalog/pg_proc.c
	src/backend/commands/functioncmds.c
	src/backend/commands/proclang.c
	src/backend/optimizer/path/costsize.c
	src/backend/optimizer/plan/createplan.c
	src/backend/optimizer/plan/setrefs.c
	src/backend/parser/gram.y
	src/backend/parser/keywords.c
	src/backend/utils/Gen_fmgrtab.sh
	src/backend/utils/cache/lsyscache.c
	src/bin/pg_dump/pg_dump.c
	src/include/catalog/catversion.h
	src/include/catalog/pg_attribute.h
	src/include/catalog/pg_class.h
	src/include/catalog/pg_proc.h
	src/include/optimizer/cost.h
	src/include/utils/lsyscache.h

Conflicts:
	doc/TODO
	doc/src/FAQ/TODO.html
	src/interfaces/ecpg/test/Makefile
	src/interfaces/ecpg/test/pg_regress.sh

This brings in test queries from the "jetpack" test case in cdbfast (a
legacy Pivotal test suite that has not been open sourced yet), to cover
the gp_toolkit functionality that was not already covered by the bugbuster
tests. Move the test case from bugbuster into the main suite - this should
not be considered optional or auxiliary anymore.

If there is a schema in the database that the user does not have access to,
doing "select * from gp_toolkit.__gp_user_tables_readable" throws a
permission denied error on the schema. Use the relation-OID-variant of
has_table_privilege() function, to work around that.

This isn't otherwise better than the existing code, but this matches the
upstream more closely, which will make merging slightly easier.

parser/analyze.c is bloated, moving larger chunks of GPDB-specific
functionality like this elsewhere makes it more readable. Make diffing and
merging of analyze.c with upstream easier, too.

I also ran pgindent on parse_partition.c.

parser/analyze.c is overcrowded, and since it's an upstream file, extra
code there can confuse merging (though completely new functions are less
of a problem).

The GPDB-specific auto-stats system doesn't really have anything to do with
autovacuum. It's not run by the autovacuum daemon, and there are no calls
from the autovacuum code to autostats code.

Conflicts:
	doc/TODO
	doc/src/FAQ/TODO.html
	doc/src/sgml/catalogs.sgml
	doc/src/sgml/func.sgml
	doc/src/sgml/indexam.sgml
	doc/src/sgml/xindex.sgml
	src/include/catalog/catversion.h
	src/include/catalog/pg_am.h

The big change in this merge is the "equivalence classes" mechanism. That's
not too exciting as a feature, but cleans up a lot of the planner stuff that
tracks which expressions can be treated as equal, and used interchangeably.

This required quite a lot of changes in the GPDB-specific code that tracks
the distribution keys of tables and intermediate nodes in a plan.

One notable refactoring, that didn't originate from the upstream, was the
change to CdbPathLocus, to split the "pathkeys" field into two. That reduces
the confusion on which kind of a List we're dealing with.

This includes fixes from a couple of later upstream commits: 48d9d8e1 and
11086f2f. Those were needed to fix regression failures in GPDB-added tests.

Merge by Daniel Gustafsson and me.

Conflicts:
	doc/src/sgml/config.sgml
	doc/src/sgml/installation.sgml
	doc/src/sgml/xoper.sgml
	src/backend/access/gist/gistget.c
	src/backend/access/gist/gistscan.c
	src/backend/nodes/copyfuncs.c
	src/backend/nodes/outfuncs.c
	src/backend/optimizer/README
	src/backend/optimizer/path/Makefile
	src/backend/optimizer/path/costsize.c
	src/backend/optimizer/path/indxpath.c
	src/backend/optimizer/path/joinpath.c
	src/backend/optimizer/path/joinrels.c
	src/backend/optimizer/path/pathkeys.c
	src/backend/optimizer/plan/createplan.c
	src/backend/optimizer/plan/initsplan.c
	src/backend/optimizer/plan/planmain.c
	src/backend/optimizer/plan/planner.c
	src/backend/optimizer/prep/prepunion.c
	src/backend/optimizer/util/joininfo.c
	src/backend/optimizer/util/pathnode.c
	src/backend/optimizer/util/relnode.c
	src/backend/optimizer/util/restrictinfo.c
	src/backend/utils/error/elog.c
	src/backend/utils/misc/postgresql.conf.sample
	src/bin/psql/describe.c
	src/include/access/gist_private.h
	src/include/access/hash.h
	src/include/nodes/nodes.h
	src/include/nodes/relation.h
	src/include/optimizer/pathnode.h
	src/include/optimizer/paths.h
	src/include/optimizer/planmain.h
	src/include/optimizer/restrictinfo.h

Bump GPOPT version to 1.618 and GPOS version to 1.334. Avoid initiating the CMinidumperDXL when not needed

Closes #274.

Since we are using 64 bit atomic operations on this pointer, it requires
to be 64-bit aligned. This only affects OS X builds.

Closes #269.

We run all regression tests with optimizer=on and optimizer=off in the buildfarm.
So remove optimizer settings here.

Closes #266.

Fix typo "Maintains"

gp_read_error_log and gp_truncate_error_log were two functions which were added
in 4.3.3.0 to support the new error logging functionality for external tables.
They were added to a "hidden" catalog in order to prevent bumping up the
catalog version in a minor version release. We need to add them to the true
catalog in a major release.

Also in the process remove hiddencat mechanism since apart from the above two
functions no other functions use it.

Fall back to legacy query optimizer for queries with partition elimination over full outer join queries.

Closes #265

Fix the compiler warning introduced by commit:
08f4ada7

Author: Heikki Linnakangas

Closes #261.

Changed gptransfer verification step in Behave to check the
return code instead of whether gpdiff prints any lines.  Also
removed an unnecessary print statement in gpdiff and made
minor readability changes to the Behave step.

Authors: James McAtamney and Jimmy Yih

Every 100th AO or CO row insert in a transaction leaks 64 bytes
(gpgastsequence tuple) memory. Hence for transaction performing bulk
inserts to AO or CO table memory footprint keeps increasing, without
the fix.

Moving the installation of gp_toolkit.sql into initdb, in commit f8910c3c,
broke all the functions that are supposed to execute on all nodes, like
gp_toolkit.__gp_localid. After that change, gp_toolkit.sql was executed
in utility mode, and the gp_distribution_policy entries for those functions
were not created as a result.

To fix, change the code so that gp_distribution_policy entries are never
never created, or consulted, for EXECUTE-type external tables. They have
more fine-grained information in pg_exttable.location field anyway, so rely
on that instead. With this change, there is no difference in whether an
EXECUTE-type external table is created in utility mode or not. We would
still have similar problems if gp_toolkit contained other kinds of
external tables, but it doesn't.

This removes the isMasterOnly() function and changes all its callers to
call GpPolicyFetch() directly instead. Some places used GpPolicyFetch()
directly to check if a table is distributed, so this just makes that the
canonical way to do it. The check for system schemas that used to be in
isMasterOnly() are no longer performed, but they should've unnecessary in
the first place. System tables don't have gp_distribution_policy entries,
so they'll be treated as master-only even without that check.

For "checksum=on/off", we used the "on" or "off" value to allocate space
(i.e. 2 or 3 bytes), but then constructed a string that said "true" or
"false" (4 or 5 bytes). That lead to overflowing the allocation by a few
bytes, which produced warnings on assertion-enabled builds.

The integer parsing almost has the same bug. We use the original string's
length to allocate space, but we use %d to construct the value actually
stored there. That happens to not be a bug, because the original length is
always at least as large. This is a near-miss though: the original value
might be in hexadecimal format, i.e. "0x7fffffff", and its decimal
representation might be longer than the original. With 32-bit integers,
however, that happens to not be possible. as the extra "0x" in front of the
hex string provides enough padding. (i.e. strlen("0x7fffffff") >=
strlen("2147483647)"))

To fix, don't even try to count the space needed. Use a StringInfo instead.

In the passing, clean up accumAOStorageOpt function in some other ways:
remove the namelen argument to make it a bit more readable (this is hardly
performance-critical code), and don't split error message across lines
(makes it easier to grep for them if you need to find where an error
is coming from).

Closes #259.

Usage: minirepro <database> [options]

Options:
  --version             show program's version number and exit
  -?, --help            Show this help message and exit
  -h HOST, --host=HOST  Specify a remote host
  -p PORT, --port=PORT  Specify a port other than 5432
  -U USER, --user=USER  Connect as someone other than current user
  -q QUERY_FILE         file name that contains the query
  -f OUTPUT_FILE        minirepro output file name

Closes #157.

Remove superflous ";" to ensure that the return value is set based
on the success of udpSignalGet(). Verified by lchang@.

This only affects OS X builds.

Adding functionality to enable retrieving the number of evicted objects from MDCache for testing purposes

This table is not used anywhere in the code.

update and refactor the test code related to commit:
bdb29386

Introduced by a89b2684.

I removed some cruft from gp_filedump's .gitignore file.

These were both only used by a single, static, function.

Upstream doesn't have them, and they are just plain setter/getter
functions. Having functions like this woldn't be a bad idea per se, but
will cause merge conflicts.