1. 31 3月, 2012 5 次提交
  2. 30 3月, 2012 5 次提交
    • R
      pg_test_timing: Lame hack to work around compiler warning. · 3f427c13
      Robert Haas 提交于
      Fujii Masao, plus a comment by me.  While I'm at it, correctly tabify
      this chunk of code.
      3f427c13
    • T
      Fix dblink's failure to report correct connection name in error messages. · b75fbe91
      Tom Lane 提交于
      The DBLINK_GET_CONN and DBLINK_GET_NAMED_CONN macros did not set the
      surrounding function's conname variable, causing errors to be incorrectly
      reported as having occurred on the "unnamed" connection in some cases.
      This bug was actually visible in two cases in the regression tests,
      but apparently whoever added those cases wasn't paying attention.
      
      Noted by Kyotaro Horiguchi, though this is different from his proposed
      patch.
      
      Back-patch to 8.4; 8.3 does not have the same type of error reporting
      so the patch is not relevant.
      b75fbe91
    • T
      Improve contrib/pg_stat_statements' handling of PREPARE/EXECUTE statements. · 566a1d43
      Tom Lane 提交于
      It's actually more useful for the module to ignore these.  Ignoring
      EXECUTE (and not incrementing the nesting level) allows the executor
      hooks to charge the time to the underlying prepared query, which
      shows up as a stats entry with the original PREPARE as query string
      (possibly modified by suppression of constants, which might not be
      terribly useful here but it's not worth avoiding).  This is much more
      useful than cluttering the stats table with a distinct entry for each
      textually distinct EXECUTE.
      
      Experimentation with this idea shows that it's also preferable to ignore
      PREPARE.  If we don't, we get two stats table entries, one with the query
      string hash and one with the jumble-derived hash, but with the same visible
      query string (modulo those constants).  This is confusing and not very
      helpful, since the first entry will only receive costs associated with
      initial planning of the query, which is not something counted at all
      normally by pg_stat_statements.  (And if we do start tracking planning
      costs, we'd want them blamed on the other hash table entry anyway.)
      566a1d43
    • T
      Improve handling of utility statements containing plannable statements. · e0e4ebe3
      Tom Lane 提交于
      When tracking nested statements, contrib/pg_stat_statements formerly
      double-counted the execution costs of utility statements that directly
      contain an executable statement, such as EXPLAIN and DECLARE CURSOR.
      This was not obvious since the ProcessUtility and Executor hooks
      would each add their measured costs to the same stats table entry.
      However, with the new implementation that hashes utility and plannable
      statements differently, this showed up as seemingly-duplicate stats
      entries.  Fix that by disabling the Executor hooks when the query has a
      queryId of zero, which was the case already for such statements but is now
      more clearly specified in the code.  (The zero queryId was causing problems
      anyway because all such statements would add to a single bogus entry.)
      
      The PREPARE/EXECUTE case still results in counting the same execution
      in two different stats table entries, but it should be much less surprising
      to users that there are two entries in such cases.
      
      In passing, include a CommonTableExpr's ctename in the query hash.
      I had left it out originally on the grounds that we wanted to omit all
      inessential aliases, but since RTE_CTE RTEs are hashing their referenced
      names, we'd better hash the CTE names too to make sure we don't hash
      semantically different queries the same.
      e0e4ebe3
    • P
      initdb: Mark more messages for translation · 2005b77b
      Peter Eisentraut 提交于
      Some Windows-only messages had apparently been forgotten so far.
      
      Also make the wording of the messages more consistent with similar
      messages other parts, such as pg_ctl and pg_regress.
      2005b77b
  3. 29 3月, 2012 9 次提交
    • S
      Correct epoch of txid_current() when executed on a Hot Standby server. · 68219aaf
      Simon Riggs 提交于
      Initialise ckptXidEpoch from starting checkpoint and maintain the correct
      value as we roll forwards. This allows GetNextXidAndEpoch() to return the
      correct epoch when executed during recovery. Backpatch to 9.0 when the
      problem is first observable by a user.
      
      Bug report from Daniel Farina
      68219aaf
    • A
      Unbreak Windows builds broken by pgpipe removal. · aeca6502
      Andrew Dunstan 提交于
      aeca6502
    • H
      Inherit max_safe_fds to child processes in EXEC_BACKEND mode. · 5762a4d9
      Heikki Linnakangas 提交于
      Postmaster sets max_safe_fds by testing how many open file descriptors it
      can open, and that is normally inherited by all child processes at fork().
      Not so on EXEC_BACKEND, ie. Windows, however. Because of that, we
      effectively ignored max_files_per_process on Windows, and always assumed
      a conservative default of 32 simultaneous open files. That could have an
      impact on performance, if you need to access a lot of different files
      in a query. After this patch, the value is passed to child processes by
      save/restore_backend_variables() among many other global variables.
      
      It has been like this forever, but given the lack of complaints about it,
      I'm not backpatching this.
      5762a4d9
    • A
      Remove now redundant pgpipe code. · d2c1740d
      Andrew Dunstan 提交于
      d2c1740d
    • T
      Improve contrib/pg_stat_statements to lump "similar" queries together. · 7313cc01
      Tom Lane 提交于
      pg_stat_statements now hashes selected fields of the analyzed parse tree
      to assign a "fingerprint" to each query, and groups all queries with the
      same fingerprint into a single entry in the pg_stat_statements view.
      In practice it is expected that queries with the same fingerprint will be
      equivalent except for values of literal constants.  To make the display
      more useful, such constants are replaced by "?" in the displayed query
      strings.
      
      This mechanism currently supports only optimizable queries (SELECT,
      INSERT, UPDATE, DELETE).  Utility commands are still matched on the
      basis of their literal query strings.
      
      There remain some open questions about how to deal with utility statements
      that contain optimizable queries (such as EXPLAIN and SELECT INTO) and how
      to deal with expiring speculative hashtable entries that are made to save
      the normalized form of a query string.  However, fixing these issues should
      require only localized changes, and since there are other open patches
      involving contrib/pg_stat_statements, it seems best to go ahead and commit
      what we've got.
      
      Peter Geoghegan, reviewed by Daniel Farina
      7313cc01
    • P
      Run maintainer-check on all PO files, not only configured ones · 4e1c7207
      Peter Eisentraut 提交于
      The intent is to allow configure --enable-nls=xx for installation
      speed and size, but have maintainer-check check all source files
      regardless.
      4e1c7207
    • P
      03f0c08f
    • R
      Attempt to unbreak pg_test_timing on Windows. · 7f63527c
      Robert Haas 提交于
      Per buildfarm, and Álvaro Herrera.
      7f63527c
    • R
      pg_basebackup: Error handling fixes. · ada763cf
      Robert Haas 提交于
      Thomas Ogrisegg and Fujii Masao
      ada763cf
  4. 28 3月, 2012 9 次提交
    • R
      pg_basebackup: Error message improvements. · 81f6bbe8
      Robert Haas 提交于
      Fujii Masao
      81f6bbe8
    • R
      Doc fix for pg_test_timing. · 9c272da8
      Robert Haas 提交于
      Fujii Masao
      9c272da8
    • R
      pg_test_timing utility, to measure clock monotonicity and timing cost. · cee52386
      Robert Haas 提交于
      Ants Aasma, Greg Smith
      cee52386
    • R
      Expose track_iotiming information via pg_stat_statements. · 5b4f3466
      Robert Haas 提交于
      Ants Aasma, reviewed by Greg Smith, with very minor tweaks by me.
      5b4f3466
    • T
      Bend parse location rules for the convenience of pg_stat_statements. · 5d3fcc4c
      Tom Lane 提交于
      Generally, the parse location assigned to a multiple-token construct is
      the location of its leftmost token.  This commit breaks that rule for
      the syntaxes TYPENAME 'LITERAL' and CAST(CONSTANT AS TYPENAME) --- the
      resulting Const will have the location of the literal string, not the
      typename or CAST keyword.  The cases where this matters are pretty thin on
      the ground (no error messages in the regression tests change, for example),
      and it's unlikely that any user would be confused anyway by an error cursor
      pointing at the literal.  But still it's less than consistent.  The reason
      for changing it is that contrib/pg_stat_statements wants to know the parse
      location of the original literal, and it was agreed that this is the least
      unpleasant way to preserve that information through parse analysis.
      
      Peter Geoghegan
      5d3fcc4c
    • T
      Add some infrastructure for contrib/pg_stat_statements. · a40fa613
      Tom Lane 提交于
      Add a queryId field to Query and PlannedStmt.  This is not used by the
      core backend, except for being copied around at appropriate times.
      It's meant to allow plug-ins to track a particular query forward from
      parse analysis to execution.
      
      The queryId is intentionally not dumped into stored rules (and hence this
      commit doesn't bump catversion).  You could argue that choice either way,
      but it seems better that stored rule strings not have any dependency
      on plug-ins that might or might not be present.
      
      Also, add a post_parse_analyze_hook that gets invoked at the end of
      parse analysis (but only for top-level analysis of complete queries,
      not cases such as analyzing a domain's default-value expression).
      This is mainly meant to be used to compute and assign a queryId,
      but it could have other applications.
      
      Peter Geoghegan
      a40fa613
    • R
      New GUC, track_iotiming, to track I/O timings. · 40b9b957
      Robert Haas 提交于
      Currently, the only way to see the numbers this gathers is via
      EXPLAIN (ANALYZE, BUFFERS), but the plan is to add visibility through
      the stats collector and pg_stat_statements in subsequent patches.
      
      Ants Aasma, reviewed by Greg Smith, with some further changes by me.
      40b9b957
    • T
      Silence compiler warning about uninitialized variable. · 98316e21
      Tom Lane 提交于
      98316e21
    • P
      dd024c22
  5. 27 3月, 2012 2 次提交
  6. 26 3月, 2012 3 次提交
    • R
      Code cleanup for heap_freeze_tuple. · 7386089d
      Robert Haas 提交于
      It used to be case that lazy vacuum could call this function with only
      a shared lock on the buffer, but neither lazy vacuum nor any other
      code path does that any more.  Simplify the code accordingly and clean
      up some related, obsolete comments.
      7386089d
    • T
      Fix COPY FROM for null marker strings that correspond to invalid encoding. · e8476f46
      Tom Lane 提交于
      The COPY documentation says "COPY FROM matches the input against the null
      string before removing backslashes".  It is therefore reasonable to presume
      that null markers like E'\\0' will work ... and they did, until someone put
      the tests in the wrong order during microoptimization-driven rewrites.
      Since then, we've been failing if the null marker is something that would
      de-escape to an invalidly-encoded string.  Since null markers generally
      need to be something that can't appear in the data, this represents a
      nontrivial loss of functionality; surprising nobody noticed it earlier.
      
      Per report from Jeff Davis.  Backpatch to 8.4 where this got broken.
      e8476f46
    • T
      Replace empty locale name with implied value in CREATE DATABASE and initdb. · c7cea267
      Tom Lane 提交于
      setlocale() accepts locale name "" as meaning "the locale specified by the
      process's environment variables".  Historically we've accepted that for
      Postgres' locale settings, too.  However, it's fairly unsafe to store an
      empty string in a new database's pg_database.datcollate or datctype fields,
      because then the interpretation could vary across postmaster restarts,
      possibly resulting in index corruption and other unpleasantness.
      
      Instead, we should expand "" to whatever it means at the moment of calling
      CREATE DATABASE, which we can do by saving the value returned by
      setlocale().
      
      For consistency, make initdb set up the initial lc_xxx parameter values the
      same way.  initdb was already doing the right thing for empty locale names,
      but it did not replace non-empty names with setlocale results.  On a
      platform where setlocale chooses to canonicalize the spellings of locale
      names, this would result in annoying inconsistency.  (It seems that popular
      implementations of setlocale don't do such canonicalization, which is a
      pity, but the POSIX spec certainly allows it to be done.)  The same risk
      of inconsistency leads me to not venture back-patching this, although it
      could certainly be seen as a longstanding bug.
      
      Per report from Jeff Davis, though this is not his proposed patch.
      c7cea267
  7. 25 3月, 2012 1 次提交
    • T
      Fix planner's handling of outer PlaceHolderVars within subqueries. · 8279eb41
      Tom Lane 提交于
      For some reason, in the original coding of the PlaceHolderVar mechanism
      I had supposed that PlaceHolderVars couldn't propagate into subqueries.
      That is of course entirely possible.  When it happens, we need to treat
      an outer-level PlaceHolderVar much like an outer Var or Aggref, that is
      SS_replace_correlation_vars() needs to replace the PlaceHolderVar with
      a Param, and then when building the finished SubPlan we have to provide
      the PlaceHolderVar expression as an actual parameter for the SubPlan.
      The handling of the contained expression is a bit delicate but it can be
      treated exactly like an Aggref's expression.
      
      In addition to the missing logic in subselect.c, prepjointree.c was failing
      to search subqueries for PlaceHolderVars that need their relids adjusted
      during subquery pullup.  It looks like everyplace else that touches
      PlaceHolderVars got it right, though.
      
      Per report from Mark Murawski.  In 9.1 and HEAD, queries affected by this
      oversight would fail with "ERROR: Upper-level PlaceHolderVar found where
      not expected".  But in 9.0 and 8.4, you'd silently get possibly-wrong
      answers, since the value transmitted into the subquery wouldn't go to null
      when it should.
      8279eb41
  8. 24 3月, 2012 3 次提交
    • T
      Cast some printf arguments to avoid possibly-nonportable behavior. · ed61127b
      Tom Lane 提交于
      Per compiler warnings on buildfarm member black_firefly.
      ed61127b
    • T
      Refactor simplify_function et al to centralize argument simplification. · 81a646fe
      Tom Lane 提交于
      We were doing the recursive simplification of function/operator arguments
      in half a dozen different places, with rather baroque logic to ensure it
      didn't get done multiple times on some arguments.  This patch improves that
      by postponing argument simplification until after we've dealt with named
      parameters and added any needed default expressions.
      
      Marti Raudsepp, somewhat hacked on by me
      81a646fe
    • T
      Code review for protransform patches. · 0339047b
      Tom Lane 提交于
      Fix loss of previous expression-simplification work when a transform
      function fires: we must not simply revert to untransformed input tree.
      Instead build a dummy FuncExpr node to pass to the transform function.
      This has the additional advantage of providing a simpler, more uniform
      API for transform functions.
      
      Move documentation to a somewhat less buried spot, relocate some
      poorly-placed code, be more wary of null constants and invalid typmod
      values, add an opr_sanity check on protransform function signatures,
      and some other minor cosmetic adjustments.
      
      Note: although this patch touches pg_proc.h, no need for catversion
      bump, because the changes are cosmetic and don't actually change the
      intended catalog contents.
      0339047b
  9. 23 3月, 2012 3 次提交