1. 28 2月, 2018 4 次提交
  2. 27 2月, 2018 1 次提交
  3. 26 2月, 2018 1 次提交
    • H
      fix gpload bug about handling nullas option (#4583) · 2e330960
      huiliang-liu 提交于
      - if the data file contains "\N" as the delimiter, it would not be
      recognized properly by gpload
      - root cause: gpload replace the quote in nullas option as well as
      replace '\' as '\\'
      - solution: add quote_no_slash function to handle nullas option
      2e330960
  4. 24 2月, 2018 3 次提交
    • M
      Fix issues in gpinitstandby tinc test. · d6de56fb
      Max Yang 提交于
      *  Add PG_BASEBACKUP_FIXME:if there are new tablespaces, gpinitstandby fails.
         pg_basebackup can't copy tablespace data to standby, besause the tablespace
         directory is not empty on standby.
      *  Check standby tablespace directory.
      *  Replace function cleanupFilespaces with function cleanup_tablespace.
      
        Author: Max Yang <myang@pivotal.io>
        Author: Xiaoran Wang <xiwang@pivotal.io>
      d6de56fb
    • N
      Make resgroup work on Ubuntu · 793b4d4a
      Ning Yu 提交于
      * resgroup: make cgroup memsw.limit_in_bytes optional.
      * resgroup: retry proc migration for rmdir to succeed.
      * resgroup: add delay in a testcase.
      * resgroup: use correct log level in cgroup ops.
      793b4d4a
    • J
      gpdeletesystem: fix hangs on error · 42269a5a
      Jamie McAtamney 提交于
      This commit moves some cleanup code to finally blocks to prevent
      gpdeletesystem hanging on error cases.
      Co-authored-by: NJamie McAtamney <jmcatamney@pivotal.io>
      Co-authored-by: NNadeem Ghani <nghani@pivotal.io>
      42269a5a
  5. 23 2月, 2018 6 次提交
    • L
      20b2e3f1
    • H
      Update minirepro to issue DELETE command only when we are inserting stats for catalog table · fab9c519
      Haisheng Yuan 提交于
      In minirepro, the following query is generated:
      ```
      DELETE FROM pg_statistic WHERE starelid='tpcds.catalog_returns_1_prt_27'::regclass AND staattnum=22;
      INSERT INTO pg_statistic VALUES ......
      ```
      It only has existing stats entries for catalog tables, so for non-catalog
      table, the DELETE command is useless, and slows down the speed of loading
      minirepro.
      
      We should NOT generate DELETE query for non-catalog tables.
      Signed-off-by: NEkta Khanna <ekhanna@pivotal.io>
      fab9c519
    • B
      Reorder gp_toolkit test · 2fea28fb
      Bhuvnesh Chaudhary 提交于
      gp_toolkit tests runs a query which checks if there are any GUCs
      which have different value on the cluster node. However, test
      udf_exception_blocks_panic_scenarios is executed before it and it
      injects PANIC which causes recovery and it takes some time for all
      the GUCs to be in consistent state between the segments. But by that
      time gp_toolkit identifies difference and fails, so moving gp_toolkit
      test above it.
      2fea28fb
    • V
      Remove fix me in primenode.h · 259cf705
      Venkatesh Raghavan 提交于
      GPORCA uses NOT_EXIST_SUBLINK to implement co-related left anti semijoin.
      Therefore we still need this in the executor for GPORCA plans.
      
      Example:
      
      ```sql
      CREATE TABLE csq_r(a int) distributed by (a);
      INSERT INTO csq_r VALUES (1);
      CREATE OR REPLACE FUNCTION csq_f(a int) RETURNS int AS $$ select $1 $$ LANGUAGE SQL CONTAINS SQL;
      explain SELECT * FROM csq_r WHERE not exists (SELECT * FROM csq_f(csq_r.a));
      Physical plan:
      +--CPhysicalMotionGather(master)   rows:1   width:34  rebinds:1   cost:882688.037301   origin: [Grp:7, GrpExpr:14]
         +--CPhysicalCorrelatedLeftAntiSemiNLJoin("" (8))   rows:1   width:34  rebinds:1   cost:882688.037287   origin: [Grp:7, GrpExpr:13]
            |--CPhysicalTableScan "csq_r" ("csq_r")   rows:1   width:34  rebinds:1   cost:431.000019   origin: [Grp:0, GrpExpr:1]
            |--CPhysicalComputeScalar   rows:1   width:1  rebinds:1   cost:0.000002   origin: [Grp:5, GrpExpr:1]
            |  |--CPhysicalConstTableGet Columns: ["" (8)] Values: [(1)]   rows:1   width:1  rebinds:1   cost:0.000001   origin: [Grp:1, GrpExpr:1]
            |  +--CScalarProjectList   origin: [Grp:4, GrpExpr:0]
            |     +--CScalarProjectElement "csq_f" (9)   origin: [Grp:3, GrpExpr:0]
            |        +--CScalarIdent "a" (0)   origin: [Grp:2, GrpExpr:0]
            +--CScalarConst (1)   origin: [Grp:8, GrpExpr:0]
      ",
                                         QUERY PLAN
      ---------------------------------------------------------------------------------
       Gather Motion 3:1  (slice1; segments: 3)  (cost=0.00..882688.04 rows=1 width=4)
         Output: a
         ->  Table Scan on public.csq_r  (cost=0.00..882688.04 rows=1 width=4)
               Output: a
               Filter: (SubPlan 1)
               SubPlan 1  (slice1; segments: 3)
                 ->  Result  (cost=0.00..0.00 rows=1 width=1)
                       Output:
                       ->  Result  (cost=0.00..0.00 rows=1 width=1)
                             Output: $0,
                             ->  Result  (cost=0.00..0.00 rows=1 width=1)
                                   Output: true
       Optimizer: PQO version 2.55.2
      (13 rows)
      ```
      259cf705
    • S
      Fix bug in RESET/RESET ALL command · b292d9cf
      sambitesh 提交于
      Prior to this commit, on calling `RESET`/`RESET ALL` command, the value of guc
      was not getting updated on all the slices(already spun up reader slices).
      This commit fixes the issue.
      Signed-off-by: NEkta Khanna <ekhanna@pivotal.io>
      b292d9cf
    • D
      Fix AO/CO visimap first row number integer overflow (#4564) · 84c5b698
      David Kimura 提交于
      There is a scenario during AO/CO delete or update where the first row number
      obtained is negative. The error is caused when the first row number in the
      aovisimap of an AO/CO table exceeds int max. There is currently a bug where
      the first row number is retrieved from the tuple as an int, but the first row
      number is an int64. We fixed this by retrieving as an int64.
      Co-authored-by: NJimmy Yih <jyih@pivotal.io>
      Co-authored-by: NDavid Kimura <dkimura@pivotal.io>
      84c5b698
  6. 22 2月, 2018 5 次提交
  7. 21 2月, 2018 3 次提交
  8. 19 2月, 2018 6 次提交
  9. 18 2月, 2018 1 次提交
    • M
      docs: gpbackup/gprestore updates (#4507) · b65f2b11
      Mel Kiyama 提交于
      * docs: gpbackup/gprestore updates
      
      -Remove experimental notes
      -Update email configuration informtion
      -Add return code information
      
      * docs: gpbackup/gprestore updated email config. file, updated email example, fix typos.
      
      * docs: gpbackup/gprestore GA- update options, -globals to -with-globals, -redirect to -redirect-db, missed one -backup-dir.
      
      * docs: gpbackup/gprestore email notification fixes
      -default for status section is to not send email notification
      -update email notification example based on fixes
      
      * docs: gpbackup/gprestore - add statement that gprestore creates a database by cloning template0
      
      * docs: gpbackup/gprestore - review comment updates, new/changed features.
      
      AdminGuide
      updated email notification informmation
      updated gpbackup/gprestore output
      added report file information
      fixed partition table filtering example
      corrected gpbackup schema/table filtering support
      updated restore limitation. table index, rule, trigger are restored
      
      gpbackup doc
      change the gpbackup option name from -backupdir to -backup-dir
      corrected description of parallel backup
      
      gprestore doc
      change the gprestore option name from -createdb to -create-db
      updated description of restore operation in description
      updated restore description if schema exists in database
      updated restore limitation. table index, rule, trigger are restored
      
      * docs: gpbackup/gprestore late updates
      -new restore options
      -clarified leaf partition backup/restore
      
      * docs: fixed typos and issues from review comments.
      b65f2b11
  10. 17 2月, 2018 4 次提交
  11. 16 2月, 2018 6 次提交
    • J
      Fix gprecoverseg Behave tests · 48d7a5f2
      Jimmy Yih 提交于
      After filerep, filespaces, and persistent tables were removed, we
      disabled the gprecoverseg Behave tests which needed gprecoverseg to be
      refactored before the tests could run. Currently, gprecoverseg is in a
      usable state so it's time to fix these Behave tests and have them
      running again. Some refactoring, workarounds, and test removal was
      needed which is detailed here.
      
      Refactoring:
      1. The tests used gpfaultinjector to cause a mirror or primary down
      situation. This is not really needed and just killing the segments is
      good enough. Also, injecting a fault on a mirror doesn't really do
      anything anymore because it would not trigger due to the mirror being
      in recovery mode.
      2. The checksum test did not look correct so we refactored it to what
      we think it was suppose to look like.
      
      Workaround:
      Running incremental recovery after killing a primary to trigger
      failover will not work without pg_rewind.  These calls have been
      changed to use full recovery similar to how gprecoverseg rebalancing
      works right now. Once pg_rewind is introduced, they should be changed
      back to use incremental recovery.
      
      Test Removal:
      1. A scenario checked for failure when there were corrupted
      changetracking logs. If corrupted, a full recovery must be run. We
      delete this test since changetracking logs are no longer a
      thing. However, this scenario is very similar to our src/test/walrep
      missing_xlogs test. That might be good enough as a low-level
      replacement but we may want to add a full end-to-end scenario back in
      these Behave tests.
      2. A scenario checked that gprecoverseg would not recover segments
      with persistent rebuild inconsistencies. Persistent tables no longer
      exist so the scenario is okay to remove.
      Co-authored-by: NJimmy Yih <jyih@pivotal.io>
      Co-authored-by: NDavid Kimura <dkimura@pivotal.io>
      48d7a5f2
    • J
      gprecoverseg fix for reading recovery input file · 97c1a172
      Jimmy Yih 提交于
      This was incorrectly modified when filespaces were removed. It was
      probably not caught because the gprecoverseg Behave tests were
      unusable. Now that they work, this issue was caught for us to fix.
      Co-authored-by: NJimmy Yih <jyih@pivotal.io>
      Co-authored-by: NDavid Kimura <dkimura@pivotal.io>
      97c1a172
    • A
      Fix tinc storage make target. · d58e2601
      Ashwin Agrawal 提交于
      d58e2601
    • A
      Check AO visimap and block directory has unique index in ICW. · 3b7a14d0
      Ashwin Agrawal 提交于
      Removing the test from tinc and adding simple check for the same in
      existing appendonly and aocs tests.
      3b7a14d0
    • A
      Delete catalog/oid_inconsistency test. · f0584015
      Ashwin Agrawal 提交于
      The test validates if order of partitions in pg_herits doesn't match
      between master and segments it doesn't introduce OID mis-match between
      master and segment. Given the new way of dispatching oids from master
      with namespace and name, entries in pg_herits table doesn't matter
      anyway and hence the test can be deleted.
      f0584015
    • A
      Delete transaction_management/high_transaction_id test. · 004fb737
      Ashwin Agrawal 提交于
      Based on history the test was added for bug where a debug log would
      cause buffer overflow and corrupt global memory in production when
      transaction id is 9 characters or more. That code is long gone, plus
      any such issues should be reported by coverity and fixed via same. The
      current test is pretty heavy as performs pg_resetxlog to bump
      transaction-id on each and every primary and mirror to have 9 digits.
      004fb737