1. 08 8月, 2017 9 次提交
    • A
      Add missing include · a0fd35db
      Adam Lee 提交于
      strcasestr() needs string.h
      a0fd35db
    • H
      Remove unnecessary use of PQExpBuffer. · cc38f526
      Heikki Linnakangas 提交于
      StringInfo is more appropriate in backend code. (Unless the buffer needs to
      be used in a thread.)
      
      In the passing, rename the 'conn' static variable in cdbfilerepconnclient.c.
      It seemed overly generic.
      cc38f526
    • N
      Fix an assertion failure in resgroup. · 840a451b
      Ning Yu 提交于
      * Fix an assertion failure in resgroup.
      
      Suppose a resgroup already has a session assigned but no query running.
      In another session (not assigned to this resgroup) drop this resgroup
      and recreate it, then an assertion failure would be triggered.
      
      The cause is that the old resgroup's struct in shm is reused for the new
      resgroup, so on a QE who only owns a weak ref to this struct may find the
      struct's resgroup id different than its expection.
      
      To fix it we add the checks for such cases.
      
      * Changes according to PR reviews.
      840a451b
    • X
      \copy command doesn't support on segment option · 755175f8
      Xiaoran Wang 提交于
      \copy command reads the file from the client filesystem
      but 'on segment'  reads file from the segment system
      So \copy command and 'on segment' option are incompatible
      Signed-off-by: NXiaoran Wang <xiwang@pivotal.io>
      755175f8
    • G
      Remove icw_resource_group from gpdb_master pipeline · f8a97f63
      Gang Xiong 提交于
      f8a97f63
    • A
      Fix gpcheckmirrorseg.pl for MAC · 92e85a42
      Ashwin Agrawal 提交于
      gpcheckmirrorseg.pl assumed GPDB is compiled as 32 bit on macs and hence doesn't
      work correctly. Fixing the same as now we compile GPDB in 64 bits on MACs too.
      
      Also, add errlog directory to ignore_list as its not supposed to be same on
      primary and mirror. Plus, reflect missing relkinds for visimap, blockdirectory
      and sequence tables.
      92e85a42
    • A
      Add .gitignore to contrib/gp_inject_fault. · f17a5d5c
      Ashwin Agrawal 提交于
      f17a5d5c
    • A
      Fix recent coverity issues and warnings. · 9b7c6924
      Ashwin Agrawal 提交于
      CID 173910 Dereference after null check. In markDirty: Pointer is checked
      against null but then dereferenced anyway. Removed the checking against and
      added Assert instead as don't see why relation should be NULL in markDirty().
      
      CID 173667 Printf arg type mismatch. A printf format string does not match the
      types of one of the arguments. Fixed to make it only one %s and relpath() to get
      the path.
      
      Also, fixing the warning
      ```
      guc.c:643:15: warning: incompatible pointer to integer conversion initializing 'bool' (aka 'char') with an expression of type 'void *' [-Wint-conversion]
                      NULL, NULL, NULL
      ```
      9b7c6924
    • H
      Fix some compiler warnings that have crept up recently. · 67e4fde2
      Heikki Linnakangas 提交于
      Clean up after commits e40e78fa, 038aa959, 859d6592 and a21da89e.
      Tut tut.
      67e4fde2
  2. 07 8月, 2017 5 次提交
  3. 05 8月, 2017 16 次提交
  4. 04 8月, 2017 8 次提交
  5. 03 8月, 2017 2 次提交
    • N
      Fix resource group memory overuse issue when increasing concurrency. · 94a08704
      Ning Yu 提交于
      Resource group may have memory overuse in below case:
      
      	CREATE RESOURCE GROUP rg_concurrency_test WITH
      	(concurrency=1, cpu_rate_limit=20, memory_limit=60,
      	 memory_shared_quota=0, memory_spill_ratio=10);
      	CREATE ROLE role_concurrency_test RESOURCE GROUP rg_concurrency_test;
      
      	11:SET ROLE role_concurrency_test;
      	11:BEGIN;
      
      	21:SET ROLE role_concurrency_test;
      	22:SET ROLE role_concurrency_test;
      	21&:BEGIN;
      	22&:BEGIN;
      
      	ALTER RESOURCE GROUP rg_concurrency_test SET CONCURRENCY 2;
      
      	11:END;
      
      The cause is that we didn't check overall memory quota usage in the
      past, so pending queries can be waken up as long as the concurrency
      limit is not reached, in such a case if the currently running tranctions
      have used all the memory quota in the resource group then the overall
      memory usage will be exceeded.
      
      To fix this issue we now checks both concurrency limit and memory quota
      usage to decide whether to wake up pending queries.
      Signed-off-by: NZhenghua Lyu <zlv@pivotal.io>
      94a08704
    • H
      759c19d0