1. 29 12月, 2010 5 次提交
    • M
      Add REPLICATION privilege for ROLEs · 9b8aff8c
      Magnus Hagander 提交于
      This privilege is required to do Streaming Replication, instead of
      superuser, making it possible to set up a SR slave that doesn't
      have write permissions on the master.
      
      Superuser privileges do NOT override this check, so in order to
      use the default superuser account for replication it must be
      explicitly granted the REPLICATION permissions. This is backwards
      incompatible change, in the interest of higher default security.
      9b8aff8c
    • T
      Avoid unexpected conversion overflow in planner for distant date values. · f2ba1e99
      Tom Lane 提交于
      The "date" type supports a wider range of dates than int64 timestamps do.
      However, there is pre-int64-timestamp code in the planner that assumes that
      all date values can be converted to timestamp with impunity.  Fortunately,
      what we really need out of the conversion is always a double (float8)
      value; so even when the date is out of timestamp's range it's possible to
      produce a sane answer.  All we need is a code path that doesn't try to
      force the result into int64.  Per trouble report from David Rericha.
      
      Back-patch to all supported versions.  Although this is surely a corner
      case, there's not much point in advertising a date range wider than
      timestamp's if we will choke on such values in unexpected places.
      f2ba1e99
    • T
      Reclassify DEFAULT as a column_constraint item in the CREATE TABLE syntax. · 31d2efae
      Tom Lane 提交于
      This is how it was documented originally, but several years ago somebody
      decided that DEFAULT isn't a type of constraint.  Well, the grammar thinks
      it is.  The documentation was wrong in two ways: it alleged that DEFAULT
      had to appear before any other kind of constraint, and it alleged that you
      can't prefix a DEFAULT clause with a "CONSTRAINT name" clause, when in fact
      you can.  (The latter behavior probably isn't SQL-standard, but our grammar
      has always allowed it.)
      
      This patch responds to Fujii Masao's observation that the ALTER TABLE
      documentation mistakenly implied that you couldn't include DEFAULT in
      ALTER TABLE ADD COLUMN; though this isn't the way he proposed fixing it.
      31d2efae
    • P
      No release notes update, just advance the date · a5f96409
      Peter Eisentraut 提交于
      a5f96409
    • T
      Fix ill-advised placement of PGRES_COPY_BOTH enum value. · 81a530a6
      Tom Lane 提交于
      It must be added at the end of the ExecStatusType enum to avoid ABI
      breakage compared to previous libpq versions.  Noted by Magnus.
      81a530a6
  2. 28 12月, 2010 11 次提交
  3. 27 12月, 2010 2 次提交
  4. 26 12月, 2010 2 次提交
  5. 25 12月, 2010 4 次提交
  6. 24 12月, 2010 5 次提交
  7. 23 12月, 2010 2 次提交
    • H
      Rewrite the GiST insertion logic so that we don't need the post-recovery · 9de3aa65
      Heikki Linnakangas 提交于
      cleanup stage to finish incomplete inserts or splits anymore. There was two
      reasons for the cleanup step:
      
      1. When a new tuple was inserted to a leaf page, the downlink in the parent
      needed to be updated to contain (ie. to be consistent with) the new key.
      Updating the parent in turn might require recursively updating the parent of
      the parent. We now handle that by updating the parent while traversing down
      the tree, so that when we insert the leaf tuple, all the parents are already
      consistent with the new key, and the tree is consistent at every step.
      
      2. When a page is split, we need to insert the downlink for the new right
      page(s), and update the downlink for the original page to not include keys
      that moved to the right page(s). We now handle that by setting a new flag,
      F_FOLLOW_RIGHT, on the non-rightmost pages in the split. When that flag is
      set, scans always follow the rightlink, regardless of the NSN mechanism used
      to detect concurrent page splits. That way the tree is consistent right after
      split, even though the downlink is still missing. This is very similar to the
      way B-tree splits are handled. When the downlink is inserted in the parent,
      the flag is cleared. To keep the insertion algorithm simple, when an
      insertion sees an incomplete split, indicated by the F_FOLLOW_RIGHT flag, it
      finishes the split before doing anything else.
      
      These changes allow removing the whole "invalid tuple" mechanism, but I
      retained the scan code to still follow invalid tuples correctly. While we
      don't create any such tuples anymore, we want to handle them gracefully in
      case you pg_upgrade a GiST index that has them. If we encounter any on an
      insert, though, we just throw an error saying that you need to REINDEX.
      
      The issue that got me into doing this is that if you did a checkpoint while
      an insert or split was in progress, and the checkpoint finishes quickly so
      that there is no WAL record related to the insert between RedoRecPtr and the
      checkpoint record, recovery from that checkpoint would not know to finish
      the incomplete insert. IOW, we have the same issue we solved with the
      rm_safe_restartpoint mechanism during normal operation too. It's highly
      unlikely to happen in practice, and this fix is far too large to backpatch,
      so we're just going to live with in previous versions, but this refactoring
      fixes it going forward.
      
      With this patch, you don't get the annoying
      'index "FOO" needs VACUUM or REINDEX to finish crash recovery' notices
      anymore if you crash at an unfortunate moment.
      9de3aa65
    • B
      Document that BBU's do not allow partial page writes to be safely turned · 7a1ca897
      Bruce Momjian 提交于
      off unless they guarantee that all writes to the BBU arrive in 8kB chunks.
      
      Per discussion with Greg Smith
      7a1ca897
  8. 22 12月, 2010 5 次提交
  9. 21 12月, 2010 2 次提交
    • R
      Work around unfortunate getppid() behavior on BSD-ish systems. · 24ecde77
      Robert Haas 提交于
      On MacOS X, and apparently also on other BSD-derived systems, attaching
      a debugger causes getppid() to return the pid of the debugging process
      rather than the actual parent PID.  As a result, debugging the
      autovacuum launcher, startup process, or WAL sender on such systems
      causes it to exit, because the previous coding of PostmasterIsAlive()
      detects postmaster death by testing whether getppid() == PostmasterPid.
      
      Work around that behavior by checking the return value of getppid()
      more carefully.  If it's PostmasterPid, the postmaster must be alive;
      if it's 1, assume the postmaster is dead.  If it's any other value,
      assume we've been debugged and fall through to the less-reliable
      kill() test.
      
      Review by Tom Lane.
      24ecde77
    • R
      Allow transactions that don't write WAL to commit asynchronously. · f6a0863e
      Robert Haas 提交于
      This case can arise if a transaction has written data, but only to
      temporary tables.  Loss of the commit record in case of a crash won't
      matter, because the temporary tables will be lost anyway.
      
      Reviewed by Heikki Linnakangas and Simon Riggs.
      f6a0863e
  10. 20 12月, 2010 2 次提交