Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

- Remove appending extra-version to Postgres Version
Signed-off-by: NGoutam Tadi <gtadi@pivotal.io>

Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

Signed-off-by: NGoutam Tadi <gtadi@pivotal.io>

* Add jobs to pipeline to create & test deb package

- Copy all of /usr/local/gpdb to /opt/gdpb
- Copy gporca libraries from /usr/local/lib/ to /opt/gpdb/lib
- Add smoke test deb package job
- Use gcc-6 and g++-6 for both gpdb and orca
- Verify that quicklz is not in open-source
- Install ORCA to debian/tmp
- Clone ORCA into gpdb for deb build
- Remove printing debian contents to console
- New lines at the end of files
- check status in all conditions
- Copy debian build configuration from separate repo
- Remove apt-get in favor of pre-built image
Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

* Run unit test along with ICW
Signed-off-by: NGoutam Tadi <gtadi@pivotal.io>

* Remove NON-PROD files
Signed-off-by: NGoutam Tadi <gtadi@pivotal.io>

* Pass env vars for debian Maintainer
Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

- As part of determining the resource group that a transaction should be
  assigned to, AssignResGroupOnMaster() calls GetResGroupIdForRole(), which
  queries a syscache on the catalog table pg_authid, which maps users to
  resource groups.
- Prior to this commit, AssignResGroupOnMaster() was doing the queries
  on pg_authid near the top of StartTransaction() before the per-transaction
  memory context was set up. This required GetResGroupIdForRole() to run
  ResourceOwnerCreate() to avoid segfaulting gpdb and also led to many
  potential issues:
  * unknown behavior if a relcache invalidation event happens on pg_authid's
    syscache
  * possible stale pg_authid entries, as access done with SnapshotNow and
    out-of-date RecentGlobalXmin
  * memory leaks due to no memory context
  * uphill battle as newer version of PostgreSQL remove SnapshotNow and
    assume catalog lookups only happen when transactions are open
Signed-off-by: NDavid Sharp <dsharp@pivotal.io>
Signed-off-by: NAmil Khanzada <akhanzada@pivotal.io>

Looks like you can't actually get here with any aggregates or placeholders
in the start/end offsets, or we would've gotten errors.

The uao drop_while_vacuum tests are non deterministic they way they are
currently written. For now we want to remove these tests to make the CI more
stable. The tests will be replaced with a more deterministic version later.

Author: Abhijit Subramanya <asubramanya@pivotal.io>
Author: Taylor Vesely <tvesely@pivotal.io>

These were missed out and need to be ignored.

Author: Jimmy Yih <jyih@pivotal.io>
Author: Asim R Praveen <apraveen@pivotal.io>

When a primary segment first detects mirror is up, primary will
automatically turn on synchronous WAL replication by directly setting
WalSndCtl->sync_standbys_defined to true during FTS probe handling
(bypassing the need to have postmaster reload and Checkpointer process
doing the update). The state will be persisted by inserting
synchronous_standby_names="*" into gp_replication.conf in case of
segment crash.

MMXLOG records should only be replayed in standby mode and smgr create
xlog records should not do anything until persistent tables and MMXLOG
records are removed from Greenplum.

Author: Jimmy Yih <jyih@pivotal.io>
Author: Asim Praveen <apraveen@pivotal.io>

There was a hack to exclude guc.c from doing single-line comment (//)
removal when creating mock c files. The hack is no longer needed in
guc.c but is now needed in guc_gp.c since the offending line was moved
to guc_gp.c.

1. When forked command is not blocking, give the output that the pipe
   received to see why it did not block.
2. Fix utility mode quit so that a utility mode connection can be
   restarted when connection is closed by postmaster.
3. Fix ! shell commands by processing -- as part of the shell command
   instead of the start of a SQL comment

Some master processes were calling gpvars_assign_gp_fts_probe_pause
when they should not. This was found when the new stats collecter
process errored out on this function call. We also move it to fts.c
where it will live alongside the other fts code.

Also, check for interrupts in fts sleep loop so that fts probe process
can process SIGHUP properly.

Prior to this commit, the below warnings were occurring with GCC versions 6.2.0
on CentOS 6 and 6.3.0 on Ubuntu 14.
These are actually invalid because the `get_dbinfo()` call will always fill in
those variables but the compiler is not smart enough to detect this.

The code change of this commit has not happened on the latest upstream Postgres
(10.1), so there will be merge conflicts in future, but we decided as a team
in #3871 that it was better to fix the warnings.

In file included from ../../../src/include/postgres.h:53:0,
                 from dbcommands.c:22:
dbcommands.c: In function ‘createdb’:
../../../src/include/utils/elog.h:184:4: error: ‘src_ctype’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
    errfinish rest; \
    ^~~~~~~~~
dbcommands.c:616:11: note: ‘src_ctype’ was declared here
  char    *src_ctype;
           ^~~~~~~~~
In file included from ../../../src/include/postgres.h:53:0,
                 from dbcommands.c:22:
../../../src/include/utils/elog.h:184:4: error: ‘src_collate’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
    errfinish rest; \
    ^~~~~~~~~
dbcommands.c:615:11: note: ‘src_collate’ was declared here
  char    *src_collate;
           ^~~~~~~~~~~
Signed-off-by: NDavid Sharp <dsharp@pivotal.io>

Prior to this commit, the below warnings were occurring on GCC 6.2.0.

The warnings seem valid but unlikely, so we just NULL initialize
logStreamStart, which would most likely still land in the correct error
case.

gcc -O3 -std=gnu99  -Wall -Wmissing-prototypes -Wpointer-arith -Werror=uninitialized -Wendif-labels -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -fno-aggressive-loop-optimizations -Wno-unused-but-set-variable -Wno-address  -fpic -I. -I. -I../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2   -c -o gplibpq.o gplibpq.c
In file included from ../../../src/include/postgres.h:53:0,
                 from gplibpq.c:7:
gplibpq.c: In function 'test_receive_and_verify':
../../../src/include/utils/elog.h:311:3: error: 'logStreamStart.xrecoff' may be used uninitialized in this function [-Werror=maybe-uninitialized]
   elog_finish(elevel, __VA_ARGS__); \
   ^~~~~~~~~~~
gplibpq.c:140:15: note: 'logStreamStart.xrecoff' was declared here
    XLogRecPtr logStreamStart;
               ^~~~~~~~~~~~~~
In file included from ../../../src/include/postgres.h:53:0,
                 from gplibpq.c:7:
../../../src/include/utils/elog.h:311:3: error: 'logStreamStart.xlogid' may be used uninitialized in this function [-Werror=maybe-uninitialized]
   elog_finish(elevel, __VA_ARGS__); \
   ^~~~~~~~~~~
gplibpq.c:140:15: note: 'logStreamStart.xlogid' was declared here
    XLogRecPtr logStreamStart;
               ^~~~~~~~~~~~~~
Signed-off-by: NAmil Khanzada <akhanzada@pivotal.io>

Fixes for:
- PGAC_FUNC_GETTIMOFDAY_1ARG and
- PGAC_FUNC_GETPWUID_R_5ARG

Update the C code for ACX_PTHREAD from the autoconf-archive

The relevant changes come from these commits:
- http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=commitdiff;h=0728dab771b2a4da8032d5f0ade8870add680b39
- http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=commitdiff;h=7a6c511965489c38f5d3bef4afe113e3fe11c2ac

> This can be used to mark custom built binaries with an extra version
> string such as a git describe identifier or distribution package release
> version.

From: Oskari Saarenmaa <os@ohmu.fi>
Originally commited by Peter Eisentraut, adapted by Pivotal.
(cherry picked from commit 46328916)

We already had the pointer size check in the upstream order in our
genesis open source commit 6b0e52be , but we seem to have missed the
rest of the rearrangement from upstream.

This commit completes that cherry-pick, to reduce merge diff with
(admittedly much later) commit 46328916 .

> Doesn't seem like a good idea to be doing AC_CHECK_SIZEOF(void *) so much
> earlier than all the other sizeof checks, and it certainly fails to follow
> the order suggested at the file head.  Rearrange.
Author: Tom Lane
Adapted by Pivotal

(cherry picked from commit 075ac80d)

(cherry picked from commit b32a290b)

Harmless, but clearly useless and unintentional.

This resulted in useless extra work during every call of parseRelOptions,
but no bad effects other than that.  Noted by Alvaro.

(Cherry-picked from PostgreSQL commit eb9954e362)

The options should only be registered once. Surprisingly, the duplicates
seem to be harmless, because everything worked, but the accumulation of
more and more reloptions was slowing down tests that created a lot of
tables.

Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

A bad 8.4 merge resolution on my part. We may not support older
server_versions in GPDB's pg_dump, but that doesn't mean we should use
uninitialized memory if we come across one.

error_unsupported_server_version() comes from pg_dump.c; this commit is
a companion to b4c5a618.

We were inconsistent with what's logged and what's not. And some objects
were logged with the GPDB-specific timestamp headers, while others were
not. Make it consistent, by removing the extra logging altogether, making
it consistent with the upstream. The status messages are now only logged in
verbose mode, and there are no timestamps on them. Use 'ts' or similar if
you wish to have timestamps in your logs.

Author: Karen Huddleston <khuddleston@pivotal.io>

It was only used at the end of cdb_dump_agent, shortly before it calls
exit(). There's no need to reset variables or free memory if we're just
about to exit the whole process. pg_dump leaves behind a lot of small
allocations, this was just the tip of the iceberg. Better to be identical
to the upstream, to avoid merge conflicts. (reset() was an awfully generic
name for a function anyway, BTW)

In the passing, also mark buildIndexArray() function as static, like it is
in the upstream.

Commit 8e6aed42 changed the format of the error
messages for reloptions but missed updating the answer files for the default
storage parameters test.

Author: Abhijit Subramanya <asubramanya@pivotal.io>
Author: Taylor Vesely <tvesely@pivotal.io>

* Remove GPHDFS 1.0 and 1.1

* Remove custom ivy repo settings

Merge the next commit from PostgreSQL 8.4, which refactors reloptions.c to
use a table-based parser. We are merging this as a separate commit, because
this needed also refactoring all the GPDB-added reloptions to the new
model.

This adds a new RELOPT_KIND_INTERNAL "relation kind", for TOAST tables and
auxiliary tables of append-only relations, like the AO visimap and block
dir. That will probably be refactored away later in the merge, when we
merge upstream commit 1c855f01, as that commit introduces a new
RELOPT_KIND_TOASTVALUE kind for TOAST tables, instead.

This also includes the new fillRelOptions(), from upstream commit
8ebe1e35 (also from 8.4), because that was very handy in the refactoring
of the GPDB code.

Author: Xiaoran Wang <xiwang@pivotal.io>
Author: Heikki Linnakangas <hlinnakangas@pivotal.io>