- 19 3月, 2019 5 次提交
-
-
由 Ashwin Agrawal 提交于
In some scenarios ERROR "append-only table version -1 is invalid" is being hit. Code inspection doens't reveal any clues why it can happen. So, for now we thought of adding more info to figure out the cause. Backtrace would definitely be helpful when the error hits. Also, check the format version as soon as entry is read from catalog. Plus also would be greatly helpful if can have corefile when the problem happens so under the controlled environment with guc evelate ERROR to PANIC. GUC `debug_appendonly_print_verify_write_block` usage for same is not ideal but wish to avoid adding special guc just for this case, hence piggyback on this existing uinteresting debug guc for now. Co-authored-by: NDaniel Gustafsson <dgustafsson@pivotal.io>
-
由 Lisa Owen 提交于
* dblink - xref to postgres 9.4 docs * docs - add some using and writing your own FDW info * add quote missing from mpp_execute master option * foreign dash data, misc edits
-
由 Bradford Boyle 提交于
ci: remove `-oss` from pattern used to parse version output
-
由 Kalen Krempely 提交于
Remove period from assertRaisesRegexp expectation to not be conflated with the regex metacharacter. Authored-by: NKalen Krempely <kkrempely@pivotal.io>
-
由 Chuck Litzell 提交于
* gpexpand - remove `-D` flag and specify expansion schema is created in postgres database - Add gpstate -x flag * From review: consistent formatting for gpexpand and postgres * Edit from review
-
- 18 3月, 2019 4 次提交
-
-
由 Larry Hamel 提交于
* README mentions how gpupgrade and gpbackup both use the database "regression" that remains after an ICW run in the directory "regress". Authored-by: NLarry Hamel <lhamel@pivotal.io>
-
由 Jialun 提交于
- get port from MASTER_DATA_DIRECTORY, so there is no confusion if PGPORT and MASTER_DATA_DIRECTORY are set to different clusters - delete tmp status file 'gpexpand.standby.status' and copy the status file to standby directly - get standby data directory from catalog instead of assuming its same with master - copy gp_segment_configuration backup file to standby also, so standby can restore this catalog if master is down
-
由 Paul Guo 提交于
Previously we added the code due to Coverity report, however, we conclude that we should better align with upstream after some further discussion. See below. https://github.com/greenplum-db/gpdb/pull/7120 In the long run, we hope StrNCpy() is gone, by the way. Reviewed-by: NDaniel Gustafsson <dgustafsson@pivotal.io>
-
由 Ning Yu 提交于
FirstNormalObjectId indicates the first OID for user objects, if a relation's oid >= FirstNormalObjectId then it's an user object, otherwise it's a catalog object. Fixed some incorrect uses of it, they treated oid == FirstNormalObjectId as catalog objects. Discussion: https://groups.google.com/a/greenplum.org/d/msg/gpdb-dev/ZHy-x1DaoXE/ceyzZ4TuCgAJReviewed-by: NDaniel Gustafsson <dgustafsson@pivotal.io> Reviewed-by: NJimmy Yih <jyih@pivotal.io> Reviewed-by: NGeorgios Kokolatos <gkokolatos@pivotal.io>
-
- 16 3月, 2019 6 次提交
-
-
由 Kris Macoskey 提交于
Authored-by: NKris Macoskey <kmacoskey@pivotal.io>
-
由 Kris Macoskey 提交于
Authored-by: NKris Macoskey <kmacoskey@pivotal.io>
-
由 Kris Macoskey 提交于
Authored-by: NKris Macoskey <kmacoskey@pivotal.io>
-
由 Kris Macoskey 提交于
The default is a non OSS build across CI. Explict CI jobs that do build OSS can use `--with-extra-version` to append `-oss`. Authored-by: NKris Macoskey <kmacoskey@pivotal.io>
-
由 Daniel Gustafsson 提交于
The catullus script had not been used to synchronize all pg_proc changes into the catalog, so ensure we are in sync before we cut Beta and (mostly) freeze the catalog. Also fix a set of typos in DESC properties.
-
由 Chuck Litzell 提交于
* Doc updates for removal of filespaces. Changes to utility refs for #4314 and #7116 - Removes references to filespaces - Allow configuring standby and master on the same host (options to specify host, port, data directory) - Standy master dir is specified with -F (gpinitsystem) or -S (gpinitstandby) * Updates from reviews
-
- 15 3月, 2019 12 次提交
-
-
由 Jinbao Chen 提交于
The error output in gpos job is very different from other jobs. Add ignore first to fix the pipeline. I would find the root cause and enable the case again.
-
由 Shaoqi Bai 提交于
It tests heap table and index, temporary table and index created in user tablespace , still exist in pg_basebackup output.
-
由 Ning Yu 提交于
A replicated table has a full replica of the data on each segment, so the 'rows' in the EXPLAIN output should not be scaled. A partial table's 'rows' in the EXPLAIN output should be scaled with the numsegments of itself. We used to scale both of above cases with the cluster size in the EXPLAIN output, so the 'rows' were incorrectly displayed. It's only a bug in EXPLAIN output, the cost calculation of the plan is not affected.
-
由 Ning Yu 提交于
We used to make cost calculation with this property, it is equal to the segments count of the cluster, however this is wrong when the table is a partial one (this happens during gpexpand). We should always get numsegments from the motion. The gangsize.sql test is updated as in some of its queries the slices order is different than before due to change of the costs.
-
由 Jialun 提交于
This job is used to test online expand, it will create a cluster with two segments, then expand to 3 and run all ICW to check whether the cluster is OK after expansion. As restart is forbidden in online expand test, so we exclude all the case which contains restart opertaion. But if someone add a new test with restart, the job may fail. Manual intervention to exclude the test is needed. So we move this job to our own dev pipeline to reduce the impact on prod pipeline.
-
由 Ning Yu 提交于
Most of these FIXME were put in the code as reminders for us to revisit the decision policy on numsegments, during the development we have verified the policies or fixed the incorrect ones, now we just need to remove these FIXME or convert them to comments. Reviewed-by: NGeorgios Kokolatos <gkokolatos@pivotal.io>
-
由 David Yozie 提交于
-
由 David Yozie 提交于
* Adding gpload limitation notice for MPP-29682 * clarify double quotes * more double quotes
-
由 David Yozie 提交于
-
由 Chuck Litzell 提交于
- Refer to specific gpcheckcat output to fix catalog
-
由 David Yozie 提交于
* Updating location of diferent temp/spill files * Update follow-on description of temp files for sorting
-
由 David Yozie 提交于
* Squashed commit of the following: commit c5f4e38fa669b3daf4c5812b924ad8704e0bdcdc Author: dyozie <dyozie@pivotal.io> Date: Fri Mar 1 14:40:19 2019 -0800 SELECT - add LATERAL, NO KEY UPDATE, KEY SHARE, and related edits to locking clause commit b6bb9e9002491bff4ced8c619ee3f4f9fb8699f3 Author: dyozie <dyozie@pivotal.io> Date: Fri Mar 1 09:10:50 2019 -0800 TRUNCATE - add * option commit 363921783d794bb18b188e585163cd998b7a2f97 Author: David Yozie <dyozie@pivotal.io> Date: Thu Feb 28 16:56:50 2019 -0800 PREPARE - add note about search_path commit 4ec9f8879f90212c34602b7ccaf9ba93c0cfbe8f Author: David Yozie <dyozie@pivotal.io> Date: Thu Feb 28 16:50:32 2019 -0800 pg_dumpall - add -d, --dbname option commit 00c97fca7a4a8420e4a148249af2cafa937c21f8 Author: David Yozie <dyozie@pivotal.io> Date: Thu Feb 28 16:41:56 2019 -0800 add * syntax for descendant tables commit ab9bd0f96ca38639b4b1ebc97cc8f4009dc7cb91 Author: Lisa Owen <lowen@pivotal.io> Date: Thu Feb 28 09:45:22 2019 -0800 pg_dump - misc edits, additions, formatting commit 2de77b61903dbbd56f5011545bf23fa794e0a5b5 Author: Lisa Owen <lowen@pivotal.io> Date: Wed Feb 27 15:04:03 2019 -0800 psql - misc additions, edits, and reformats commit 43bbeed814c56037bbe9bed2bd0b778475264e1c Author: Lisa Owen <lowen@pivotal.io> Date: Wed Feb 27 10:49:00 2019 -0800 reindexdb - add -t option support for multiple tables; misc edits commit b9128c528c258d5c84457db12a2a43439a9bacef Author: Lisa Owen <lowen@pivotal.io> Date: Wed Feb 27 10:47:24 2019 -0800 vacuumdb - add -t option support for multiple tables * Squashed commit of the following: commit c8d0bd57acc1a038b2bbd0d9a6900762bf19498e Author: Chuck Litzell <litzellc@pivotal.io> Date: Fri Mar 1 15:33:35 2019 -0600 CREATE TABLE. Syntax changes. Add SET CONSTRAINTS command. commit a34ddfac6a5c6aea43b71f7445d6e8d82ab43592 Author: Chuck Litzell <litzellc@pivotal.io> Date: Fri Mar 1 16:00:51 2019 -0600 CREATE TABLE AS. Add WITH/WITHOUT OIDS commit dde4d614cf10a178b6e1b1dbc8d64608b171924f Author: Chuck Litzell <litzellc@pivotal.io> Date: Fri Mar 1 15:58:54 2019 -0600 bgworker. Add bgworker topic to reference guide commit 2749f2e735cc0b59e1153f04fe693e83a812bfc5 Author: Chuck Litzell <litzellc@pivotal.io> Date: Wed Feb 27 17:27:57 2019 -0600 CREATE SCHEMA. Add IF NOT EXISTS forms of command commit 581274c1d5b218443a9516c160c290aeb73e0999 Author: Chuck Litzell <litzellc@pivotal.io> Date: Wed Feb 27 16:43:40 2019 -0600 CREATE INDEX. Minor synopsis update. commit b83065abce53d0021eee01c1e8cdf0c7a53d60d4 Author: Chuck Litzell <litzellc@pivotal.io> Date: Wed Feb 27 16:13:19 2019 -0600 COPY. Add FREEZE option and edits. commit a0800bb10b581cccff97ef5193ef430b53061327 Author: Chuck Litzell <litzellc@pivotal.io> Date: Wed Feb 27 15:37:40 2019 -0600 ALTER RULE. Add new command and fix some conref issues commit dcf917189d601c1ef9d7c894ea016bd6139e29e8 Author: Chuck Litzell <litzellc@pivotal.io> Date: Wed Feb 27 14:58:58 2019 -0600 ALTER ROLE. Re-order syntax and descriptions. commit c5f4e38fa669b3daf4c5812b924ad8704e0bdcdc Author: dyozie <dyozie@pivotal.io> Date: Fri Mar 1 14:40:19 2019 -0800 SELECT - add LATERAL, NO KEY UPDATE, KEY SHARE, and related edits to locking clause commit b6bb9e9002491bff4ced8c619ee3f4f9fb8699f3 Author: dyozie <dyozie@pivotal.io> Date: Fri Mar 1 09:10:50 2019 -0800 TRUNCATE - add * option commit 363921783d794bb18b188e585163cd998b7a2f97 Author: David Yozie <dyozie@pivotal.io> Date: Thu Feb 28 16:56:50 2019 -0800 PREPARE - add note about search_path commit 4ec9f8879f90212c34602b7ccaf9ba93c0cfbe8f Author: David Yozie <dyozie@pivotal.io> Date: Thu Feb 28 16:50:32 2019 -0800 pg_dumpall - add -d, --dbname option commit 00c97fca7a4a8420e4a148249af2cafa937c21f8 Author: David Yozie <dyozie@pivotal.io> Date: Thu Feb 28 16:41:56 2019 -0800 add * syntax for descendant tables commit ab9bd0f96ca38639b4b1ebc97cc8f4009dc7cb91 Author: Lisa Owen <lowen@pivotal.io> Date: Thu Feb 28 09:45:22 2019 -0800 pg_dump - misc edits, additions, formatting commit 2de77b61903dbbd56f5011545bf23fa794e0a5b5 Author: Lisa Owen <lowen@pivotal.io> Date: Wed Feb 27 15:04:03 2019 -0800 psql - misc additions, edits, and reformats commit 43bbeed814c56037bbe9bed2bd0b778475264e1c Author: Lisa Owen <lowen@pivotal.io> Date: Wed Feb 27 10:49:00 2019 -0800 reindexdb - add -t option support for multiple tables; misc edits commit b9128c528c258d5c84457db12a2a43439a9bacef Author: Lisa Owen <lowen@pivotal.io> Date: Wed Feb 27 10:47:24 2019 -0800 vacuumdb - add -t option support for multiple tables * Changes from review * json-data. Edits, mostly already present in GPDB doc. * ALTER FOREIGN TABLE. ENABLE/DISABLE trigger forms. * ALTER INDEX. Add ALL IN TABLESPACE. * ALTER SYSTEM. new command * ALTER TABLE. ALL IN TABLESPACE, edits, MVCC warning. * ALTER TABLESPACE. minor changes only. * CREATE ROLE. Take out warning about older clients/MD5 * CREATE TABLE. multiple edits. * CREATE VIEW. Edits. Added RECURSIVE, but also added a Beta warning. * DISCARD. Add SEQUENCES; edits. * DROP OWNED. Minor edits. * GRANT. Add default privileges for object types. * psql. Many edits. * SELECT. Many edits. * gpbackup. typo fix. * TRUNCATE. Add note truncate is not mvcc-safe. * VACUUM. Restore description of example * Corrections from reviews * Add missing period.
-
- 14 3月, 2019 13 次提交
-
-
由 Jinbao Chen 提交于
-
由 Daniel Gustafsson 提交于
It's kilobytes, not kilo bytes.
-
由 Daniel Gustafsson 提交于
This removes a whole set of GUCs which are no longer used in the codebase. Also remove relevant documentation. Reviewed-by: NAshwin Agrawal <aagrawal@pivotal.io> Reviewed-by: NHeikki Linnakangas <hlinnakangas@pivotal.io> Reviewed-by: NGeorgios Kokolatos <gkokolatos@pivotal.io>
-
由 Daniel Gustafsson 提交于
As we merge with upstream and by that keep refining the Postgres planner, legacy planner is no longer a suitable name. This changes all variations of the spelling (legacy planner, legacy optimizer, legacy query optimizer etc) to say "Postgres" rather than "legacy". Reviewed-by: NVenkatesh Raghavan <vraghavan@pivotal.io> Reviewed-by: NDavid Yozie <dyozie@pivotal.io> Reviewed-by: NGeorgios Kokolatos <gkokolatos@pivotal.io>
-
由 Daniel Gustafsson 提交于
This just removes unused imports, variables and functions as well as cleans up a little bit of whitespace. No functional changes. Reviewed-by: NAdam Berlin <aberlin@pivotal.io> Reviewed-by: NShoaib Lari <slari@pivotal.io> Reviewed-by: NKalen Krempely <kkrempely@pivotal.io>
-
由 Heikki Linnakangas 提交于
* Avoid unnecessary start/end_ignore blocks * The test tables were supposed to be created in a dedicated schema, but because of the RESET ALL commands, they were created in 'public' schema instead. Fix by replacing "RESET ALL" with "RESET test_print_direct_dispatch_info" * Don't try to DROP tables that should not exist yet. * Don't bother DROPping test tables as we go. They will be dropped at the end, when we drop the whole schema. * Use fewer partitions in a test on partitioned table. * Use fewer rows in 'tblexecutions' test table. This reduces the execution time by about 20 s.
-
由 Heikki Linnakangas 提交于
-
由 Heikki Linnakangas 提交于
We had essentially the same test in 'partition' already.
-
由 Heikki Linnakangas 提交于
* Avoid using start/end_ignore blocks where not necessary. * Remove unnecessary DROP commands. * Use begin/commit when building test tables, to reduce 2PC overhead * Reuse test tables, rather than drop and recreate them Shaves a few seconds from the total execution time.
-
由 Heikki Linnakangas 提交于
Commit 90a957eb changed the test to create fewer partitions, but didn't update the NOTICEs in expected output accordingly. NOTICEs are ignored when comparing the expected output with actual output, but it's still nice to keep the expected output in sync with reality.
-
由 Shaoqi Bai 提交于
* Update relation's stats in pg_class during vacuum full. Hash index depends on estimation of numbers of tuples and pages of relations, incorrect value could be a reason of significantly growing of index. Vacuum full recreates heap and reindex all indexes before renewal stats. The patch fixes that, so indexes will see correct values. Backpatch to v10 only because earlier versions haven't usable hash index and growing of hash index is a single user-visible symptom. Author: Amit Kapila Reviewed-by: Ashutosh Sharma, me Discussion: https://www.postgresql.org/message-id/flat/20171115232922.5tomkxnw3iq6jsg7@inml.weebeastie.net * Collect QE's relpages and reltuples to QD And logic in swap_relation_files() to collect QE's relpages and reltuples to QD when doing vacuum full Co-authored-by: NJimmy Yih <jyih@pivotal.io> Co-authored-by: NAshwin Agrawal <aagrawal@pivotal.io> * Add test Add test to verify that relpages and reltuples has become proper numbers when vacuum full Co-authored-by: NTaylor Vesely <tvesely@pivotal.io> * Update PR pipeline failures Reviewed-by: NAdam Berlin <aberlin@pivotal.io> Reviewed-by: NAlexandra Wang <lewang@pivotal.io> Reviewed-by: NJimmy Yih <jyih@pivotal.io> Reviewed-by: NAshwin Agrawal <aagrawal@pivotal.io> Reviewed-by: NTaylor Vesely <tvesely@pivotal.io>
-
由 Jinbao Chen 提交于
this commit re-enable commit 1ec65820
-
由 Paul Guo 提交于
Reviewed-by Adam Berlin
-