- 03 5月, 2016 4 次提交
-
-
由 Heikki Linnakangas 提交于
ParallelizeCorrelatedSubPlanMutator() turns each Scan on a base relation into a "Result - Material - Broadcast - Scan" pattern, but it missed ExternalScans. External tables are supposed to be treated as distributed, i.e. each segment holds different part of the external table, so they need to be treated like regular tables.
-
由 Heikki Linnakangas 提交于
Long time ago, a hack was put in place in GPDB to use the "scan" slot, instead of the "outer" slot which is used in the upstream, to hold the result of an Agg or Window plan node's child. It's not clear to me why that was done. There was even a comment in fix_upper_expr() saying we wouldn't need it if we just fixed the executor to not contain that hack, and there was also a TODO comment in CMappingColIdVarPlStmt.cpp about that. Everything seems to work without those hacks, so revert this thing back to the way it works in the upstream. This is simpler in its own right, and also reduces our diff vs. upstream, which will make merging easier in the future.
-
由 Daniel Gustafsson 提交于
This was raised in #691 and was identified as a bug in upstream as well. The patch has now been committed to upstream, this is a backport with Greenplum versions of Flex/Perl maintained. See below for upstream commit message. commit 7d7b1292 Author: Tom Lane <tgl@sss.pgh.pa.us> Date: Mon May 2 11:18:10 2016 -0400 Fix configure's incorrect version tests for flex and perl. awk's equality-comparison operator is "==" not "=". We got this right in many places, but not in configure's checks for supported version numbers of flex and perl. It hadn't been noticed because unsupported versions are so old as to be basically extinct in the wild, and because the only consequence is whether or not a WARNING flies by during configure. Daniel Gustafsson noted the problem with respect to the test for flex, I found the other by reviewing other awk calls.
-
This closes #697
-
- 30 4月, 2016 3 次提交
-
-
This closes #682 Without GUC_GPDB_ADOPT, the values for guc is not going to be dispatched to the QE processes.
-
由 Marbin Tan 提交于
Specically persistent check: gp_persistent_relation_node <=> filesystem Authors: Marbin Tan & Larry Hamel
-
由 Marbin Tan 提交于
Batch size of 8 is too low and each cluster may have a different system configuration, so we would like to dertermine a default batch size before running gpcheckcat. * Add unittest for batch size * Truncate batch size to be, at maximum, the amount of primaries. Batch size can be no longer be larger than the amount of primaries. * Refactor: Create method main() for gpcheckcat In order improve unit testing, move functionality from '__main__' to a method. Authors: Marbin Tan, Larry Hamel, Nikhil Kak
-
- 29 4月, 2016 3 次提交
-
-
由 Kuien Liu 提交于
* Remove warning when compiling aosegfiles.c Use strlcpy instead of strncat to stop compiler complaining. The original case "strncat(segnumArray, tmp, sizeof(tmp))" is simple and safe, but the compiler complains much by law [-Wstrncat-size]. Changes to be committed: modified: src/backend/access/aocs/aocssegfiles.c modified: src/backend/access/appendonly/aosegfiles.c * speed up a bit by replacing strncat with strlcpy
-
由 Kuien Liu 提交于
Files changed: modified: src/backend/access/external/url.c modified: src/backend/cdb/cdbhash.c modified: src/backend/cdb/cdbmutate.c modified: src/pl/plpgsql/src/pl_funcs.c Skipped: catcoretable.c:104:26:CatCoreType_int4_array because it is an enumerated constant to ensure integrity
-
由 Chumki Roy 提交于
In a previous commit, f569c1d1, gpcheckcat was modified to display a list of tables with missing attributes. This commit adds the ability to list tables with extraneous attributes. Authors: Chumki Roy and James McAtamney
-
- 28 4月, 2016 1 次提交
-
-
由 Daniel Gustafsson 提交于
Fixed a typo in the --with-codegen-prefix description and corrected spelling in the CMake check error message. No functional changes.
-
- 27 4月, 2016 2 次提交
-
-
由 Shreedhar Hardikar 提交于
-
由 Shreedhar Hardikar 提交于
-
- 26 4月, 2016 2 次提交
-
-
由 Nikhil Kak 提交于
-
由 Daniel Gustafsson 提交于
-
- 25 4月, 2016 7 次提交
-
-
由 Heikki Linnakangas 提交于
atpxPartAddList() needs a CreateStmt that represents the parent table, but instead of creating it already in the parser, and adding more details to it in analyze.c, it's simpler to create it later, in atpxPartAddList(), where it's actually needed.
-
由 Heikki Linnakangas 提交于
The code in InitPostgres() was refactored in PostgreSQL 9.0 so that it no longer uses FindMyDatabaseByOid() function. We had backpatched the InitPostgres() changes already, so backpatch the removal of FindMyDatabaseByOid() as well. Silences a compiler warning.
-
由 Pengzhou Tang 提交于
In _SPI_execute_plan, debug_query_string was set directly to plan->query which is not memory context safe, it means debug_query_string have a chance to refer to a invalid address when FATAL/PANIC level error occurs.
-
由 Heikki Linnakangas 提交于
A common source of bugs has been that an object gets assigned a different OID in the master and in segments. A segment should normally never have to allocate an OID (for catalog objects) on its own, all OIDs should be allocated in the master, and sent over to the segments. To make such bugs easier to catch, add a WARNING if an OID is allocated in a segment. There were some DEBUG1 elogs for the same thing in place already, but the list of catalogs that need synchronized OIDS wasn't up-do-date, and this new place for the elog() is less invasive anyway.
-
由 Heikki Linnakangas 提交于
When I merged the operator family patch, I missed dispatching the new DDL commands to segments. Because of that, the segments didn't have information about operator families. Some operator families would be greated implicitly by CREATE OPERATOR CLASS, but you wouldn't necessarily get the same configuration of families and classes as in the master. Things worked pretty well despite that, because operator families and classes are used for planning, and planning happens in the master. Nevertheless, we really should have the operator family information in segments too, in case you run queries in maintenance mode directly on the segments, or if you execute functions in segments that need to execute expression that depend on them. Also, there were no regression tests for the new DDL commands.
-
由 Heikki Linnakangas 提交于
If you do CREATE OPERATOR, with a commutator or negator operator that doesn't exist yet, the system creates a "shell" entry for the non-existent operator. But those shell operators didn't get the same OID in all segments, which could lead to strange errors later. I couldn't find a test case demonstrating actual bugs from that, but it sure seems sketchy. Given that we take care to synchronize the OID of the primary created operator, surely we should do the same for all operators.
-
由 Heikki Linnakangas 提交于
The out/readfuncs.c support for AlterTableStmt.comptypeArrayOid was missing. Because of that, the segments didn't get the OID of the composite type's array type from master, and allocated it on their own.
-
- 23 4月, 2016 1 次提交
-
-
由 Marbin Tan 提交于
We were using "complex" as a user defined type, which is no longer the case once #605 was checked in.
-
- 22 4月, 2016 5 次提交
-
-
由 Pengzhou Tang 提交于
-
tuple. This closes #649 Squashed commit of the following: commit 96f415bc1744533e96a74bcc85016ff5df65d06e Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Thu Apr 21 15:08:49 2016 -0700 Don't call prepare for execution if no generator is registered commit 5318e9214a3bbc237c0d79017cdef02538c4e711 Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Thu Apr 21 11:35:22 2016 -0700 Adding if codegen protection in starting active manager and while deleting manager commit 12b0045d51a5b056b32a6cc9ef370e6d9af315fd Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Fri Apr 15 14:33:55 2016 -0700 Updating Readme for Codegen GPDB Function commit d17119c5d8ce9a706b3321d5e7ad41f419fddbdc Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Wed Apr 13 13:25:14 2016 -0700 Add documentation for how to codegen in README.md commit d711be4bb044592e7f97bf31ceb5f32337ad6d03 Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Wed Apr 13 11:19:03 2016 -0700 Fixing doxygen namespace addtogroup commit e34131bcc9bb3d36c5e8995e1a0efe11fbd55417 Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Wed Apr 13 11:17:32 2016 -0700 Changing CodeGen to Codegen commit bedfcca80b5f1ff796783ca7c2035d920ae86c4e Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Wed Apr 13 10:51:39 2016 -0700 Fix cpplint error commit 32f89feedba655e1242529c78a54faf01ddf32bf Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Wed Apr 13 10:48:49 2016 -0700 Change regular version of generated to regular version of target in comment commit d1da2824c08e34eb7139b08cd9d2aff19bf008e7 Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Wed Apr 13 10:42:09 2016 -0700 Made GetFunctionPointer and CreateFunction to take typedef of function type as only public api commit 9f48f77bd9fc50c7d29a4e8f7700452ef88dc79f Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Tue Apr 12 17:18:24 2016 -0700 Rename doCodegeneration to GenerateCodeInternal commit 9884d07f4c6ab08d9ccca8d07b80974081cda1fa Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Tue Apr 12 17:15:55 2016 -0700 fix cpplint error commit c21b3bee3e289675fc13017688269b40e26efa11 Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Tue Apr 12 17:08:16 2016 -0700 Update comments commit f016bb582af65e84def1b55917017008e292d45b Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Tue Apr 12 17:01:19 2016 -0700 Adding assert in static setToRegular function commit 93a791a4ec415313933dd5b7c1ae17dbdd6193a6 Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Tue Apr 12 16:49:15 2016 -0700 Removing decltype in Slotdeformtype codegen since we know the functype commit ed95193d0991cb24fd68f6d9a473de630f297b0c Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Tue Apr 12 16:45:49 2016 -0700 Fixed compiler / unit test failure Changed InitCodeGen to InitCodegen commit 3c95c9efdd4336e100a86748b0e87d79f07bcc11 Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Date: Tue Apr 12 16:28:24 2016 -0700 Changing CodeGen back to Codegen while cherry-picking commit 4e24ef22bcf54edc00c2a0d1f9f9703364cdf5ba Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Tue Apr 12 11:08:42 2016 -0700 Changing auto to actual type commit 1d92fc190dda3ec866edc83d56d9eca9fe90a63a Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Tue Apr 12 10:44:49 2016 -0700 fix indent in codegen_utils commit ea6fa787a2332f94b8d20d24825ba1f0a240d02e Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Mon Apr 11 17:25:53 2016 -0700 Adding codegen guc to wrapper function so related function not executed when codegen guc is disabled commit f1cd7d80d8d81f3565f3ab12cb94a3c4cc58c44a Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Mon Apr 11 17:13:24 2016 -0700 Changing bool to unsigned int in codegen_wrapper.h commit 7ef462540a312d077b332c732c125c55dedb6b14 Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Mon Apr 11 16:59:08 2016 -0700 Fix based on lint complain commit ddc55cec0d579a03cb9e2303efa6d74f5183979f Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Mon Apr 11 16:19:48 2016 -0700 Removing commented code from unittest commit 28b8886ed2bfdc854aa38f871a41536c1e6cef29 Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Mon Apr 11 16:17:45 2016 -0700 Chaging auto in for to actual type commit ad8d78e07e9b789f4d8ae3c6ccc3cea1a05089c0 Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Mon Apr 11 16:13:21 2016 -0700 * Handle return value of SetToGenerated from PrepareForExecution * Change size_t to unsigned integer commit d46ee8be414b3ac2a9ea7ef899f29cef3df145c7 Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Mon Apr 11 15:30:40 2016 -0700 Introducing template function to do enroll for any type of generator commit 83428605f906e28d0fc994dcc311e0cc3e6d9e12 Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Mon Apr 11 14:41:11 2016 -0700 Changing manager to take module name as argument commit b88aa40f89860e7c15503365ea304d2392f71cda Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Mon Apr 11 14:27:31 2016 -0700 adding more comments to SlotDeformTupleCodeGenInfo and unique counter commit df1b704548fcbc1b43524064eb2f024995eea865 Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Mon Apr 11 14:08:34 2016 -0700 Change test target to have ext .t and adding gitignore for that extension commit 9ee3521ca687c4ea7f13d15893f47146ecdb5277 Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Mon Apr 11 13:59:57 2016 -0700 Add target_include_directories for test library header file commit effb7dc165b4c7094731dc39e0872741b28b2e6a Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Mon Apr 11 13:36:50 2016 -0700 Move all possible ifdef from gpdb to codegen_wrapper based on pull request comments commit 989b96a91c1e843577b5f24623d1e4a6b810394c Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Fri Apr 8 10:43:17 2016 -0700 fixing comments for GetOrigFuncName in codegen_interface commit 665de065c34ea13abcec8c5f3a3336558dae501f Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Fri Apr 8 10:27:31 2016 -0700 Disabling codegen guc by default commit ec34513e86dea95bd36ee528724273c1c19e7062 Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Thu Apr 7 16:28:43 2016 -0700 Fixed comments space/tab so it aligned in different editor commit 35a60fe2fd053a5babd1820302afad95c5c2635f Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Thu Apr 7 16:12:08 2016 -0700 Fixing coding style based on cpplint commit 9477dcf6c0a7ffcca77b9f2c62c7340d13f474aa Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io> Date: Thu Apr 7 13:37:01 2016 -0700 Adding USE_CODEGEN ifdef commit 142ffc1416341a3ac1d0fe37a83577168f2ec166 Author: Shreedhar Hardikar <shardikar@pivotal.io> Date: Tue Apr 5 22:21:19 2016 +0000 Make codegen work with GPDB unit test framework commit 9dca9507dd933a5517bee3ca34615c09c23c1728 Author: Shreedhar Hardikar <shardikar@pivotal.io> Date: Mon Apr 4 22:10:21 2016 +0000 Add gpcodegen_mock.c commit 41d515ff0342d3df3b0853ad91731f6d1d75843c Author: Shreedhar Hardikar <shardikar@pivotal.io> Date: Mon Apr 4 21:46:34 2016 +0000 Remove unneccessary header file includes in codegen commit 14c5e14b9834197693b1ef56efa96386cfe049c5 Author: Foyzur Rahman <frahman@gmail.com> Date: Tue Apr 12 14:49:51 2016 -0700 Integrate codegen framework and make simple external call to slot deform tuple Signed-off-by: NKarthikeyan Jambu Rajaraman <karthi.jrk@gmail.com> Signed-off-by: NFoyzur Rahman <frahman@gmail.com>
-
-
由 George Caragea 提交于
Removed one test that was checking for a memory leak by attempting to run the system out of memory. Refactored one test that was checking for a large insert into a table with a bitmap index. Closes #660. [#116336737, #117671863]
-
由 Nikos Armenatzoglou 提交于
Commit 9d19664c ported a test from cdbfast to master, which uses gp_fault_inject mechanism to throw a SIGSEGV. We remove this test because i) gp_fault_inject works only if USE_TEST_UTILS = 1, while when we test GPDB, we set USE_TEST_UTILS to 0, and ii) throwing segmentation faults in ICG is a wrong approach.
-
- 21 4月, 2016 3 次提交
-
-
由 Daniel Gustafsson 提交于
Fixes compiler warning for implicit declaration due to missing headerfile include: copy.c:4143:6: warning: implicit declaration of function 'reconstructTupleValues' is invalid in C99 [-Wimplicit-function-declaration]
-
由 Haozhou Wang 提交于
Backport from upstream and related commits are commit e5fe2e84 Author: Tom Lane <tgl@sss.pgh.pa.us> Date: Fri Nov 9 23:58:32 2007 +0000 Recognize RETURN QUERY via a textual test, so that QUERY doesn't need to be a plpgsql keyword. This avoids springing a new reserved word on plpgsql programmers. For consistency, handle RETURN NEXT the same way. commit b2b9b4d5 Author: Neil Conway <neilc@samurai.com> Date: Wed Jul 25 04:19:09 2007 +0000 Implement RETURN QUERY for PL/PgSQL. This provides some convenient syntax sugar for PL/PgSQL set-returning functions that want to return the result of evaluating a query; it should also be more efficient than repeated RETURN NEXT statements. Based on an earlier patch from Pavel Stehule. Committers: Kuien Liu and Haozhou Wang
-
由 Venkatesh Raghavan 提交于
-
- 20 4月, 2016 3 次提交
-
-
由 Atri Sharma 提交于
-
`set optimizer_join_arity_for_associativity_commutativity=7` will hint at the optimizer to stop exploring join associativity and join commutativity transformations when an n-ary join operator has more than 7 children during optimization, pruning quite a bit of the search space.
-
- 19 4月, 2016 2 次提交
-
-
由 Daniel Gustafsson 提交于
-
由 Daniel Gustafsson 提交于
We really shouldn't get a sentinel node here but if we for some reason do we need/should handle it by erroring out rather than propagating the sentinel. Reviewed by vraghavan@
-
- 18 4月, 2016 2 次提交
-
-
由 Daniel Gustafsson 提交于
Commit 41dfd82b moved gpcheckcat from bin/lib to bin/ and installed a symlink to maintain backwards compatibility. However, installing and copying the symlink in the source tree makes Git complain that it's an untracked file. Rather than adding it to .gitignore we might as well do this in the installation directory since that's where we want to maintain backwards compatability anyways. Cleaned up a few comments around the installation as well while in there.
-
由 Abhijit Subramanya 提交于
The cursor test for external table is non deterministic. The query errors out either during DECLARE cursor or during FETCH. If the query errors out during DECLARE and we perform a FETCH after the DECLARE an extra line of error is produced in the output stating that the transaction has been aborted. In the case where FETCH errors out this error is not produced in the output. This commit adds a separate expected answer file to handle the two cases.
-
- 16 4月, 2016 2 次提交
-
-
由 Foyzur Rahman 提交于
CodegenUtils. This closes #648 Signed-off-by: NFoyzur Rahman <frahman@gmail.com>
-
由 Jimmy Yih 提交于
In gpconfigurenewsegment, the class ConfExpSegCmd inherits from the class Command. Command uses a variable of type ExecutionContext which was updated back in December 2011 to include passing the Command object itself to the execute(), interrupt(), and cancel() ExecutionContext methods. The author of that patch did not update the gpconfigurenewsegment.ConfExpSegCmd class which overrides those methods. It doesn't make sense to even override them in the first place so they should just be removed.
-