1. 09 4月, 2006 2 次提交
    • T
      Fix best_inner_indexscan to actually enforce that an "inner indexscan" use · 898eb254
      Tom Lane 提交于
      at least one join condition as an indexqual.  Before bitmap indexscans, this
      oversight didn't really cost much except for redundantly considering the
      same join paths twice; but as of 8.1 it could result in silly bitmap scans
      that would do the same BitmapOr twice and then BitmapAnd these together :-(
      898eb254
    • T
      Fix EXPLAIN so that it can drill down through multiple levels of subplan · c6e81aee
      Tom Lane 提交于
      when trying to locate the referent of a RECORD variable.  This fixes the
      'record type has not been registered' failure reported by Stefan
      Kaltenbrunner about a month ago.  A side effect of the way I chose to
      fix it is that most variable references in join conditions will now be
      properly labeled with the variable's source table name, instead of the
      not-too-helpful 'outer' or 'inner' we used to use.
      c6e81aee
  2. 08 4月, 2006 3 次提交
    • T
      Fix pg_dumpall to do something sane when a pre-8.1 installation has · 74bdf965
      Tom Lane 提交于
      identically named user and group: we merge these into a single entity
      with LOGIN permission.  Also, add ORDER BY commands to ensure consistent
      dump ordering, for ease of comparing outputs from different installations.
      74bdf965
    • A
      · 39ec43a2
      Andrew Dunstan 提交于
      Revert getaddrinfo configure changes until we get a solution that is
      properly tested on Tru64 - pre recent discussion (or lack thereof) on -hackers.
      39ec43a2
    • T
      Fix make_restrictinfo_from_bitmapqual() to preserve AND/OR flatness of its · 2f8a7bf2
      Tom Lane 提交于
      output, ie, no OR immediately below an OR.  Otherwise we get Asserts or
      wrong answers for cases such as
      	select * from tenk1 a, tenk1 b
      	where (a.ten = b.ten and (a.unique1 = 100 or a.unique1 = 101))
      	   or (a.hundred = b.hundred and a.unique1 = 42);
      Per report from Rafael Martinez Guerrero.
      2f8a7bf2
  3. 07 4月, 2006 2 次提交
  4. 06 4月, 2006 2 次提交
  5. 05 4月, 2006 4 次提交
    • P
      When merging PO files, take into consideration translations in other PO · 89a67e52
      Peter Eisentraut 提交于
      files of the same languages.  That way, similar or equal translations in
      different programs are automatically propagated and the life of translators
      becomes a little bit easier.
      89a67e52
    • T
      Add a field to the first page of each WAL file to indicate the · 09b5271e
      Tom Lane 提交于
      XLOG_BLCKSZ.  This ought to help in preventing configuration mismatch
      problems if anyone tries to ship PITR files between servers compiled
      with different XLOG_BLCKSZ settings.  Simon Riggs
      09b5271e
    • T
      Don't use BLCKSZ for the physical length of the pg_control file, but · e6140d90
      Tom Lane 提交于
      instead a dedicated symbol.  This probably makes no functional difference
      for likely values of BLCKSZ, but it makes the intent clearer.
      Simon Riggs, minor editorialization by Tom Lane.
      e6140d90
    • T
      Modify all callers of datatype input and receive functions so that if these · 147d4bf3
      Tom Lane 提交于
      functions are not strict, they will be called (passing a NULL first parameter)
      during any attempt to input a NULL value of their datatype.  Currently, all
      our input functions are strict and so this commit does not change any
      behavior.  However, this will make it possible to build domain input functions
      that centralize checking of domain constraints, thereby closing numerous holes
      in our domain support, as per previous discussion.
      
      While at it, I took the opportunity to introduce convenience functions
      InputFunctionCall, OutputFunctionCall, etc to use in code that calls I/O
      functions.  This eliminates a lot of grotty-looking casts, but the main
      motivation is to make it easier to grep for these places if we ever need
      to touch them again.
      147d4bf3
  6. 04 4月, 2006 3 次提交
  7. 03 4月, 2006 9 次提交
  8. 02 4月, 2006 4 次提交
  9. 01 4月, 2006 2 次提交
    • T
      Remove the 'slow' path for btree index build, which built the btree · 89bda95d
      Tom Lane 提交于
      incrementally by successive inserts rather than by sorting the data.
      We were only using the slow path during bootstrap, apparently because
      when first written it failed during bootstrap --- but it works fine now
      AFAICT.  Removing it saves a hundred or so lines of code and produces
      noticeably (~10%) smaller initial states of the system catalog indexes.
      While that won't make much difference for heavily-modified catalogs,
      for the more static ones there may be a useful long-term performance
      improvement.
      89bda95d
    • T
      Clean up WAL/buffer interactions as per my recent proposal. Get rid of the · a8b8f4db
      Tom Lane 提交于
      misleadingly-named WriteBuffer routine, and instead require routines that
      change buffer pages to call MarkBufferDirty (which does exactly what it says).
      We also require that they do so before calling XLogInsert; this takes care of
      the synchronization requirement documented in SyncOneBuffer.  Note that
      because bufmgr takes the buffer content lock (in shared mode) while writing
      out any buffer, it doesn't matter whether MarkBufferDirty is executed before
      the buffer content change is complete, so long as the content change is
      completed before releasing exclusive lock on the buffer.  So it's OK to set
      the dirtybit before we fill in the LSN.
      This eliminates the former kluge of needing to set the dirtybit in LockBuffer.
      Aside from making the code more transparent, we can also add some new
      debugging assertions, in particular that the caller of MarkBufferDirty must
      hold the buffer content lock, not merely a pin.
      a8b8f4db
  10. 31 3月, 2006 2 次提交
    • T
      Improve gist XLOG code to follow the coding rules needed to prevent · 89395bfa
      Tom Lane 提交于
      torn-page problems.  This introduces some issues of its own, mainly
      that there are now some critical sections of unreasonably broad scope,
      but it's a step forward anyway.  Further cleanup will require some
      code refactoring that I'd prefer to get Oleg and Teodor involved in.
      89395bfa
    • T
      Suppress attempts to report dropped tables to the stats collector from a · 4243f238
      Tom Lane 提交于
      startup or recovery process.  Since such a process isn't a real backend,
      pgstat.c gets confused.  This accounts for recent reports of strange
      "invalid server process ID -1" log messages during crash recovery.
      There isn't any point in attempting to make the report, since we'll discard
      stats in such scenarios anyhow.
      4243f238
  11. 30 3月, 2006 2 次提交
  12. 29 3月, 2006 3 次提交
  13. 25 3月, 2006 1 次提交
    • T
      Comments in IndexBuildHeapScan describe the indexing of recently-dead · 4e7d10c7
      Tom Lane 提交于
      tuples as needed "to keep VACUUM from complaining", but actually there is
      a more compelling reason to do it: failure to do so violates MVCC semantics.
      This is because a pre-existing serializable transaction might try to use
      the index after we finish (re)building it, and it might fail to find tuples
      it should be able to see.  We got this mostly right, but not in the case
      of partial indexes: the code mistakenly discarded recently-dead tuples for
      partial indexes.  Fix that, and adjust the comments.
      4e7d10c7
  14. 24 3月, 2006 1 次提交
    • T
      Arrange to emit a description of the current XLOG record as error context · 0a202070
      Tom Lane 提交于
      when an error occurs during xlog replay.  Also, replace the former risky
      'write into a fixed-size buffer with no overflow detection' API for XLOG
      record description routines; use an expansible StringInfo instead.  (The
      latter accounts for most of the patch bulk.)
      
      Qingqing Zhou
      0a202070