1.It's a known issue with gpperfmon that cpu skew and row skew information is inaccurate.
 We remove this flaky case for now.
2.GPDB6 rename table gp_distribution_policy colum attnum distkey.
Co-authored-by: NWenlin Zhang <wzhang@pivotal.io>
Co-authored-by: NBing Xu <bxu@pivotal.io>

GCC was generating compiler warnings about these for me:

gpmonlib.c: In function ‘gpmon_print’:
gpmonlib.c:124:5: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
     vfprintf(stdout, fmt, ap);
     ^~~~~~~~

That sems like a good idea, so I added 'printf' attributes to all those
logging functions.

That produced a bunch of new warnings, mainly for harmless mixups of %d,
%u, %ld, etc. But there were a few cases of mixing up %d and %s, too. Fix
the format strings to eliminate those warnings, too.

This reverts commit 4750e1b6.

This is the final batch of commits from PostgreSQL 9.2 development,
up to the point where the REL9_2_STABLE branch was created, and 9.3
development started on the PostgreSQL master branch.

Notable upstream changes:

* Index-only scan was included in the batch of upstream commits. It
  allows queries to retrieve data only from indexes, avoiding heap access.

* Group commit was added to work effectively under heavy load. Previously,
  batching of commits became ineffective as the write workload increased,
  because of internal lock contention.

* A new fast-path lock mechanism was added to reduce the overhead of
  taking and releasing certain types of locks which are taken and released
  very frequently but rarely conflict.

* The new "parameterized path" mechanism was added. It allows inner index
  scans to use values from relations that are more than one join level up
  from the scan. This can greatly improve performance in situations where
  semantic restrictions (such as outer joins) limit the allowed join orderings.

* SP-GiST (Space-Partitioned GiST) index access method was added to support
  unbalanced partitioned search structures. For suitable problems, SP-GiST can
  be faster than GiST in both index build time and search time.

* Checkpoints now are performed by a dedicated background process. Formerly
  the background writer did both dirty-page writing and checkpointing. Separating
  this into two processes allows each goal to be accomplished more predictably.

* Custom plan was supported for specific parameter values even when using
  prepared statements.

* API for FDW was improved to provide multiple access "paths" for their tables,
  allowing more flexibility in join planning.

* Security_barrier option was added for views to prevents optimizations that
  might allow view-protected data to be exposed to users.

* Range data type was added to store a lower and upper bound belonging to its
  base data type.

* CTAS (CREATE TABLE AS/SELECT INTO) is now treated as utility statement. The
  SELECT query is planned during the execution of the utility. To conform to
  this change, GPDB executes the utility statement only on QD and dispatches
  the plan of the SELECT query to QEs.
Co-authored-by: NAdam Lee <ali@pivotal.io>
Co-authored-by: NAlexandra Wang <lewang@pivotal.io>
Co-authored-by: NAshwin Agrawal <aagrawal@pivotal.io>
Co-authored-by: NAsim R P <apraveen@pivotal.io>
Co-authored-by: NDaniel Gustafsson <dgustafsson@pivotal.io>
Co-authored-by: NGang Xiong <gxiong@pivotal.io>
Co-authored-by: NHaozhou Wang <hawang@pivotal.io>
Co-authored-by: NHeikki Linnakangas <hlinnakangas@pivotal.io>
Co-authored-by: NJesse Zhang <sbjesse@gmail.com>
Co-authored-by: NJinbao Chen <jinchen@pivotal.io>
Co-authored-by: NJoao Pereira <jdealmeidapereira@pivotal.io>
Co-authored-by: NMelanie Plageman <mplageman@pivotal.io>
Co-authored-by: NPaul Guo <paulguo@gmail.com>
Co-authored-by: NRichard Guo <guofenglinux@gmail.com>
Co-authored-by: NShujie Zhang <shzhang@pivotal.io>
Co-authored-by: NTaylor Vesely <tvesely@pivotal.io>
Co-authored-by: NZhenghua Lyu <zlv@pivotal.io>

- use the new fact that datadirs are in the gp_segment_configuration
- fix a few things with the gpperfmon behave tests (mostly for macOS)
   --> the change to mgmt_utils.py is to do the config file manipulation
   natively in python
   --> the change to the gp_bash_functions.sh is to use ASCII '
   characters so that python string comparison is happier

Author: C.J. Jameson <cjameson@pivotal.io>

This removes code which is either unreachable due to prior identical
tests which break the codepath, or which is dead due to always being
true. Asserting that an unsigned integer is >= 0 will always be true,
so it's pointless.

Per "logically dead code" gripes by Coverity

gpperfmon drop partition sql statement was syntactically incorrect, so
partition_age gpperfmon feature was not working.

We were using the rows in partitionrangestart column from
pg_partition to drop specific partitions. The row value from
partitionrangestart is reported, as such, '2017-02-01 00:00:00'::timestamp(0) without time zone.
The query was reporting an error "Not a constant expression".

Use only the first part of partitionrangestart to make our ALTER DROP
query work.

- Added behave test to confirm that it is now working
Signed-off-by: NNadeem Ghani <nghani@pivotal.io>
Signed-off-by: NMarbin Tan <mtan@pivotal.io>
Signed-off-by: NC.J. Jameson <cjameson@pivotal.io>

gpmondb.c CID 160656: Resource leak in gpdb_check_partitions(). An early
return meant that the connection was not always closed. Hence, calculate
the return value, close the connection, then return.

gpmon_agg.c CID 160655: Resource leak in write_dbmetrics(). Files were
not being closed if dbmetrics were too long. Hence, fix the case where
early return means files don't get closed.

gpmondb.c CID 160654: Resource leak in gpdb_exec(). The pconn passed in
was not always getting a PGconn assigned to it. But returning a failed
connection and letting the caller of gpdb_exec clean it up is the usage
pattern. Hence, always make the conn available before returning.

gpmmon.c CID 160653: removed as part of remove_iterators work.

gpmon_agg.c CID 160652: duplicate of CID 160655
Signed-off-by: NLarry Hamel <lhamel@pivotal.io>
Signed-off-by: NC.J. Jameson <cjameson@pivotal.io>

- Remove iteration specific members of qexec packet
- Remove iterators_history table
- Remove measures used to populate iterators_history
- Remove iterator_aggregate flag
Signed-off-by: NNadeem Ghani <nghani@pivotal.io>
Signed-off-by: NMelanie Plageman <mplageman@pivotal.io>

Signed-off-by: NMarbin Tan <mtan@pivotal.io>

* gpperfmon: remove health history
* gpperfmon: remove code that pertains to DCA appliances
Signed-off-by: NC.J. Jameson <cjameson@pivotal.io>

Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

Signed-off-by: NMarbin Tan <mtan@pivotal.io>

Signed-off-by: NMarbin Tan <mtan@pivotal.io>

- add new configure option `--enable-gpperfmon`
- include gpperfmon libraries into configure
Signed-off-by: NLarry Hamel <lhamel@pivotal.io>
Signed-off-by: NChumki Roy <croy@pivotal.io>
Signed-off-by: NMelanie Plageman <mplageman@pivotal.io>
Signed-off-by: NLarry Hamel <lhamel@pivotal.io>
Signed-off-by: NC.J. Jameson <cjameson@pivotal.io>

Signed-off-by: NChumki Roy <croy@pivotal.io>

* gpperfmon alert log grows indefinitely in case of format issues

If there is a formatting issue in GPDB alert log, gppefmon would
constantly try to load the same errorneous data. It results in log
file growth beyond acceptable limits (gigabytes), which in turn
causes server OOM because loading process uses iconv on the whole
input file.
In case of broken entries we should just archive affected CSV file,
marking it as "broken" one, to avoid issue escalation

* Table definition for log_alert_now reads all the *.csv files from the logs directory, and broken files match this filter as well. Fixing by storing broken files without csv extension