Signed-off-by: NAdam Lee <ali@pivotal.io>

Added a link to a quickstart docker guide located on the Pivotal Engineering Journal.

ExprTreeGeneratorInfo object keeps track of metadata information
needed to generate code for expression trees.
Refactor ExprTreeGenerators to always use econtext->ecxt_scantuple to
generate the functions. We also have an extra slot_check block to fall
back if it is called with a different slot - which shouldn't happen for
Agg and Scan nodes.

Split ExecVariableListCodegen::GenerateExecVariableList into 2 parts,
one for managing the generation of ExecVariableList itself, and another
for of slot_getattr(). Also move the implementation of the code The
SlotGetAttr generator uses a static method called from both
ExecVariableList and ExecEvalExpr to generate appropriate
slot_getattr(). The actual generation is wrapped to handle the case when
the generation fails, since there is no infrastructure right now to
implement shared code generation classes that automatically clean up
created functions.

The code was assigning a (Datum) 0 to a void pointer.  That creates a
warning from clang 3.4.  It was probably a thinko to begin with.

Shifting a negative signed value is undefined behavior in C, instead
replace with the defined constant that was intended to reach with
the bitshift. It's not entirely clear to me *why* setting such a low
value is of interest given that further operations on it can overflow
to being positive but this keeps the current functionality with one
less compiler warning.

Normally the compiler can figure out when logical chains have inverted
truths like: if (foo) {} else if (!foo) {}. When there are more variables
involved this doesn't always work and we get compiler warnings for unset
variables which are indeed set. Remove and rewrite offending logic to be
clearer for the compiler and the human reader.

Dereferencing address zero is undefined behavior in C and the compiler
is free to optimize any such calls away (even though that is rare).
Ensure that any optimizations are avoided by declaring the variable
volatile and at the same time get rid of a clang compiler warning.

Remove a pointless redefinition of the prefixsel variable and move
the selec setting into under the else clause as it otherwise over-
writes the value we just calculated. This shortcircuited the GPDB
code and fell back on the default upstream behaviour so the effect
was nullified.

These variables are unitialized but will be set before used, clang
doesn't always figure this out though so give a helping hand and
set a value at initialization. The initalizations in Gin scanning
were later performed upstream in 87b8db37 as part of a larger body
of work.

Since the actual datatype used for an enum is implementation specific
per each compiler in both C90 and C99 we can't rely on it automatically
being an unsigned integer even though it most likely will be in this
case. Inverting the check and testing for it's negation will achieve
the range check that was intended without compiler warnings issued for
comparison of unsigned enum (-Wtautological-compare in clang). Adding
a comment explaining this both in the code and the headerfile.

Note that the existing coding was actually incorrect as it was testing
for the tabletype ranges with logical AND and not logical OR which
would've been correct, the severity of this bug must be considered
quite low though.

locale-dependent character classification properly when the database encoding
is UTF8.

The previous coding worked okay in single-byte encodings, or in any case for
ASCII characters, but failed entirely on multibyte characters.  The fix
assumes that the <wctype.h> functions use Unicode code points as the wchar
representation for Unicode, ie, wchar matches pg_wchar.

This is only a partial solution, since we're still stupid about non-ASCII
characters in multibyte encodings other than UTF8.  The practical effect
of that is limited, however, since those cases are generally Far Eastern
glyphs for which concepts like case-folding don't apply anyway.  Certainly
all or nearly all of the field reports of problems have been about UTF8.
A more general solution would require switching to the platform's wchar
representation for all regex operations; which is possible but would have
substantial disadvantages.  Let's try this and see if it's sufficient in
practice.

The BM_MAX_TUPLES_PER_PAGE macro will evaluate to the uint16 max so
asserting that an OffsetNumber is <= is always true given the typedef
on OffsetNumber from uint16.

This fixes -Wtautological-constant-out-of-range-compare warnings.

The @outarr array may at this point be empty and using subscript -1
to reach the last element will thus throw an uninitialized error.
Test for array contents before accessing any elements to avoid the
error and to exit early since the block by definition isn't of
interest. Observed in the wild for the bfv_partition test suite.

This is by no means all the offending lines in this file, but they
were the ones I had to read in order to figure out a bug. Remove
the worst offenders such as three-space indentation, commented out
code and and blocks at the wrong level. A larger cleanup is at some
point needed but piece by piece we are getting this code into shape.

Signed-off-by: NAdam Lee <ali@pivotal.io>

Make the error message more descriptive when cannot enlarge readRecordBuf.

When the workfile caching support was removed the number of columns
in the gp_workfile_mgr_cache_entries view was decreased to twelve.
Fix the array offsets to avoid writing past the end of the array as
they were accidentally left out in that commit.

Also move the assertion for view width to before the use of the
tupledesc's in question as it's more useful there than after we've
accessed what we're asserting.

The ALTER TABLE .. COALESCE PARTITION feature is while partially
implemented not supported. Removing all the scaffolding around the
parsing might as well be worthwhile but at least it seems reasonable
to kill the completely dead code in ATPExecPartCoalesce(). As this
was the only external caller of parruleord_open_gap() make the
function static.

Signed-off-by: NKuien Liu <kliu@pivotal.io>

Signed-off-by: NAdam Lee <ali@pivotal.io>

Signed-off-by: NAdam Lee <ali@pivotal.io>

Signed-off-by: NAdam Lee <ali@pivotal.io>
Signed-off-by: NHaozhou Wang <hawang@pivotal.io>

ATExecAlterColumnType.

misunderstanding, for following reasons:
(1) the performance improvement is little, it only works for some code
paths of ALTER TABLE ALTER COLUMN TYPE and CREATE UNIQUE/PRIMARY INDEX
(2) the feature is incomplete and buggy, especially the cache invalidation part

Signed-off-by: NKarthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>

Refactor gpcheckcat to modularize the repair code and add repair for the missing_extraneous module. (#873)

* refactor gpcheckcat to modularize the repair code and add repair for
missing_extraneous.
1. Moved all the generic repair code to its own module.
2. New module for missing_extraneous repair.
3. Make gpcheckcat do repairs per check instead of doing it after all
the checks have finished
4. Fix gpcheckcat so that it now creates a repair dir with -R option.
5. Unit and behave tests for the above mentioned modules.
6. Update gpcheckcat behave to use consistent db names
7. Behave tests for a few other checks like foreign_key, constraint_db,
part_integrity and also for the -g option

While fixing the typo, remove trailing whitespace from the comment
text as well as setting a postgres style comment header and put the
return value type on it's own line to match more of the style in
the file.