In the previous generation of analyze, gpdb provided features to merge
statistics such as MCVs (Most common values) and histograms for the root
or midlevel partitions from the leaf partition's statistics.

This commit imports the utility functions for merging MCVs and
histograms and modifies based on the needs of current version.
Signed-off-by: NBhunvesh Chaudhary <bchaudhary@pivotal.io>

The processed variable should not be reset while looping all partitions.

BeginCopy() returns a brand new CopyState but ignored the value of
skip_ext_partition, set after it.

It's a simple boolean of struct CopyStmt, no need to wrap in options.

1, pass external table encoding to copy's options, then set
cstate->file_encoding to it, for reading and writing.

2, after the merge, copy state doesn't have a member of client encoding,
which used to set to the target encoding, get the converted data as a
client, now passes the file encoding (from copy options) to convert
directly.

- Change strncpy to StrNCpy, make sure dest string be terminated
- Initilize some variables before use it.

Without this patch the strorage layout is not known in md and smgr layer. Due
to lack of this info sub-optimal operations need to be performed generically
for all table types. For example Heap specific functions like
ForgetRelationFsyncRequests(), DropRelFileNodeBuffers() gets called even for AO
and CO tables.

Adding new RelFileNodeWithStorageType struct to carry pass storage type to md
and smgr layer. XLOG_XACT_COMMIT and XLOG_XACT_ABORT wal records use the new
structure which has RelFileNode and storage type
Co-authored-by: NDavid Kimura <dkimura@pivotal.io>

Alter tablespace needs to copy all underlying files of table from one tablespace
to other. For AO/CO tables this was implemented using full directory scan to
find files and copy when persistent tables were removed. This gets very
inefficient and varies in performance based on number of files present in the
directory. Instead use the same optimization logic used for `mdunlink_ao()`
leveraging known file layout for AO/CO tables.

Also, old logic had couple of bugs:
- missed coping the base or .0 file. Which means data loss if table was altered in past.
- xlogging even for temp tables

These are fixed as well with this patch. Additional tests added to cover for
those missing scenaiors. Also, moved the AO specific code to aomd.c, out of
tablecmds.c file to reduce conflicts to upstream.

* Implement CPUSET, a new management of cpu resource in resource
group which can reserve the specified cores for specified
resource group exclusively. This can ensure that there are always
available cpu resources for the group which has set CPUSET.
The most common scenario is allocating fixed cores for short
queries.

- One can use it by executing CREATE RESOURCE GROUP xxx WITH (
  cpuset='0-1', xxxx). 0-1 are the reserved cpu cores for
  this group. Or ALTER RESOURCE GROUP SET CPUSET '0,1' to modify
  the value.
- The syntax of CPUSET is a combination of the tuples, each
  tuple represents one core number or the core numbers interval,
  separated by comma. E.g. 0,1,2-3. All the core in CPUSET must be
  available in system and the core numbers in each group cannot
  have overlap.
- CPUSET and CPU_RATE_LIMIT are mutually exclusive. One cannot
  create a resource group with both CPUSET and CPU_RATE_LIMIT.
  But the CPUSET and CPU_RATE_LIMIT can be freely switched in
  one group by executing ALTER operation, that means if one
  feature has been set, the other is disabled.
- The cpu cores will be returned to GPDB, when the group has been
  dropped, or the CPUSET value has been changed, or the CPU_RATE_LIMIT
  has been set.
- If some of the cores have been allocated to the resource group,
  then the CPU_RATE_LIMIT in other groups only indicating the
  percentage of cpu resources of the left cpu cores.
- If the GPDB is busy, all the other cores which have not be
  allocated to any resource groups exclusively through CPUSET
  have already been run out, the cpu cores in CPUSET will still
  not be allocated.
- The cpu cores in CPUSET will be used exclusively only in GPDB
  level, the other non-GPDB processes in system may use them.
- Add test cases for this new feature, and the test environment
  must contain at least two cpu cores, so we upgrade the configuration
  of instance_type in resource_group jobs.

* - Compatible with the case that cgroup directory cpuset/gpdb
  does not exist
- Implement pg_dump for cpuset & memory_auditor
- Fix a typo
- Change default cpuset value from empty string to -1, for
  the code in 5X assume that all the default value in
  resource group is integer, a non-integer value will make the
  system fail to start

In order to be able to set comments on resource queues, they must
be object addressable, so fix by implement object addressing. Also
add a small test for commenting on a resource queue.

* Remove redundant copy of toast and its index in ATExecSetTableSpace()

Commit f70f49fe introduced this double copy of
toast and its index. Lets fix it.

* Fix mismerged lines in src/interfaces/libpq/Makefile.

Author: Ashwin Agrawal <aagrawal@pivotal.io>

Unlike upstream, GPDB needs to keep collations in-sync between multiple
databases. Add tests for GPDB specific collation behavior.

These tests need to import a system locale, so add a @syslocale@ variable to
gpstringstubs.pl in order to test the creation/deletion of collations from
system locales.
Co-authored-by: NJim Doty <jdoty@pivotal.io>

Make CREATE COLLATION and pg_import_system_collations() parallel aware by
dispatching collation creation to the QEs.

In order for collations to work correctly, we need to be sure that every
collation that is created on the QD is also installed on the QEs, and that the
OID matches in every database. We will take advantage of two phase commit to
prevent collations from being created if there is a problem adding it on any
QE. In upstream, collations are created during initdb, but this won't work for
GPDB, because while initdb is running there is no way to be sure that every
segment has the same locales installed.

We disable collation creation during initdb, and make it the responsibility of
the system administrator to initialize any needed collations by either running
a CREATE COLLATION command, or running the pg_import_system_collations() UDF.
Co-authored-by: NJim Doty <jdoty@pivotal.io>

Pull in more recent version of pg_import_system_collations() from
upstream. We have not pulled in the ICU collations, so wholesale
remove the sections of code that deal with them.

This commit is primarily a cherry-pick of 0b13b2a7, but also pulls
in prerequisite changes for CollationCreate().

	Rethink behavior of pg_import_system_collations().

	Marco Atzeri reported that initdb would fail if "locale -a" reported
	the same locale name more than once.  All previous versions of Postgres
	implicitly de-duplicated the results of "locale -a", but the rewrite
	to move the collation import logic into C had lost that property.
	It had also lost the property that locale names matching built-in
	collation names were silently ignored.

	The simplest way to fix this is to make initdb run the function in
	if-not-exists mode, which means that there's no real use-case for
	non if-not-exists mode; we might as well just drop the boolean argument
	and simplify the function's definition to be "add any collations not
	already known".  This change also gets rid of some odd corner cases
	caused by the fact that aliases were added in if-not-exists mode even
	if the function argument said otherwise.

	While at it, adjust the behavior so that pg_import_system_collations()
	doesn't spew "collation foo already exists, skipping" messages during a
	re-run; that's completely unhelpful, especially since there are often
	hundreds of them.  And make it return a count of the number of collations
	it did add, which seems like it might be helpful.

	Also, re-integrate the previous coding's property that it would make a
	deterministic selection of which alias to use if there were conflicting
	possibilities.  This would only come into play if "locale -a" reports
	multiple equivalent locale names, say "de_DE.utf8" and "de_DE.UTF-8",
	but that hardly seems out of the question.

	In passing, fix incorrect behavior in pg_import_system_collations()'s
	ICU code path: it neglected CommandCounterIncrement, which would result
	in failures if ICU returns duplicate names, and it would try to create
	comments even if a new collation hadn't been created.

	Also, reorder operations in initdb so that the 'ucs_basic' collation
	is created before calling pg_import_system_collations() not after.
	This prevents a failure if "locale -a" were to report a locale named
	that.  There's no reason to think that that ever happens in the wild,
	but the old coding would have survived it, so let's be equally robust.

	Discussion: https://postgr.es/m/20c74bc3-d6ca-243d-1bbc-12f17fa4fe9a@gmail.com
	(cherry picked from commit 0b13b2a7)

Move this logic out of initdb into a user-callable function.  This
simplifies the code and makes it possible to update the standard
collations later on if additional operating system collations appear.
Reviewed-by: NAndres Freund <andres@anarazel.de>
Reviewed-by: NEuler Taveira <euler@timbira.com.br>
(cherry picked from commit aa17c06f)

* rpt: reorganize data when ALTER from/to replicated.

There was a bug that altering from/to a replicated table has no effect,
the root cause is that we did not change gp_distribution_policy neither
reorganize the data.

Now we perform the data reorganization by creating a temp table with the
new dist policy and transfering all the data to it.

* rpt: support RETURNING for replicated tables.

This is to support below syntax (suppose foo is a replicated table):

	INSERT INTO foo VALUES(1) RETURNING *;
	UPDATE foo SET c2=c2+1 RETURNING *;
	DELETE * FROM foo RETURNING *;

A new motion type EXPLICIT GATHER MOTION is introduced in EXPLAIN
output, data will be received from one explicit sender in this motion
type.

* rpt: fix motion type under explicit gather motion.

Consider below query:

	INSERT INTO foo SELECT f1+10, f2, f3+99 FROM foo
	  RETURNING *, f1+112 IN (SELECT q1 FROM int8_tbl) AS subplan;

We used to generate a plan like this:

	Explicit Gather Motion 3:1  (slice2; segments: 3)
	  ->  Insert
	        ->  Seq Scan on foo
	        SubPlan 1  (slice2; segments: 3)
	          ->  Gather Motion 3:1  (slice1; segments: 1)
	                ->  Seq Scan on int8_tbl

A gather motion is used for the subplan, which is wrong and will cause a
runtime error.

A correct plan is like below:

	Explicit Gather Motion 3:1  (slice2; segments: 3)
	  ->  Insert
	        ->  Seq Scan on foo
	        SubPlan 1  (slice2; segments: 3)
	          ->  Materialize
	                ->  Broadcast Motion 3:3  (slice1; segments: 3)
	                      ->  Seq Scan on int8_tbl

* rpt: add test case for with both PRIMARY and UNIQUE.

On a replicated table we could set both PRIMARY KEY and UNIQUE
constraints, test cases are added to ensure this feature during future
development.

(cherry picked from commit 72af4af8)

When altering a table's distribution policy we might need to reorganize
the data by creating a __temp__ table, copying the data to it, then swap
the underlying relation files.  However we always create the __temp__
table as permanent, then when the original table is temp the underlying
files can not be found in later queries.

	CREATE TEMP TABLE t1 (c1 int, c2 int) DISTRIBUTED BY (c1);
	ALTER TABLE t1 SET DISTRIBUTED BY (c2);
	SELECT * FROM t1;

This reverts commit 72af4af8.

* rpt: reorganize data when ALTER from/to replicated.

There was a bug that altering from/to a replicated table has no effect,
the root cause is that we did not change gp_distribution_policy neither
reorganize the data.

Now we perform the data reorganization by creating a temp table with the
new dist policy and transfering all the data to it.


* rpt: support RETURNING for replicated tables.

This is to support below syntax (suppose foo is a replicated table):

	INSERT INTO foo VALUES(1) RETURNING *;
	UPDATE foo SET c2=c2+1 RETURNING *;
	DELETE * FROM foo RETURNING *;

A new motion type EXPLICIT GATHER MOTION is introduced in EXPLAIN
output, data will be received from one explicit sender in this motion
type.


* rpt: fix motion type under explicit gather motion.

Consider below query:

	INSERT INTO foo SELECT f1+10, f2, f3+99 FROM foo
	  RETURNING *, f1+112 IN (SELECT q1 FROM int8_tbl) AS subplan;

We used to generate a plan like this:

	Explicit Gather Motion 3:1  (slice2; segments: 3)
	  ->  Insert
	        ->  Seq Scan on foo
	        SubPlan 1  (slice2; segments: 3)
	          ->  Gather Motion 3:1  (slice1; segments: 1)
	                ->  Seq Scan on int8_tbl

A gather motion is used for the subplan, which is wrong and will cause a
runtime error.

A correct plan is like below:

	Explicit Gather Motion 3:1  (slice2; segments: 3)
	  ->  Insert
	        ->  Seq Scan on foo
	        SubPlan 1  (slice2; segments: 3)
	          ->  Materialize
	                ->  Broadcast Motion 3:3  (slice1; segments: 3)
	                      ->  Seq Scan on int8_tbl


* rpt: add test case for with both PRIMARY and UNIQUE.

On a replicated table we could set both PRIMARY KEY and UNIQUE
constraints, test cases are added to ensure this feature during future
development.

The Postgres 9.1 merge introduced a problem where issuing a COPY FROM
to a partition table could result in an unexpected error, "ERROR:
extra data after last expected column", even though the input file was
correct. This would happen if the partition table had partitions where
the relnatts were not all the same (e.g. ALTER TABLE DROP COLUMN,
ALTER TABLE ADD COLUMN, and then ALTER TABLE EXCHANGE PARTITION). The
internal COPY logic would always use the COPY state's relation, the
partition root, instead of the actual partition's relation to obtain
the relnatts value. In fact, the only reason this is intermittently
seen is because the COPY logic, when working on the leaf partition's
relation that has a different relnatts value, was looking beyond a
boolean array's allocated memory and got a phony value that would
evaluate to TRUE.
Co-authored-by: NJimmy Yih <jyih@pivotal.io>
Co-authored-by: NAshwin Agrawal <aagrawal@pivotal.io>

To verify that autovacuum actually freezes template0, we used to just
busy wait for about two minutes, expecting to observe the change of
pg_database.datfrozenxid. While this "usually works", it's too sensitive
to the amount of time it takes to vacuum freeze template0. Specifically,
in some of our very I/O-deprived environments, this process sometimes
takes slightly longer than two minutes.

This patch introduces a fault injector to help us observe the expected
vacuuming. The wait-in-a-loop is still there, but the bulk of the
uncertain timing is now before the loop, not during the loop.
Co-authored-by: NJesse Zhang <sbjesse@gmail.com>
Co-authored-by: NJimmy Yih <jyih@pivotal.io>

Many places is code need to check if its row or column oriented storage table,
which means basically is it AppendOptimized table or not. Currently its done by
combination of two macros RelationIsAoRows() and RelationIsAoCols(). Simplify
the same with new macro RelationIsAppendOptimized().

Integer overflow occurs without this when copied more than 2^31 rows,
under the `COPY ON SEGMENT` mode.

Errors happen when it is casted to uint64, the type of `processed` in
`CopyStateData`, third-party Postgres driver, which takes it as an
int64, fails out of range.

Consider the following SQL, we expect logging to be turned off for table
`ext_error_logging_off`

```sql
create external table ext_error_logging_off (a int, b int)
    location ('file:///tmp/test.txt') format 'text'
    segment reject limit 100;
\d+ ext_error_logging_off
```
And then in this next case we expect error logging to be turned on for
table `ext_t2`:

```sql
create external table ext_t2 (a int, b int)
    location ('file:///tmp/test.txt') format 'text'
    log errors segment reject limit 100;
\d+ ext_t2
```

Before this patch, we are making two mistakes in handling these external
table DDL:

1. We intend to enable error logging *whenever* the user specifies
`SEGMENT REJECT` clause, completely ignoring whether he or she specifies
`LOG ERRORS` 1. Even then, we make the mistake of implicitly coercing
the OID (an unsigned 32-bit integer) to a bool (which is really just a C
`char`): that means, 255/256 of the time (99.6%) the result is `true`,
and 0.4% of the time we get a `false` instead.

The `OID` to `bool` implicit conversion could have been caught by a
`-Wconversion` GCC/Clang flag. It's most likely a leftover from commit
8f6fe2d6.

This bug manifests itself in the `dsp` regression test mysteriously
failing about once every 200 runs -- with the only diff on a `\d+` of an
external table that should have error logging turned on, but the
returned definition has it turned off.

While working on this we discovered that all of our existing external
tables have both `LOG ERRORS` and `SEGMENT REJECT`, which is why this
bug wasn't caught in the first place.

This patch fixes the issue by properly setting the catalog column
`pg_exttable.logerrors` according to the user input.

While we were at it, we also cleaned up a few dead pieces of code and
made the `dsp` test a bit friendlier to debug.
Co-authored-by: NJesse Zhang <sbjesse@gmail.com>
Co-authored-by: NDavid Kimura <dkimura@pivotal.io>

Code had these two variables (GUCs), serving same purpose. GpIdentity.segindex
is set to content-id, based on command line argument at start-up and inherited
by all processes from postmaster. Whereas Gp_segment, was session level guc only
set for backends, by dispatching the same from QD. So. essentially Gp_segment
was not available and had incorrect value in auxiliary processes.

Hence replaced all usages with GpIdentity.segindex. As a side effect log files
now have correct value reported for segment number (content-id) in each and
every line of file, irrespective of which process generated the log message.

Discussion:
https://groups.google.com/a/greenplum.org/forum/#!msg/gpdb-dev/Yr8-LZIiNfA/ob4KLgmkAQAJ

We used to implement the memory auditor feature differently on master
and 5X, on master the attribute is stored in pg_resgroup while on 5X
it's stored in pg_resgroupcapability.  This increases the maintenance
effort significantly.  So we refactor this feature on master to minimize
the difference between these two branches.

- Revert "resgroup: fix an access to uninitialized address."
  This reverts commit 56c20709.
- Revert "ic: Mark binary_swap_gpdb as optional input for resgroup jobs."
  This reverts commit 9b3d0cfc.
- Revert "resgroup: fix a boot failure when cgroup is not mounted."
  This reverts commit 4c8f28b0.
- Revert "resgroup: backward compatibility for memory auditor"
  This reverts commit f2f86174.
- Revert "Show memory statistics for cgroup audited resource group."
  This reverts commit d5fb628f.
- Revert "Fix resource group test failure."
  This reverts commit 78b885ec.
- Revert "Support cgroup memory auditor for resource group."
  This reverts commit 6b3d0f66.
- Apply "resgroup: backward compatibility for memory auditor"
  This cherry picks commit 23cd8b1e
- Apply "ic: Mark binary_swap_gpdb as optional input for resgroup jobs."
  This Cherry picks commit c86652e6
- Apply "resgroup: fix an access to uninitialized address."
  This Cherry picks commit b257b344

Upstream commit cab9a065 introduced an optimization to truncate tables
in scenarios that permit "unsafe" operations where we don't have to
churn on the relfilenode for the underlying tables. AO table got a free
ride but for the wrong reason.

This patch teaches heap_truncate_one_rel() to perform the unsafe /
optimal truncation on AO tables. This allows us to converge the callers
back to how they look like in Postgres 9.0.

Specifically, we're now able to inline TruncateRelfiles() back into
ExecuteTruncate() .

One caveat introduced by this patch though, is the "optimal" / unsafe
truncation of an AO table can potentially leak some disk space: we are
not performing a real file-level truncate, merely seeking back to offset
0 -- because the aoseg auxiliary table is truncated -- on the next
write, therefore the space after the EOF mark is wasted in some sense.
Co-authored-by: NJesse Zhang <sbjesse@gmail.com>

ExecBRInsertTriggers() uses the per tuple memory context, which might be
reset and pfree() SEGV.

In 3be31490 we changed max spill_ratio
to INT_MAX, but it will not take effect until more related logic is
accordingly changed.

Before we have all the work done we will change the max spill_ratio back
to 100.

User query can use global shared memory across resource group when available(Same as the PR 4843, just made the test cases stable) (#4866)

1) Global shared memory will be used if the query has run out of
	the group shared memory.
2) The limit of memory_spill_ratio changes to [0, INT_MAX], because
	global shared memory can be allocated, 100% limitation is not
	make sense.
3) Using Atomic Operation & "Compare And Save" instead of lock to
	get high performance.
4) Modify the test cases according to the new rules.

Memory auditor was a new feature introduced to allow external components
(e.g. pl/container) managed by resource group.  This feature requires a
new gpdb dir to be created in cgroup memory controller, however on 5X
branch unless the users created this new dir manually then the upgrade
from a previous version would fail.

In this commit we provide backward compatibility by checking the release
version:

- on 6X and master branches the memory auditor feature is always enabled
  so the new gpdb dir is mandatory;
- on 5X branch only if the new gpdb dir is created with proper
  permissions the memory auditor feature could be enabled, when it's
  disabled `CREATE RESOURCE GROUP WITH (memory_auditor='cgroup') will fail
  with guide information on how to enable it;

Binary swap tests are also provided to verify backward compatibility in
future releases.  As cgroup need to be configured to enable resgroup we
split the resgroup binary swap tests into two parts:

- resqueue mode only tests which can be triggered in the
  icw_gporca_centos6 pipeline job after the ICW tests, these parts have
  no requirements on cgroup;
- complete resqueue & resgroup modes tests which can be triggered in the
  mpp_resource_group_centos{6,7} pipeline jobs after the resgroup tests,
  these parts need cgroup to be properly configured;

Revert "User query can use global shared memory across resource group when available(#4843)" (#4862)

This reverts commit a5b3831d.

1) Global shared memory will be used if the query has run out of
	the group shared memory.
2) The limit of memory_spill_ratio changes to [0, INT_MAX], because
	global shared memory can be allocated, 100% limitation is not
	make sense.
3) Using Atomic Operation & "Compare And Save" instead of lock to
	get high performance.
4) Modify the test cases according to the new rules.

The patch 62aba765 from upstream fixed
the CVE-2009-4136 (security vulnerability) with the intent to properly
manage session-local state during execution of an index function by a
database superuser, which in some cases allowed remote authenticated
users to gain privileges via a table with crafted index functions.

Looking into the details of the CVE-2009-4136 and related CVE-2007-6600,
the patch should ideally have limited the scope while we calculate the
stats on the index expressions, where we run functions to evaluate the
expression and could potentially present a security threat.

However, the patch changed the user to table owner before collecting the
sample, due to which even if analyze was run by superuser the sample
couldn't be collected as the table owner did not had sufficient
privileges to access the table. With this commit, we switch back to the
original user while collecting the sample as it does not deal with
indexes, or function call which was the original intention of the patch.

Upstream did not face the privilege issue, as it does block sampling
instead of issuing a query.
Signed-off-by: NSambitesh Dash <sdash@pivotal.io>

For pg_upgrade, gpdb runs in GP_ROLE_UTILITY mode and with IsBinaryUpgrade set as true.
In this patch we allow some partition related code run if IsBinaryUpgrade is true so that
those partition related sql clauses, which are generated by pgdump, could recover
previous partition schemas.
Co-authored-by: NMax Yang <myang@pivotal.io>

This is a backport of the below commit from upstream 9.3:

  commit 16d8e594
  Author: Magnus Hagander <magnus@hagander.net>
  Date:   Wed Dec 7 10:35:00 2011 +0100

    Remove spclocation field from pg_tablespace

    Instead, add a function pg_tablespace_location(oid) used to return
    the same information, and do this by reading the symbolic link.

    Doing it this way makes it possible to relocate a tablespace when the
    database is down by simply changing the symbolic link.