1. 07 10月, 2012 3 次提交
  2. 06 10月, 2012 1 次提交
    • P
      Improve LDAP authentication documentation · ae835c7d
      Peter Eisentraut 提交于
      Use the terms "simple bind" and "search+bind" consistently do
      distinguish the two modes (better than first mode and second mode in
      any case).  They were already used in some places, now it's just more
      prominent.
      
      Split up the list of options into one for common options and one for
      each mode, for clarity.
      
      Add configuration examples for either mode.
      ae835c7d
  3. 05 10月, 2012 9 次提交
    • M
      Removed sentence about not being able to retrieve more than one row at a time, · 1045af95
      Michael Meskes 提交于
      because it is not correct.
      1045af95
    • M
      Fixed test for array boundary. · 6e41fa2e
      Michael Meskes 提交于
      Instead of continuing if the next character is not an array boundary get_data()
      used to continue only on finding a boundary so it was not able to read any
      element after the first.
      6e41fa2e
    • H
      Use the regular main processing loop also in walsenders. · fd5942c1
      Heikki Linnakangas 提交于
      The regular backend's main loop handles signal handling and error recovery
      better than the current WAL sender command loop does. For example, if the
      client hangs and a SIGTERM is received before starting streaming, the
      walsender will now terminate immediately, rather than hang until the
      connection times out.
      fd5942c1
    • T
      getnameinfo_unix has to be taught not to insist on NI_NUMERIC flags, too. · 1997f34d
      Tom Lane 提交于
      Per testing of previous patch.
      1997f34d
    • P
      PL/pgSQL: rename gram.y to pl_gram.y · 05346c13
      Peter Eisentraut 提交于
      This makes the naming inside plpgsql consistent and distinguishes the
      file from the backend's gram.y file.  It will also allow easier
      refactoring of the bison make rules later on.
      05346c13
    • P
      Remove redundant code for getnameinfo() replacement · c424d0d1
      Peter Eisentraut 提交于
      Our getnameinfo() replacement implementation in getaddrinfo.c failed
      unless NI_NUMERICHOST and NI_NUMERICSERV were given as flags, because
      it doesn't resolve host names, only numeric IPs.  But per standard,
      when those flags are not given, an implementation can still degrade to
      not returning host names, so this restriction is unnecessary.  When we
      remove it, we can eliminate some code in postmaster.c that apparently
      tried to work around that.
      c424d0d1
    • T
      Make CREATE AGGREGATE complain if the initcond is invalid for the datatype. · e1e60694
      Tom Lane 提交于
      The initial transition value is stored as a text string and not fed to the
      transition type's input function until runtime (so that values such as
      "now" don't get frozen at creation time).  Previously, CREATE AGGREGATE
      didn't do anything with it but that, which meant that even erroneous values
      would be accepted and not complained of until the aggregate is used.  This
      seems unhelpful, and it's confused at least one user, as in Rhys Stewart's
      recent report.  It seems worth taking a few more cycles to invoke the input
      function and verify that the value is acceptable.  We can't do this if the
      transition type is polymorphic, but in normal aggregates we know the actual
      transition type so we can call the right input function.
      e1e60694
    • T
      Fix parse location tracking for lists that can be empty. · 70726354
      Tom Lane 提交于
      The previous coding of the YYLLOC_DEFAULT macro behaved strangely for empty
      productions, assigning the previous nonterminal's location as the parse
      location of the result.  The usefulness of that was (at best) debatable
      already, but the real problem is that in list-generating nonterminals like
      	OptFooList: /* EMPTY */ { ... } | OptFooList Foo { ... } ;
      the initially-identified location would get copied up, so that even a
      nonempty list would be given a bogus parse location.  Document how to work
      around that, and do so for OptSchemaEltList, so that the error condition
      just added for CREATE SCHEMA IF NOT EXISTS produces a sane error cursor.
      So far as I can tell, there are currently no other cases where the
      situation arises, so we don't need other instances of this coding yet.
      70726354
    • T
      Fix permissions explanations in CREATE DATABASE and CREATE SCHEMA docs. · 7e389f73
      Tom Lane 提交于
      These reference pages still claimed that you have to be superuser to create
      a database or schema owned by a different role.  That was true before 8.1,
      but it was changed in commits aa111062 and
      f91370cd to allow assignment of ownership
      to any role you are a member of.  However, at the time we were thinking of
      that primarily as a change to the ALTER OWNER rules, so the need to touch
      these two CREATE ref pages got missed.
      7e389f73
  4. 04 10月, 2012 4 次提交
    • H
    • T
      Support CREATE SCHEMA IF NOT EXISTS. · fb34e94d
      Tom Lane 提交于
      Per discussion, schema-element subcommands are not allowed together with
      this option, since it's not very obvious what should happen to the element
      objects.
      
      Fabrízio de Royes Mello
      fb34e94d
    • A
      refactor ALTER some-obj SET OWNER implementation · 994c36e0
      Alvaro Herrera 提交于
      Remove duplicate implementation of catalog munging and miscellaneous
      privilege and consistency checks.  Instead rely on already existing data
      in objectaddress.c to do the work.
      
      Author: KaiGai Kohei
      Tweaked by me
      Reviewed by Robert Haas
      994c36e0
    • T
      Avoid planner crash/Assert failure with joins to unflattened subqueries. · 1f91c8ca
      Tom Lane 提交于
      examine_simple_variable supposed that any RTE_SUBQUERY rel it gets pointed
      at must have been planned already.  However, this isn't a safe assumption
      because we must do selectivity estimation while generating indexscan paths,
      and that code might look at join clauses involving a rel that the loop in
      set_base_rel_sizes() hasn't reached yet.  The simplest fix is to play dumb
      in such a situation, that is give up trying to extract any stats for the
      Var.  This could possibly be improved by making a separate pass over the
      RTE list to plan each unflattened subquery before we start the main
      planning work --- but that would be pretty invasive and it doesn't seem
      worth it, for now at least.  (We couldn't just break set_base_rel_sizes()
      into two loops: the prescan would need to handle all subquery rels in the
      query, not only those in the current join subproblem.)
      
      This bug was introduced in commit 1cb108ef,
      although I think that subsequent changes may have exposed it more than it
      was originally.  Per bug #7580 from Maxim Boguk.
      1f91c8ca
  5. 03 10月, 2012 10 次提交
    • A
      REASSIGN OWNED: consider grants on tablespaces, too · fe3b5eb0
      Alvaro Herrera 提交于
      Apparently this was considered in the original code (see commit
      cec3b0a9) but I failed to notice that such entries would always be
      skipped by the database check at the start of the loop.
      
      Per bugs #7578 by Nikolay, #6116 by tushar.qa@gmail.com.
      fe3b5eb0
    • H
      Add --sampling-rate option to pgbench. · e1be1df5
      Heikki Linnakangas 提交于
      This allows logging only some fraction of transactions, greatly reducing
      the amount of log generated.
      
      Tomas Vondra, reviewed by Robert Haas and Jeff Janes.
      e1be1df5
    • H
      Return the number of rows processed when COPY is executed through SPI. · 7ae18159
      Heikki Linnakangas 提交于
      You can now get the number of rows processed by a COPY statement in a
      PL/pgSQL function with "GET DIAGNOSTICS x = ROW_COUNT".
      
      Pavel Stehule, reviewed by Amit Kapila, with some editing by me.
      7ae18159
    • H
      Fix two bugs introduced in the xlog.c split. · bc1229c8
      Heikki Linnakangas 提交于
      The comment explaining the naming of timeline history files was wrong, and
      the history file was not being arhived.
      
      Pointed out by Fujii Masao.
      bc1229c8
    • P
      Improve some LDAP authentication error messages · 6bd17609
      Peter Eisentraut 提交于
      6bd17609
    • B
      In pg_upgrade, use full path name for analyze_new_cluster.sh script. · ce754579
      Bruce Momjian 提交于
      Backpatch to 9.2.
      ce754579
    • T
      Work around unportable behavior of malloc(0) and realloc(NULL, 0). · 09ac603c
      Tom Lane 提交于
      On some platforms these functions return NULL, rather than the more common
      practice of returning a pointer to a zero-sized block of memory.  Hack our
      various wrapper functions to hide the difference by substituting a size
      request of 1.  This is probably not so important for the callers, who
      should never touch the block anyway if they asked for size 0 --- but it's
      important for the wrapper functions themselves, which mistakenly treated
      the NULL result as an out-of-memory failure.  This broke at least pg_dump
      for the case of no user-defined aggregates, as per report from
      Matthew Carrington.
      
      Back-patch to 9.2 to fix the pg_dump issue.  Given the lack of previous
      complaints, it seems likely that there is no live bug in previous releases,
      even though some of these functions were in place before that.
      09ac603c
    • A
      Refactor "ALTER some-obj SET SCHEMA" implementation · 2164f9a1
      Alvaro Herrera 提交于
      Instead of having each object type implement the catalog munging
      independently, centralize knowledge about how to do it and expand the
      existing table in objectaddress.c with enough data about each object
      type to support this operation.
      
      Author: KaiGai Kohei
      Tweaks by me
      Reviewed by Robert Haas
      2164f9a1
    • T
      Standardize naming of malloc/realloc/strdup wrapper functions. · a563d941
      Tom Lane 提交于
      We had a number of variants on the theme of "malloc or die", with the
      majority named like "pg_malloc", but by no means all.  Standardize on the
      names pg_malloc, pg_malloc0, pg_realloc, pg_strdup.  Get rid of pg_calloc
      entirely in favor of using pg_malloc0.
      
      This is an essentially cosmetic change, so no back-patch.  (I did find
      a couple of places where psql and pg_dump were using plain malloc or
      strdup instead of the pg_ versions, but they don't look significant
      enough to bother back-patching.)
      a563d941
    • H
      Fix typo in previous warning-silencing patch. · 779f80b7
      Heikki Linnakangas 提交于
      Fujii Masao
      779f80b7
  6. 02 10月, 2012 8 次提交
  7. 01 10月, 2012 5 次提交
    • B
      Add C comment that IsBackendPid() is called by external modules, so we · dbdb2172
      Bruce Momjian 提交于
      don't accidentally remove it.
      dbdb2172
    • A
      Remove collations from generic ALTER test · ece26987
      Alvaro Herrera 提交于
      The error messages they generate are not portable enough.
      
      Also, since the only point of the alter_generic_1 expected file was to
      cover platforms with no collation support, it's now useless, so remove
      it.
      ece26987
    • H
      2ad881f0
    • T
      Provide some static-assertion functionality on all compilers. · 0d0aa5d2
      Tom Lane 提交于
      On reflection (especially after noticing how many buildfarm critters have
      __builtin_types_compatible_p but not _Static_assert), it seems like we
      ought to try a bit harder to make these macros do something everywhere.
      The initial cut at it would have been no help to code that is compiled only
      on platforms without _Static_assert, for instance; and in any case not all
      our contributors do their initial coding on the latest gcc version.
      
      Some googling about static assertions turns up quite a bit of prior art
      for making it work in compilers that lack _Static_assert.  The method
      that seems closest to our needs involves defining a struct with a bit-field
      that has negative width if the assertion condition fails.  There seems no
      reliable way to get the error message string to be output, but throwing a
      compile error with a confusing message is better than missing the problem
      altogether.
      
      In the same spirit, if we don't have __builtin_types_compatible_p we can at
      least insist that the variable have the same width as the type.  This won't
      catch errors such as "wrong pointer type", but it's far better than
      nothing.
      
      In addition to changing the macro definitions, adjust a
      compile-time-constant Assert in contrib/hstore to use StaticAssertStmt,
      so we can get some buildfarm coverage on whether that macro behaves sanely
      or not.  There's surely more places that could be converted, but this is
      the first one I came across.
      0d0aa5d2
    • T
      Add infrastructure for compile-time assertions about variable types. · ea473fb2
      Tom Lane 提交于
      Currently, the macros only work with fairly recent gcc versions, but there
      is room to expand them to other compilers that have comparable features.
      
      Heavily revised and autoconfiscated version of a patch by Andres Freund.
      ea473fb2