Signed-off-by: NNikos Armenatzoglou <nikos.armenatzoglou@gmail.com>

* Adding explicit casting for concatenation operator with integer
operands.
Signed-off-by: NFoyzur Rahman <foyzur@gmail.com>

* Explicit casting to convert integer to string to make opperf green.
Signed-off-by: NFoyzur Rahman <foyzur@gmail.com>

* Making expression tree mutation unconditional

We previously did not consider that we need to mutate an expression tree
only if there is a pseudo column. This introduces an executor crash in
non-assert build as executor does not know how to interpret a pseudo
column. Moreover, in assert build we fail an assert.

The conditional we are removing  was introduced to optimize performance
by commit a36436ea, but a quick performance
run shows that performance is not noticeably affected by removing the
optimization. [#131785597]
Signed-off-by: NFoyzur Rahman <foyzur@gmail.com>

* Adding PR comments.

syscache.h was previously included from parse_oper.h, but I removed that
in commit 8d77fb99. Turns out that gpdbwrappers.c was relying on that
indirect include.

Having an "extern" declaration directly in a C file is a bad habit, because
that can fail in surprising ways if the datatype of the variable is changed.
In thise case, we don't really need to check the variable at all, because
these functions are only used from ORCA.

Now that we capture and dispatch OIDs separately, we can revert these
changes vs. upstream.

I wasn't 100% sure if the change in bmbulkdelete() was OK. We no longer
update the relNode in the relcache entry. However, running this in a
debugger shows that reindex_index() updates the relcache entry itself,
so setting it in bmbulkdelete should not be necessary. Also, the
regression tests are happy with this.

No functional changes. Operator look up code had been refactored into
separate fetch_op_tup() function in GPDB, but that was rather pointless.
Revert it the way it's in the upstream, to reduce our diff footprint.

The upstream doesn't have it, and it's an odd one out, when none of the
other syscaches have such macros. This reduces our diff vs. upstream, which
makes diffing and merging easier.

We have no plans to add columsn to AO metadata tables using ALTER TABLE.
Even if we did, the penalty of a single syscache lookup hardly matters.

We don't do EXEC_BACKEND builds at the moment, but if we did, this would
likely cause compiler or Coverity warnings. Or a crash at runtime, if a
locale had a really long name.

This separate pipeline helps to run the catalog and storage TINC test projects,
eventually will be merged to run along side ICG on main and PR pipeline.

Transactional stats for heap_delete must be updated only if in transaction,
which should always be the case. Except the issue was encountered now when we
started calling heap_delete for PT tables to free tuples instead of older
mechanism. During recovery based on object state if transaction was aborted the
tuple in PT needs to be deleted and was failing in this function as
TopTransactionContext is not allocated. Hence, added the protection that only if
nesting level if greater than 0 which will be the case if we are in transaction
collect stats else ignore the same. Which helps to fix the problem.

Removed timetz columns from certain tables in the filespace regression
test.  They were not needed and caused a false failure due to United
States timezone change from PDT to PST.

Reported by Heikki Linnakangas.

I changed the expected output of partition_locking regression test in
commit f9016da2, but forgot to update the ORCA-specific output.

Commit f9016da2 removed the definition of the relid variable, remove
the assertion on it as well.

Instead of carrying a "new OID" field in all the structs that represent
CREATE statements, introduce a generic mechanism for capturing the OIDs
of all created objects, dispatching them to the QEs, and using those same
OIDs when the corresponding objects are created in the QEs. This allows
removing a lot of scattered changes in DDL command handling, that was
previously needed to ensure that objects are assigned the same OIDs in
all the nodes.

This also provides the groundwork for pg_upgrade to dictate the OIDs to use
for upgraded objects. The upstream has mechanisms for pg_upgrade to dictate
the OIDs for a few objects (relations and types, at least), but in GPDB,
we need to preserve the OIDs of almost all object types.

Asserting that an assignment isn't zero is a valid use of Assert(),
but these instances look more like accidental assignments due to a
missing '='. getgpsegmentCount() is already internally asserting
that the count is > 0 so we would never reach here in case it was.

The code that we generate for slot_getattr is not correct.
In particular, to check if a tuple is virtual, we have to implement the code below:
if (TupHasVirtualTuple(slot) && slot->PRIVATE_tts_nvalid >= attnum)

In the codegened slot_getattr, we had not implemented the
second condition, i.e., slot->PRIVATE_tts_nvalid >= attnum.

In this commit, we generate code for the second condition.

Signed-off-by: NKenan Yao <kyao@pivotal.io>

Signed-off-by: NCorbin Halliwill <challiwill@pivotal.io>

Signed-off-by: NRyan Tang <rtang@pivotal.io>

* Tighten the criteria for partition validation

Add additional case when source and destination attributes are different.

Authors: Larry Hamel, Marbin Tan, Chris Hajas

Ignore cursor case to get CI passed for now. Have submitted two issues
to track it.
Signed-off-by: NPengzhou Tang <ptang@pivotal.io>

This is hopefully a temporary change to increase stability of the pipeline.

So far we were assuming that the content of `llvm_isNull_ptr` variable, which is passed as
input to expression evaluation, is always `false`. Consequently, when the result of the
expression is not null, we avoid setting `llvm_isNull_ptr` to `false`.

However, this assumption is not correct since in codegen we do not use a temporary `fcinfo`
struct (for perfromance reasons), which initializes `fcinfo->isnull` to `false`.
Instead, we pass a pointer to the isnull variable of the caller directly (which might not
have been inititialized). For example, in `GenerateAdvanceAggregates` we pass a pointer
to `transValueIsNull`.

In this commit, we explicitly set `llvm_isNull_ptr` to `false` when the result is not null.
This will cover all cases that the input is not initialized to `false`.
Signed-off-by: NKarthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>

Codegened advance_aggregares did not support null attributes. With this
patch, we enhance it with checks for strict functions and create the
proper arguments' nullity checks accordingly.

Authors: Nikos Armenatzoglou and Jimmy Yih

With this commit adding infrastructure scripts to enable running catalog and
storage tests in Concourse containers natively. Using this infra interatively
will be migrating CS tests suites to concourse.

This avoids a lot of overhead for short read-only queries. We still don't
do lazy assignment for most transactions, like PostgreSQL 8.3 does, but
this is a step in the right direction.

Replace sleeps with deterministic check for database operational, after
injecting PANIC faults.