It was quite clearly broken, as it didn't do anything with the new_tle
that it chased up, and the end result was just the same as calling
canonicalize_pathkeys() on the input.

When compiling gpfdist on Ubuntu, the compile fails because of the compiler
flag to treat all warnings as errors. You get a warning when calling
freopen and not checking the result of the call.

Added a check for NULL of the redirect of stdout and stderr on init. If it
fails, it will print a message and return out of init with a -1.

This set of patches were all already cherry-picked into PGDB or was rejected
due to being Doc patches.

 Conflicts:
	contrib/intarray/_int.h
	doc/TODO
	doc/src/FAQ/TODO.html
	doc/src/sgml/Makefile
	doc/src/sgml/docguide.sgml
	doc/src/sgml/installation.sgml
	src/backend/libpq/be-secure.c
	src/backend/port/win32/socket.c
	src/backend/postmaster/pgstat.c
	src/backend/utils/adt/xml.c
	src/include/port/win32.h
	src/interfaces/ecpg/ChangeLog
	src/interfaces/ecpg/ecpglib/extern.h
	src/interfaces/ecpg/ecpglib/typename.c
	src/interfaces/libpq/fe-secure.c
	src/interfaces/libpq/libpq-int.h
	src/pl/plperl/expected/plperl.out
	src/pl/plperl/plperl.c
	src/pl/plperl/sql/plperl.sql
	src/timezone/ialloc.c
	src/timezone/zic.c
	src/tools/msvc/Project.pm
	src/tools/msvc/build.bat
	src/tools/msvc/mkvcbuild.pl

This merge only brings a small doc update and a bugfix in detaosting
access to bytea field in pg_trigger.tgargs. The main changes in this
set of patches were XML related which we already have (from 9.1) and
the introduction of tablespaces for temporary objects which GPDB
already have with filespaces for temporary objects.

 Conflicts:
	doc/TODO
	doc/src/FAQ/TODO.html
	doc/src/sgml/config.sgml
	doc/src/sgml/datatype.sgml
	src/backend/commands/indexcmds.c
	src/backend/commands/tablecmds.c
	src/backend/commands/tablespace.c
	src/backend/commands/trigger.c
	src/backend/executor/execMain.c
	src/backend/executor/execQual.c
	src/backend/parser/gram.y
	src/backend/parser/keywords.c
	src/backend/parser/parse_expr.c
	src/backend/storage/file/fd.c
	src/backend/utils/adt/xml.c
	src/backend/utils/misc/postgresql.conf.sample
	src/include/utils/guc.h
	src/include/utils/xml.h
	src/pl/plpython/plpython.c
	src/test/regress/expected/xml.out
	src/test/regress/expected/xml_1.out
	src/test/regress/sql/xml.sql

I'm not 100% the code is doing the right thing even with this: If the
pathkey's operator family doesn't match the join clause's operator family,
the output isn't truly ordered the same way. This is not an issue for the
case that I included in the regression test, where the join happens on a
constant, but I can't figure out whether this might be an issue with some
other query.

When the combocids patch was backported from PostgreSQL 8.3 (c3983003), the
changes to change the cache key of compiled functions were left out for
some reason. Those changes are necessary: calling HeapTupleHeaderGetCMin()
on the pg_proc tuple will trip an assertion, if the tuple has been moved by
VACUUM FULL, and therefore HEAP_MOVED flags on the tuple are set. To fix,
backport the missing parts of the upstream combocid patch.

The comment in apply_shareinput_xslice() said that we process top-plan
first, to ensure that we find the producer of a shared scan before its
consumers, when the top plan contains a producer for subplans. But the
situation can just as well be the other way 'round.

No new test case added, because running the existing with_clause test
with gp_cte_sharing=on trips the assertion.

Fixes github issue #287.

My previous commit (3d0a4806), which was solving the issue described in pull request #276, was braking some ICG tests in some operating systems and we reverted it. This is a complete fix for the same issue.

Currently to check previous runtimes it takes multiple grep commands
to summarize the log file. This change adds all the information to a
single line making it far easier to check historical runtimes. The
historical runtimes can be used to estimate the required maintenance
window for future runs.

This merge adds --tablespaces-only and --roles-only to pg_dumpall. Since
both GPDB and upstream have used -r in pg_dumpall, this commits disables
-r and instead issues an error to avoid confusion.

 Conflicts:
	doc/TODO
	doc/src/FAQ/TODO.html
	doc/src/sgml/ref/pg_dumpall.sgml
	src/bin/pg_dump/pg_backup_archiver.h
	src/bin/pg_dump/pg_dumpall.c
	src/include/c.h

This patch prevents WAL logging when COPY is done in the same transaction
that created it. fba8113c is also cherry
picked into this merge since it has fixups to this patch as well as
related WAL skipping changes to CLUSTER.

 Conflicts:
	doc/src/sgml/perform.sgml
	src/backend/access/heap/heapam.c
	src/backend/access/heap/tuptoaster.c
	src/backend/catalog/index.c
	src/backend/commands/copy.c
	src/backend/executor/execMain.c
	src/backend/utils/cache/relcache.c
	src/include/access/tuptoaster.h

Closes 275

The dump process was checking the segments for several kinds of
metadata, such as indexes and triggers, even though they were not
being included in the dump.  The statements that were performing
these useless checks have been modified to only run on the master.

Authors: James McAtamney and Jimmy Yih

This reverts commit 3d0a4806.

Closes #288

This fix prevents gpdb from a segmentation fault in case that: i) a SharedInputScan has a Sort child node, ii) sort spills, and iii) somebody requests to finish the execution during the last stage of the sort (i.e., QueryFinishPending = true). Currently, in the above scenario, SharedInputScan continues the execution and tries to access sort's result_tape, which is NULL, due to QueryFinishPending.

This commit makes a sort node to pretend that there are no results when QueryFinishPending flag is set to true. The commit also  creates a new Fault injector type and includes an ICG test.

This adds the capability to dump operator families. XML and MSVC build
fixes were already merged and kept at master.

 Conflicts:
	doc/src/sgml/xindex.sgml
	src/backend/executor/execScan.c
	src/backend/utils/adt/xml.c
	src/backend/utils/mb/wchar.c
	src/bin/pg_dump/common.c
	src/bin/pg_dump/pg_backup_archiver.c
	src/bin/pg_dump/pg_dump.c
	src/bin/pg_dump/pg_dump.h
	src/include/port/win32.h
	src/test/regress/expected/xml.out
	src/tools/msvc/Project.pm
	src/tools/msvc/Solution.pm
	src/tools/msvc/mkvcbuild.pl

Gpcrondump and gpdbrestore redirect stderr into status file for segments,
errors should be reflected into the master's report file.
Warnings will be given if process completed but errors were generated in
the report file.

Also made some refactor of the code.

This commit also reverts 08f4ada7.

Authors: Pengcheng Tang, Nikhil Kak

systemd IPC cleanup takes effect if gpadmin is not system user

int2vector and aclitem don't have B-tree operators, making them not
mergejoinable. In the merge of the equivalence classes patch, I made
cdb_make_pathkeys_for_expr() more strict on that, and it now throws
an error if it's passed a datatype that doesn't have a mergejoinable
= operator. It used to return a path key with InvalidOid as the sort
operator, but that seems like a recipe for bugs elsehere.

To fix, mandate that all gpdb-hashable datatypes must be mergejoinable.
int2vector and aclitem are not, so forbid using them in DISTRIBUTED BY.

This is a backwards-incompatible change, but hopefully no-one is using
int2vector or aclitem in user-tables, at least not as a distribution key.

Ensure that the comment match what can happen, YAML files with .yml
suffix can also be created from mapred.

This adds CREATE/ALTER/DROP OPERATOR FAMILY commands.

Conflicts:
	doc/src/sgml/ref/allfiles.sgml
	doc/src/sgml/ref/comment.sgml
	doc/src/sgml/ref/drop_opclass.sgml
	doc/src/sgml/reference.sgml
	src/backend/catalog/aclchk.c
	src/backend/commands/opclasscmds.c
	src/backend/parser/gram.y
	src/backend/parser/keywords.c
	src/backend/tcop/utility.c
	src/include/nodes/parsenodes.h

Conflicts:
	contrib/pgbench/pgbench.c
	doc/FAQ_MINGW
	doc/src/sgml/manage-ag.sgml
	src/backend/optimizer/path/costsize.c
	src/backend/postmaster/postmaster.c
	src/include/port/win32.h
	src/port/exec.c

There were failures from these in the Pivotal buildfarm. Some tables were
larger than expected. I'm not sure why - perhaps there was some concurrent
activity that bloats append-only tables - but there have been no functional
changes so these really should be passing.

This is dead, because SubPlan is an Expr node and therefore cannot appear
in a Plan tree.

This was broken, because the "subplan = (SubPlan *) subplan" cast didn't
do anything, and subplan was potentially uninitialized. It meant to say
"subplan = (SubPlan *) plan".

Spotted by Daniel Gustafsson.

This merges the COST and ROWS options for functions.

One GPDB-specific question was what the ROWS option means for GPDB
table functions. I decided to keep the old estimation method, where the
number of output rows for a table function is estimated to be the same
as input rows, and ignore the ROWS option.

Also regenerate 4.3.json file, which I forgot to do in the previous commit.

Conflicts:
	doc/src/sgml/catalogs.sgml
	doc/src/sgml/ref/create_function.sgml
	src/backend/bootstrap/bootstrap.c
	src/backend/catalog/pg_aggregate.c
	src/backend/catalog/pg_proc.c
	src/backend/commands/functioncmds.c
	src/backend/commands/proclang.c
	src/backend/optimizer/path/costsize.c
	src/backend/optimizer/plan/createplan.c
	src/backend/optimizer/plan/setrefs.c
	src/backend/parser/gram.y
	src/backend/parser/keywords.c
	src/backend/utils/Gen_fmgrtab.sh
	src/backend/utils/cache/lsyscache.c
	src/bin/pg_dump/pg_dump.c
	src/include/catalog/catversion.h
	src/include/catalog/pg_attribute.h
	src/include/catalog/pg_class.h
	src/include/catalog/pg_proc.h
	src/include/optimizer/cost.h
	src/include/utils/lsyscache.h

Conflicts:
	doc/TODO
	doc/src/FAQ/TODO.html
	src/interfaces/ecpg/test/Makefile
	src/interfaces/ecpg/test/pg_regress.sh

This brings in test queries from the "jetpack" test case in cdbfast (a
legacy Pivotal test suite that has not been open sourced yet), to cover
the gp_toolkit functionality that was not already covered by the bugbuster
tests. Move the test case from bugbuster into the main suite - this should
not be considered optional or auxiliary anymore.

If there is a schema in the database that the user does not have access to,
doing "select * from gp_toolkit.__gp_user_tables_readable" throws a
permission denied error on the schema. Use the relation-OID-variant of
has_table_privilege() function, to work around that.

This isn't otherwise better than the existing code, but this matches the
upstream more closely, which will make merging slightly easier.

parser/analyze.c is bloated, moving larger chunks of GPDB-specific
functionality like this elsewhere makes it more readable. Make diffing and
merging of analyze.c with upstream easier, too.

I also ran pgindent on parse_partition.c.

parser/analyze.c is overcrowded, and since it's an upstream file, extra
code there can confuse merging (though completely new functions are less
of a problem).

The GPDB-specific auto-stats system doesn't really have anything to do with
autovacuum. It's not run by the autovacuum daemon, and there are no calls
from the autovacuum code to autostats code.

Conflicts:
	doc/TODO
	doc/src/FAQ/TODO.html
	doc/src/sgml/catalogs.sgml
	doc/src/sgml/func.sgml
	doc/src/sgml/indexam.sgml
	doc/src/sgml/xindex.sgml
	src/include/catalog/catversion.h
	src/include/catalog/pg_am.h

The big change in this merge is the "equivalence classes" mechanism. That's
not too exciting as a feature, but cleans up a lot of the planner stuff that
tracks which expressions can be treated as equal, and used interchangeably.

This required quite a lot of changes in the GPDB-specific code that tracks
the distribution keys of tables and intermediate nodes in a plan.

One notable refactoring, that didn't originate from the upstream, was the
change to CdbPathLocus, to split the "pathkeys" field into two. That reduces
the confusion on which kind of a List we're dealing with.

This includes fixes from a couple of later upstream commits: 48d9d8e1 and
11086f2f. Those were needed to fix regression failures in GPDB-added tests.

Merge by Daniel Gustafsson and me.

Conflicts:
	doc/src/sgml/config.sgml
	doc/src/sgml/installation.sgml
	doc/src/sgml/xoper.sgml
	src/backend/access/gist/gistget.c
	src/backend/access/gist/gistscan.c
	src/backend/nodes/copyfuncs.c
	src/backend/nodes/outfuncs.c
	src/backend/optimizer/README
	src/backend/optimizer/path/Makefile
	src/backend/optimizer/path/costsize.c
	src/backend/optimizer/path/indxpath.c
	src/backend/optimizer/path/joinpath.c
	src/backend/optimizer/path/joinrels.c
	src/backend/optimizer/path/pathkeys.c
	src/backend/optimizer/plan/createplan.c
	src/backend/optimizer/plan/initsplan.c
	src/backend/optimizer/plan/planmain.c
	src/backend/optimizer/plan/planner.c
	src/backend/optimizer/prep/prepunion.c
	src/backend/optimizer/util/joininfo.c
	src/backend/optimizer/util/pathnode.c
	src/backend/optimizer/util/relnode.c
	src/backend/optimizer/util/restrictinfo.c
	src/backend/utils/error/elog.c
	src/backend/utils/misc/postgresql.conf.sample
	src/bin/psql/describe.c
	src/include/access/gist_private.h
	src/include/access/hash.h
	src/include/nodes/nodes.h
	src/include/nodes/relation.h
	src/include/optimizer/pathnode.h
	src/include/optimizer/paths.h
	src/include/optimizer/planmain.h
	src/include/optimizer/restrictinfo.h

Bump GPOPT version to 1.618 and GPOS version to 1.334. Avoid initiating the CMinidumperDXL when not needed

Closes #274.