1. 21 6月, 2005 9 次提交
    • T
      Cause initdb to create a third standard database "postgres", which · 6f7fc0ba
      Tom Lane 提交于
      unlike template0 and template1 does not have any special status in
      terms of backend functionality.  However, all external utilities such
      as createuser and createdb now connect to "postgres" instead of
      template1, and the documentation is changed to encourage people to use
      "postgres" instead of template1 as a play area.  This should fix some
      longstanding gotchas involving unexpected propagation of database
      objects by createdb (when you used template1 without understanding
      the implications), as well as ameliorating the problem that CREATE
      DATABASE is unhappy if anyone else is connected to template1.
      Patch by Dave Page, minor editing by Tom Lane.  All per recent
      pghackers discussions.
      6f7fc0ba
    • N
      Fix a potential backend crash during authentication when parsing a · ec3a1af0
      Neil Conway 提交于
      malformed ident map file.  This was introduced by the linked list
      rewrite in 8.0 -- mea maxima culpa.
      
      Per Coverity static analysis performed by EnterpriseDB.
      ec3a1af0
    • N
      Trivial dead code removal: in CreateSchemaCommand(), 'owner_name' is · 09d1110c
      Neil Conway 提交于
      only used in one branch of an if statement, so we can move its
      declaration to that block. This also avoids an unnecessary syscache
      lookup.
      
      Per Coverity static analysis performed by EnterpriseDB.
      09d1110c
    • N
      Trivial dead code removal: in _complete_from_query(), 'text' cannot be · 2d4b9736
      Neil Conway 提交于
      NULL (e.g. due to the preceding strlen()). Therefore we needn't recheck
      this before initializing 'e_text'.
      
      Per Coverity static analysis performed by EnterpriseDB.
      2d4b9736
    • N
      Trivial dead code removal: in makeObjectName(), name1 must be non-NULL · 141e878b
      Neil Conway 提交于
      (due to the preceding strlen(), for example), so we needn't recheck this
      before invoking pg_mbcliplen().
      
      Per Coverity static analysis performed by EnterpriseDB.
      141e878b
    • T
      exec_eval_datum leaks memory when dealing with ROW or REC values. · 638feae2
      Tom Lane 提交于
      It never leaked memory before PG 8.0, so none of the callers are
      expecting this.  Cleanest fix seems to be to make it allocate the needed
      memory in estate->eval_econtext, where it will be cleaned up by
      the next exec_eval_cleanup.  Per report from Bill Rugolsky.
      638feae2
    • T
      Remove read_file/write_file tests. These were originally intended to · 59ee9448
      Tom Lane 提交于
      *fail*, to test that plpython didn't allow untrusted operations.
      When we changed plpython to plpythonu because python didn't actually have
      a secure sandbox mode, someone (probably me :-() misinterpreted the tests
      as checking whether Python's file I/O works.  Which is a stupid thing for
      us to be testing.  Remove it so we don't clutter the filesystem with
      random temporary files.
      59ee9448
    • T
      plpgsql's exec_assign_value() freed the old value of a variable before · 9d7c0052
      Tom Lane 提交于
      copying/converting the new value, which meant that it failed badly on
      "var := var" if var is of pass-by-reference type.  Fix this and a similar
      hazard in exec_move_row(); not sure that the latter can manifest before
      8.0, but patch it all the way back anyway.  Per report from Dave Chapeskie.
      9d7c0052
    • T
      Avoid WAL-logging individual tuple insertions during CREATE TABLE AS · b95ae32b
      Tom Lane 提交于
      (a/k/a SELECT INTO).  Instead, flush and fsync the whole relation before
      committing.  We do still need the WAL log when PITR is active, however.
      Simon Riggs and Tom Lane.
      b95ae32b
  2. 20 6月, 2005 14 次提交
  3. 19 6月, 2005 5 次提交
  4. 18 6月, 2005 6 次提交
  5. 17 6月, 2005 6 次提交