- 18 7月, 2008 4 次提交
-
-
由 Tom Lane 提交于
(Unlike the original submission, this patch treats TABLE output parameters as being entirely equivalent to OUT parameters -- tgl) Pavel Stehule
-
由 Alvaro Herrera 提交于
-
由 Alvaro Herrera 提交于
it. Per report from Tom Lane based on buildfarm evidence.
-
由 Tom Lane 提交于
problem with DISTINCT, so might as well commit it.
-
- 17 7月, 2008 3 次提交
-
-
由 Tom Lane 提交于
-
由 Tom Lane 提交于
need to deconstruct proargmodes for each pg_proc entry inspected by FuncnameGetCandidates(). Fixes function lookup performance regression caused by yesterday's variadic-functions patch. In passing, make pg_proc.probin be NULL, rather than a dummy value '-', in cases where it is not actually used for the particular type of function. This should buy back some of the space cost of the extra column.
-
由 Bruce Momjian 提交于
-
- 16 7月, 2008 3 次提交
-
-
由 Tom Lane 提交于
so long as all the trailing arguments are of the same (non-array) type. The function receives them as a single array argument (which is why they have to all be the same type). It might be useful to extend this facility to aggregates, but this patch doesn't do that. This patch imposes a noticeable slowdown on function lookup --- a follow-on patch will fix that by adding a redundant column to pg_proc. Pavel Stehule
-
由 Bruce Momjian 提交于
Pavel Stehule
-
由 Bruce Momjian 提交于
Euler Taveira de Oliveira.
-
- 15 7月, 2008 4 次提交
-
-
由 Bruce Momjian 提交于
Dickson S. Guedes
-
由 Bruce Momjian 提交于
psql.
-
由 Bruce Momjian 提交于
Gregory Stark
-
由 Bruce Momjian 提交于
-
- 14 7月, 2008 4 次提交
-
-
由 Tom Lane 提交于
macros patch :-(. Results from both baiji and mastodon imply that MSVC fails to perceive offsetof(PageHeaderData, pd_linp[0]) as a constant expression in some contexts where offsetof(PageHeaderData, pd_linp) works fine. Sloth, thy name is Micro.
-
由 Tom Lane 提交于
on the most common individual lexemes in place of the mostly-useless default behavior of counting duplicate tsvectors. Future work: create selectivity estimation functions that actually do something with these stats. (Some other things we ought to look at doing: using the Lossy Counting algorithm in compute_minimal_stats, and using the element-counting idea for stats on regular arrays.) Jan Urbanski
-
由 Tom Lane 提交于
thereby forestalling any problems with alignment of the data structure placed there. Since SizeOfPageHeaderData is maxalign'd anyway in 8.3 and HEAD, this does not actually change anything right now, but it is foreseeable that the header size will change again someday. I had to fix a couple of places that were assuming that the content offset is just SizeOfPageHeaderData rather than MAXALIGN(SizeOfPageHeaderData). Per discussion of Zdenek's page-macros patch.
-
由 Tom Lane 提交于
SizeOfPageHeaderData instead of sizeof(PageHeaderData) in places where that makes the code clearer, and avoid casting between Page and PageHeader where possible. Zdenek Kotala, with some additional cleanup by Heikki Linnakangas. I did not apply the parts of the proposed patch that would have resulted in slightly changing the on-disk format of hash indexes; it seems to me that's not a win as long as there's any chance of having in-place upgrade for 8.4.
-
- 12 7月, 2008 4 次提交
-
-
由 Peter Eisentraut 提交于
-
由 Tom Lane 提交于
it's just too dang expensive. Per recent discussion, but I just got my nose rubbed in it again while doing some performance checking.
-
由 Tom Lane 提交于
warnings. Clean up various unneeded cruft that was left behind after creating those routines. Introduce some convenience functions str_tolower_z etc to eliminate tedious and error-prone double arguments in formatting.c. (Currently there seems no need to export the latter, but maybe reconsider this later.)
-
由 Tom Lane 提交于
-
- 11 7月, 2008 4 次提交
-
-
由 Peter Eisentraut 提交于
Document return type of cast functions. Also change documentation to prefer the term "binary coercible" in its present sense instead of the previous term "binary compatible".
-
由 Alvaro Herrera 提交于
CopySnapshot, per Neil Conway. Also add a comment about the assumption in GetSnapshotData that the argument is statically allocated. Also, fix some more typos in comments in snapmgr.c.
-
由 Neil Conway 提交于
alphabetically.
-
由 Tom Lane 提交于
wal_segment_size to make those configuration parameters available to clients, in the same way that block_size was previously exposed. Bernd Helmle, with comments from Abhijit Menon-Sen and some further tweaking by me.
-
- 10 7月, 2008 2 次提交
-
-
由 Tom Lane 提交于
the current query level that aren't in fact output parameters of the current initPlans. (This means, for example, output parameters of regular subplans.) To make this work correctly for output parameters coming from sibling initplans requires rejiggering the API of SS_finalize_plan just a bit: we need the siblings to be visible to it, rather than hidden as SS_make_initplan_from_plan had been doing. This is really part of my response to bug #4290, but I concluded this part probably shouldn't be back-patched, since all that it's doing is to make a debugging cross-check tighter.
-
由 Tom Lane 提交于
bug #4290. The fundamental bug is that masking extParam by outer_params, as finalize_plan had been doing, caused us to lose the information that an initPlan depended on the output of a sibling initPlan. On reflection the best thing to do seemed to be not to try to adjust outer_params for this case but get rid of it entirely. The only thing it was really doing for us was to filter out param IDs associated with SubPlan nodes, and that can be done (with greater accuracy) while processing individual SubPlan nodes in finalize_primnode. This approach was vindicated by the discovery that the masking method was hiding a second bug: SS_finalize_plan failed to remove extParam bits for initPlan output params that were referenced in the main plan tree (it only got rid of those referenced by other initPlans). It's not clear that this caused any real problems, given the limited use of extParam by the executor, but it's certainly not what was intended. I originally thought that there was also a problem with needing to include indirect dependencies on external params in initPlans' param sets, but it turns out that the executor handles this correctly so long as the depended-on initPlan is earlier in the initPlans list than the one using its output. That seems a bit of a fragile assumption, but it is true at the moment, so I just documented it in some code comments rather than making what would be rather invasive changes to remove the assumption. Back-patch to 8.1. Previous versions don't have the case of initPlans referring to other initPlans' outputs, so while the existing logic is still questionable for them, there are not any known bugs to be fixed. So I'll refrain from changing them for now.
-
- 09 7月, 2008 2 次提交
-
-
由 Tom Lane 提交于
1024 to improve performance when sending large elog messages. Also add a comment about why we use that number. Since this represents an externally visible behavior change, and might possibly result in portability issues, it seems best not to back-patch it.
-
由 Tom Lane 提交于
log message at newlines cost O(N^2) for very long messages with few or no newlines. For messages in the megabyte range this became the dominant cost. Per gripe from Achilleas Mantzios. Patch all the way back, since this is a safe change with no portability risks. I am also thinking of increasing PG_SYSLOG_LIMIT, but that should be done separately.
-
- 08 7月, 2008 4 次提交
-
-
由 Neil Conway 提交于
-
由 Bruce Momjian 提交于
/* This is PGC_SIGHUP so all backends have the same value. */
-
由 Tom Lane 提交于
results always contribute two groups, regardless of the expression contents. This is very substantially more accurate than the regular heuristic for certain boolean tests like "col IS NULL". Per gripe from Sam Mason. Back-patch to all supported releases, since the behavior of estimate_num_groups() hasn't changed all that much since 7.4.
-
由 Tom Lane 提交于
the timezone argument as a timezone abbreviation, and only try it as a full timezone name if that fails. The zic database has four zones (CET, EET, MET, WET) that are full daylight-savings zones and yet have names that are the same as their abbreviations for standard time, resulting in ambiguity. In the timestamp input functions we resolve the ambiguity by preferring the abbreviation, and AT TIME ZONE should work the same way. (No functionality is lost because the zic database also has other names for these zones, eg Europe/Zurich.) Per gripe from Jaromir Talir. Backpatch to 8.1. Older releases did not have the issue because AT TIME ZONE only accepted abbreviations not zone names. (Thus, this patch also arguably fixes a compatibility botch introduced at 8.1: in ambiguous cases we now behave the same as 8.0 did.)
-
- 07 7月, 2008 1 次提交
-
-
由 Tom Lane 提交于
variable that has units. Per report from Stefan Kaltenbrunner. Backport to 8.2. I also backported my patch of 2007-06-21 that prevented comparable overflows on the input side, since that now seems to have enough field track record to be back-patched safely. That patch included addition of hints listing the available unit names, which I did not bother to strip out of it --- this will make a little more work for the translators, but they can copy the translation from 8.3, and anyway an untranslated hint is better than no hint.
-
- 04 7月, 2008 4 次提交
-
-
由 Teodor Sigaev 提交于
-
由 Magnus Hagander 提交于
* Don't cut off the prefix. With this fix, it's again readable. * Properly store it in the Global namespace as intended.
-
由 Tom Lane 提交于
known to the SQL parser. Dave Page
-
由 Peter Eisentraut 提交于
scripts, to allow running the test successfully with another database name.
-
- 03 7月, 2008 1 次提交
-
-
由 Peter Eisentraut 提交于
-