Debug_gp_relation_node_fetch_wait_for_debugging was added to assist
debugging an issue in the RelationFetchGpRelationNodeForXLog recursion
guard. The bug was not reproduced but the GUC was left in when the
ticket was closed so remove. If we need to debug this in the future
we should add something back then.

Fix a common typo in the user facing documentation.

The error messages are developer or debug facing, no reason to
believe this will break anyones regexing of logfiles in prod.

* Update regex to reflect output change [#140454709]

`pg_lock_status` changed output format.

We cannot assume we are running in a special environment that is always
in -8 time zone without DST. Making such setting explicit to make tests
portable.

Unskipping test as they will succeed now.

Followup stories created to fix the issues

It depends on TPCH datagen, which is not a viable idea.

Fix various typos that seemed common.

The current dbInfoRel hash table key only contains the relfilenode
oid. However, relfilenode oids can be duplicated over different
tablespaces which can cause dropdb (and possibly persistent rebuild)
to fail. This commit adds the tablespace oid as part of the dbInfoRel
hash table key for more uniqueness.

One thing to note is that a constructed tablespace/relfilenode key is
compared with other keys using memcmp. Supposedly... this should be
fine since the struct just contains two OID variables and the keys are
always palloc0'd. The alignment should be fine during comparison.

These tests are necessary to validate our backup and restore utilities on Data Domain. Unfortunately they are still in TINC, but we plan to move them to behave when possible.

Authors: Chris Hajas and Marbin Tan

We may have UNKNOWN vars from untyped const or params
which must be coerced.
Signed-off-by: NOmer Arap <oarap@pivotal.io>

The test launched one backend, and ran ALTER TABLE ADD COLUMN in it. Before
committing the ALTER TABLE transaction, it launched another backend, and
ran a query against the table. That will block, because the ALTER TABLE
is holding an AccessExclusiveLock on the table. It then committed the
first transaction, letting the second transaction to continue.

That's not a very interesting test case. ALTER TABLE grabs an
AccessExclusiveLock very early, so it's hard to imagine it would fail to
hold it. Also hard to imagine what could go wrong in having the other query
block on the lock. Backends frequently block on all kinds of locks, for
short periods of time, so just blocking on a lock isn't very interesting.
Furthermore, AFAICS, if the ALTER TABLE somehow failed to acquire the lock,
so that the query didn't block, the test would return the same output, and
therefore wouldn't catch that case.

We have sufficient coverage of external tables in the main regression
suite and src/bin/gpfdist/regress already.

I kept the tests using QuickLZ in TINC, as we don't have QuickLZ support in
the open source version anymore. They ought to be moved to where we keep
the code for reading legacy quicklz-compressed tables.

There were three variants of the same test, combined with 4 compresslevels.
The "*_null" variants insert rows, such that the delta between some rows is
positive, and between others, negative. And it also contains some NULLs.
The other variants only contained positive or postive and negative deltas,
without NULLs. It doesn't seem interesting to have separate tests for the
more narrow cases. If there's something wrong with the handling of positive
or negative deltas, the "*_nulls" tests will catch that too.

OIDS defaults to 'off' for user tables, so this test is effectively the
same as not specifying OIDS at all. (And OIDS=true is not supported on AOCS
tables.)

Commit 714a8375 removed the Python script that referenced these.

There is no tincrepo/mpp/gpdb/tests/utilities/upgrade directory.

We must support older than 80300 in dumping pg_type Oid's in order
to support upgrades from 4.3. Remove bogus check inherited from
upstream PostgreSQL where 8.3 is the earliest version supported by
pg_upgrade. Replace with a check for 8.2 as the base version in
the main binary upgrade dump function and explain the difference
to upstream.

In case there were no auxiliary relations associated with the rel
oid then skip adding the Archive entry to not have blank entries
in the dump with just a header comment.

The conrelid is equal to the oid (it's a join criteria after all).
Perform a little bit of cleanup for clarity (and microoptimization)
and don't project it into the result.

This moves over the queries worth keeping from Bugbuster gpsort to
ICW sort. Many of the queries returned a single row, no rows at all
or even had syntax errors, all of which are uninteresting cases for
testing result sorting. All rows in the test table are distributed
to a single segment to keep the sort order stable during testing.

Also remove pointless ignore blocks from sort and avoid dropping
the schema at the end so shave some time off.

The gp_enable_alter_table_inherit_cols GUC was used to allow a list
of columns to override the attribute discovery for inheritance in
ALTER TABLE INHERIT. According to code comments the only consumer
of this was gpmigrator, but no callsite remains and no support in
pg_dumpall remains either. Remove the leftovers of this to avoid a
potential footgun and get us closer to upstream code.

TINC had a lot of gpmapreduce tests which weren't connected to any
build or pipeline, resurrect (some of) these by porting over to the
mapred suite in ICW.

This is by no means a direct copy of the existing TINC testsuites,
but instead a partial port of the tests that made sense to bring
over. A lot of the tests were highly overlapping, some completely
broken, some were testing functionality ICW already had tests for
and others plain uninteresting.

The gp_external_grant_privileges GUC was needed before 4.0 to let
non superusers create external tables for gphdfs and http protocols.
This GUC was however deprecated during the 4.3 cycle so remove all
traces of it. The utility of the GUC was replaced in 4.0 when rights
management for external tables was implemented with the normal GRANT
REVOKE framework so this has been dead code for quite some time.

Remove GUC, code which handles it, all references to it from the
documentation and a release notes entry.

Release notes entry for the removal of gp_hashagg_compress_spill_files,
gp_eager_hashtable_release, max_work_mem and gp_hash_index.

The gp_eager_hashtable_release GUC was deprecated in version 4.2
in 2011 when the generic eager free framework was implemented. The
leftover gp_eager_hashtable_release was asserted to be true and
never intended to be turned off. The same body of work deprecated
the max_work_mem setting which was bounding the work_mem setting.
While not technically tied to eager hashtable release, remove as
well since it's deprecated, undocumented and not terribly useful.

Relevant commit in closed source repo is 88986b7d

The gp_hashagg_compress_spill_files GUC was deprecated in 2010 when
it was replaced by gp_workfile_compress_algorithm. The leftovers
haven't done anything for quite some time so remove GUC.

Relevant commit in closed source repo is c1ce9f03

Revert commit ffc6226a and 1d31323a. It failed on concourse.