Commit 0bf31cd6 ensured that we are using proper error codes
instead of internal errors with filename:location. Remove this
left over regex which will no longer be useful.

This was causing icw_orca to fail.  Removing order by will allow for gpdiff's
order agnostic comparison.  The order by was on a non-distinct set of keys,
causing the results to differ between orca and planner.

Also add yet another orca-specific answer file that was missed earlier.

* Cleaning-up bunch of sqls and functions not used
* Adding robust mechanism to test if db is back-up to make tests deterministic
* Optimize a bit by stop performing restartdb, remove drop table statements,
  etc..

* Merge 4 alter_ao_part_exch* tests into one to avoid redundant
   partitioned table creation.
 * Avoid creating bitmap index when not required.
 * Merge analyze* tests into analyze_ao_table_every_dml.sql to reduce
   number of tables that need to be created.
 * Merge cluster.sql into alter_ao_table_index.sql.
 * Merge auxiliary_tables.sql into create_ao_tables.sql.
 * Add update and delete statements where they were missing.
 * Remove DROP TABLE statements.
 * Remove unnecessary "select * from ..." to reduce diff time.
 * Merge truncate_ao_table.sql into create_ao_tables.sql.
 * Merge truncate_ao_table_part.sql into alter_ao_part_tables.sql.
 * Remove redundant COPY tests.  COPY command is already tested by
   analyze_ao_table_every_dml.sql.
 * Remove "ALTER TABLE ... CLUSTER" tests, these commands should
   report error if run against append-optimized tables.
 * Remove fillfactor tests, fillfactor is not applicable to
   append-optimized tables.
 * Merge blocksize tests into one to minimize creating tables.
 * Merge *ao_table_compresstype.sql into one compresstype.sql.

Use a single DB connection when dumping stats instead of starting a new
one for each table.

The previous commit included a bug causing unit test pollution which has
since been fixed.  The changes involve patching out the mocked method
rather than directly replacing it in the module.

Ensure to free any allocated content on premature exit. These potential
leaks are small but we might as well clean up to make static analysis
happy.

Per defect in Coverity

The MemTupleNoOidSpace() wasn't implemented and did just do an
assertion rather than what it said on the tin. Remove since the
intention of the macro isn't really possible - there is nothing
like HEAP_HASOID for memtuples.

If we error out we need to properly close the filehandle.

Per defect in Coverity

Passing -pthread to programs not using threading cause clang to
complain over unused flag.

While these uses of strcpy() were safe in the sense that the limits
were set to NAMEDATALEN, using strlcpy() is not wrong and it makes
the intent of the code clear such that anyone looking for potential
buffer overflows can skip over these.

Per gripe by Coverity

transformPassThroughParms() is hardcoded to always return true since
the code that could render false has been killed. No single callsite
further inspect the returnvalue (for good reasons). Remove return
value altogether and make function return void.

At this point we already know that pQry is non-NULL as we have
dereferenced it previous in the function. Remove useless check
to make the code clearer.

Per gripe by Coverity.

Remove commented out code which clearly hasn't been in use for some
time. Anyone interested in this code have the VCS archives at their
disposal.

- This commit causes unit tests to fail
- They pass when you run `make check test="test_unit_dump.py"

This reverts commit 4173cc60.

Signed-off-by: NJingyi Mei <jmei@pivotal.io>

Signed-off-by: NDavid Sharp <dsharp@pivotal.io>

Signed-off-by: NTom Meyer <tmeyer@pivotal.io>

faultinjection is failed to inject.

This closes #1454

It turns out that PostgreSQL had effectively the same bug, so reported
and fixed (commit 4f5182e1) there too. See:

https://www.postgresql.org/message-id/20161216105001.13334.42819%40wrigleys.postgresql.org

This needs to be refactored, by latest when we merge with PostgreSQL 9.1,
as there is a function called quote_literal_internal there with different
arguments, and the equivalend of GPDB's quote_literal_internal() is called
quote_literal_cstr() there. But for now, just fix the bug.

Fixes github issue #1301, reported by Tang Pengzhou.

stacktracearray is an array member of the ErrorData struct, not a pointer.
It cannot be NULL.

To silence Coverity warning.

The if() block in  pg_get_expr_worker() had apparently been backported from
8.4, long time ago. But when that if-block was introduced in 8.4, this line
was removed at the same time. As it stands, the context constructed in the
if-block was ignored.

Spotted by Coverity.

The 8.3 merge introduced new LOCKTAG_VIRTUALTRANSACTION case, and a mistake
was made in fixing the merge conflict with the GPDB-specific
LOCKTAG_RELATION_APPENDONLY_SEGMENT_FILE case. As a result, pg_locks showed
information for virtualxid locks incorrectly.

Spotted by Coverity.

Per Coverity.

This if-block was dead, because truncOid was never set. It used to be used
by gp_enable_delete_as_truncate machinery. Commit 24db2c6b removed the
supposedly last remnants of it, but missed this one.

Spotted by coverity.

The return value of LockAcquire() can be ignored when dontWait=false is
passed. Add (void), like in all the other such callers, to silence warning.

Spotted by Coverity.

This greatly simplifies the error handling and resource cleanup of Bfz
files. Now closing and unlinking bfz files on error is handled by the
resource owner mechanism. This brings the BufFile and BFZ codepaths of
so-called "workfiles", in execWorkFile.c, much closer to each other. Both
now rely on the same mechanism for resource cleanup.

This fixes a crash in the test case that's memorized in the included
regression test.

Remove silly test on bfz_scan_begin(). It was broken, because it used to
set the 'fd' field to 1, which means stdout. That trick doesn't work with
the File interface, it will throw an assertion failure. Rather than fix it,
remove the test altogether. It only tested things that are very explicitly,
directly and unconditionally set in bfz_scan_begin(). There's no real value
in that. Fix the compress_zlib mock test to reflect that the bfz is now
allocated in CurrentMemoryContext rather than TopMemoryContext.

Analysis and test case by Karthikeyan Jambu Rajaraman.

They were marked as having NULL prodataacess, but prodataaccess is a not
nullable column. That caused an assertion failure with "SELECT * FROM
pg_available_extensions".

Reported by Kuien Liu. Fixes github issue #1446.

Signed-off-by: NJingyi Mei <jmei@pivotal.io>

Use only one cached DB connection to perform the statistics dump
We were opening 2 DB connections for each table when dumping stats (one
for tuples and one for stats), causing gpcrondump to take a significant
amount of time.

Authors: Stephen Wu, Natalie Bennett

The old GPDB code had a "fall through" in switch-case block, that was not
present in PostgreSQL 8.2. PostgreSQL 8.3 added a new case-block to the
statement, so that the GPDB-specific "fall through" fell through to the
wrong case-block. This lead to a crash, if a sort was small enough to be
performed in memory, was shared by multiple slices. Fix by moving the
GPDB-specific check outside the switch-case statement.

- Remove RESET ALL so that it can actually test with optimizer=on
- Remove duplicated population of table A, B, C
- Rename tables touched by DML to avoid duplicated setup
- Fix subquery to verify the correct result other than verify error message
- Remove query with non-deterministic result

Now, with GPORCA, all SQL statements passed without ERROR. Planner still got few
failures due to multi-level correlated subqueries, which is expected.

* Delete unused genoverflow tests
* Remove all but a few of the ExplainAnalyzeTestCase tests
* Fix OOM tests to use DataSetDatabase
* Remove memory_accounting/memory_account tests

Signed-off-by: NOmer Arap <oarap@pivotal.io>

Added a guc, `optimizer_penalize_broadcast_threshold` to set the threshold on
maximum number of rows to broadcast.
Signed-off-by: NOmer Arap <oarap@pivotal.io>

This reverts commit 6f2e35bc.

Pipeline detect failure when codegen is enabled with gporca.