These tests were invoking the new fault injector interface using its
temporary name - gp_inject_fault2().  Now the new interface is the
only one present in the repository, named as gp_inject_fault().

The new interface employs a special libpq connection parameter and a
libpq message to convey fault details to destination postmaster.  This
interface has been in use for some time now.  It was getting cumbersome
to maintain both the old as well as the new interface.

To be clear, we now have only one interface to inject fault and that is
"gp_inject_fault()".

Existing tests that were using gp_inject_fault2() will be updated in a
follow up commit.

This makes the signature of the new interface match that of the old
gp_inject_fault interface, so as to make it easy to replace the old interface
with the new one.

Re-ran the script with a small tweak which generated two more hits,
soon we should be caught up with all variations we have.

gpdb, we pre-execute init plan in ExecutorStart to reduce slice number.
However, for some initplans, which require params from the same level node,
should follow upstream execution flow.

To recognize this initplan's pattern, record `extParam` when creating
`subplan` object.

Fix issue: #6953

ExecChooseHashTableSize takes KB as parameter while global_work_mem returns bytes

Currently, ORCA does not emit LockRows plannode. So when
ORCA is enabled, we do not consider the query a simple
select-for-locking case.

If a test decides to fail because not all segments are running, it will
be nice to get the details of segments that are found to be not running.

The details printed by this patch will only be shown by behave upon a test
failure.  They will not be shown when a test passes.
Reviewed-by: NGeorgios Kokolatos <gkokolatos@pivotal.io>
Reviewed-by: NJacob Champion <pchampion@pivotal.io>
Reviewed-by: NDavid Krieger <dkrieger@pivotal.io>

When there are no bats testcases present, the current coding returned an
error due to the glob not being able to expand. This was made clear by
the recent removal of the last test, and the discussion in #8270. Rather
than using a glob, use ls and if statement. This allows us to keep the
unittest framework in place even if there are currently no tests.
Co-authored-by: NAmil Khanzada <akhanzada@pivotal.io>
Co-authored-by: NDaniel Gustafsson <dgustafsson@pivotal.io>

When reading the Behave test code for stopping segments, it is not obvious that
we are waiting for the segment to stop. Therefore we are explicitly adding the
`-w` flag to show the blocking behavior.
Co-authored-by: NNikolaos Kalampalikis <nkalampalikis@pivotal.io>

* Backport pg_strong_random

- Backport pg_strong_random related things from fe0a0b59.
  (https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=fe0a0b5993d)
  pg_strong_random() is added for better generation of random bytes.
  Only parts of fe0a0b59 has been ported back includes the c file and
  necessary makefile changes.

  By default, the function is enabled. It can be disabled by
  --disable-strong-random when configure.
  HAVE_STRONG_RANDOM is defined if the function is available.

- Backport a few OPENSSL related compile options from 680513ab.
  (https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=680513ab79c)
  This is to solve a few dependencies of pg_strong_random.
  A new macro USE_OPENSSL is introduced. It will be set to true when
  --with-openssl is configured. The old USE_SSL is still being used.
  When USE_OPENSSL defined, USE_SSL will be defined as well.

This is a dependency of #8211 for endpoint token generation.
Authored-by: NChen Mulong <muchen@pivotal.io>

Wait until we've inserted the fts_probe skip fault, AND we have
observed the fault being hit. This ensures that we've completed the
in-progress fts probe before continuing on with a test.

Previously, if we don't wait and our test continues forward to inject
a panic, then then in-progress fts probe would do its job and promote
the mirror.

We lower the minimum allowed gp_fts_probe_interval to 1 second, which
allows us to configure the interval to one second during our tests and
speeds up the tests significantly.
Reported-by: NAsim R P <apraveen@pivotal.io>

pstate->raw_buf_len should never be less than zero because it's the
length of unprocessed data in externalgettup_custom(). Add an assert to
make sure this.

We should probably try and get this one right.

This patch addresses two main scenarios:
1) Allowing multiple probes both internal and external to reuse the same
results when appropriate (ie: piggybacking on previous results). Multiple
requests should share the same results if they all request before the start of
a new fts loop, and after the results of the previous probe.

2) Ensuring fresh results from an external probe. When a request occurs during
a current probe in progress, this request should get fresh results rather
"piggybacking" or using the current results.

We use similar logic as the checkpointer code to detect whether a probe is in
progress with a probe start tick and probe end tick. To request a probe, we
send a signal requesting a fts results, then wait for a new loop to start,
then wait again for that current loop to finish. This implementation uses a
busy wait loop, which includes a short sleep. In the future, we can
leverage the upstream conditaion variable implementation which enables us
to signal multiple fts notify processes.
Co-authored-by: NSoumyadeep Chakraborty <sochakraborty@pivotal.io>
Co-authored-by: NKalen Krempely <kkrempely@pivotal.io>
Co-authored-by: NDavid Krieger <dkrieger@pivotal.io>
Co-authored-by: NTaylor Vesely <tvesely@pivotal.io>
Co-Authored-by: NAlexandra Wang <lewang@pivotal.io>
Co-Authored-by: NJimmy Yih <jyih@pivotal.io>

As a continued follow-up in the CVE-2018-1058, ensure that the utilities
that connect using PyGreSQL primitives also have search_path protection.

We set an empty search_path for the connection in all cases except for
segment_reconfigurer.py, where a fully-qualified SELECT statement seemed
sufficient (there is only one query being performed on the connection,
and that seems unlikely to change).
Co-authored-by: NJamie McAtamney <jmcatamney@pivotal.io>
Co-authored-by: NJacob Champion <pchampion@pivotal.io>
Co-authored-by: NShoaib Lari <slari@pivotal.io>

* Add docs for sslinfo contrib module

* Postgres -> Greenplum

* Add statement of non-differentiation

* Another postgresql -> Greenplum

* fix copy/paste error

* docs - updates and corrections to ALTER PARTITION clause of ALTER TABLE

-- Corrected ALTER PARTITION clause syntax
-- Clarified description for ALTER PARTITION clause.
-- Clarified information about altering partitions in Admin. Guide
-- Added example in Ref. Guide and Admin. Guide
-- Other minor edits.

* docs - edits based on review comments.

* docs - reorganize/reorder the reference guide topics

* remove Greenplum qualifier, edits requested by david

* remove Reference from sql commands, sys catalogs topic titles

The drop tablespace tests that introduce panics were not disabling
fts, which is a source of flakey tests.

Introduce a disable_fts() function that we can call before each
test. The fault reset at the end of each test will reenable fts for
the next test.

The tree I was working off clearly had stale files, which led me to
include two utils which were removed some time ago: gpcheckutil.py
and gpcheck.py. Remove these two from their respective Makefiles.

Also fix a Bash error in the Stream symlink test, the logoical AND
requires [[ .. ]]; rather than [ .. ];.

Both of these spotted while repeatedly running make install with
trees in various states.

We have a kind of query that its InitPlan execute in ExecutorStart.
If Explain Analyze this kind of query, as well as, some memory or disk
information requires to collect in the main plan, the QD will crash.
Since queryDesc->showstatctx->stats_gathered is assigned to true
in ExecSetParamPlan function before ExecutorRun, So we only gather
Initplan metrics and left other slices information over. Segment fault when
some execution node print out metrics message.

To fix this problem, variable stats_gathered only be assigned after slice 0
metrics information collection.

reproduce process:

create table t(a int);
explain analyze select a
from (
	select a
	from t
	where a > (
		select avg(a)
		from t
	)
) as foo
order by a
limit 1
fix issue:#6951

Reviewed-by: NDaniel Gustafsson <dgustafsson@pivotal.io>

- before this change, the guc would setup a pPostCreate hook to be run
  after the creation of a partition table, but we never actually read
  from that hook setting, so it is dead code.

ICG changes for commit "Add 4 xforms for LOJ index apply on dynamic table
scan"

These transforms existed for non-partition tables, but not for partition
tables.
Authored-by: NChris Hajas <chajas@pivotal.io>

Co-authored-by: NMelanie Plageman <mplageman@pivotal.io>

Static function and variables are unused for mock files and hence
generate warnings. Hence, ignore only those warnings.
Co-authored-by: NMelanie Plageman <mplageman@pivotal.io>

"-w" flag inhibits all warning messages. That's not ideal. Hence,
remove the flag.

Commit feb3a399 removed the example
postgresql_conf_gp_additions file for gpinitsystem, but the refactor
of the gpMgmt/bin Makefiles didn't get the memo as the file existed
when that work was done. Fix by removing the file to avoid warning
during make install.

The calculation for minimum amount of memory to memory intensive
operators was using kB for both input and output, leading to an
assertion failure in case the minimum memory requirement was less
than a kB. Since we are using a full uint64 for calculating, we
have room for using just bytes instead leaving the formatting to
the caller (which is just EXPLAIN ANALYZE).
Reviewed-by: NWeinan Wang <wewang@pivotal.io>

While hacking on another thing, I spotted that we had numerous lines
with tab + 1 space indentation, which is clearly wrong. Fix by using
just tab indentation as per the style guide.