1. 20 7月, 2006 3 次提交
  2. 19 7月, 2006 4 次提交
  3. 18 7月, 2006 1 次提交
    • T
      Make pg_regress a tad simpler and more general-purpose by removing its · 84e60427
      Tom Lane 提交于
      code to forcibly drop regressuser[1-4] and regressgroup[1-2].  Instead,
      let the privileges.sql test do that for itself (this is made easy by
      the recent addition of DROP ROLE IF EXISTS).  Per a recent patch proposed
      by Joachim Wieland --- the rest of his patch is superseded by the
      rewrite into C, but this is a good idea we should adopt.
      84e60427
  4. 14 7月, 2006 1 次提交
  5. 12 7月, 2006 1 次提交
  6. 06 7月, 2006 1 次提交
  7. 02 7月, 2006 2 次提交
    • N
      Do a pass of code review for the ALTER TABLE ADD INHERITS patch. Keep · 7fb9090e
      Neil Conway 提交于
      the read lock we hold on the table's parent relation until commit.
      Update equalfuncs.c for the new field in AlterTableCmd. Various
      improvements to comments, variable names, and error reporting.
      
      There is room for further improvement here, but this is at least
      a step in the right direction.
      7fb9090e
    • B
      ALTER TABLE ... ADD/DROPS INHERIT (actually INHERIT / NO INHERIT) · 8c092781
      Bruce Momjian 提交于
      Open items:
      
      There were a few tangentially related issues that have come up that I think
      are TODOs. I'm likely to tackle one or two of these next so I'm interested in
      hearing feedback on them as well.
      
      . Constraints currently do not know anything about inheritance. Tom suggested
        adding a coninhcount and conislocal like attributes have to track their
        inheritance status.
      
      . Foreign key constraints currently do not get copied to new children (and
        therefore my code doesn't verify them). I don't think it would be hard to
        add them and treat them like CHECK constraints.
      
      . No constraints at all are copied to tables defined with LIKE. That makes it
        hard to use LIKE to define new partitions. The standard defines LIKE and
        specifically says it does not copy constraints. But the standard already has
        an option called INCLUDING DEFAULTS; we could always define a non-standard
        extension LIKE table INCLUDING CONSTRAINTS that gives the user the option to
        request a copy including constraints.
      
      . Personally, I think the whole attislocal thing is bunk. The decision about
        whether to drop a column from children tables or not is something that
        should be up to the user and trying to DWIM based on whether there was ever
        a local definition or the column was acquired purely through inheritance is
        hardly ever going to match up with user expectations.
      
      . And of course there's the whole unique and primary key constraint issue. I
        think to get any traction at all on this you have a prerequisite of a real
        partitioned table implementation where the system knows what the partition
        key is so it can recognize when it's a leading part of an index key.
      
      Greg Stark
      8c092781
  8. 30 6月, 2006 1 次提交
  9. 27 6月, 2006 2 次提交
  10. 19 6月, 2006 1 次提交
    • T
      Increase timeout in statement_timeout test from 1 second to 2 seconds. · f1e671a0
      Tom Lane 提交于
      We have once or twice seen failures suggesting that control didn't get
      to the exception block before the timeout elapsed, which is unlikely
      but not impossible in a parallel regression test (with a dozen other
      backends competing for cycles).  This change doesn't completely prevent
      the problem of course, but it should reduce the probability enough that
      we don't see it anymore.  Per buildfarm results.
      f1e671a0
  11. 31 5月, 2006 1 次提交
    • T
      Code review for magic-block patch. Remove separate header file pgmagic.h, · e60cb3a3
      Tom Lane 提交于
      as this seems only likely to create headaches for module developers.  Put
      the macro in the pre-existing fmgr.h file instead.  Avoid being too cute
      about how many fields we can cram into a word, and avoid trying to fetch
      from a library we've already unlinked.
      Along the way, it occurred to me that the magic block really ought to be
      'const' so it can be stored in the program text area.  Do the same for
      the existing data blocks for PG_FUNCTION_INFO_V1 functions.
      e60cb3a3
  12. 30 5月, 2006 5 次提交
  13. 28 5月, 2006 2 次提交
    • A
      · 7a6676d9
      Andrew Dunstan 提交于
       fix typo
      7a6676d9
    • A
      · 3a9ae3d2
      Andrew Dunstan 提交于
      TG_table_name and TG_table_schema for plpgsql, plus docs and regression.
      3a9ae3d2
  14. 20 5月, 2006 1 次提交
  15. 12 5月, 2006 1 次提交
  16. 06 5月, 2006 2 次提交
  17. 02 5月, 2006 1 次提交
  18. 16 4月, 2006 1 次提交
    • T
      Support the syntax · 3651a3e6
      Tom Lane 提交于
      	CREATE AGGREGATE aggname (input_type) (parameter_list)
      along with the old syntax where the input type was named in the parameter
      list.  This fits more naturally with the way that the aggregate is identified
      in DROP AGGREGATE and other utility commands; furthermore it has a natural
      extension to handle multiple-input aggregates, where the basetype-parameter
      method would get ugly.  In fact, this commit fixes the grammar and all the
      utility commands to support multiple-input aggregates; but DefineAggregate
      rejects it because the executor isn't fixed yet.
      I didn't do anything about treating agg(*) as a zero-input aggregate instead
      of artificially making it a one-input aggregate, but that should be considered
      in combination with supporting multi-input aggregates.
      3651a3e6
  19. 07 4月, 2006 1 次提交
  20. 06 4月, 2006 1 次提交
    • T
      Fix a bunch of problems with domains by making them use special input functions · 7fdb4305
      Tom Lane 提交于
      that apply the necessary domain constraint checks immediately.  This fixes
      cases where domain constraints went unchecked for statement parameters,
      PL function local variables and results, etc.  We can also eliminate existing
      special cases for domains in places that had gotten it right, eg COPY.
      
      Also, allow domains over domains (base of a domain is another domain type).
      This almost worked before, but was disallowed because the original patch
      hadn't gotten it quite right.
      7fdb4305
  21. 03 4月, 2006 1 次提交
  22. 23 3月, 2006 2 次提交
  23. 19 3月, 2006 1 次提交
  24. 18 3月, 2006 1 次提交
    • T
      Fix bug introduced into mergejoin logic by performance improvement patch of · b3358e26
      Tom Lane 提交于
      2005-05-13.  When we find that a new inner tuple can't possibly match any
      outer tuple (because it contains a NULL), we can't immediately skip the
      tuple when we are in NEXTINNER state.  Doing so can lead to emitting
      multiple copies of the tuple in FillInner mode, because we may rescan the
      tuple after returning to a previous marked tuple.  Instead, proceed to
      NEXTOUTER state the same as we used to do.  After we've found that there's
      no need to return to the marked position, we can go to SKIPINNER_ADVANCE
      state instead of SKIP_TEST when the inner tuple is unmatchable; this
      preserves the performance improvement.  Per bug report from Bruce.
      I also made a couple of cosmetic code rearrangements and added a regression
      test for the problem.
      b3358e26
  25. 15 3月, 2006 2 次提交
    • T
      Missed this file in previous commit :-( · 35b55097
      Tom Lane 提交于
      35b55097
    • T
      Improve parser so that we can show an error cursor position for errors · 20ab467d
      Tom Lane 提交于
      during parse analysis, not only errors detected in the flex/bison stages.
      This is per my earlier proposal.  This commit includes all the basic
      infrastructure, but locations are only tracked and reported for errors
      involving column references, function calls, and operators.  More could
      be done later but this seems like a good set to start with.  I've also
      moved the ReportSyntaxErrorPosition logic out of psql and into libpq,
      which should make it available to more people --- even within psql this
      is an improvement because warnings weren't handled by ReportSyntaxErrorPosition.
      20ab467d