Signed-off-by: NLav Jain <ljain@pivotal.io>
Signed-off-by: NOleksandr Diachenko <odiachenko@pivotal.io>
Signed-off-by: NShivram Mani <smani@pivotal.io>
Signed-off-by: NJohn Gaskin <jgaskin@pivotal.io>
Signed-off-by: NAlexandra Wang <lewang@pivotal.io>

Signed-off-by: NNadeem Ghani <nghani@pivotal.io>

When you use gpconfig, users were forced to double quote the guc values.
For example:
    Prior:
       gpconfig -c pljava_classpath -v "'examples.jar'"

    Now:
       gpconfig -c pljava_classpath -v 'examples.jar' or gpconfig -c pljava_classpath -v examples.jar

Enhancement: Now all GUCs with vartype string will be wrapped in single
quotes before being written to the postgresql.conf.
Signed-off-by: NMarbin Tan <mtan@pivotal.io>

Now we support the resgroup memory_limit memory_shared_quota alteration
in below syntax:

	ALTER RESOURCE GROUP <group> SET MEMORY_SHARED_QUOTA <value>;
	ALTER RESOURCE GROUP <group> SET MEMORY_LIMIT <value>;

The new value may take effect immediately if the actual shared memory
usage is lower than the new value; otherwise it will delay the effect.
Signed-off-by: NHaisheng Yuan <hyuan@pivotal.io>

* resgroup: increase max slots for isolation tests.
* ICW: ignore resgroup related warnings.
* ICW: try to load resgroup variant of answers when resgroup enabled.
* ICW: provide resgroup variant of answers.
* ICW: check whether resqueue is enabled in UDF.
* ICR: substitude usrname in gpconfig output.
* ICR: explicitly set max_connections.
* isolation2: increase resgroup concurrency for max_concurrency tests.

We want to stop using gpfaultinjector utility in favor of using the
new gp_inject_fault extension. This commit creates the extension in
each test that requires it and replaces all uses of gpfaultinjector
utility with gp_inject_fault.

Authors: Abhijit Subramanya and Jimmy Yih

The MIRROREDLOCK macros in bufmgr.h referenced functions defined in
cdb/cdbfilerepprimary.h. Add an #include for that in bufmgr.h itself,
otherwise all the .c files that #include bufmgr.h and use those macros
need to include it.

Remove the now-unnecessary includes from .c files. This reduces our
diff footprint vs. upstream nicely.

The pattern of palloc'ing a Datum and isnull array is ubiquitous, no point
in hiding it behind a function, especially when the function only has one
caller.

When running gpconfig within the source code, you'll get the following:
$ ./gpMgmt/bin/gpconfig --help
  OptParser instance has no attribute 'helpStr'

fix this by initializing the help string list

These calls got lost during the 8.3 merge. There was a different mechanism
in GPDB earlier, to free these, and we replaced it with the upstream
mechanism in the merge, but missed these lines.

They were placed into wrong file.

This makes the code independent of the exact shape of pg_attribute. That
will save us some headaches when merging pg_attribute changes in the
future.

They were mostly marked as static in the prototype already, so this is just
for readability.

postgres.h is #included pretty much *everywhere*, so let's try to keep it
slim.

* SyncAgentMain function doesn't exist, so just remove its prototype.
* CdbProgramerrorHandler is only used in postgres.c, so make it static.
* Move gp_set_thread_sigmasks into miscadmin.h, where the prototypes for
  other functions in tcop/postgres.c are.

It compiles an old tag of gpdb for binary swap comparison testing
- It shouldn't go red
- It doesn't trigger on gpdb_src; often is just a stable cache

New jobs should also be added to the "All" group, but we expect that
there may be exceptions and it's not a dealbreaker

If the reusable anchors are declared at the end, some yaml parsers may
have trouble reading the file. In this case, pyyaml was throwing:

```
yaml.composer.ComposerError: found undefined alias 'ccp_create_params'
  in "<string>", line 702, column 11:
          <<: *ccp_create_params
              ^
```

We set CDB_PALLOC_TAGS regardless of USE_ASSERT_CHECKING on 81627e27. This bloated chunk header in release build, resulting in significantly more memory consumption in certain cases.

In this PR we are restoring the original behavior by setting CDB_PALLOC_TAGS only when USE_ASSERT_CHECKING is set. We are also removing unused code.
Signed-off-by: NFoyzur Rahman <foyzur@gmail.com>

* DOCS: un-deprecating gpmapreduce and associated yaml spec

* Add heap checksums to gpinitsystem ref and GUC reference

* Replace heap_checksums with data_checksomes

This cuts down the size of each test program from about 45 MB to 41 MB on
my laptop, with debug-enabled builds. That should help to speed up the tests
a little bit.

One less test program makes the tests to go a tiny bit faster. This also
tests more directly the problem with the GUCs that the low-level function
was added for, rather than the low-level function.

Arguably we don't need a test for any of this at all anymore, as this fix
for the ALTER USER RESET ALL bug was backported from PostgreSQL a long time
ago, but at this point, we have caught up with that PostgreSQL code and
the GPDB code is identical to the upstream. But OTOH, it's easy and quick to
test as a pg_regress test, so might as well.

Record the version in configure.in for releases which are not full
Git trees.

resource group tests are messing up isolation2 directory, this commits
move them all to the same directory to be tidy and organized, it also
handle the sub directory in input/output directory for resgroup.

* DOCS: PostGIS docs - add new install script information

* Updates from review.

* Preliminary changes for COPY FROM ON SEGMENT

* Rework note on redistributing data

* codeph tags

* Review input

* STDIN/STDOUT with ON SEGMENT nonsupport

* Edits from David

Signed-off-by: NChris Hajas <chajas@pivotal.io>

Signed-off-by: NXin Zhang <xzhang@pivotal.io>

Occationally, the test failed saying syntax error of pg_terminate_backend, due
to the bug in test fetching multiple procpid if there are multiple `create temp
table t%` statements, which do happen occationally with ORCA on separate
slices.

The fix is to always pick the oldest procpid, and also double check the process
is the one test started. We are leveraging the new feature in
pg_terminate_backend to provide additional message to verify the proper process
is terminated.
Signed-off-by: NXin Zhang <xzhang@pivotal.io>
Signed-off-by: NJacob Champion <pchampion@pivotal.io>