- 20 3月, 2018 2 次提交
-
-
由 Ashwin Agrawal 提交于
-
由 Ashwin Agrawal 提交于
Mirror is provided with grace period before being marked as down. FTS probes during this grace period interval, return retryRequested to probe request. Based on `retryRequested` should retry probes to primary and incase number of retries reach retry limit of `gp_fts_probe_retries` must skip marking such mirror down as still primary has not given go ahead to mark it down. Only when `retryRequested=false`, mirror must be marked down.
-
- 17 3月, 2018 2 次提交
-
-
由 Jimmy Yih 提交于
The fixme comment was placed here to warn that the implementation might be backwards on Greenplum 4.X and 5.X. The concern is not valid for Greenplum 4.X because there is no lazy xids. However, the concern is indeed valid for Greenplum 5.x. This is noted and will be changed on the 5X_STABLE branch. [ci skip]
-
由 Ekta Khanna 提交于
Prior to GPORCA version 2.55.10, ORCA produced a plan with Redistribute Motion on the hstore attribute(which is not a "GPDB hashable" type). This caused queries to fail with the error like: ERROR: Type 40963 is not hashable. This FIXME was added in `contrib/hstore/sql/hstore.sql` to run such failing queries with planner. Since the issue has been fixed in ORCA, removing it.
-
- 16 3月, 2018 17 次提交
-
-
由 Daniel Gustafsson 提交于
cache_test_acquire was incorrectly spelled in the test definition struct making it hard to run as a single test (without using the same typo).
-
由 Heikki Linnakangas 提交于
The code was quite confused on whether this was a switch-case or an if-else statement.. The command tag is unfortunately not included in pg_regress output, so this is not reflected in regression tests, even though we have ALTER EXTERNAL TABLE commands in the test suite. Fixes github issue #4377.
-
由 Heikki Linnakangas 提交于
This function was made unnecessary by commit b3f300b9, which changed GetOldestXmin() to "include" any distributed snapshots, too. rewriteheap.c no longer changes the freezeXid it's given, so there's no need for a function to get the new value back from it.
-
由 Heikki Linnakangas 提交于
We had removed these earlier, when we didn't have GIN indexes. Now we do.
-
由 Jimmy Yih 提交于
This argument was introduced when master/standby WAL replication was implemented to handle persistent table cases. Since persistent tables have been removed, we no longer need this argument to mdtruncate. This takes care of a GPDB_84_MERGE_FIXME.
-
由 Taylor Vesely 提交于
This reverts commit a21da89e. These changes are obsolete now that persistent tables have been removed. Co-authored-by: NAsim R P <apraveen@pivotal.io>
-
由 Jacob Champion 提交于
When upgrading to 8.4, upstream's pg_upgrade refuses to copy old sequence data due to a change in columns. However, that check also prevented copying of sequence data during an 8.2->8.3 upgrade -- Postgres doesn't care about this case, but GPDB does. Don't omit the copy if we're upgrading to 8.3, and enable the 8.2 heap upgrade for sequence tables so that the page makes sense in the new database.
-
由 Jacob Champion 提交于
Follow-up to 71916050. Checksums were backported to Postgres 8.3, so we ignore them for <= 8.2. While we're at it, switch the data_checksum_version from a false assignment to a zero assignment, to match upstream. The actual implementation is an unsigned int; Postgres master incorrectly uses a bool type in the declaration.
-
由 Jacob Champion 提交于
Follow-up to e8de956e. Correct the GPDB 5 check to use Postgres 8.3's version number, and correctly return the cached value from the GPDB 4 check.
-
由 Asim R P 提交于
This state was meant to prevent auxiliary processes from waiting from syncrep. As far as we can tell, auxiliary process should not be calling SyncRepWaitForLSN() unless it is committing a transaction. And if it is committing a transaction, it better wait for mirror to flush XLOG upto the commit LSN. One example of an auxiliary process committing a transaction is FTS, when it updates cluster configuration on master. Co-authored-by: NTaylor Vesely <tvesely@pivotal.io>
-
由 Lisa Owen 提交于
* docs - add pxf developer topics (release 1) * misc edits * add pxf dev topics to oss book subnav * misc edits from david
-
由 Lisa Owen 提交于
docs - perms for hdfs files backing pxf ext tbls are for gp user. This closes #4692 and #4667 (#4676) * docs - perms for hdfs files backing pxf ext tbls are for gp user * correct pxf stop instructions * reword pxf stop intro * address comments from alex * lowercase a Y
-
由 Shreedhar Hardikar 提交于
These were related to chosing the right arguments to send to GPDB's make_agg() and cost_agg() methods for queries containing DISTINCT or set operations. Hash aggregation when used to implement a DISTINCT (in either form) in the query is not related to grouping sets and thus the argments to num_nullcols, input_grouping, grouping and rollup_gs_times should be 0. However, since SetOp uses the upstream TupleHashTable while HashAgg uses GPDB's HHashTable implementation, the hash table size calculations should be computed differently. This is fixed in this commit Signed-off-by: NSambitesh Dash <sdash@pivotal.io>
-
由 Heikki Linnakangas 提交于
They've been unused for as long as I can see.
-
由 Jimmy Yih 提交于
There was a GPDB_84_MERGE_FIXME regarding whether or not an extra lock was needed when getting the list of child partitions during CREATE INDEX. We already have the lock on the root partition which prevents any ALTER TABLE operations from changing the child partition list. Because of that, an extra lock is not required. [ci skip]
-
由 Haisheng Yuan 提交于
Commit 087bf2e8 made big change on the "equivalence classes" mechanism. Unfortunately, when it compares the expression equality in function 'get_eclass_for_sort_expr', it doesn't strip out the 'relabel' node. GPDB may automatically add a relabel node(or cast it) for binary-coercible type, like varchar to text, which causes planner to generate bad plan to broadcast or redistribute the table that is already distributed by the join key, due to the inablity to match the equivalence class in the function. The issue has been fixed by stripping out the relabel node when matching.
-
由 Ashwin Agrawal 提交于
Can't find rational for perfmoring strict checks on which all faults are supported for skip fault. Skip fault type is like any other fault type should just work for any fault, shouldn't be treated specially. Having this checking just needs extra place to update for any type wish to use skip fault.
-
- 15 3月, 2018 12 次提交
-
-
由 Jacob Champion 提交于
As attribute types change, tables that were not toastable in previous GPDB versions may become toastable, and we won't have a preassigned OID ready to go. Deal with this by assigning a new one on the fly.
-
由 Jacob Champion 提交于
During 4-to-5 upgrades, we won't have the OIDs for rowtype arrays already preassigned and need to generate them on the fly. A couple of calls to GetPreassignedOidForType() were prepared for this and checked for a returned InvalidOid, but commit f51f2f57 forced missing OIDs to throw an ERROR instead of returning. For these cases, add a new parameter that allows InvalidOid to be returned if the caller is prepared to handle it.
-
由 Jacob Champion 提交于
Follow-up to 4f4e5a5c. In GPDB 4, the ON clause information is stored in pg_exttable.location, not .command.
-
由 Jacob Champion 提交于
The values array was being double-freed, causing a crash.
-
由 Jimmy Yih 提交于
The gpcheckmirrorseg.pl script was a tool that was heavily used for checking primary/mirror consistency when we had file replication. File replication has been replaced with WAL replication and a separate tool, gp_replica_check, which uses the actual internal masking functions has already been created and in use in installcheck-world. We no longer need gpcheckmirrorseg.pl so let's remove it. This also removes a GPDB_84_MERGE_FIXME.
-
由 Todd Sedano 提交于
gpbackup and gpmigrate need the GOPATH to be set to the standard GOPATH gpupgrade uses direnv to successfully set a custom GOPATH
-
由 Abhijit Subramanya 提交于
Remove the 8.4 merge fixme for window function related tests. Before the merge, ORCA and planner would both error out if the aggregate used in the window did not have preliminary functions associated with it. After the merge, ORCA still falls back to the planner, but the planner produces the correct plan.
-
由 sambitesh 提交于
-
由 Sambitesh Dash 提交于
Earlier we were accounting for `optimizer_nestloop_factor` while translating back from DXL in GPDB side in COptTasks::SetCostModelParams. Now it is being taken care in GPORCA side. Signed-off-by: NBhuvnesh Chaudhary <bchaudhary@pivotal.io>
-
由 Kevin Yeap 提交于
Co-authored-by: NJamie McAtamney <jmcatamney@pivotal.io> Co-authored-by: NKevin Yeap <kyeap@pivotal.io> Co-authored-by: NShoaib Lari <slari@pivotal.io> (cherry picked from commit ed48879627686b36336529d0b445073687ec68cd)
-
- 14 3月, 2018 7 次提交
-
-
由 Lisa Owen 提交于
-
由 Ashwin Agrawal 提交于
Co-authored-by: NAshwin Agrawal <aagrawal@pivotal.io> Co-authored-by: NXin Zhang <xzhang@pivotal.io>
-
由 Daniel Gustafsson 提交于
Commit ba5cfa93 introduced the upstream code for managing timezones, but it failed to include the the below diff to initdb for moving timezone handling from the postmaster to initdb. This is a partial backport of the below commit, some hunks didn't apply because due to requiring code introduced in PostgreSQL 9.1 and 9.2. commit ca4af308 Author: Tom Lane <tgl@sss.pgh.pa.us> Date: Fri Sep 9 17:59:11 2011 -0400 Simplify handling of the timezone GUC by making initdb choose the default. We were doing some amazingly complicated things in order to avoid running the very expensive identify_system_timezone() procedure during GUC initialization. But there is an obvious fix for that, which is to do it once during initdb and have initdb install the system-specific default into postgresql.conf, as it already does for most other GUC variables that need system-environment-dependent defaults. This means that the timezone (and log_timezone) settings no longer have any magic behavior in the server. Per discussion.
-
由 David Kimura 提交于
We validated a hidden feature of CREATE TYPE which allows users to create append only column oriented encoding defaults for user defined types. It still works after the 9.0 merge. Discussed on gpdb-dev: https://groups.google.com/a/greenplum.org/forum/#!topic/gpdb-dev/gYuBL-Fk8rMCo-authored-by: NJimmy Yih <jyih@pivotal.io> Co-authored-by: NDavid Kimura <dkimura@pivotal.io>
-
由 Ekta Khanna 提交于
While Bumping ORCA version in commit d8bb2aeb incorrectly updated the binary from `bin_orca_centos5_release.tar.gz` to `bin_orca_centos6_release.tar.gz`. Reverting back binary name to `bin_orca_centos5_release.tar.gz`
-
由 Ekta Khanna 提交于
-
由 dyozie 提交于
-