1. 25 1月, 1999 3 次提交
  2. 24 1月, 1999 7 次提交
  3. 23 1月, 1999 3 次提交
  4. 22 1月, 1999 8 次提交
    • M
      · 8135140a
      Marc G. Fournier 提交于
      |From: "D'Arcy" "J.M." Cain <darcy@druid.net>
      |
      |The following patch just prevents a warning from being generated because
      |the data type isn't specified.
      8135140a
    • B
      It seems that SPI_prepare() doesn't work well in some cases. · 03155dc7
      Bruce Momjian 提交于
      Pawel Pierscionek [pawel@astercity.net] reported about the
      following case 1([SQL] drop table in pgsql).
      Michael Contzen [mcontzen@dohle.com] reported about the
      following case 2(PL/PGSQL bug using aggregates).
      You can find it from pgsql-hackers archive.
      
      1. PL/pgSQL can't execute UTILITY commands.
         SPI_prepare() doesn't copy(save) the utilityStmt member of
         Query type nodes,because copyObject() is not implemented
         for nodes of (Create/Destroy etc)Stmt type.
      
      2. Aggregates in PL/pgSQL cause wrong results.
      
      ...
         It's a list including Aggreg type nodes which exist in
         TargetList(i.e Aggreg type nodes are common to aggs
         member list and TargetList).
         AFAIC the common pointer is not copied to the same
         pointer by copyObject() function.
         In my patch I reconstruct aggs member node from
         new(copied) Agg type node.
         Is it proper to use set_agg_tlist_references() function to
         reconstruct aggs member node for Agg type nodes ?
      
      Thanks.
      
      Hiroshi Inoue
      Inoue@tpf.co.jp
      03155dc7
    • B
      Here is a new version of my patch for allowing pg_dump to DROP schema · 289a826d
      Bruce Momjian 提交于
      elements prior to CREATEing new ones.  It is under control of the -c
      command line option (with the default being status quo).
      
      The DROP TRIGGER portion still needs implementation.  Anyone able to
      help clarify what exactly the CREATE TRIGGER portion does so I can fix
      this?
      
      Again, I have tried this with tables/indexes/sequences, but do not
      have other schema elements in my database.  As a result, I am not 100%
      convinced that I got the syntax correct in all cases (but think I did,
      nonetheless).  If anyone can check the other cases, I'd appreciate it.
      
      Cheers,
      Brook
      
      [I added manual page and sgml additions for the new -c option.]
      289a826d
    • B
      The following patch finishes primary key support. Previously, when · c91dbcc5
      Bruce Momjian 提交于
      a field was labelled as a primary key, the system automatically
      created a unique index on the field.  This patch extends it so
      that the index has the indisprimary field set.  You can pull a list
      of primary keys with the followiing select.
      
      SELECT pg_class.relname, pg_attribute.attname
          FROM pg_class, pg_attribute, pg_index
          WHERE pg_class.oid = pg_attribute.attrelid AND
              pg_class.oid = pg_index.indrelid AND
              pg_index.indkey[0] = pg_attribute.attnum AND
              pg_index.indisunique = 't';
      
      There is nothing in this patch that modifies the template database to
      set the indisprimary attribute for system tables.  Should they be
      changed or should we only be concerned with user tables?
      
      D'Arcy
      c91dbcc5
    • B
      i have made minor changes to array_iterator to make it work with · 7311da9e
      Bruce Momjian 提交于
      pgsql-6.3.2. I think array_iterator is a great thing to have!!!
      
      With best regards,
      
      
      Tobias Gabele
      7311da9e
    • M
      · cdbaec77
      Marc G. Fournier 提交于
      From: Michael Meskes <Michael.Meskes@usa.net>
      
      See attached file. Now accepts "exec sql whenever sqlwarning".
      cdbaec77
    • V
      Copy RowMark node (it's for (-:)) FOR UPDATE). · 1f379056
      Vadim B. Mikheev 提交于
      1f379056
    • V
      FOR UPDATE is in parser & rules. · 12be3e08
      Vadim B. Mikheev 提交于
      12be3e08
  5. 21 1月, 1999 5 次提交
  6. 20 1月, 1999 5 次提交
  7. 19 1月, 1999 1 次提交
    • B
      Okay, I've updated the ecpg parser yet again. Unfortunately it has one · 0347dcc8
      Bruce Momjian 提交于
      remaining shift/reduce conflict. But the very same conflict is in gram.y, so
      I don't dig into it very much now.
      
      Anyway, I just saw that there were minor changes made to ecpg by others. Now
      I like that but I would prefer if I was told about that. Otherwise my
      version numbering and Changelog maintaining might break. Or simply change
      these too. :-)
      
      Also I had to add #include <errno.h> to  backend/libpq/pqcomprim.c to be
      able to compile postgresql.
      
      Patch is attached. Since my resubscription process is still not finished
      yet, I still send them here.
      
      Michael
      0347dcc8
  8. 18 1月, 1999 8 次提交
    • B
      Add missing Windows files. · 909c5197
      Bruce Momjian 提交于
      909c5197
    • B
      Fix cfor typos. · d3423daa
      Bruce Momjian 提交于
      d3423daa
    • B
      Fix for typo in gram.y · fd7b9633
      Bruce Momjian 提交于
      fd7b9633
    • B
      Add masters thesis to docs. · be321b74
      Bruce Momjian 提交于
      be321b74
    • B
      Hi! · bd8ffc6f
      Bruce Momjian 提交于
      INTERSECT and EXCEPT is available for postgresql-v6.4!
      
      The patch against v6.4 is included at the end of the current text
      (in uuencoded form!)
      
      I also included the text of my Master's Thesis. (a postscript
      version). I hope that you find something of it useful and would be
      happy if parts of it find their way into the PostgreSQL documentation
      project (If so, tell me, then I send the sources of the document!)
      
      The contents of the document are:
        -) The first chapter might be of less interest as it gives only an
           overview on SQL.
      
        -) The second chapter gives a description on much of PostgreSQL's
           features (like user defined types etc. and how to use these features)
      
        -) The third chapter starts with an overview of PostgreSQL's internal
           structure with focus on the stages a query has to pass (i.e. parser,
           planner/optimizer, executor). Then a detailed description of the
           implementation of the Having clause and the Intersect/Except logic is
           given.
      
      Originally I worked on v6.3.2 but never found time enough to prepare
      and post a patch. Now I applied the changes to v6.4 to get Intersect
      and Except working with the new version. Chapter 3 of my documentation
      deals with the changes against v6.3.2, so keep that in mind when
      comparing the parts of the code printed there with the patched sources
      of v6.4.
      
      Here are some remarks on the patch. There are some things that have
      still to be done but at the moment I don't have time to do them
      myself. (I'm doing my military service at the moment) Sorry for that
      :-(
      
      -) I used a rewrite technique for the implementation of the Except/Intersect
         logic which rewrites the query to a semantically equivalent query before
         it is handed to the rewrite system (for views, rules etc.), planner,
         executor etc.
      
      -) In v6.3.2 the types of the attributes of two select statements
         connected by the UNION keyword had to match 100%. In v6.4 the types
         only need to be familiar (i.e. int and float can be mixed). Since this
         feature did not exist when I worked on Intersect/Except it
         does not work correctly for Except/Intersect queries WHEN USED IN
         COMBINATION WITH UNIONS! (i.e. sometimes the wrong type is used for the
         resulting table. This is because until now the types of the attributes of
         the first select statement have been used for the resulting table.
         When Intersects and/or Excepts are used in combination with Unions it
         might happen, that the first select statement of the original query
         appears at another position in the query which will be executed. The reason
         for this is the technique used for the implementation of
         Except/Intersect which does a query rewrite!)
         NOTE: It is NOT broken for pure UNION queries and pure INTERSECT/EXCEPT
               queries!!!
      
      -) I had to add the field intersect_clause to some data structures
         but did not find time to implement printfuncs for the new field.
         This does NOT break the debug modes but when an Except/Intersect
         is used the query debug output will be the already rewritten query.
      
      -) Massive changes to the grammar rules for SELECT and INSERT statements
         have been necessary (see comments in gram.y and documentation for
         deatails) in order to be able to use mixed queries like
         (SELECT ... UNION (SELECT ... EXCEPT SELECT)) INTERSECT SELECT...;
      
      -) When using UNION/EXCEPT/INTERSECT you will get:
         NOTICE: equal: "Don't know if nodes of type xxx are equal".
         I did not have  time to add comparsion support for all the needed nodes,
         but the default behaviour of the function equal met my requirements.
         I did not dare to supress this message!
      
         That's the reason why the regression test for union will fail: These
         messages are also included in the union.out file!
      
      -) Somebody of you changed the union_planner() function for v6.4
         (I copied the targetlist to new_tlist and that was removed and
         replaced by a cleanup of the original targetlist). These chnages
         violated some having queries executed against views so I changed
         it back again. I did not have time to examine the differences between the
         two versions but now it works :-)
         If you want to find out, try the file queries/view_having.sql on
         both versions and compare the results . Two queries won't produce a
         correct result with your version.
      
      regards
      
          Stefan
      bd8ffc6f
    • T
      Clean up trivial compiler warning from gcc. · 52065cf3
      Tom Lane 提交于
      52065cf3
    • T
      Reverse out yesterday's patch from Horak Daniel, since · d1a391c3
      Tom Lane 提交于
      it fails to compile on any machine without a <features.h> header.
      If this header is actually necessary on Windows, perhaps an #if test
      is in order.
      d1a391c3
    • T
      Keep Tcl from getting confused if backend closes connection · be94d8fb
      Tom Lane 提交于
      when a notify is installed.
      be94d8fb