- 28 2月, 2011 3 次提交
-
-
由 Peter Eisentraut 提交于
We don't have complete expected coverage for Python 2.2 anyway, so it doesn't seem worth keeping this one around that no one appears to be updating anyway. Visual inspection of the differences ought to be good enough for those few who care about this obsolete Python version.
-
由 Tom Lane 提交于
The originally committed patch for modifying CTEs didn't interact well with EXPLAIN, as noted by myself, and also had corner-case problems with triggers, as noted by Dean Rasheed. Those problems show it is really not practical for ExecutorEnd to call any user-defined code; so split the cleanup duties out into a new function ExecutorFinish, which must be called between the last ExecutorRun call and ExecutorEnd. Some Asserts have been added to these functions to help verify correct usage. It is no longer necessary for callers of the executor to call AfterTriggerBeginQuery/AfterTriggerEndQuery for themselves, as this is now done by ExecutorStart/ExecutorFinish respectively. If you really need to suppress that and do it for yourself, pass EXEC_FLAG_SKIP_TRIGGERS to ExecutorStart. Also, refactor portal commit processing to allow for the possibility that PortalDrop will invoke user-defined code. I think this is not actually necessary just yet, since the portal-execution-strategy logic forces any non-pure-SELECT query to be run to completion before we will consider committing. But it seems like good future-proofing.
-
由 Bruce Momjian 提交于
output of actual Postgres parameter _values_ related to shared memory, and suggesting that these are only possible parameters to reduce.
-
- 27 2月, 2011 6 次提交
-
-
由 Magnus Hagander 提交于
Josh Kupershmidt
-
由 Bruce Momjian 提交于
per suggestion from Andrew.
-
由 Heikki Linnakangas 提交于
sender is immediately woken up by transaction commit, there's no need to wake up so aggressively.
-
由 Andrew Dunstan 提交于
-
由 Bruce Momjian 提交于
pg_attribute.attoptions.
-
由 Bruce Momjian 提交于
-
- 26 2月, 2011 6 次提交
-
-
由 Peter Eisentraut 提交于
This allows functions with multiple OUT parameters returning both one or multiple records (RECORD or SETOF RECORD). Jan Urbański, reviewed by Hitoshi Harada
-
由 Bruce Momjian 提交于
-
由 Tom Lane 提交于
We need ExecutorEnd to run the ModifyTable nodes to completion in reverse order of initialization, not forward order. Easily done by constructing the list back-to-front.
-
由 Tom Lane 提交于
This patch implements data-modifying WITH queries according to the semantics that the updates all happen with the same command counter value, and in an unspecified order. Therefore one WITH clause can't see the effects of another, nor can the outer query see the effects other than through the RETURNING values. And attempts to do conflicting updates will have unpredictable results. We'll need to document all that. This commit just fixes the code; documentation updates are waiting on author. Marko Tiikkaja and Hitoshi Harada
-
由 Alvaro Herrera 提交于
Per comment from Tom
-
由 Alvaro Herrera 提交于
HeapTupleHeader's t_infomask and t_infomask2 are defined as 16-bit unsigned integers, so when the 16th bit was set, heap_page_item was returning them as negative values, which was ugly. The change to pageinspect--unpackaged--1.0.sql allows a module upgraded from 9.0 to be cleanly updated from the previous definition.
-
- 25 2月, 2011 1 次提交
-
-
由 Robert Haas 提交于
Emit a log message when creating a named restore point, and improve documentation for pg_create_restore_point(). Euler Taveira de Oliveira, per suggestions from Thom Brown, with some additional wordsmithing by me.
-
- 24 2月, 2011 2 次提交
-
-
由 Itagaki Takahiro 提交于
- ALTER FOREIGN DATA WRAPPER with HANDLER - ALTER TABLE VALIDATE CONSTRAINT - ALTER TYPE ADD VALUE - COPY with ENCODING and FORCE NOT NULL - CREATE FOREIGN DATA WRAPPER with HANDLER - CREATE TRIGGER ... INSTEAD OF
-
由 Itagaki Takahiro 提交于
and fix unexpected completion for DROP TEMP and UNIQUE.
-
- 23 2月, 2011 6 次提交
-
-
由 Bruce Momjian 提交于
can have duplicates, per request from Tom.
-
由 Itagaki Takahiro 提交于
-
由 Tom Lane 提交于
The recent additions for FDW support required checking foreign-table-ness in several places in the parse/plan chain. While it's not clear whether that would really result in a noticeable slowdown, it seems best to avoid any performance risk by keeping a copy of the relation's relkind in RangeTblEntry. That might have some other uses later, anyway. Per discussion.
-
由 Peter Eisentraut 提交于
Add functions plpy.quote_ident, plpy.quote_literal, plpy.quote_nullable, which wrap the equivalent SQL functions. To be able to propagate char * constness properly, make the argument of quote_literal_cstr() const char *. This also makes it more consistent with quote_identifier(). Jan Urbański, reviewed by Hitoshi Harada, some refinements by Peter Eisentraut
-
由 Robert Haas 提交于
"SELECT ... INTO UNLOGGED tabname" works, but wasn't documented; CREATE UNLOGGED SEQUENCE and CREATE UNLOGGED VIEW failed an assertion, instead of throwing a sensible error. Latter issue reported by Itagaki Takahiro; patch review by Tom Lane.
-
由 Tom Lane 提交于
void_send is useful for the same reason that void_out doesn't throw error, namely that someone might do "select void_returning_func(...)" from a client that prefers to operate in binary mode. The void_recv function may or may not have any practical use, but we provide it for symmetry. Radosław Smogura
-
- 22 2月, 2011 4 次提交
-
-
由 Bruce Momjian 提交于
-
由 Tom Lane 提交于
This was a leftover from the pre-8.1 design of junkfilters. It doesn't seem to have any reason to live, since it's merely a combination of two easy function calls, and not a well-designed combination at that (it encourages callers to leak the result tuple).
-
由 Tom Lane 提交于
ExecUpdate checked for whether ExecBRUpdateTriggers had returned a new tuple value by seeing if the returned tuple was pointer-equal to the old one. But the "old one" was in estate->es_junkFilter's result slot, which would be scribbled on if we had done an EvalPlanQual update in response to a concurrent update of the target tuple; therefore we were comparing a dangling pointer to a live one. Given the right set of circumstances we could get a false match, resulting in not forcing the tuple to be stored in the slot we thought it was stored in. In the case reported by Maxim Boguk in bug #5798, this led to "cannot extract system attribute from virtual tuple" failures when trying to do "RETURNING ctid". I believe there is a very-low-probability chance of more serious errors, such as generating incorrect index entries based on the original rather than the trigger-modified version of the row. In HEAD, change all of ExecBRInsertTriggers, ExecIRInsertTriggers, ExecBRUpdateTriggers, and ExecIRUpdateTriggers so that they continue to have similar APIs. In the back branches I just changed ExecBRUpdateTriggers, since there is no bug in the ExecBRInsertTriggers case.
-
由 Bruce Momjian 提交于
information schema documentation because it affects several tables.
-
- 21 2月, 2011 6 次提交
-
-
由 Bruce Momjian 提交于
-
由 Itagaki Takahiro 提交于
-
由 Itagaki Takahiro 提交于
File encodings can be specified separately from client encoding. If not specified, client encoding is used for backward compatibility. Cases when the encoding doesn't match client encoding are slower than matched cases because we don't have conversion procs for other encodings. Performance improvement would be be a future work. Original patch by Hitoshi Harada, and modified by me.
-
由 Bruce Momjian 提交于
-
由 Tom Lane 提交于
Alexander Korotkov
-
由 Tom Lane 提交于
This is both very useful in its own right, and an important test case for the core FDW support. This commit includes a small refactoring of copy.c to expose its option checking code as a separately callable function. The original patch submission duplicated hundreds of lines of that code, which seemed pretty unmaintainable. Shigeru Hanada, reviewed by Itagaki Takahiro and Tom Lane
-
- 20 2月, 2011 4 次提交
-
-
由 Tom Lane 提交于
This commit provides the core code and documentation needed. A contrib module test case will follow shortly. Shigeru Hanada, Jan Urbanski, Heikki Linnakangas
-
由 Bruce Momjian 提交于
avg() because it was inaccurate.
-
由 Bruce Momjian 提交于
Marko Kreen
-
由 Bruce Momjian 提交于
from information_schema.referential_constraints might return several in Postgres because we allow duplicate-named constraints in the same schema.
-
- 19 2月, 2011 2 次提交
-
-
由 Peter Eisentraut 提交于
type changes. The invalidation will cause the type information to be refetched, and everything will work. Jan Urbański, reviewed by Alex Hunsaker
-
由 Bruce Momjian 提交于
-