Signed-off-by: NChris Hajas <c.hajas@pivotal.io>

* add behave test for diskspace_history
* remove commented-out test (moved to new tracker story to redo)
* refactor test for qamode
Signed-off-by: NC.J. Jameson <cjameson@pivotal.io>

Signed-off-by: NMarbin Tan <mtan@pivotal.io>
Signed-off-by: NC.J. Jameson <cjameson@pivotal.io>

- We think that external tables previously broke with newlines. This is
  no longer the case, so removing space replacement logic.
Signed-off-by: NMarbin Tan <mtan@pivotal.io>
Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

Signed-off-by: NMelanie Plageman <mplageman@pivotal.io>

Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

Modify previous behave tests to address test flakiness
-- Use gpstop instead of pkill
-- Reduce min_query_time to 0
Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

Signed-off-by: NMelanie Plageman <mplageman@pivotal.io>

On our normal workstations, gpsmon comes up within 5 seconds very
consistently, but in other environments, it might need more time
Signed-off-by: NC.J. Jameson <cjameson@pivotal.io>

These were missed from commit 8e02d076.
Also removes backup files from /tmp directory.

Authors: Karen Huddleston and Chris Hajas

These were creating complex DDL that is covered by other tests. This shortens the suite by ~5 minutes.

-- add README for macOS build and configuration notes
Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

This is tested in the C unit tests already.

Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

A lot of tests assumed OID == relfilenode. We updated the tests to not assume
that anymore.

Signed-off-by: NChris Hajas <chajas@pivotal.io>

* Rewrite Kerberos test suite

* Remove obsolete Kerberos test stuff from pipeline and TINC

We now have a rewritten Kerberos test script in installcheck-world.

* Update ICW kerberos test to run on concourse container

This adds a whole new test script in src/test/regress, implemented in plain bash. It sets up temporary a KDC as part of the script, and doesn't therefore rely on a pre-existing Kerberos server, like the old MU_kerberos-smoke test job did. It does require MIT Kerberos server-side utilities to be installed, instead, but no server needs to be running, and no superuser privileges are required.

This supersedes the MU_kerberos-smoke behave tests. The new rewritten bash script tests the same things:
  1. You cannot connect to the server before running 'kinit' (to verify that the server doesn't just let anyone in, which could happen if the pg_hba.conf is misconfigured for the test, for example)
  2. You can connect, after running 'kinit'
  3. You can no longer connect, if the user account is expired

The new test script is hooked up to the top-level installcheck-world target.

There were also some Kerberos-related tests in TINC. Remove all that, too. They didn't seem interesting in the first place, looks like they were just copies of a few random other tests, intended to be run as a smoke test, after a connection had been authenticated with Kerberos, but there was nothing in there to actually set up the Kerberos environment in TINC.

Other minor patches added:

* Remove absolute path when calling kerberos utilities
-- assume they are on path, so that they can be accessed from various installs
-- add clarification message if sample kerberos utility is not found with 'which'

* Specify empty load library for kerberos tools

* Move kerberos test to its own script file
-- this allows a failure to be recorded without exiting Make, and
therefore the server can be turned off always

* Add trap for stopping kerberos server in all cases
* Use localhost for kerberos connection
Signed-off-by: NMarbin Tan <mtan@pivotal.io>
Signed-off-by: NChumki Roy <croy@pivotal.io>
Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

This reverts commit b20a3f92 and 37cdd250
since the gptransfer suite is failing.

This was missed in b20a3f92

Signed-off-by: NChumki Roy <croy@pivotal.io>

Instead of simply printing which files are different, print the contents
of the diff files.

This commit splits up the single backup.feature file (where each
scenario both dumps and restores data) into two files, 
dumps_only.feature which performs all necessary dumps and is 
run against a 4.3 database and restores_only.feature which 
performs the corresponding restores and is run against a 5 
database. It also adds and/or modifies Behave steps to account
for differences in functionality between 4.3 and 5. It uses the 
installed GPDB python version when running behave tests. This is
necessary when running different versions of Greenplum with the 
same behave feature file.

Authors: Karen Huddleston, Chris Hajas, Todd Sedano

-- it is red in pipeline with a report of OoM, but that could actually
be a symptom of a missing library.

This reverts commit e4976920.

* Rewrite Kerberos test suite

* Remove obsolete Kerberos test stuff from pipeline and TINC

We now have a rewritten Kerberos test script in installcheck-world.

* Update ICW kerberos test to run on concourse container

This adds a whole new test script in src/test/regress, implemented in plain bash. It sets up temporary a KDC as part of the script, and doesn't therefore rely on a pre-existing Kerberos server, like the old MU_kerberos-smoke test job did. It does require MIT Kerberos server-side utilities to be installed, instead, but no server needs to be running, and no superuser privileges are required.

This supersedes the MU_kerberos-smoke behave tests. The new rewritten bash script tests the same things:
  1. You cannot connect to the server before running 'kinit' (to verify that the server doesn't just let anyone in, which could happen if the pg_hba.conf is misconfigured for the test, for example)
  2. You can connect, after running 'kinit'
  3. You can no longer connect, if the user account is expired

The new test script is hooked up to the top-level installcheck-world target.

There were also some Kerberos-related tests in TINC. Remove all that, too. They didn't seem interesting in the first place, looks like they were just copies of a few random other tests, intended to be run as a smoke test, after a connection had been authenticated with Kerberos, but there was nothing in there to actually set up the Kerberos environment in TINC.

Other minor patches added:

* Remove absolute path when calling kerberos utilities
-- assume they are on path, so that they can be accessed from various installs
-- add clarification message if sample kerberos utility is not found with 'which'

* Specify empty load library for kerberos tools

* Move kerberos test to its own script file
-- this allows a failure to be recorded without exiting Make, and
therefore the server can be turned off always

* Add trap for stopping kerberos server in all cases
* Use localhost for kerberos connection
Signed-off-by: NMarbin Tan <mtan@pivotal.io>
Signed-off-by: NChumki Roy <croy@pivotal.io>
Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

In commit e8dd6b61 we
changed the way gprestore_filter.py filters languages
and functions.  The new functionality is tested in the
base backup.feature suite and does not need to be
separately tested in netbackup.feature.

Previously, any restore that filtered based on table or
schema name did not restore user-created CASTs because
they were not included in the filter. This commit adds
support for restoring casts with table and schema filters
and the --change-schema flag.

-- for guc's that are read-only when not accompanied by
--skipvalidation,
-- instead of saying a hidden guc doesn't exist, say that it is not
changeable and refer user to documentation
Signed-off-by: NChumki Roy <croy@pivotal.io>

- Update sql/answer files to set timezone to PST.
- This prevents test failures if the tests are run on a
  machine that has a different timezone.

Authors: Chris Hajas and Karen Huddleston

- Also remove unwanted test: the abort test should be skipped,
  based on feedback from Storage team
Signed-off-by: NC.J. Jameson <cjameson@pivotal.io>