1. 11 1月, 2010 4 次提交
  2. 10 1月, 2010 7 次提交
    • M
      Update Windows installation notes. · 48eaa34d
      Magnus Hagander 提交于
      pginstaller isn't used anymore, in favor of the one-click installers.
      Make it clear that we support Windows 2000 and newer with the native
      port, instead of first saying we support NT4 and then saying we don't.
      48eaa34d
    • S
      During Hot Standby, fix drop database when sessions idle. · 3bfcccc2
      Simon Riggs 提交于
      Previously we only cancelled sessions that were in-transaction.
      
      Simple fix is to just cancel all sessions without waiting. Doing
      it this way avoids complicating common code paths, which would
      not be worth the trouble to cover this rare case.
      
      Problem report and fix by Andres Freund, edited somewhat by me
      3bfcccc2
    • M
      Create typedef pgsocket for storing socket descriptors. · 87091cb1
      Magnus Hagander 提交于
      This silences some warnings on Win64. Not using the proper SOCKET datatype
      was actually wrong on Win32 as well, but didn't cause any warnings there.
      
      Also create define PGINVALID_SOCKET to indicate an invalid/non-existing
      socket, instead of using a hardcoded -1 value.
      87091cb1
    • R
      Remove partial, broken support for NULL pointers when fetching attributes. · 84b6d5f3
      Robert Haas 提交于
      Previously, fastgetattr() and heap_getattr() tested their fourth argument
      against a null pointer, but any attempt to use them with a literal-NULL
      fourth argument evaluated to *(void *)0, resulting in a compiler error.
      Remove these NULL tests to avoid leading future readers of this code to
      believe that this has a chance of working.  Also clean up related legacy
      code in nocachegetattr(), heap_getsysattr(), and nocache_index_getattr().
      
      The new coding standard is that any code which calls a getattr-type
      function or macro which takes an isnull argument MUST pass a valid
      boolean pointer.  Per discussion with Bruce Momjian, Tom Lane, Alvaro
      Herrera.
      84b6d5f3
    • R
      Document pg_tablespace.spcoptions. · 8b9fa7a9
      Robert Haas 提交于
      This should have been part of the original tablespace-options patch, but I
      overlooked the need to update this portion of the documentation.
      8b9fa7a9
    • T
      Make ExecEvalFieldSelect throw a more intelligible error if it's asked to · 85113bcf
      Tom Lane 提交于
      extract a system column, and remove a couple of lines that are useless
      in light of the fact that we aren't ever going to support this case.  There
      isn't much point in trying to make this work because a tuple Datum does
      not carry many of the system columns.  Per experimentation with a case
      reported by Dean Rasheed; we'll have to fix his problem somewhere else.
      85113bcf
    • S
      During Hot Standby, set DatabasePath correctly during relcache init file · 42edbd16
      Simon Riggs 提交于
      deletion, so that we attempt to unlink the correct filepath. unlink()
      errors are ignorable there, so lack of a DatabasePath initialization step
      did not cause visible problems until a related bug showed up on Solaris.
      
      Code refactored from xact_redo_commit() to
      ProcessCommittedInvalidationMessages() in inval.c. Recovery may replay
      shared invalidation messages for many databases, so we cannot
      SetDatabasePath() once as we do in normal backends. Read the databaseid
      from the shared invalidation messages, then set DatabasePath
      temporarily before calling RelationCacheInitFileInvalidate().
      
      Problem report by Robert Treat, analysis and fix by me.
      42edbd16
  3. 09 1月, 2010 4 次提交
    • A
      Provide regression testing for plperlu, and for plperl+plperlu interaction. · 510f3502
      Andrew Dunstan 提交于
      The latter are only run if the platform can run both interpreters in the
      same backend.
      510f3502
    • A
      Build perlchunks.h for plperl on MSVC · 0346442b
      Andrew Dunstan 提交于
      0346442b
    • T
      Fix makefile so it works for VPATH case. · c79640ef
      Tom Lane 提交于
      c79640ef
    • A
      Tidy up and refactor plperl.c. · a2b34b16
      Andrew Dunstan 提交于
      - Changed MULTIPLICITY check from runtime to compiletime.
          No loads the large Config module.
      - Changed plperl_init_interp() to return new interp
          and not alter the global interp_state
      - Moved plperl_safe_init() call into check_interp().
      - Removed plperl_safe_init_done state variable
          as interp_state now covers that role.
      - Changed plperl_create_sub() to take a plperl_proc_desc argument.
      - Simplified return value handling in plperl_create_sub.
      - Changed perl.com link in the docs to perl.org and tweaked
          wording to clarify that require, not use, is what's blocked.
      - Moved perl code in large multi-line C string literal macros
          out to plc_*.pl files.
      - Added a test2macro.pl utility to convert the plc_*.pl files to
          macros in a perlchunks.h file which is #included
      - Simplifed plperl_safe_init() slightly
      - Optimized pg_verifymbstr calls to avoid unneeded strlen()s.
      
      Patch from Tim Bunce, with minor editing from me.
      a2b34b16
  4. 08 1月, 2010 8 次提交
    • M
      Also update ChangerLog file. · 369494e4
      Michael Meskes 提交于
      369494e4
    • T
      Fix oversight in EvalPlanQualFetch: after failing to lock a tuple because · 217dc525
      Tom Lane 提交于
      someone else has just updated it, we have to set priorXmax to that tuple's
      xmax (ie, the XID of the other xact that updated it) before looping back to
      examine the next tuple.  Obviously, the next tuple in the update chain should
      have that XID as its xmin, not the same xmin as the preceding tuple that we
      had been trying to lock.  The mismatch would cause the EvalPlanQual logic to
      decide that the tuple chain ended in a deletion, when actually there was a
      live tuple that should have been found.
      
      I inserted this error when recently adding logic to EvalPlanQual to make it
      lock tuples before returning them (as opposed to the old method in which the
      lock would occur much later, causing a great deal of work to be wasted if we
      only then discover someone else updated it).  Sigh.  Per today's report from
      Takahiro Itagaki of inconsistent results during pgbench runs.
      217dc525
    • I
    • I
      Add buffer access counters to pg_stat_statements. · 8964dbd5
      Itagaki Takahiro 提交于
      This uses the same infrastructure with EXPLAIN BUFFERS to support
      {shared|local}_blks_{hit|read|written} andtemp_blks_{read|written}
      columns in the pg_stat_statements view. The dumped file format
      also updated.
      
      Thanks to Robert Haas for the review.
      8964dbd5
    • R
    • T
      Fix 3-parameter form of bit substring() to throw error for negative length, · 50626efe
      Tom Lane 提交于
      as required by SQL standard.
      50626efe
    • T
      Make bit/varbit substring() treat any negative length as meaning "all the rest · e4a6ebf7
      Tom Lane 提交于
      of the string".  The previous coding treated only -1 that way, and would
      produce an invalid result value for other negative values.
      
      We ought to fix it so that 2-parameter bit substring() is a different C
      function and the 3-parameter form throws error for negative length, but
      that takes a pg_proc change which is impractical in the back branches;
      and in any case somebody might be relying on -1 working this way.
      So just do this as a back-patchable fix.
      e4a6ebf7
    • T
      Fix (some of the) breakage introduced into query-cancel processing by HS. · 82170c74
      Tom Lane 提交于
      It is absolutely not okay to throw an ereport(ERROR) in any random place in
      the code just because DoingCommandRead is set; interrupting, say, OpenSSL
      in the midst of its activities is guaranteed to result in heartache.
      
      Instead of that, undo the original optimizations that threw away
      QueryCancelPending anytime we were starting or finishing a command read, and
      instead discard the cancel request within ProcessInterrupts if we find that
      there is no HS reason for forcing a cancel and we are DoingCommandRead.
      
      In passing, may I once again condemn the practice of changing the code
      and not fixing the adjacent comment that you just turned into a lie?
      82170c74
  5. 07 1月, 2010 17 次提交