- 26 2月, 2013 3 次提交
-
-
由 Heikki Linnakangas 提交于
Like with pg_basebackup and pg_receivexlog, it's a bit strange to call the option -d/--dbname, when in fact you cannot pass a database name in it. Original patch by Amit Kapila, heavily modified by me.
-
由 Heikki Linnakangas 提交于
You could already pass a database name just by passing it as the last option, without -d. This is an alias for that, like the -d/--dbname option in psql and many other client applications. For consistency.
-
由 Andrew Dunstan 提交于
The previous commit didn't work on MSVC editions earlier than Visual Studio 2011, apparently. This works by copying files into the contrib directory, and making provision to clean them up, which should work on all editions.
-
- 25 2月, 2013 3 次提交
-
-
由 Heikki Linnakangas 提交于
Without this, there's no way to pass arbitrary libpq connection parameters to these applications. It's a bit strange that the option is called -d/--dbname, when in fact you can *not* pass a database name in it, but it's consistent with other client applications where a connection string is also passed using -d. Original patch by Amit Kapila, heavily modified by me.
-
由 Andrew Dunstan 提交于
-
由 Peter Eisentraut 提交于
It is obviously no longer true.
-
- 24 2月, 2013 3 次提交
-
-
由 Tom Lane 提交于
rmgrdesc.c is not auto-generated now, though it apparently was the last time the Makefile was updated.
-
由 Peter Eisentraut 提交于
-
由 Tom Lane 提交于
The new name was originally my typo, but per discussion it seems like a better name anyway. So make the code match the docs, not vice versa.
-
- 23 2月, 2013 6 次提交
-
-
由 Peter Eisentraut 提交于
Louis-Claude Canon and Josh Kupershmidt
-
由 Peter Eisentraut 提交于
-
由 Alvaro Herrera 提交于
Erik Rijkers
-
由 Alvaro Herrera 提交于
... as well a update copyrights statements to 2013. Noted by Thom Brown and Peter Geoghegan
-
由 Alvaro Herrera 提交于
Harmless, but it's certainly better like this. Noticed by Andres Freund
-
由 Alvaro Herrera 提交于
This program relies on rm_desc backend routines and the xlogreader infrastructure to emit human-readable rendering of WAL records. Author: Andres Freund, with many reworks by Álvaro Reviewed (in a much earlier version) by Peter Eisentraut
-
- 22 2月, 2013 9 次提交
-
-
由 Tom Lane 提交于
Include eval costs of local conditions in remote-estimate mode, and don't assume the remote eval cost is zero in local-estimate mode. (The best we can do with that at the moment is to assume a seqscan, which may well be wildly pessimistic ... but zero won't do at all.) To get a reasonable local estimate, we need to know the relpages count for the remote rel, so improve the ANALYZE code to fetch that rather than just setting the foreign table's relpages field to zero.
-
由 Alvaro Herrera 提交于
Apparently, they need -DBUILDING_DLL for the Assert() declarations to work correctly.
-
由 Tom Lane 提交于
The optimization to not retrieve unnecessary columns wasn't smart enough. Noted by Thom Brown.
-
由 Tom Lane 提交于
On reflection this method seems to be exposing an unreasonable amount of implementation detail. It wouldn't matter when talking to a remote server of the identical Postgres version, but it seems likely to make things worse not better if the remote is a different version with different casting infrastructure. Instead adopt ruleutils.c's policy of regurgitating the cast as it was originally specified; including not showing it at all, if it was implicit to start with. (We must do that because for some datatypes explicit and implicit casts have different semantics.)
-
由 Tom Lane 提交于
The only place we depended on that was in sending numeric type OIDs in PQexecParams; but we can replace that usage with explicitly casting each Param symbol in the query string, so that the types are specified to the remote by name not OID. This makes no immediate difference but will be essential if we ever hope to support use of non-builtin types.
-
由 Heikki Linnakangas 提交于
We must still initialize minRecoveryPoint if we start straight with archive recovery, e.g when recovering from a normal base backup taken with pg_start/stop_backup. Otherwise we never consider the system consistent.
-
由 Tom Lane 提交于
Set the remote session's search path to exactly "pg_catalog" at session start, then schema-qualify only names that aren't in that schema. This greatly reduces clutter in the generated SQL commands, as seen in the regression test changes. Per discussion. Also, rethink use of FirstNormalObjectId as the "built-in object" cutoff --- FirstBootstrapObjectId is safer, since the former will accept objects in information_schema for instance.
-
由 Heikki Linnakangas 提交于
If you create a base backup using an atomic filesystem snapshot, and try to perform PITR starting from that base backup, or if you just kill a master server and create recovery.conf to put it into standby mode, we don't know how far we need to recover before reaching consistency. Normally in crash recovery, we replay all the WAL present in pg_xlog, and assume that we're consistent after that. And normally in archive recovery, minRecoveryPoint, backupEndRequired, or backupEndPoint is set in the control file, indicating how far we need to replay to reach consistency. But if the server was previously up and running normally, and you kill -9 it or take an atomic filesystem snapshot, none of those fields are set in the control file. The solution is to perform crash recovery first, replaying all the WAL in pg_xlog. After that's done, we assume that the system is consistent like in normal crash recovery, and switch to archive recovery mode after that. Per report from Kyotaro HORIGUCHI. In his scenario, recovery.conf was created after "pg_ctl stop -m i". I'm not sure we need to support that exact scenario, but we should support backing up using a filesystem snapshot, which looks identical. This issue goes back to at least 9.0, where hot standby was introduced and we started to track when consistency is reached. In 9.1 and 9.2, we would open up for hot standby too early, and queries could briefly see an inconsistent state. But 9.2 made it more visible, as we started to PANIC if we see a reference to a non-existing page during recovery, if we've already reached consistency. This is a fairly big patch, so back-patch to 9.2 only, where the issue is more visible. We can consider back-patching further after this has received some more testing in 9.2 and master.
-
由 Alvaro Herrera 提交于
This enables non-backend code, such as pg_xlogdump, to use it easily. The previous location, in src/backend/catalog/catalog.c, made that essentially impossible because that file depends on many backend-only facilities; so this needs to live separately.
-
- 21 2月, 2013 4 次提交
-
-
由 Alvaro Herrera 提交于
Per Jeff Janes
-
由 Tom Lane 提交于
Per buildfarm.
-
由 Tom Lane 提交于
Per buildfarm.
-
由 Tom Lane 提交于
There's still a lot of room for improvement, but it basically works, and we need this to be present before we can do anything much with the writable-foreign-tables patch. So let's commit it and get on with testing. Shigeru Hanada, reviewed by KaiGai Kohei and Tom Lane
-
- 20 2月, 2013 3 次提交
-
-
由 Heikki Linnakangas 提交于
If a database name contained a '=' character, pg_dumpall failed. The problem was in the way pg_dumpall passes the database name to pg_dump on the command line. If it contained a '=' character, pg_dump would interpret it as a libpq connection string instead of a plain database name. To fix, pass the database name to pg_dump as a connection string, "dbname=foo", with the database name escaped if necessary. Back-patch to all supported branches.
-
由 Heikki Linnakangas 提交于
Back-patch to all supported branches.
-
由 Heikki Linnakangas 提交于
Etsuro Fujita
-
- 19 2月, 2013 2 次提交
-
-
由 Alvaro Herrera 提交于
It needs to be defined in the backend even when assertions are not enabled. It's cleaner to put it back, than create a separate #ifdef section in c.h. Per trouble report from Jeff Janes
-
由 Alvaro Herrera 提交于
We now write one file per database and one global file, instead of having the whole thing in a single huge file. This reduces the I/O that must be done when partial data is required -- which is all the time, because each process only needs information on its own database anyway. Also, the autovacuum launcher does not need data about tables and functions in each database; having the global stats for all DBs is enough. Catalog version bumped because we have a new subdir under PGDATA. Author: Tomas Vondra. Some rework by Álvaro Testing by Jeff Janes Other discussion by Heikki Linnakangas, Tom Lane.
-
- 18 2月, 2013 1 次提交
-
-
由 Peter Eisentraut 提交于
This generalizes the existing ALTER ROLE ... SET and ALTER DATABASE ... SET functionality to allow creating settings that apply to all users in all databases. reviewed by Pavel Stehule
-
- 17 2月, 2013 1 次提交
-
-
由 Bruce Momjian 提交于
Add code to detect and warn about trying to initdb or create pg_xlog on mount points.
-
- 16 2月, 2013 2 次提交
-
-
由 Heikki Linnakangas 提交于
Revert my earlier fix for the bug that unarchived WAL files get deleted on crash recovery, commit c9cc7e05. We create a .done file for files streamed or restored from archive, so the WAL file recycling logic used during normal operation works just as well during archive recovery. Per Fujii Masao's suggestion.
-
由 Simon Riggs 提交于
This is a forward-patch of commit 6f4b8a4f4f7a2d683ff79ab59d3693714b965e3d, applied to 9.2 back in August. The plan was to do something else in master, but it looks like it's not going to happen, so let's just apply the 9.2 solution to master as well. Fujii Masao
-
- 15 2月, 2013 3 次提交
-
-
由 Heikki Linnakangas 提交于
Bug reported by Jehan-Guillaume (ioguix) de Rorthais. This was introduced with the change to keep WAL files restored from archive in pg_xlog, in 9.2.
-
由 Peter Eisentraut 提交于
The previous order of steps didn't literally work, because git clean -fdx would delete the downloaded typedefs.list. Also, pgindent needs to be called with a path when one is in at the top of the build tree.
-
由 Tom Lane 提交于
Currently it's only possible for loadable modules to get control during post-commit cleanup of a transaction. That doesn't work too well if they want to do something that could throw an error; for example, an FDW might need to issue a remote commit, which could well fail. To improve matters, extend the existing APIs for XactCallback and SubXactCallback functions to provide new pre-commit events for this purpose. The release notes will need to mention that existing callback functions should be checked to make sure they don't do something unwanted when one of the new event types occurs. In the examples within our source tree, contrib/sepgsql was fine but plpgsql had been a bit too cute.
-