1. 29 4月, 2016 1 次提交
  2. 28 4月, 2016 1 次提交
  3. 27 4月, 2016 2 次提交
  4. 26 4月, 2016 2 次提交
  5. 25 4月, 2016 7 次提交
    • H
      Simplify the parsed-representation of ALTER TABLE ADD PARTITION. · 08db9061
      Heikki Linnakangas 提交于
      atpxPartAddList() needs a CreateStmt that represents the parent table,
      but instead of creating it already in the parser, and adding more details
      to it in analyze.c, it's simpler to create it later, in atpxPartAddList(),
      where it's actually needed.
      08db9061
    • H
      Remove unused function. · 42b53fe4
      Heikki Linnakangas 提交于
      The code in InitPostgres() was refactored in PostgreSQL 9.0 so that it
      no longer uses FindMyDatabaseByOid() function. We had backpatched the
      InitPostgres() changes already, so backpatch the removal of
      FindMyDatabaseByOid() as well. Silences a compiler warning.
      42b53fe4
    • P
      Set debug_query_string correctly in _SPI_execute_plan · f9a020e1
      Pengzhou Tang 提交于
      In _SPI_execute_plan, debug_query_string was set directly to plan->query which is not
      memory context safe, it means debug_query_string have a chance to refer to a invalid
      address when FATAL/PANIC level error occurs.
      f9a020e1
    • H
      Give a WARNING if an object is allocated an OID in segment. · 78496474
      Heikki Linnakangas 提交于
      A common source of bugs has been that an object gets assigned a different
      OID in the master and in segments. A segment should normally never have to
      allocate an OID (for catalog objects) on its own, all OIDs should be
      allocated in the master, and sent over to the segments. To make such bugs
      easier to catch, add a WARNING if an OID is allocated in a segment.
      
      There were some DEBUG1 elogs for the same thing in place already, but the
      list of catalogs that need synchronized OIDS wasn't up-do-date, and this new
      place for the elog() is less invasive anyway.
      78496474
    • H
      Fix dispatching of operator family and class DDL commands. · b723294f
      Heikki Linnakangas 提交于
      When I merged the operator family patch, I missed dispatching the new DDL
      commands to segments. Because of that, the segments didn't have information
      about operator families. Some operator families would be greated implicitly
      by CREATE OPERATOR CLASS, but you wouldn't necessarily get the same
      configuration of families and classes as in the master. Things worked pretty
      well despite that, because operator families and classes are used for
      planning, and planning happens in the master. Nevertheless, we really should
      have the operator family information in segments too, in case you run
      queries in maintenance mode directly on the segments, or if you execute
      functions in segments that need to execute expression that depend on them.
      Also, there were no regression tests for the new DDL commands.
      b723294f
    • H
      Synchronize the OIDs of shell operators created for commutator/negator. · 6d0f73da
      Heikki Linnakangas 提交于
      If you do CREATE OPERATOR, with a commutator or negator operator that
      doesn't exist yet, the system creates a "shell" entry for the non-existent
      operator. But those shell operators didn't get the same OID in all segments,
      which could lead to strange errors later. I couldn't find a test case
      demonstrating actual bugs from that, but it sure seems sketchy. Given that
      we take care to synchronize the OID of the primary created operator, surely
      we should do the same for all operators.
      6d0f73da
    • H
      Fix ALTER TABLE so that the array type gets the same OID in all segments. · 51dd4e30
      Heikki Linnakangas 提交于
      The out/readfuncs.c support for AlterTableStmt.comptypeArrayOid was
      missing. Because of that, the segments didn't get the OID of the composite
      type's array type from master, and allocated it on their own.
      51dd4e30
  6. 23 4月, 2016 1 次提交
  7. 22 4月, 2016 5 次提交
    • P
    • K
      Integrate codegen framework and make simple external call to slot deform · ae4a7754
      Karthikeyan Jambu Rajaraman 提交于
      tuple.
      This closes #649
      
      Squashed commit of the following:
      
      commit 96f415bc1744533e96a74bcc85016ff5df65d06e
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Thu Apr 21 15:08:49 2016 -0700
      
          Don't call prepare for execution if no generator is registered
      
      commit 5318e9214a3bbc237c0d79017cdef02538c4e711
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Thu Apr 21 11:35:22 2016 -0700
      
          Adding if codegen protection in starting active manager and while
          deleting manager
      
      commit 12b0045d51a5b056b32a6cc9ef370e6d9af315fd
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Fri Apr 15 14:33:55 2016 -0700
      
          Updating Readme for Codegen GPDB Function
      
      commit d17119c5d8ce9a706b3321d5e7ad41f419fddbdc
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Wed Apr 13 13:25:14 2016 -0700
      
          Add documentation for how to codegen in README.md
      
      commit d711be4bb044592e7f97bf31ceb5f32337ad6d03
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Wed Apr 13 11:19:03 2016 -0700
      
          Fixing doxygen namespace addtogroup
      
      commit e34131bcc9bb3d36c5e8995e1a0efe11fbd55417
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Wed Apr 13 11:17:32 2016 -0700
      
          Changing CodeGen to Codegen
      
      commit bedfcca80b5f1ff796783ca7c2035d920ae86c4e
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Wed Apr 13 10:51:39 2016 -0700
      
          Fix cpplint error
      
      commit 32f89feedba655e1242529c78a54faf01ddf32bf
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Wed Apr 13 10:48:49 2016 -0700
      
          Change regular version of generated to regular version of target in comment
      
      commit d1da2824c08e34eb7139b08cd9d2aff19bf008e7
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Wed Apr 13 10:42:09 2016 -0700
      
          Made GetFunctionPointer and CreateFunction to take typedef of function type as only public api
      
      commit 9f48f77bd9fc50c7d29a4e8f7700452ef88dc79f
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Tue Apr 12 17:18:24 2016 -0700
      
          Rename doCodegeneration to GenerateCodeInternal
      
      commit 9884d07f4c6ab08d9ccca8d07b80974081cda1fa
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Tue Apr 12 17:15:55 2016 -0700
      
          fix cpplint error
      
      commit c21b3bee3e289675fc13017688269b40e26efa11
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Tue Apr 12 17:08:16 2016 -0700
      
          Update comments
      
      commit f016bb582af65e84def1b55917017008e292d45b
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Tue Apr 12 17:01:19 2016 -0700
      
          Adding assert in static setToRegular function
      
      commit 93a791a4ec415313933dd5b7c1ae17dbdd6193a6
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Tue Apr 12 16:49:15 2016 -0700
      
          Removing decltype in Slotdeformtype codegen since we know the functype
      
      commit ed95193d0991cb24fd68f6d9a473de630f297b0c
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Tue Apr 12 16:45:49 2016 -0700
      
          Fixed compiler / unit test failure
          Changed InitCodeGen to InitCodegen
      
      commit 3c95c9efdd4336e100a86748b0e87d79f07bcc11
      Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Date:   Tue Apr 12 16:28:24 2016 -0700
      
          Changing CodeGen back to Codegen while cherry-picking
      
      commit 4e24ef22bcf54edc00c2a0d1f9f9703364cdf5ba
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Tue Apr 12 11:08:42 2016 -0700
      
          Changing auto to actual type
      
      commit 1d92fc190dda3ec866edc83d56d9eca9fe90a63a
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Tue Apr 12 10:44:49 2016 -0700
      
          fix indent in codegen_utils
      
      commit ea6fa787a2332f94b8d20d24825ba1f0a240d02e
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Mon Apr 11 17:25:53 2016 -0700
      
          Adding codegen guc to wrapper function so related function not executed when codegen guc is disabled
      
      commit f1cd7d80d8d81f3565f3ab12cb94a3c4cc58c44a
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Mon Apr 11 17:13:24 2016 -0700
      
          Changing bool to unsigned int in codegen_wrapper.h
      
      commit 7ef462540a312d077b332c732c125c55dedb6b14
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Mon Apr 11 16:59:08 2016 -0700
      
          Fix based on lint complain
      
      commit ddc55cec0d579a03cb9e2303efa6d74f5183979f
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Mon Apr 11 16:19:48 2016 -0700
      
          Removing commented code from unittest
      
      commit 28b8886ed2bfdc854aa38f871a41536c1e6cef29
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Mon Apr 11 16:17:45 2016 -0700
      
          Chaging auto in for to actual type
      
      commit ad8d78e07e9b789f4d8ae3c6ccc3cea1a05089c0
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Mon Apr 11 16:13:21 2016 -0700
      
          * Handle return value of SetToGenerated from PrepareForExecution
          * Change size_t to unsigned integer
      
      commit d46ee8be414b3ac2a9ea7ef899f29cef3df145c7
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Mon Apr 11 15:30:40 2016 -0700
      
          Introducing template function to do enroll for any type of generator
      
      commit 83428605f906e28d0fc994dcc311e0cc3e6d9e12
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Mon Apr 11 14:41:11 2016 -0700
      
          Changing manager to take module name as argument
      
      commit b88aa40f89860e7c15503365ea304d2392f71cda
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Mon Apr 11 14:27:31 2016 -0700
      
          adding more comments to SlotDeformTupleCodeGenInfo and unique counter
      
      commit df1b704548fcbc1b43524064eb2f024995eea865
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Mon Apr 11 14:08:34 2016 -0700
      
          Change test target to have ext .t and adding gitignore for that extension
      
      commit 9ee3521ca687c4ea7f13d15893f47146ecdb5277
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Mon Apr 11 13:59:57 2016 -0700
      
          Add target_include_directories for test library header file
      
      commit effb7dc165b4c7094731dc39e0872741b28b2e6a
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Mon Apr 11 13:36:50 2016 -0700
      
          Move all possible ifdef from gpdb to codegen_wrapper based on pull request comments
      
      commit 989b96a91c1e843577b5f24623d1e4a6b810394c
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Fri Apr 8 10:43:17 2016 -0700
      
          fixing comments for GetOrigFuncName in codegen_interface
      
      commit 665de065c34ea13abcec8c5f3a3336558dae501f
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Fri Apr 8 10:27:31 2016 -0700
      
          Disabling codegen guc by default
      
      commit ec34513e86dea95bd36ee528724273c1c19e7062
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Thu Apr 7 16:28:43 2016 -0700
      
          Fixed comments space/tab so it aligned in different editor
      
      commit 35a60fe2fd053a5babd1820302afad95c5c2635f
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Thu Apr 7 16:12:08 2016 -0700
      
          Fixing coding style based on cpplint
      
      commit 9477dcf6c0a7ffcca77b9f2c62c7340d13f474aa
      Author: Karthikeyan Jambu Rajaraman <krajaraman@pivotal.io>
      Date:   Thu Apr 7 13:37:01 2016 -0700
      
          Adding USE_CODEGEN ifdef
      
      commit 142ffc1416341a3ac1d0fe37a83577168f2ec166
      Author: Shreedhar Hardikar <shardikar@pivotal.io>
      Date:   Tue Apr 5 22:21:19 2016 +0000
      
          Make codegen work with GPDB unit test framework
      
      commit 9dca9507dd933a5517bee3ca34615c09c23c1728
      Author: Shreedhar Hardikar <shardikar@pivotal.io>
      Date:   Mon Apr 4 22:10:21 2016 +0000
      
          Add gpcodegen_mock.c
      
      commit 41d515ff0342d3df3b0853ad91731f6d1d75843c
      Author: Shreedhar Hardikar <shardikar@pivotal.io>
      Date:   Mon Apr 4 21:46:34 2016 +0000
      
          Remove unneccessary header file includes in codegen
      
      commit 14c5e14b9834197693b1ef56efa96386cfe049c5
      Author: Foyzur Rahman <frahman@gmail.com>
      Date:   Tue Apr 12 14:49:51 2016 -0700
      
          Integrate codegen framework and make simple external call to slot deform tuple
      Signed-off-by: NKarthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
      Signed-off-by: NFoyzur Rahman <frahman@gmail.com>
      ae4a7754
    • H
      Bump the GPORCA version to 1.630 · 603ee8d0
      Haisheng Yuan and Xin Zhang 提交于
      603ee8d0
    • G
      Speeding up qp_misc_jiras by cleaning up two tests. · 5367cbd1
      George Caragea 提交于
      Removed one test that was checking for a memory leak by attempting to run the system out of memory.
      Refactored one test that was checking for a large insert into a table with a bitmap index.
      
      Closes #660.
      
      [#116336737, #117671863]
      5367cbd1
    • N
      Remove inappropriate ICG test · 23c81a00
      Nikos Armenatzoglou 提交于
      Commit 9d19664c ported a test from cdbfast to master, which uses gp_fault_inject mechanism to throw a SIGSEGV.
      We remove this test because i) gp_fault_inject works only if USE_TEST_UTILS = 1, while when we test GPDB, we set USE_TEST_UTILS to 0, and ii) throwing segmentation faults in ICG is a wrong approach.
      23c81a00
  8. 21 4月, 2016 3 次提交
    • D
      Add required headerfile for reconstructTupleValues() · c11e3f4f
      Daniel Gustafsson 提交于
      Fixes compiler warning for implicit declaration due to missing
      headerfile include:
      
        copy.c:4143:6: warning: implicit declaration of function
           'reconstructTupleValues' is invalid in C99
           [-Wimplicit-function-declaration]
      c11e3f4f
    • H
      Support RETURN QUERY for PL/PgSQL (#644) · 4be5878e
      Haozhou Wang 提交于
      Backport from upstream and related commits are
      
          commit e5fe2e84
          Author: Tom Lane <tgl@sss.pgh.pa.us>
          Date:   Fri Nov 9 23:58:32 2007 +0000
      
              Recognize RETURN QUERY via a textual test, so that QUERY doesn't need to be
              a plpgsql keyword.  This avoids springing a new reserved word on plpgsql
              programmers.
              For consistency, handle RETURN NEXT the same way.
      
          commit b2b9b4d5
          Author: Neil Conway <neilc@samurai.com>
          Date:   Wed Jul 25 04:19:09 2007 +0000
      
              Implement RETURN QUERY for PL/PgSQL. This provides some convenient syntax
              sugar for PL/PgSQL set-returning functions that want to return the result
              of evaluating a query; it should also be more efficient than repeated
              RETURN NEXT statements. Based on an earlier patch from Pavel Stehule.
      
      Committers: Kuien Liu and Haozhou Wang
      4be5878e
    • V
  9. 20 4月, 2016 3 次提交
  10. 19 4月, 2016 2 次提交
  11. 18 4月, 2016 2 次提交
    • D
      Move gpcheckcat symlink installation to install dir from source tree · 34d14aae
      Daniel Gustafsson 提交于
      Commit 41dfd82b moved gpcheckcat from bin/lib to bin/ and installed a
      symlink to maintain backwards compatibility. However, installing and
      copying the symlink in the source tree makes Git complain that it's
      an untracked file. Rather than adding it to .gitignore we might as
      well do this in the installation directory since that's where we want
      to maintain backwards compatability anyways.
      
      Cleaned up a few comments around the installation as well while in
      there.
      34d14aae
    • A
      Fix error log test for external table. · 8588efd1
      Abhijit Subramanya 提交于
      The cursor test for external table is non deterministic. The query errors out
      either during DECLARE cursor or during FETCH. If the query errors out during
      DECLARE and we perform a FETCH after the DECLARE an extra line of error is
      produced in the output stating that the transaction has been aborted. In the
      case where FETCH errors out this error is not produced in the output. This
      commit adds a separate expected answer file to handle the two cases.
      8588efd1
  12. 16 4月, 2016 6 次提交
  13. 15 4月, 2016 5 次提交
    • A
      s3ext: source cleanup and reorganization · 497761cc
      Adam Lee 提交于
      remove scripts directory.
      remove LICENSE file since it's the same as GPDB's.
      remove dead codes and meaningless comments.
      reorder header includings alphabetically.
      add a missing unit test for find_replace().
      rename testing sql files.
      rename source files.
      optimize compiling flags.
      497761cc
    • J
      Improve duplicate key value violation reporting on unique indexes. · 4022c338
      Jimmy Yih 提交于
      Currently, the error reporting for duplicate key value violation for unique
      indexes does not contain useful information for users when debugging. This
      commit backports two commits from PostgreSQL (shown below) and updates our
      multikey tuplesort to use the same. Now the error will display the first
      instance of a duplicate key violation.
      
      Authors: Jimmy Yih and Abhijit Subramanya
      
      commit b680ae4b
      Author: Tom Lane <tgl@sss.pgh.pa.us>
      Date:   Sat Aug 1 19:59:41 2009 +0000
      
          Improve unique-constraint-violation error messages to include the exact
          values being complained of.
      
          In passing, also remove the arbitrary length limitation in the similar
          error detail message for foreign key violations.
      
          Itagaki Takahiro
      
       Conflicts:
      	contrib/citext/expected/citext.out
      	contrib/citext/expected/citext_1.out
      	src/backend/access/common/indextuple.c
      	src/backend/access/index/genam.c
      	src/backend/access/nbtree/nbtinsert.c
      	src/backend/utils/adt/ri_triggers.c
      	src/backend/utils/adt/ruleutils.c
      	src/include/access/genam.h
      	src/include/access/itup.h
      	src/include/utils/builtins.h
      	src/test/regress/expected/alter_table.out
      	src/test/regress/expected/arrays.out
      	src/test/regress/expected/create_index.out
      	src/test/regress/expected/plpgsql.out
      	src/test/regress/expected/transactions.out
      	src/test/regress/expected/uuid.out
      	src/test/regress/output/constraints.source
      	src/test/regress/output/tablespace.source
      
      commit 527f0ae3
      Author: Tom Lane <tgl@sss.pgh.pa.us>
      Date:   Sat Aug 1 20:59:17 2009 +0000
      
          Department of second thoughts: let's show the exact key during unique index
          build failures, too.  Refactor a bit more since that error message isn't
          spelled the same.
      
       Conflicts:
      	src/backend/access/nbtree/nbtinsert.c
      	src/backend/utils/sort/tuplesort.c
      	src/test/regress/expected/alter_table.out
      	src/test/regress/expected/create_index.out
      4022c338
    • L
      Add behave test for gpcheckcat: catalog problems for conflicting db ownership... · 8793ffe5
      Larry Hamel 提交于
      Add behave test for gpcheckcat: catalog problems for conflicting db ownership will generate repair scripts that have timestamped names (to avoid overwriting)
      - add behave steps for removing and also validating directories that are relative to the current working directory (allows * globbing)
      - criteria for determining that repair file was not overwritten:  run gpcheckcat twice, and expect 1 and then 2 repair scripts.
      - verify that stdout reports "owner" error
      - change criteria for gpcheckcat ownership: relax the pg_type check so that both 4.3STABLE and master report an ownership error for pg_type.
      8793ffe5
    • M
      Removing built-in logger from gp_unittest · 7b5ccff5
      Marbin Tan 提交于
      This was causing issues on make check where the logger gets inherited
      by other unittests and causes unexpected log outputs.
      
      Authors: Marbin Tan & Stephen Wu
      7b5ccff5
    • M
      Adds support for running gpcheckcat when indexes are defined with opclass · de6e9c52
      Marbin Tan and Stephen Wu 提交于
      Updates unique index query to find column names by querying pg_attribute instead of string-parsing the index definition.  This allows us to support opclasses as well as special characters in the column name.
      de6e9c52