This includes fixing the MSVC copy of ecpg/preproc's version info, which
seems to have been overlooked repeatedly.  Can't we fix that so there are
not two copies??

Let the hacking begin ...

commit-fest.

pgindent and perltidy should clean up the rest.

Postgres 9.2, and perhaps no existing users either.

	--details-after
	--master-only
	--oldest-first

A few simplifications and stylistic improvements, found while grepping
around for makefile problems elsewhere.

Josh Kupershmidt

The header file is needed by any module that wants to use the PL/pgSQL
instrumentation plugin interface. Most notably, the pldebugger plugin needs
this. With this patch, it can be built using pgxs, without having the full
server source tree available.

Per buildfarm, and Álvaro Herrera.

And minor other pgindent documentation tweaks.

(And why in the world is this OBJS list not being scraped from the
corresponding Makefile?)

This makes it much more convenient to build tools for Postgres that are
separately compiled and require a matching CRC implementation.

To prevent multiple copies of the CRC polynomial tables being introduced
into the postgres binaries, they are now included in the static library
libpgport that is mainly meant for replacement system functions.  That
seems like a bit of a kludge, but there's no better place.

This cleans up building of the tools pg_controldata and pg_resetxlog,
which previously had to build their own copies of pg_crc.o.

In the future, external programs that need access to the CRC tables can
include the tables directly from the new header file pg_crc_tables.h.

Daniel Farina, reviewed by Abhijit Menon-Sen and Tom Lane

For that purpose, have check_keywords.pl print errors to stderr and
return a useful exit status.

that has been renamed and undocumented since 2003;  instead, use the
documented option.  Add comments.

Per recent work by Peter Geoghegan, it's significantly faster to
tuplesort on a single sortkey if ApplySortComparator is inlined into
quicksort rather reached via a function pointer.  It's also faster
in general to have a version of quicksort which is specialized for
sorting SortTuple objects rather than objects of arbitrary size and
type.  This requires a couple of additional copies of the quicksort
logic, which in this patch are generate using a Perl script.  There
might be some benefit in adding further specializations here too,
but thus far it's not clear that those gains are worth their weight
in code footprint.

Alex Hunsaker

Thanks to Andrew Dunstan for bringing this to my attention.

Kevin Grittner

Kevin Grittner

Brar Piening, reviewed by Craig Ringer.

directories.  Per suggestion from Andrew Dunstan.

those files corrupts the index.

to 'make' rather than 'gmake' for the binary name.

Not everyone has /pg linked to the src subdirectory of their PostgreSQL
tree.  Also, cc isn't the way to invoke the compiler everywhere.

pg_dumpall to use the same memory allocation functions as the others.

This fixes a longstanding but up to now benign bug in the way pg_dumpall
was built. The bug was exposed by recent code adjustments. The Makefile
does not use $(OBJS) to build pg_dumpall, so this fix removes their source
files from the pg_dumpall object and adds in the one source file it
consequently needs.

distro version of perl.

David Wheeler and Alex Hunsaker.

Backpatch to 9.1 where it applies cleanly. A simple workaround is available for earlier
branches, and further effort doesn't seem warranted.