1. 21 10月, 2020 1 次提交
    • J
      The inner relation of LASJ_NOTIN should not have partition locaus · 343f8826
      Jinbao Chen 提交于
      The result of NULL not in an unempty set is false. The result of
      NULL not in an empty set is true. But if an unempty set has
      partitioned locus. This set will be divided into several subsets.
      Some subsets may be empty. Because NULL not in empty set equals
      true. There will be some tuples that shouldn't exist in the result
      set.
      
      The patch disable the partitioned locus of inner table by removing
      the join clause from the redistribution_clauses.
      
      this commit cherry pick from 6X_STABLE 8c93db54f3d93a890493f6a6d532f841779a9188
      Co-authored-by: NHubert Zhang <hubertzhang@apache.org>
      Co-authored-by: NRichard Guo <riguo@pivotal.io>
      343f8826
  2. 30 6月, 2017 1 次提交
  3. 03 2月, 2017 1 次提交
    • H
      Fix memory leak and error handling of workfiles. · f0a0a593
      Heikki Linnakangas 提交于
      There's no need to allocate ExecWorkFile struct in TopMemoryContext. We
      don't rely on a callback to clean them up anymore, they will be closed
      by the normal ResourceOwner and MemoryContext mechanisms. Otherwise,
      the memory allocated for the struct is leaked on abort.
      
      In the passing, make the error handling more robust.
      
      Also modify tuplestorenew.c, to allocate everything in a MemoryContext,
      rather than using gp_malloc() directly. ResourceOwner and MemoryContext
      mechanisms will now take care of cleanup on abort, instead of the custom
      end-of-xact callback.
      
      Remove execWorkFile mock test. The only thing it tested was that
      ExecWorkFile was allocated in TopMemoryContext. That didn't seem very
      interesting to begin with, and the assumption is now false, anyway. We
      could've changed the test to test that it's allocated in
      CurrentMemoryContext instead, but I don't see the point.
      
      Per report in private from Karthikeyan Rajaraman. Test cases also by him,
      with some cleanup by me.
      f0a0a593
  4. 06 12月, 2015 1 次提交
  5. 28 10月, 2015 1 次提交