Includes tests:
  composite_keys_gpdb_1
  composite_keys_gpdb_3
  composite_keys_gpdb_2
  partitionindexes
  staticselection
  cte_functest
  cte_queries
  create_table_default_distribution
  lastj lastj_hash
  indexapply

Commit 33a1278c merged upstream addition of a typmod argument to
makeConst(). However, one of the calls was botched during the merge, and
the typmod argument was inserted to wrong place in argument list. This
seems to have been harmless because the constant ended up being NULL
anyway, and the bogus values for the other arguments were ignored.

These got in the way in the PostgreSQL 8.3 merge, so let's get them over
with before the big merge lands.

This makes no difference at runtime, as the argument is always passed as
NULL anyway, but let's avoid unnecessary differences vs. upstream.

These changes were lifted from upcoming PostgreSQL 8.3 merge branch, but
are not related to the merge per se, so let's get them out of the way
before the big merge lands. Plus other cosmetic things in neighbouring
code that stuck my eye.

A new regression test was added in the upstream that does work_mem='64kB',
which used to fail without --enable-cassert. There's little reason to not
allow a small value here, so let's just allow it. It doesn't mean that
anyone should use such a small value in production, but that's just a
matter of "don't do that then".

The minimum was changed later in the upstream, too, to be 64 kb regardless
of BLCKSZ.

prev_item variable needs to be reset between the two loops. Otherwise,
if the first item in the latter list (allocatedReaderGangs1) needs to
be removed, things go wrong. I got an assertion failure with
installcheck-good from that:

FailedAssertion(""!(prev != ((void *)0) ? ((prev)->next) == cell : list_head(list) == cell)"", File: ""list.c"", Line: 616)

This got broken in the recent refactoring commit 46dfa750. The rest of the
changes in this commit, introducing the new next_item variable, wasn't
needed for correctness, but IMHO makes the code easier to understand.

I missed this in commit af7b1b51, which reverted the backend shutdown code
closer to the upstream. Without it, auxiliary proc slots are never reused,
so you run out of them fairly quickly, if any (non-permanent) auxiliary
processes are used.

Reported by Gang Xiong, who ran into this with gprecoverseg.

The checks for invalid TIDs are very cheap, a few CPU instructions. It's
better to catch bugs involving invalid TID early, so let's always check
for them.

The LOGs in storeAttrDefault() that were also tied to this GUC seemed
oddly specific. They were probably added long time ago to hunt for some
particular bug, and don't seem generally useful, so I just removed them.

Previously, the functions and subclasses in gpcrondump, gpdbrestore, dump.py,
and restore.py all required long lists of arguments to be passed around and
required many helper functions.  This made adding new command-line options
or new features quite time-consuming to implement and to test.

Now, a Context class has been added to backup_utils.py that holds all of the
variables used for command-line options, as well as other variables used in
many places during backup and restore; additionally, many helper functions
have been condensed into a few functions within Context, and in the future
more such functions can be moved to Context as needed.  This will make it
much easier to expand dump and restore functionality going forward.

This way we can reuse the csv files in other installcheck suites.

Caught by access_methods/indexscan TINC tests.

This seems like a copy-paste error since the IDENTIFICATION marker
is a PostgreSQL artifact and Peter Eisentraut probably didn't write
the gpopt Makefile. Remove to make it look like the headers in other
GPDB specific makefiles.

This commit addresses the pg_restore documentation which was overlooked
in the original commit 0b28e753 where pg_dump and pg_dumpall were fixed.

Refactor s3common codes and add unit tests.

Author: Adam & Yandong

Enhacing code generated ExecVariableList with support of null attributes.
Also, there are some formatting changes based on Google C++ style.

1) add one new type of gang: singleton reader gang.
2) change interface of allocateGang.
3) handling exceptions during gang creation: segment down and segment reset.
4) cleanup some dead code.

This closes #764

The -i option is a noop in pg_dump and pg_dumpall, remove documentation
from reference page.

Andreas Scherbaum

Make the description text match the summary.

This attempts to clean up the autoconf script a bit and follow the
upstream division of generic code in config/ with the actual lookup
configuration in configure.in. Also updated our installation to rely
on a more modern version of autoconf by backporting parts of upstream
commit 7cc514ac. This commit consist of:

  * Decouple --enable-codegen and --with-codegen-prefix to not
    silently ignore prefixes if the enable flag isn't passed.
	Emit a warning if configuring prefixes without codegen. Also
	moves --with-codegen-prefix to require an argument since
	--with-codegen-prefix without an argument is likely to hide
	either a scripting bug or a misunderstanding from the user
  * Move program checks for cmake and apr-1-config to programs.m4
    and allow for path overrides and ensure to use the resolved
	path when invoking cmake for --enable-codegen
  * Propagate the apr-1-config flags and objects to where used via
    Makefile.global rather than performing another lookup
  * Remove check for unused arguments since autoconf does that
    automatically since 2.63
  * Remove backported fseeko handling since that isn't relevant
    for modern autoconf versions
  * Minor help output tidying and spelling fixes

information.

Authors: Christopher Hajas, Pengcheng Tang

If peer of failed segment is in ChangeTrackingDisabled state, its change tracking
log is corrupted. This commit is for gprecoverseg to stop recovering such
segments in incremental mode, instead it warns user to run a full recovery.

Also enable gprecoverseg unit and behave tests.

Authors: Pengcheng Tang, Chumki Roy, Christopher Hajas

This will no longer spill logfiles from the demo cluster into
the users ~/gpAdminLogs directory. Also it makes it easier to
identify which logfile was created by the last regression test run.

Closes #689
Closes #523

To get fast feedback. Also deleted some dead codes and improved tests for s3conf.