1. 21 3月, 2018 8 次提交
  2. 20 3月, 2018 15 次提交
  3. 17 3月, 2018 2 次提交
    • J
      Remove GPDB_84_MERGE_FIXME from sinvaladt.c · 2c55325d
      Jimmy Yih 提交于
      The fixme comment was placed here to warn that the implementation
      might be backwards on Greenplum 4.X and 5.X.  The concern is not valid
      for Greenplum 4.X because there is no lazy xids.  However, the concern
      is indeed valid for Greenplum 5.x.  This is noted and will be changed
      on the 5X_STABLE branch.
      
      [ci skip]
      2c55325d
    • E
      Remove GPDB_90_MERGE_FIXME from hstore.sql · 3a24e11b
      Ekta Khanna 提交于
      Prior to GPORCA version 2.55.10, ORCA produced a plan with Redistribute
      Motion on the hstore attribute(which is not a "GPDB hashable" type).
      This caused queries to fail with the error like:
      ERROR:  Type 40963 is not hashable.
      This FIXME was added in `contrib/hstore/sql/hstore.sql` to run such
      failing queries with planner. Since the issue has been fixed in ORCA,
      removing it.
      3a24e11b
  4. 16 3月, 2018 15 次提交
    • D
      Fix misspelled workfile_mgr test · 1d4a060e
      Daniel Gustafsson 提交于
      cache_test_acquire was incorrectly spelled in the test definition struct
      making it hard to run as a single test (without using the same typo).
      1d4a060e
    • H
      Fix command tag for ALTER EXTERNAL TABLE. · dd36d360
      Heikki Linnakangas 提交于
      The code was quite confused on whether this was a switch-case or an if-else
      statement..
      
      The command tag is unfortunately not included in pg_regress output, so this
      is not reflected in regression tests, even though we have ALTER EXTERNAL
      TABLE commands in the test suite.
      
      Fixes github issue #4377.
      dd36d360
    • H
      Remove now-unnecessary get_rewrite_freeze_xid() function. · d96291c2
      Heikki Linnakangas 提交于
      This function was made unnecessary by commit b3f300b9, which changed
      GetOldestXmin() to "include" any distributed snapshots, too. rewriteheap.c
      no longer changes the freezeXid it's given, so there's no need for a
      function to get the new value back from it.
      d96291c2
    • H
      Put back upstream intarray GIN code and tests. · 04d80c37
      Heikki Linnakangas 提交于
      We had removed these earlier, when we didn't have GIN indexes. Now we do.
      04d80c37
    • J
      Remove allowNotFound argument from mdtruncate function · 0e2b90bb
      Jimmy Yih 提交于
      This argument was introduced when master/standby WAL replication was
      implemented to handle persistent table cases.  Since persistent tables
      have been removed, we no longer need this argument to mdtruncate.
      This takes care of a GPDB_84_MERGE_FIXME.
      0e2b90bb
    • T
      Revert "XLOG_HINT integration with persistent table (PT)" · 8c8b5c39
      Taylor Vesely 提交于
      This reverts commit a21da89e. These
      changes are obsolete now that persistent tables have been removed.
      Co-authored-by: NAsim R P <apraveen@pivotal.io>
      8c8b5c39
    • J
      get_rel_infos: handle sequences during 8.2->8.3 upgrade · 907803c0
      Jacob Champion 提交于
      When upgrading to 8.4, upstream's pg_upgrade refuses to copy old
      sequence data due to a change in columns. However, that check also
      prevented copying of sequence data during an 8.2->8.3 upgrade --
      Postgres doesn't care about this case, but GPDB does.
      
      Don't omit the copy if we're upgrading to 8.3, and enable the 8.2 heap
      upgrade for sequence tables so that the page makes sense in the new
      database.
      907803c0
    • J
      get_control_data: fix checksum version check · c687f53f
      Jacob Champion 提交于
      Follow-up to 71916050. Checksums were backported to Postgres 8.3, so we
      ignore them for <= 8.2.
      
      While we're at it, switch the data_checksum_version from a false
      assignment to a zero assignment, to match upstream. The actual
      implementation is an unsigned int; Postgres master incorrectly uses a
      bool type in the declaration.
      c687f53f
    • J
      pg_dump: correct version checks · 86614433
      Jacob Champion 提交于
      Follow-up to e8de956e. Correct the GPDB 5 check to use Postgres 8.3's
      version number, and correctly return the cached value from the GPDB 4
      check.
      86614433
    • A
      Remove SYNC_REP_DISABLED state · d4e9e3f1
      Asim R P 提交于
      This state was meant to prevent auxiliary processes from waiting from syncrep.
      As far as we can tell, auxiliary process should not be calling
      SyncRepWaitForLSN() unless it is committing a transaction.  And if it is
      committing a transaction, it better wait for mirror to flush XLOG upto the
      commit LSN.  One example of an auxiliary process committing a transaction is
      FTS, when it updates cluster configuration on master.
      Co-authored-by: NTaylor Vesely <tvesely@pivotal.io>
      d4e9e3f1
    • L
      docs - add pxf developer topics (release 1) (#4476) · 1a935f8e
      Lisa Owen 提交于
      * docs - add pxf developer topics (release 1)
      
      * misc edits
      
      * add pxf dev topics to oss book subnav
      
      * misc edits from david
      1a935f8e
    • L
      docs - perms for hdfs files backing pxf ext tbls are for gp user. This closes... · 798a37e4
      Lisa Owen 提交于
      docs - perms for hdfs files backing pxf ext tbls are for gp user. This closes #4692 and #4667 (#4676)
      
      * docs - perms for hdfs files backing pxf ext tbls are for gp user
      
      * correct pxf stop instructions
      
      * reword pxf stop intro
      
      * address comments from alex
      
      * lowercase a Y
      798a37e4
    • S
      Remove GPDB_84_MERGE_FIXME in planner.c and prepunion.c · 74546663
      Shreedhar Hardikar 提交于
      These were related to chosing the right arguments to send to GPDB's
      make_agg() and cost_agg() methods for queries containing DISTINCT or set
      operations.
      
      Hash aggregation when used to implement a DISTINCT (in either form) in
      the query is not related to grouping sets and thus the argments to
      num_nullcols, input_grouping, grouping and rollup_gs_times should be 0.
      
      However, since SetOp uses the upstream TupleHashTable while HashAgg uses
      GPDB's HHashTable implementation, the hash table size calculations
      should be computed differently. This is fixed in this commit
      Signed-off-by: NSambitesh Dash <sdash@pivotal.io>
      74546663
    • H
      Remove unused pg_am.amcanshrink column, and Am_btree. · da53f349
      Heikki Linnakangas 提交于
      They've been unused for as long as I can see.
      da53f349
    • J
      Remove FIXME comment in parse_utilcmd.c · 0f1b546a
      Jimmy Yih 提交于
      There was a GPDB_84_MERGE_FIXME regarding whether or not an extra lock
      was needed when getting the list of child partitions during CREATE
      INDEX.  We already have the lock on the root partition which prevents
      any ALTER TABLE operations from changing the child partition list.
      Because of that, an extra lock is not required.
      
      [ci skip]
      0f1b546a