If you have a simple insert, like "INSERT INTO foo VALUES ('bar')", we
evalute the target list (i.e. 'bar') in the master, and route the insert to
the correct partition and segment, based on the constants. However, there
was a mismatch between allConstantValuesClause(), and what its callers
assumed. The callers assumed that if allConstantValuesClause() returns
true, the target list contains only Const nodes. But in reality,
allConstantValuesClause() also returned true, if there were non-volatile
function expressions in the target list, that could be evaluated, and would
then produce a constant result.

Fix the mismatch, by making allConstantValuesClause() be more strict, so
so that it only returns true if all the entries are true Consts.

Fixes github issue #285, reported by @liruto.

It almost seems like when we merged with PostgreSQL 8.2 (sic), we missed
this one line from commit 986085a7. Before that, the rowMarks list was
a list of integers, but now it's a list of RowMarkClauses.

* Add table entries for rolcreaterexthdfs, rolcreatewexthdfs

* Change to gphdfs protocol

* typo

and its maximum value from 1000 to 10000.  ALTER TABLE SET STATISTICS
similarly now allows a value up to 10000.  Per discussion.

Cherry-pick from 65e3ea76

* Expand description of data_checksums GUC to include checksum behavior and scope.

* Mention that failed checksum verification prevents mirroring corrupted data.

Commit e40e78fa added the "unused" attribute to the function, but it
didn't have any effect. It seems that for a function that returns a pointer,
the attribute must be placed before the "*" indicating that the return type
is a pointer. Go figure..

This silences a compiler warning:

regress.c:2884:7: warning: implicit declaration of function ‘IsResGroupEnabled’ [-Wimplicit-function-declaration]

Per discussion at https://github.com/greenplum-db/gpdb/pull/2379, we don't
really need to use a special, patched, version of Xerces-C. Remove the
check.

This allows removing all the code in CTranslatorDXLToPlStmt that tracked
the parent of each call.

I found the plan node IDs awkward, when I was hacking on
CTranslatorDXLToPlStmt. I tried to make a change where a function would
construct a child Plan node first, and a Result node on top of that, but
only if necessary, depending on the kind of child plan. The parent plan
node IDs made it impossible to construct a part of Plan tree like that, in
a bottom-up fashion, because you always had to pass the parent's ID when
constructing a child node. Now that is possible.

1, remove unnecessary web tables
2, add various distribution with `ON SEGMENT` tests
3, add zero column with `ON SEGMENT` tests

Signed-off-by: NAlexandra Wang <lewang@pivotal.io>

Previously, the "all" target was used only by gpMgmt/bin/Makefile in
place of the "install" target used elsewhere. The underlying reason was
because python doesn't need a compile phase (the "all" target).

However, this is inconsistent. Change to use the standard "install"
target, which is also the default on the gpMgmt/bin/Makefile.
Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

Signed-off-by: NJingyi Mei <jmei@pivotal.io>

Beginning with the next development cycle, PG servers will report two-part
not three-part version numbers.  Fix libpq so that it will compute the
correct numeric representation of such server versions for reporting by
PQserverVersion().  It's desirable to get this into the field and
back-patched ASAP, so that older clients are more likely to understand the
new server version numbering by the time any such servers are in the wild.

(The results with an old client would probably not be catastrophic anyway
for a released server; for example "10.1" would be interpreted as 100100
which would be wrong in detail but would not likely cause an old client to
misbehave badly.  But "10devel" or "10beta1" would result in sversion==0
which at best would result in disabling all use of modern features.)

Extracted from a patch by Peter Eisentraut; comments added by me

Patch: <802ec140-635d-ad86-5fdf-d3af0e260c22@2ndquadrant.com>

gp_resgroup_memory_policy is recently introduced by resource group
module, so when running binary swap cases, the old binary can not
recognize it, so remove it to make cases pass

CopyRelPath() is essentially a copy of relpath(), but it returns the result
in a caller-supplied buffer instead of pallocing. That's redundant, and the
calls are not in performance-critical path, so let's just use relpath() and
get rid of CopyRelPath(). This reduces our diff footprint vs upstream. If
there were upstream changes to relpath(), we would surely forget to make
the same changes to CopyRelPath().

Resource group DDL is supposed to be executed by DBA and usually will not be in an explicit transaction with other statements.
To reduce the complexity of resource group, resource group DDL is designed cannot run inside transaction block, sub-transaction, function or multi-command string.
Signed-off-by: NZhenghua Lyu <zlv@pivotal.io>

Signed-off-by: NXin Zhang <xzhang@pivotal.io>

DOCS: External table - gpfdist or file protocol w/named pipe data source allows only 1 reader. From 4.3.x

Upstream commit cd902b33, from 8.4, changed StoreAttrDefault function's
adbin argument from a string to a Node *. We had backported that, but the
code to deal with it inside the function was not 100% identical to the
upstream version. There was nothing wrong with the way it was written in
GPDB per se, but let's make it identical to the upstream version anyway,
to avoid merge conflicts.

It will be re-introduced in 8.4, but it's unused now.

Currently, isolation2 vacuum_cleanup test was using base AO/CO tables for
validating if age drops down. Actaully the test should check auxiliary
tables. As anyways relfrozenxid doesn't carry any weigth for AO/CO base table.

AO and CO tables never store transactionIds and persistent table always have
tuples with FrozenXid only. Hence these tables should not have valid
relfrozenxid, hence also should not matter for age calculation. Persistent
tables are currently skipped internally from `datfrozenxid` calculation but
still contained valid value for relfrozenxid in pg_class. Whereas AO/CO tables
carried valid relfrozenxid and were used for `datfrozenxid` calculation as well.

This commit makes sure only tables involved in `datfrozenxid` calculation,
actually carry valid relfrozenxid in pg_class and others don't. So, externally
someone executing age() function can easily ignore such tables by checking `not
relfrozenxid = 0`.

Fixes #2856.

When running pg_regress, sometimes you may want to exclude certain
tests from your schedule file from running. Before, you would have to
modify the schedule file to comment/ignore out the unwanted test. Now
we can do it from command line with --exclude-tests option that is
space and comma delimited.

Example:
./pg_regress --exclude-tests="test1 test2,test3 ... testN"

Authors: Abhijit Subramanya and Jimmy Yih

* Add ignore_checksum_failure GUC to reference

* Changes for review comments

* Promote embedded warning to a tagged warning