- 13 1月, 2018 40 次提交
-
-
由 Heikki Linnakangas 提交于
The server-side code to exclude the listed files was accidentally removed, with the removal of filespace-related changes to basebackup.c. Resurrect it.
-
由 Heikki Linnakangas 提交于
Harmless, but compiler warnings are not nice.
-
由 Daniel Gustafsson 提交于
-
由 Heikki Linnakangas 提交于
The code used to wait for sent_location == replay_location, but that had similar problems that we had with the similar code in gp_replica_check earlier. Firstly, there is no guarantee that a checkpoint had been sent to the mirror, by the time that we check for it. So even if sent_location == replay_location, it was possible that the checkpoint hadn't even been sent to the mirror. That was highly unlikely in practice, though. Secondly, there are some corner cases where the primary would send half of a WAL record, up to a page boundary, but not the rest of the record, until something nudges it. I think that happens if the WAL record is not part of a transaction, so that there is no commit record to force it to be flushed. In that case, replay_location would not catch up to sent_location, because sent_location would point in the middle of a WAL record, and the standby can't replay half of a WAL record. That situation would persist until there's some new WAL activity to force it to be flushed, which could take longer than the timeout used in the test (possibly forever). To fix, memorize the WAL posititions on each segment, after issuing the CHECKPOINT, and wait until replay_location catches up to that position. That more accurately reflects what we are trying to accomplish: we want to wait until the checkpoint has been replayed, not necessarily that the standby is completely in sync with the primary. (gp_replica_check needed more strict logic, it wants the standby to really catch up to the primary, not just up to the latest checkpoint.) This hopefully fixes the occasional failures of the missing_xlog test we've been seeing in the pipeline.
-
由 Daniel Gustafsson 提交于
Include the diff between the first mismatching byte in the log output as we have it, and it can aid debugging (it just now helped me). Can't hurt.
-
由 Daniel Gustafsson 提交于
Commit f4c05df21d0906482e38010b15bac8221f52ee0b temporarily removed sequences from gp_replica_check due to them causing failures. Re-add them again as the masking should be fixed now.
-
由 Daniel Gustafsson 提交于
SEQ_LOG_VALS are pre-logged to avoid logging every fetch from a sequence, so we need to mask out last_value and log_cnt for sequence pages before running consistency checks.
-
由 Daniel Gustafsson 提交于
Makes filenames in mismatch messages consistently quoted and includes the length diff for ease of debugging.
-
由 Daniel Gustafsson 提交于
There were windows where we could return with open filehandles, ensure that we always close up and free up resources on retries before exiting.
-
由 Heikki Linnakangas 提交于
I'm not sure if we're going to keep these tests in the end, but might as well fix this for now.
-
由 Heikki Linnakangas 提交于
-
由 Ashwin Agrawal 提交于
-
由 Ashwin Agrawal 提交于
-
由 Ashwin Agrawal 提交于
-
由 Ashwin Agrawal 提交于
-
由 Heikki Linnakangas 提交于
There are more in other tests, but I suspect those other tests are obsolete in whole, so I'm just patching this one that caused a failure in the concourse pipeline.
-
由 Heikki Linnakangas 提交于
-
由 Heikki Linnakangas 提交于
-
由 Heikki Linnakangas 提交于
-
由 Heikki Linnakangas 提交于
-
由 Heikki Linnakangas 提交于
-
由 Heikki Linnakangas 提交于
-
由 Jimmy Yih 提交于
The walreceiver test establishes a walrep connection to the master's walsender. With the recent change to start standby master by default on gpdemo cluster, the mock walreceiver will be unable to create a connection to the walsender since max_wal_senders is hardcoded to 1. Moving this to run only on mirrorless cluster makes more sense since the assumption is to have an available walrep connection.
-
由 Jimmy Yih 提交于
This reverts commit 3214d80fabf7c208e40b2ec4f7ec69c97a9e7dd6.
-
由 Jimmy Yih 提交于
This reverts commit f38f024d7d314ae8ac100d862307a228b212c70e.
-
由 C.J. Jameson 提交于
- use the new fact that datadirs are in the gp_segment_configuration - fix a few things with the gpperfmon behave tests (mostly for macOS) --> the change to mgmt_utils.py is to do the config file manipulation natively in python --> the change to the gp_bash_functions.sh is to use ASCII ' characters so that python string comparison is happier Author: C.J. Jameson <cjameson@pivotal.io>
-
由 Heikki Linnakangas 提交于
It just doesn't mean "filespace" anymore, just plain "datadir".
-
由 Heikki Linnakangas 提交于
Since persistent tables were removed, these were not used for anything.
-
由 Heikki Linnakangas 提交于
Plenty remains, but this is a start.
-
由 Heikki Linnakangas 提交于
-
由 Heikki Linnakangas 提交于
-
由 Ashwin Agrawal 提交于
These tests are very tightly coupled with filerep and persistent tables implemenation. We do need to have tests in replacement but these would be coded not in TINC and mostly much less scenarios as in general walreplication mirrors active for full ICW validates most of crashrecovery logic. What's missing mostly is real crash scenarios in middle of active workload like creating/dropping objects and all.
-
由 Heikki Linnakangas 提交于
After removing -s option from gpsegstart, this unit test started failing with curious error: Stderr: Usage: gpunit [--help] [options] gpunit: error: no such option: -s ====================================================================== ERROR: Test Suite Name|programs.test.unit.test_cluster_clsrecoversegment|Test Case Name|test_output_segments_in_change_tracking_disabled_should_print_failed_segments|Test Details| ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/heikki/git-sandbox-gpdb/master/gpMgmt/bin/gppylib/programs/test/unit/test_cluster_clsrecoversegment.py", line 16, in setUp (options, _) = raw_options.parse_args() File "/usr/lib/python2.7/optparse.py", line 1402, in parse_args self.error(str(err)) File "/usr/lib/python2.7/optparse.py", line 1584, in error self.exit(2, "%s: error: %s\n" % (self.get_prog_name(), msg)) File "/usr/lib/python2.7/optparse.py", line 1574, in exit sys.exit(status) SystemExit: 2 It turns out that the unit test was passing the command-line options from the gpunit invocation, to the options parser of the gpsegstart command. It was accidental that it ever worked, because gpsegstart also happened to have a -s option, like gpunit did. Now that the option was removed, the gpsegstart options parser started to fail. To fix, explicitly pass "no command-line arguments" to the gpsegstart options parser, so that it doesn't pick up the args from the gpunit invocation.
-
由 Heikki Linnakangas 提交于
Remove test code for check_persistent_tables function, which was removed earlier. Fix a few more initFromString() lines.
-
由 Ashwin Agrawal 提交于
Many times the `commit_blocking` test fails, its not clear if the problem happened during the test, or cluster was not in right state before we started. Hence adding expected state for the test at start which would help to easily know if this test failed or is just side-effect for previous test failure.
-
由 Heikki Linnakangas 提交于
-
由 Heikki Linnakangas 提交于
I removed the filespaces arg earlier, but failed to update the format string accordingly.
-
由 Ashwin Agrawal 提交于
-
由 Ashwin Agrawal 提交于
- Special lock functions for RelationExtension - Special function ReadBuffer_Resync() - States related to CT and RESYNC - Xlog during PageInit() for vacuum lazy (upstream doesn't have it so removed it)
-
由 Ashwin Agrawal 提交于
This reverts commit 1a27788edfd2163cbfcb1dc30c5eb870eac77181. As should be passing now since FTS using uninitialized variable `fts_status` causing the failure has been fixed now.
-